1. 22 Jul, 2022 1 commit
  2. 21 Jul, 2022 13 commits
    • JJ Kasper's avatar
      v12.2.3-canary.17 · 12b7c584
      JJ Kasper authored
      12b7c584
    • JJ Kasper's avatar
      Update query/hash test for safari (#38889) · 89e572b1
      JJ Kasper authored
      89e572b1
    • Sukka's avatar
      fix(#38743): config.runtime support template literal (#38750) · 02c78a5c
      Sukka authored
      
      
      ## Bug
      
      - [x] Related issues linked using `fixes #number`
      - [x] Integration tests added
      - [ ] Errors have helpful link attached, see `contributing.md`
      
      Fixes #38743.
      Fixes: https://github.com/vercel/next.js/pull/38750
      
      The PR adds basic `TemplateLiteral` support for static analysis.
      
      The corresponding re-production of #38743 has also been implemented in e2e tests.
      02c78a5c
    • JJ Kasper's avatar
      Ensure mixed query/hash values are handled correctly (#38852) · 366a04b7
      JJ Kasper authored
      This ensures we correctly detect query and hash values when there are `?` characters in the hash. A regression test to ensure this working properly has been added. 
      
      ## Bug
      
      - [x] Related issues linked using `fixes #number`
      - [x] Integration tests added
      - [ ] Errors have helpful link attached, see `contributing.md`
      
      Fixes: https://github.com/vercel/next.js/issues/38783
      366a04b7
    • Javi Velasco's avatar
      Update Edge Runtime (#38862) · 14463ddd
      Javi Velasco authored
      This PR updates the Edge Runtime to use a new version that loads dependencies differently. This addresses https://github.com/vercel/next.js/pull/38766 so `instanceof` works as expected.
      
      It involved a few code changes, mostly regarding to types. The most important change is that the `Runner` function in the sandbox doesn't take a `ReadableStream` as `body` anymore since this implies creating the instance on "node land" and makes the runtime `fetch` function not to be able to compare with `ReadableStream` using `instanceof`.  Instead we introduce a "clonable body" abstraction that allows to create the `ReadableStream` from `Readable` by using the edge runtime primitive which would hold the correct prototype.
      
      Also, this PR changes the way we pre-compile the Edge Runtime to adapt it to the new version.
      14463ddd
    • Sukka's avatar
      fix: correct the next config optimizeCss type (#38879) · fe4b7113
      Sukka authored
      `experimental.optimizeCss` from `next.config.js` can be an object containing the critters' option:
      
      https://github.com/vercel/next.js/blob/70a53e0789c7e361f12139db6e124a5bb1d2afd9/packages/next/server/post-process.ts#L224-L232
      
      The PR corrects the ajv schema and the type definition of `experimental.optimizeCss`.
      fe4b7113
    • Raquel Amorim's avatar
      chore(examples): Convert `with-cypress` example to TypeScript (#38818) · 552620f9
      Raquel Amorim authored
      
      
      
      - Update `with-cypress` example dependencies;
      - Convert `with-cypress` example to TypeScript as suggested in the Contribution docs.
      
      
      ## Documentation / Examples
      
      - [x] Make sure the linting passes by running `pnpm lint`
      - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
      552620f9
    • Damien Simonin Feugas's avatar
      fix(edge): error handling for edge route and middleware is inconsistent (#38401) · 90bbac44
      Damien Simonin Feugas authored
      ## What’s in there?
      
      This PR brings more consistency in how errors and warnings are reported when running code in the Edge Runtime:
      
      - Dynamic code evaluation (`eval()`, `new Function()`, `WebAssembly.instantiate()`, `WebAssembly.compile()`…)
      - Usage of Node.js global APIs (`BroadcastChannel`, `Buffer`, `TextDecoderStream`, `setImmediate()`...)
      - Usage of Node.js modules (`fs`, `path`, `child_process`…)
      
      The new error messages should mention *Edge Runtime* instead of *Middleware*, so they are valid in both cases.
      
      It also fixes a bug where the process polyfill would issue a warning for  `process.cwd` (which is `undefined` but legit). Now, one has to invoke the function `process.cwd()` to trigger the error.
      
      It finally fixes the react-dev-overlay, where links from middleware and Edge API route files could not be opened because of the `(middleware)/` prefix in their name.
      
      About the later, please note that we can’t easily remove the prefix or change it for Edge API routes. It comes from the Webpack layer, which is the same for both. We may consider renaming it to *edge* instead in the future.
      
      ## How to test?
      
      These changes are almost fully covered with tests:
      
      ```bash
      pnpm testheadless --testPathPattern runtime-dynamic
      pnpm testheadless --testPathPattern runtime-with-node
      pnpm testheadless --testPathPattern runtime-module
      pnpm testheadless --testPathPattern middleware-dev-errors
      ```
      
      To try them out manually, you can write a middleware and Edge route files like these:
      
      ```jsx
      // middleware.js
      import { NextResponse } from 'next/server'
      import { basename } from 'path'
      
      export default async function middleware() {
        eval('2+2')
        setImmediate(() => {})
        basename()
        return NextResponse.next()
      }
      
      export const config = { matcher: '/' }
      ```
      
      ```jsx
      // pages/api/route.js
      import { basename } from 'path'
      
      export default async function handle() {
        eval('2+2')
        setImmediate(() => {})
        basename()
        return Response.json({ ok: true })
      }
      
      export const config = { runtime: 'experimental-edge' }
      ```
      
      The expected behaviours are:
      
      - [x] dev, middleware/edge route is using a node.js module: error at runtime (logs + read-dev-overlay):
      
      ```bash
      error - (middleware)/pages/api/route.js (1:0) @ Object.handle [as handler]
      error - The edge runtime does not support Node.js 'path' module.
      Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime
      > 1 | import { basename } from "path";
        2 | export default async function handle() {
      ```
      
      - [x] build, middleware/edge route is using a node.js module: warning but succeeds
      
      ```bash
      warn  - Compiled with warnings
      
      ./middleware.js
      A Node.js module is loaded ('path' at line 4) which is not supported in the Edge Runtime.
      Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime
      
      ./pages/api/route.js
      A Node.js module is loaded ('path' at line 1) which is not supported in the Edge Runtime.
      Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime
      ```
      
      - [x] production, middleware/edge route is using a node.js module: error at runtime (logs + 500 error)
      
      ```bash
      Error: The edge runtime does not support Node.js 'path' module.
      Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime
          at <unknown> (file:///Users/damien/dev/next.js/packages/next/server/web/sandbox/context.ts:149)
      ```
      
      - [x] dev, middleware/edge route is using a node.js global API: error at runtime (logs + read-dev-overlay):
      
      ```bash
      error - (middleware)/pages/api/route.js (4:2) @ Object.handle [as handler]
      error - A Node.js API is used (setImmediate) which is not supported in the Edge Runtime.
      Learn more: https://nextjs.org/docs/api-reference/edge-runtime
        2 |
        3 | export default async function handle() {
      > 4 |   setImmediate(() => {})
          |  ^
      ```
      
      - [x] build, middleware/edge route is using a node.js global API: warning but succeeds
      
      ```bash
      warn  - Compiled with warnings
      
      ./middleware.js
      A Node.js API is used (setImmediate at line: 6) which is not supported in the Edge Runtime.
      Learn more: https://nextjs.org/docs/api-reference/edge-runtime
      
      ./pages/api/route.js
      A Node.js API is used (setImmediate at line: 3) which is not supported in the Edge Runtime.
      Learn more: https://nextjs.org/docs/api-reference/edge-runtime
      ```
      
      - [x] production, middleware/edge route is using a node.js module: error at runtime (logs + 500 error)
      
      ```bash
      Error: A Node.js API is used (setImmediate) which is not supported in the Edge Runtime.
      Learn more: https://nextjs.org/docs/api-reference/edge-runtime
          at <unknown> (file:///Users/damien/dev/next.js/packages/next/server/web/sandbox/context.ts:330)
      ```
      
      - [x] dev, middleware/edge route is loading dynamic code: warning at runtime (logs + read-dev-overlay) and request succeeds (we allow dynamic code in dev only):
      
      ```bash
      warn  - (middleware)/middleware.js (7:2) @ Object.middleware [as handler]
      warn  - Dynamic Code Evaluation (e. g. 'eval', 'new Function') not allowed in Edge Runtime
         5 |
         6 | export default async function middleware() {
      >  7 |   eval('2+2')
      ```
      
      - [x] build, middleware/edge route is loading dynamic code: build fails with error:
      
      ```bash
      Failed to compile.
      
      ./middleware.js
      Dynamic Code Evaluation (e. g. 'eval', 'new Function', 'WebAssembly.compile') not allowed in Edge Runtime
      Used by default
      
      ./pages/api/route.js
      Dynamic Code Evaluation (e. g. 'eval', 'new Function', 'WebAssembly.compile') not allowed in Edge Runtime
      Used by default
      ```
      
      ## Notes to reviewers
      
      Edge-related errors are either issued from `next/server/web/sandbox/context.ts` file (runtime errors) or from `next/build/webpack/plugins/middleware-plugin.ts` (webpack compilation).
      
      The previous implementation (I’m pleading guilty here) was way too verbose: some errors (Node.js global APIs like using `process.cwd()`) could be reported several times, and the previous mechanism to dedupe them (in middleware-plugin) wasn’t really effective.
      
      Changes in tests are due to renaming existing tests such as `test/integration/middleware-with-node.js-apis` into `test/integration/edge-runtime-with-node.js-apis`. I extended them to cover Edge API route.
      
      @hanneslund I’ve pushed the improvement you did in https://github.com/vercel/next.js/pull/38289/ one step further to avoid duplication.
      90bbac44
    • Sukka's avatar
      ci: dropping macos-10.15 (#38865) · 6486e12e
      Sukka authored
      GitHub Action is sunsetting the `macos-10.15` runner and it will be removed by 8/30/22: https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/
      
      Next.js only uses `macos-10.15` for building the freebsd version of the `next-swc` binary, and I have checked [`vmactions/freebsd-vm`](https://github.com/vmactions/freebsd-vm) does support `macos-12` (which requires `vmactions/freebsd-vm@0.2.0`).
      
      I have updated the `runs-on` to `macos-12` and bumped `vmactions/freebsd-vm` to `0.2.0` in the PR.
      6486e12e
    • Tim Neutkens's avatar
      v12.2.3-canary.16 · 5dafe472
      Tim Neutkens authored
      5dafe472
    • Jiachi Liu's avatar
      7921b675
    • Tim Neutkens's avatar
      Ensure module require is awaited in app-render (#38860) · 5752d4a6
      Tim Neutkens authored
      Fixes a bug where `import { nanoid } from 'nanoid'` broke the tests. 
      
      
      
      ## Bug
      
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Errors have helpful link attached, see `contributing.md`
      
      ## Feature
      
      - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Documentation added
      - [ ] Telemetry added. In case of a feature if it's used or not.
      - [ ] Errors have helpful link attached, see `contributing.md`
      
      ## Documentation / Examples
      
      - [ ] Make sure the linting passes by running `pnpm lint`
      - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
      5752d4a6
    • Balázs Orbán's avatar
      chore: convert `with-dynamic-import` to TypeScript (#38844) · adf40a6f
      Balázs Orbán authored
      Closes #38806
      
      ## Bug
      
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Errors have helpful link attached, see `contributing.md`
      
      ## Feature
      
      - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Documentation added
      - [ ] Telemetry added. In case of a feature if it's used or not.
      - [ ] Errors have helpful link attached, see `contributing.md`
      
      ## Documentation / Examples
      
      - [ ] Make sure the linting passes by running `pnpm lint`
      - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
      Co-authored-by: 's avatarJJ Kasper <22380829+ijjk@users.noreply.github.com>
      adf40a6f
  3. 20 Jul, 2022 13 commits
  4. 19 Jul, 2022 6 commits
  5. 18 Jul, 2022 7 commits