- 04 Aug, 2022 8 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
-
Cupid Valentine authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by:
Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
-
Damien Simonin Feugas authored
* fix: buffer is not usable on edge runtime * chore: improves implementation to allow any fallbacks
-
JJ Kasper authored
-
Cupid Valentine authored
Co-authored-by:
spcma <46758907+spcma@users.noreply.github.com> ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
OJ Kwon authored
* build(cargo): update dependencies * feat(next-swc/wasm): export async interfaces * feat(next/swc): use async wasm binding interface * refactor(next/swc): allow to fallback for non-async published pkg * Apply suggestions from code review Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
JJ Kasper authored
-
- 03 Aug, 2022 13 commits
-
-
Ikko Ashimine authored
arbitary -> arbitrary
-
Jiachi Liu authored
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
* Update Android NDK path for swc builds * add debug log * update paths * update * re-add isRelease checks * update strip util path * double check * Revert "double check"
-
Sukka authored
-
Alex Castle authored
This PR removes the default styling of `object-fit:"contain"` for images using the future image component. This means images will get the default `object-fit` behavior of `"fill"`. The main reason for this change is that an inline style will take precedence over external CSS, making this default behavior difficult to override with some styling strategies. Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
hiro authored
fix typo document.
-
Jiachi Liu authored
rename `middlewares` (typo, shouldn't have ending **s**) to `interceptors` to distinguish from middleware
-
Josh Parnham authored
Currently next.js polyfills a [subset](https://github.com/vercel/next.js/blob/canary/packages/next-polyfill-nomodule/src/index.js) of APIs for `nomodule` browsers (such as IE 11), however it's not immediately clear to developers which APIs are transparently polyfilled. For example, currently `Object.entries` is polyfilled and thus is usable in IE 11, but [it was decided](https://github.com/vercel/next.js/pull/15772#discussion_r463984612) that `Object.fromEntries` should not be polyfilled. As a developer, this is a confusing situation until you end up finding the `next-polyfill-nomodule` list of polyfills that are included. This PR attempts to improve the Supported Browser Features page by: - linking to the list of polyfills - clarifying that custom polyfills are required for IE11 (and other old browser) compatibility - moving the section on Sever-Side polyfills further down the page so all browser polyfill sections are better grouped together ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
Jiachi Liu authored
Use flush effects to custom apply css-in-js solution to app. Re-introduce flush effects to app-render, and remove default support of styled-jsx in `app/`. So that users will choose their own css-in-js solution if they need any customization. styled-jsx won't appear in client bundle if you didn't use it. For now we have to inject the initial styles before `</head>` to avoid hydration errors. Later on we can remove this once react can handle it. - [x] inject styles before end of head element - [x] add tests
-
JJ Kasper authored
-
JJ Kasper authored
-
- 02 Aug, 2022 6 commits
-
-
Steven authored
This expands on the previous PR #38978 with a section on migrating
-
Duc Tran authored
* fix: use if-else in dockerfile * fix: remove typo
-
JJ Kasper authored
* Ensure middleware has single data fetch on query hydration with valid props * re-add check * fix redirect case
-
Colin McDonnell authored
Update `with-edgedb` to use `2.0`.
-
Matt DuLeone authored
## Documentation / Examples This PR specifically calls out in more clear language how the rewrites function behaves. This tripped me up recently as I recently came looking for more information, and the documentation left me with more questions than answers. This is an attempt to clear up the confusion I walked away with for anyone who comes in after me. - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
Gal Schlezinger authored
This commit allows the users to import URLPattern from `next/server`, by defining a key that uses `global.URLPattern`. Why is this any good? or: why don't we add URLPattern to the global namespace? URLPattern is exposed as global on Edge Runtime _only_. This means that if we define a constructor in global namespace in our TypeScript definitions, people might have runtime errors in their Node.js functions. Importing from `next/server` enables users to get the constructor without risking in runtime errors and wrong type definitions. Keep in mind, that with the current implementation, we do not check if the constructor actually exists, but `next/server` shouldn't be imported in Node.js functions, AFAIK. ## Related - Fixes #38131 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Co-authored-by:JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
- 01 Aug, 2022 7 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
This ensures we properly leverage the `assetPrefix` for `app`. Note for reviewing the test changes are mostly spacing so hiding that may help. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes: [slack thread](https://vercel.slack.com/archives/C035J346QQL/p1659387244559979)
-
Steven authored
This PR fixes an issue where tests fail because the generated tmp directory already exists. This is likely caused from two tmp dirs being generated in the same millisecond. ``` Failed to create next instance [Error: EEXIST: file already exists, mkdir '/tmp/next-repo-1659368089063/packages'] { errno: -17, code: 'EEXIST', syscall: 'mkdir', path: '/tmp/next-repo-1659368089063/packages' } ``` https://github.com/vercel/next.js/runs/7615808051?check_suite_focus=true -
Alex Castle authored
This PR adds a `fill` attribute to the future image component, that behave similarly to the fill mode on the existing image component. Functionally, it mainly adds `position: "absolute"` and `object-fit: "contain"` to the image element, along with `height: "100%"` and `width: "100%"` to preserve the image aspect ratio. All of these can be overwritten by the user, except for `position: "absolute"`, which will throw an error. This is because changing that property without height and width is likely to cause layout shift. Because we no longer have the wrapper element, this new version of `fill` requires that the user set `overflow: "hidden"` on the parent element themself, if they want that behavior. This PR also includes several runtime checks to catch instances where the fill mode may provide unexpected results. These runtime checks warn if: * The image doesn't have the `sizes` attribute and loads much smaller than the viewport * The containing element does not have `position: "relative"` * The image height value is 0 Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
Jiachi Liu authored
When we detect if `reactRoot` rendering should be enabled we `require` the require to check the version. But at that time the `NODE_ENV` isn't set yet. Then the react dev build stays in the `require.cache` that any future require of react will get the wrong build. In that case, React dev bundle is picked in production mode. Fun fact: if you're using hooks, that seem not to effect you, but context consumer works different then you couldn't get the proper context from provider. Fixes #38176 Fixes #38765 Fixes #38332 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
Jiachi Liu authored
x-ref #39199 The change in #39199 isn't correct. Middleware manifest should only contain middleware route, so that when router navigates, it only try to apply middleware instead of checking all edge routes. This PR also changes the middleware manifest global value from array to object for easier access ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
NikhilNama18 authored
In `Generating paths on-demand` section It was mentioned that `getStaticProps` allows you to control which pages are generated during the build. But `getStaticPaths` will allows us to control which pages are generated during the build. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
- 31 Jul, 2022 3 commits
-
-
John Daly authored
## Documentation / Examples Updating the `with-msw` example to use TypeScript - [X] Make sure the linting passes by running `pnpm lint` - [X] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
Santi Dalmasso authored
Update `e2e/example.spec.ts` ([/docs/testing](https://nextjs.org/docs/testing#creating-your-first-playwright-end-to-end-test) page) to fix the failed test. Fixes: #39194 ## Bug - [ ] Related issues linked using fixes #number - [ ] Integration tests added - [ ] Errors have helpful link attached, see contributing.md ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using fixes #number - [ ] Integration tests added - [X] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see contributing.md ## Documentation / Examples - [ ] Make sure the linting passes by running pnpm lint - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md?rgh-link-date=2022-07-13T09%3A09%3A13Z#adding-examples)
-
Jiachi Liu authored
## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
- 30 Jul, 2022 3 commits
-
-
Jessica Franco authored
Otherwise build-native fails with "napi: command not found.". Alternatively, this is missing from this package's devDependencies. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) P.S.: local copy fails `pnpm lint` due to the `target` subfolder with intermediate rust build artifacts... should I add a `.prettierignore` update to exclude `/packages/next-swc/target/`? Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Jiachi Liu authored
* refactor: simplify middleware execution * remove ssr prop from RoutingItem * fix build
-
Severin Ibarluzea authored
* fix(#11930): rewritten api routes can correctly handle cors in dev mode * test that request matches hot reloader middleware instead of api https://github.com/vercel/next.js/pull/38937#pullrequestreview-1055957698 * remove unnecessary imports * remove unused constant * remove api route import
-