- 10 Aug, 2022 10 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
* Tweak styled-jsx type declarations * fix lint
-
Wyatt Johnson authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by:
Tim Neutkens <6324199+timneutkens@users.noreply.github.com> Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
JJ Kasper authored
This ensures we properly handle rewrites when the request is a WebSocket request. This also adds an integration test to ensure it is working as expected in dev and production mode. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes: https://github.com/vercel/next.js/issues/32634 Closes: https://github.com/vercel/next.js/pull/38455
-
JJ Kasper authored
* Ensure default _app is used when falling back to default _error * make render check less specific due to arbitrary wait
-
Tim Neutkens authored
Found that this rule was added but all options are set to `false` so it doesn't do anything. Started with enabling it for examples to ensure minimal breaking of existing PRs. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
Damien Simonin Feugas authored
###
📖 What's in there? As part of the 4 hands work done in #39397, we accidentally removed a describe for middleware "using a single matcher with i18n" (and no base path nor trailing slash). This PR restores it. ### 🧪 How to test? ``` pnpm testheadless --testPathPattern middleware-matcher ``` ###🆙 Note to reviewers There's only a couple lines with meaningful change in this PR. Hide whitespaces in github's diff screen to find it more easily: https://github.com/vercel/next.js/pull/39452/files?diff=split&w=1 -
Gal Schlezinger authored
This version fixes a bug where [crypto buffers (ArrayBuffer, Uint8Array) not compatible with text decoding](https://github.com/vercel/edge-runtime/commit/17475e4df728c1f1be2956cf8cf0b376fc8c1f59).
-
M. Zakiyuddin Munziri authored
# Description The link to https://nextjs.org/docs/messages/invalid-getserversideprops-value does not exist, the correct link should be https://nextjs.org/docs/messages/invalid-getserversideprops-return-value   # Solution ## From Referring to the pattern, there is no `return`  ## To So I removed the word `return` to match the pattern  ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ x] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Jono Hewitt authored
* Update `router.prefetch` documentation Include documentation for setting the locale as an option within `router.prefetch`. * apply suggestions Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
- 09 Aug, 2022 11 commits
-
-
JJ Kasper authored
-
Damien Simonin Feugas authored
* feat(middleware): augments / matcher with /index * fix(#39396): not invoked with i18n and trailingSlash * add test case * tweak matcher a bit and add tests Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Alex Castle authored
* Wrap sizes code snippets in component * Don't remove docs import statement
-
JJ Kasper authored
-
Shu Ding authored
extract redirect utils
-
Alex Castle authored
This PR updates the documentation for the `sizes` proper in next/image to make it more clear what this prop does and why it's (very) important to use it. After feedback, I'll update this PR to also modify the future image component docs. Co-authored-by:
Steven <229881+styfle@users.noreply.github.com> Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Jiachi Liu authored
Improve styled-jsx types in next.js, previously there's no `declare module` for styled-jsx and there's type name conflicts in `styled-jsx/index.d.ts` and we use a rename hack to avoid the conflicts. Now styled-jsx 5.0.3 fixed those issues. x-ref: https://github.com/vercel/styled-jsx/pull/805
-
fediev authored
Improve description of `query` `query` is not just representing of the query string. It has the same values as `router.query`.
-
Balázs Orbán authored
fix: ensure trailing slash on registry URL
-
Lee Robinson authored
Renames Middleware to Request Helpers to be both more accurate and also less confusing since Middleware is a separate feature of Next.js now.
-
Jiachi Liu authored
* Use require hook and alias to resolve styled-jsx * re-export styled-jsx types from compiled * fix lint * add test for styled-jsx css * setup require hook in server * compile import path to styled-jsx/style * revert require hook * add test for server styled-jsx resolving * update test * pre copy styled-jsx assets * fix styled-jsx dts * add npmrc for styled-jsx e2e test * load require hook directly * rm legacy test * fix lint * fix pnpm install error * split require hook * only alias styled-jsx * make styled-jsx resolving statically analyzable * update test Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
- 08 Aug, 2022 17 commits
-
-
JJ Kasper authored
-
pekarja5 authored
* Fix SSG Link generation if using domain locales * Updated condition and test * Changed export worker domain locale check * Update check Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Anthony Shew authored
* chore: add typescript and update deps * style: add tsconfig * chore: add g.avatar.com domain * fix: images domain api url to match with hostname * style: convert files to typescript * refactor(Avatar): const name for readable purpose * refactor: change regex to extract www from url * Update next-image domains. * Update a few types. * Update readme. * typo Co-authored-by:
Chaiwat Trisuwan <chaiwattsw@gmail.com> Co-authored-by:
Lee Robinson <me@leerob.io> Co-authored-by:
Anthony Shew <anthony@inthezone.dev> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Sanjaiyan Parthipan authored
Adding `strategy="lazyOnload"` for prevent minor confusion. Co-authored-by:JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
sumiren authored
getStaticProps will be called in conjection with fallback. it's written in following page, but not in concerned page. https://nextjs.org/docs/basic-features/data-fetching/get-static-paths
-
Balázs Orbán authored
* fix internal type * allow `void` to be returned from Middleware * mark deprecated APIs in JSDoc * fix typo * add missing error page * remove unused import
-
Julien Deniau authored
Fixes #33072 I documented all `esXXX` features to be sure that they were already polyfilled. Only `es2019` feature `Object.fromEntries` is not already polyfilled by nextjs. I added some unwanted polyfill (that are polyfilled by nextjs). I kept the `es5`, `es6` and `es2015` "as-is" as they contain functions that does not seem to be explicitly polyfilled (all `Math` functions or `Date.now` for example) in the [polyfill file](https://github.com/vercel/next.js/blob/master/packages/next-polyfill-nomodule/src/index.js) Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
JJ Kasper authored
* update(README) * fix create scripts Co-authored-by:MarDi66 <yohann.mtfpro@gmail.com>
-
Everton Nunes authored
Add support for `--output-file` on ESLint cli, based on this discussion https://github.com/vercel/next.js/discussions/26179, and this closed PR https://github.com/vercel/next.js/pull/35154. With this flag, it is possible to save the output in a file and use it for any purpose. ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Sukka authored
-
Michael Novotny authored
Adds `eslint-plugin-eslint-plugin` to ensure `eslint-plugin-next` rules follow ESLint rule best practices along with enforcing some consistency. (#37920) * Adds eslint-plugin-eslint-plugin and recommended rules. * Removes `fixable` as none of the rules contain fixers. * Adds description and url rules. * Adds message format. * Removes optional dependencies. * Lints eslint-plugin-next tests too. * Removes optional dependencies from pnpm lock file. * Resets pnpm lock file. * Resets package.json too. * Fixes pnpm lockfile.
-
양현석 authored
fix: imgixLoader can use multiple auto params
-
LongYinan authored
fixes https://github.com/vercel/next.js/issues/38291 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
Sicarius authored
* added yarn 2 based files/dirs to valid files * remove package.json Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
LongYinan authored
fixes https://github.com/vercel/next.js/issues/39386
-
Aniket Singh Rawat authored
## Bug - [x] Related issues linked using `fixes #number` fixes #14434 Before  After  Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Lucas Rosa authored
* Allow custom path for preview mode cookies * update params order and tests * update tests * fix tests and update docs Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
- 07 Aug, 2022 2 commits
-
-
Josh Goldberg authored
## Bug - [x] Fixes #38047 - ~[ ] Integration tests added: do you want them added for such an unusual edge case?~ [Comment below: skipping](https://github.com/vercel/next.js/pull/38046#issuecomment-1207444526) - [x] Errors have helpful link attached, see `contributing.md`: ~I'll wait until this approach & error message are confirmed before thinking more deeply on how to explain the error~ Sending a draft PR as reference ahead of time.
🙂 Doesn't resolve the root issue of why `_devPagesManifest.json` might fail to load. But does improve the log for when it happens. I'd suggest applying this same fix to `_devMiddlewareManifest.json` too. <table> <thead> <tr> <th></th> <th>Before</th> <th>After</th> </tr> </thead> <tbody> <tr> <th>Console</th> <td> <pre> <code> Failed to fetch devPagesManifest TypeError: Failed to fetch at PageLoader.getPageList (page-loader.js?e87a:30:53) at _callee$ (router.js?8684:955:45) at ... </code> </pre> <pre> <code> router.js?8684:1319 Uncaught (in promise) TypeError: Cannot \ read properties of undefined (reading 'includes') at resolveDynamicRoute (router.js?8684:1319:16) at _callee$ at ... </code> </pre> </td> <td> <pre> <code> Failed to fetch devPagesManifest: TypeError: Failed to fetch at PageLoader.getPageList (page-loader.js?e87a:30:53) at _callee$ (router.js?8684:955:45) at ... </code> </pre> </td> </tr> <tr> <th>Visual</th> <td><img alt="Screenshot of a Next.js runtime error: TypeError: Cannot read properties of undefined (reading 'includes')" src="https://user-images.githubusercontent.com/3335181/175854728-8d5c2051-1229-4da7-8af1-fc95236befae.png" /></td> <td><img alt="Screenshot of a Next.js runtime error: Error: Failed to fetch _devPagesManifest.json. Is something blocking that network request?" src="https://user-images.githubusercontent.com/3335181/175854774-07895846-1a1c-4bb8-bf57-fa696b8c6ba4.png" /></td> </tr> </tbody> </table> -
Yamagishi Kazutoshi authored
* Add runtime to PageConfig type * Add test case for runtime type * Apply suggestions from code review * dedupe type * fix import * fix lint Co-authored-by:JJ Kasper <jj@jjsweb.site>
-