1. 22 Sep, 2022 16 commits
  2. 21 Sep, 2022 16 commits
    • Henrik Wenz's avatar
      chore: refactor using-router example (#40774) · 69595adc
      Henrik Wenz authored
      ## Changes
      
      - Updated dependencies
      - Migrated to Typescript
      - Added additional router use cases
      
      ## Documentation / Examples
      
      - [x] Make sure the linting passes by running `pnpm lint`
      - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
      69595adc
    • JJ Kasper's avatar
      Update publish to scope as public for initializing (#40778) · 48264c26
      JJ Kasper authored
      New scoped packages need to be initialized as public so this adds the
      `publishConfig` for this.
      
      Fixes:
      https://github.com/vercel/next.js/actions/runs/3101494786/jobs/5023375720
      48264c26
    • Balázs Orbán's avatar
      chore(examples): lock `msw` version in `with-msw` example (#40777) · 1d7ce56a
      Balázs Orbán authored
      Closes #40775
      
      <!--
      Thanks for opening a PR! Your contribution is much appreciated.
      To make sure your PR is handled as smoothly as possible we request that
      you follow the checklist sections below.
      Choose the right checklist for the change that you're making:
      -->
      
      ## Bug
      
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Feature
      
      - [ ] Implements an existing feature request or RFC. Make sure the
      feature request has been accepted for implementation before opening a
      PR.
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Documentation added
      - [ ] Telemetry added. In case of a feature if it's used or not.
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Documentation / Examples
      
      - [ ] Make sure the linting passes by running `pnpm lint`
      - [ ] The "examples guidelines" are followed from [our contributing
      doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
      1d7ce56a
    • JJ Kasper's avatar
      v12.3.2-canary.1 · 4607140a
      JJ Kasper authored
      4607140a
    • Hannes Bornö's avatar
      Add next font package (#40227) · 12641968
      Hannes Bornö authored
      For some context:
      https://vercel.slack.com/archives/CGU8HUTUH/p1662124179102509
      
      Adds `@next/font` package.
      
      `scripts/update-google-fonts.js` generates functions and metadata for
      all available google fonts. The metadata is used in `loader.ts` to
      validate font options (from #40221). It then fetches the CSS from google
      fonts, downloads the font files and emits them as static assets.
      
      The actual integration with `packages/next` and integration tests
      depends on #40221, will follow up with new PR.
      Co-authored-by: 's avatarJJ Kasper <jj@jjsweb.site>
      12641968
    • Hannes Bornö's avatar
      next-swc: add next-font-loaders to crates/core (#40221) · 97b31873
      Hannes Bornö authored
      For some context:
      https://vercel.slack.com/archives/CGU8HUTUH/p1662124179102509
      
      Transforms call expressions of imported functions, only affects imports
      specified in SWC options. Each argument is turned into JSON and appended
      to the import as a query. The query can be read in a webpack loader,
      i.e. the call expression is only evaluated at build time
      
      ### Transform
      From
      ```tsx
      import { Fn } from "package"
      const res = Fn(1, "2", { three: true })
      ```
      To
      ```tsx
      import res from 'package?Fn;1;"2";{"three":true}'
      ```
      
      ### Visitors
      #### NextFontLoaders (mod.rs)
      Creates several visitors that updates the state and reports errors. This
      is where the AST is mutated. After all other visitors are done the call
      expressions and original imports are removed. The newly generated
      imports are added instead.
      
      #### FontFunctionsCollector
      Finds imports from the specified packages. Function calls of these
      imports should be transformed.
      
      #### FontImportsGenerator
      Creates import declarations, call expression arguments are turned into
      JSON and added to the import as a query.
      
      #### FindFunctionsOutsideModuleScope
      Makes sure that there's no reference of the functions anywhere else but
      the module scope.
      Co-authored-by: 's avatarJJ Kasper <jj@jjsweb.site>
      97b31873
    • Shu Ding's avatar
      Remove unnecessary experimental flag (#40766) · 11dd1de6
      Shu Ding authored
      `config.experimental.serverComponents` is currently required to be
      enabled or disabled together with `config.experimental.appDir` (which
      means `serverComponents === appDir` otherwise it will throw) so there is
      no reason to keep both of them. This PR removes `serverComponents` from
      Next.js and only rely on `appDir` instead.
      
      ## Bug
      
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Feature
      
      - [ ] Implements an existing feature request or RFC. Make sure the
      feature request has been accepted for implementation before opening a
      PR.
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Documentation added
      - [ ] Telemetry added. In case of a feature if it's used or not.
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Documentation / Examples
      
      - [ ] Make sure the linting passes by running `pnpm lint`
      - [ ] The "examples guidelines" are followed from [our contributing
      doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
      11dd1de6
    • Shu Ding's avatar
      Improved bundling strategy for the server graph (#40739) · 6d4f2631
      Shu Ding authored
      This PR changes the external module resolution to eagerly bundle
      node_modules, and some specific Next.js internal modules, if on the
      `WEBPACK_LAYERS.server` layer. While resolving corresponding packages,
      we use the `react-server` export condition (fallbacks to default).
      
      A follow-up PR will be adding a Next.js option to opt-out specific
      packages from being bundled on the server layer.
      
      ## Bug
      
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Feature
      
      - [ ] Implements an existing feature request or RFC. Make sure the
      feature request has been accepted for implementation before opening a
      PR.
      - [ ] Related issues linked using `fixes #number`
      - [x] Integration tests added
      - [ ] Documentation added
      - [ ] Telemetry added. In case of a feature if it's used or not.
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Documentation / Examples
      
      - [ ] Make sure the linting passes by running `pnpm lint`
      - [ ] The "examples guidelines" are followed from [our contributing
      doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
      6d4f2631
    • JJ Kasper's avatar
      Add test case for /404 client transition (#40734) · c5f1e2f7
      JJ Kasper authored
      This adds a test case verifying client transitions to `/404` or
      `/_error` are working properly.
      
      Test deployment with patched reproduction can be seen here
      https://router-bug-repro-4bozmev4p-ijjk-testing.vercel.app/blocked
      
      Closes: https://github.com/vercel/next.js/issues/40667
      c5f1e2f7
    • Henrik Wenz's avatar
      chore: migrate missing document of with-geist-ui example to typescript (#40743) · fc179d14
      Henrik Wenz authored
      ## Documentation / Examples
      
      - [x] Make sure the linting passes by running `pnpm lint`
      - [x] The "examples guidelines" are followed from [our contributing
      doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
      fc179d14
    • Henrik Wenz's avatar
      chore: refactor with-typestyle example (#40740) · 806db1a2
      Henrik Wenz authored
      ## Changes
      
      see commits
      
      ## Documentation / Examples
      
      - [x] Make sure the linting passes by running `pnpm lint`
      - [x] The "examples guidelines" are followed from [our contributing
      doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
      806db1a2
    • Rishabh Poddar's avatar
      Updates with-supertokens example app (#40707) · 51b728fb
      Rishabh Poddar authored
      - Updates supertokens-node and supertokens-auth-react dependencies.
      - Uses separate Email verification recipe instead of using it inside the
      ThirdPartyEmailPassword recipe (as per the update)
      - Uses <SessionAuth> guard instead of <ThirdPartyEmailPassword> guard
      (as per the lib update)
      51b728fb
    • Shu Ding's avatar
      Skip copying next-swc debug files during testing (#40761) · 244b6297
      Shu Ding authored
      I have next-swc compiled locally inside the folder so there're a lot of files there (totally unexpected). And then the `fs.copy` takes 28433 ms... by filtering it out it's only 1s.
      
      ## Bug
      
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Feature
      
      - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Documentation added
      - [ ] Telemetry added. In case of a feature if it's used or not.
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Documentation / Examples
      
      - [ ] Make sure the linting passes by running `pnpm lint`
      - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
      244b6297
    • Tim Neutkens's avatar
      2b9afcfe
    • Tim Neutkens's avatar
      v12.3.2-canary.0 · 5f7caf27
      Tim Neutkens authored
      5f7caf27
    • JJ Kasper's avatar
      Update to leverage AsyncLocalStorage for app static handling (#40727) · bbeaf081
      JJ Kasper authored
      Leverages `AsyncLocalStorage` when available for handling static generation context and falls back to requiring render to be isolated when `AsyncLocalStorage` is not available. 
      
      Note: most changes are spacing so toggling to ignore spacing may make reviewing easier
      bbeaf081
  3. 20 Sep, 2022 8 commits
    • Rostyslav Melnychuk's avatar
      Updated example for i18n middleware (#40728) · 47195173
      Rostyslav Melnychuk authored
      Added support for search params and NEXT_LOCALE cookie if set
      
      <!--
      Thanks for opening a PR! Your contribution is much appreciated.
      To make sure your PR is handled as smoothly as possible we request that
      you follow the checklist sections below.
      Choose the right checklist for the change that you're making:
      -->
      
      ## Bug
      
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Feature
      
      - [ ] Implements an existing feature request or RFC. Make sure the
      feature request has been accepted for implementation before opening a
      PR.
      - [ ] Related issues linked using `fixes #number`
      - [ ] Integration tests added
      - [ ] Documentation added
      - [ ] Telemetry added. In case of a feature if it's used or not.
      - [ ] Errors have a helpful link attached, see `contributing.md`
      
      ## Documentation / Examples
      
      - [ ] Make sure the linting passes by running `pnpm lint`
      - [ ] The "examples guidelines" are followed from [our contributing
      doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
      Co-authored-by: 's avatarJJ Kasper <jj@jjsweb.site>
      47195173
    • Henrik Wenz's avatar
      fix: InferGetServerSidePropsType and InferGetStaticPropsType (#40635) · 3943b20f
      Henrik Wenz authored
      ## Problem
      
      Currently the Next.js infer utility (`InferGetServerSidePropsType` and
      `InferGetStaticPropsType`) types can lead to a wrong inferred types
      (`never`). This happens if these functions return something different
      than: `{props: {}}`.
      
      **Example:** `getServerSideProps`
      
      ```typescript
      export async function getServerSideProps({ query }: GetServerSidePropsContext) {
        if (query.foo) {
          return {
            notFound: true,
          }
        }
      
        return {
          props: { 
            foo: "bar"
          },
        }
      }
      
      type PageProps = InferGetServerSidePropsType<typeof getServerSideProps>
      // => type PageProps = never
      ```
      
      **Example:** `getStaticProps`
      
      ```typescript
      import type { InferGetStaticPropsType, GetStaticPropsContext } from 'next'
      
      export async function getStaticProps(context: GetStaticPropsContext) {
        if (context.params?.bar) {
          return {
            notFound: true,
          }
        }
      
        return {
          props: {
            foo: 'bar',
          },
        }
      }
      
      type PageProps = InferGetStaticPropsType<typeof getStaticProps>
      // => type PageProps = never
      ```
      
      This is because the first infer condition of the utility type is not
      satified leading to a never result.
      
      ```typescript
      export type InferGetServerSidePropsType<T> = T extends GetServerSideProps<
        infer P, // <- NOT SATISFIED
        any
      >
        ? P
        : T extends (
            context?: GetServerSidePropsContext<any>
          ) => Promise<GetServerSidePropsResult<infer P>>
        ? P
        : never  // <- NOT SATISFIED
      ```
      
      ## Solution
      
      I have experimented with different solutions ending with a much simpler
      type, that is faster to execute, easier to read and universally usable
      for both prop variations.
      
      ```typescript
      /**
       * Flow:
       * - Make sure getStaticProps is a function
       * - Get its return type
       * - Extract the one that contains {props: any}
       * - Return the props
       */
      export type InferGetStaticPropsType<T extends (args: any) => any> = Extract<
        Awaited<ReturnType<T>>,
        { props: any }
      >['props']
      ```
      
      ## Bug
      
      - [x] Related issues: fixes #36615, #15913,
      https://twitter.com/leeerob/status/1563540593003106306
      - [x] Type tests added
      
      ## Future thoughts
      
      Since `InferGetStaticPropsType` and `InferGetServerSidePropsType` are
      now the same, it's api could be merged into one utility type (e.g:
      InferNextProps). I recommend doing this in a different PR.
      
      ## Additional info
      
      I have tested this approach using the following [external
      package](https://www.npmjs.com/package/infer-next-props-type)
      (@timneutkens sorry for the late PR). Since about 12 Month I haven't
      received any negative feedback (issues) regarding this approach.
      Co-authored-by: 's avatarJJ Kasper <jj@jjsweb.site>
      3943b20f
    • Henrik Wenz's avatar
      chore: refactor with-next-sitemap example (#40712) · c2f48ea8
      Henrik Wenz authored
      ## Changes
      
      see commits
      
      ## Documentation / Examples
      
      - [x] Make sure the linting passes by running `pnpm lint`
      - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
      c2f48ea8
    • Tim Neutkens's avatar
      499ce6db
    • Tim Neutkens's avatar
    • Jiachi Liu's avatar
      Use resolved url in flight entry loader (#40697) · 0fb3284d
      Jiachi Liu authored
      If there's any resolve alias in webpack config, an aliased resource url will error with `require.resolve` usage in flight manifest plugin, we need to resolve the absolute resource url first then pass down to flight manifest
      
      
      ## Bug
      
      - [ ] Related issues linked using `fixes #number`
      - [x] Integration tests added
      - [ ] Errors have a helpful link attached, see `contributing.md`
      0fb3284d
    • JJ Kasper's avatar
      Break assetPrefix app tests into separate suite (#40701) · 642d52e1
      JJ Kasper authored
      As discussed in slack this breaks out the `assetPrefix` tests to a
      separate suite to speed up the main `app` suite.
      
      x-ref: [slack
      thread](https://vercel.slack.com/archives/C035J346QQL/p1663623560467579)
      642d52e1
    • JJ Kasper's avatar
      Temporarily skip switchable runtime test on deploy (#40700) · e7040602
      JJ Kasper authored
      We can re-enable this after the necessary support has been landed. 
      
      x-ref:
      https://github.com/vercel/next.js/actions/runs/3086118218/jobs/4990617168
      e7040602