- 04 Jan, 2023 1 commit
-
-
JJ Kasper authored
-
- 03 Jan, 2023 22 commits
-
-
Jesse Jafa authored
## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) The https://www.npmjs.com/package/@testing-library/jest-dom is included in the `with-jest` and `with-jest-babel` examples, but that package has DT types which are not included and may cause TS errors. This PR adds them
-
JJ Kasper authored
Corrects the glob from the `src` folder change. Fixes: https://github.com/vercel/next.js/actions/runs/3833725939/jobs/6525483379
-
JJ Kasper authored
This fixture is not being used as we aren't currently able to test the ts plugin directly and will need to investigate using a headless vs code instance to test against. x-ref: https://vercel.slack.com/archives/C04DUD7EB1B/p1672784680457859
-
JJ Kasper authored
Updates to latest version of the dependency.
-
JJ Kasper authored
This request occasionally gets a `403` response most likely from rate limiting inside of GitHub actions so this attempts to increase our rate limits by using the test timings token when available. x-ref: https://github.com/vercel/next.js/actions/runs/3833572871/jobs/6525160878 x-ref: https://github.com/vercel/next.js/actions/runs/3833158940/attempts/1
-
JJ Kasper authored
Closes: https://github.com/vercel/next.js/issues/44542 ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Hannes Bornö authored
Sequences of call stack frames from React or Next.js are collapsed, most of the time these just adds noise to the error overlay. The collapsed stack frames can be expanded though by clicking them. Adds the package of the stack frame to the `'/__nextjs_original-stack-frame'` response, so we can figure out if the stack frame is from React/Next.js in the error overlay. <details> <summary>View before/after</summary> ## Before  ## After  ## Another error, React expanded  </details> ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Jan Kaifer authored
add `testonly` variants for all test modes and refactored `test` as alias of `testheadless` (#44528) So that we don't need to use `NEXT_TEST_MODE=...` ever again manually.
-
Chris Watts authored
Add aws-crt to server-external-packages <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change that you're making: --> ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Francis Li authored
When parsing a cookie, extra `=` characters are removed, when only the first should be removed. e.g. with the cookie `csrf_token_ae6261a96213c493a37ea69489ee39c8bc33a53cda7d95f84efa53146145d09c=lnQptRUO/gpU26e8ZKpGIFHKqtP54vVfR7RBiph8Uc0=` You would expect: key: `csrf_token_ae6261a96213c493a37ea69489ee39c8bc33a53cda7d95f84efa53146145d09c` value: `lnQptRUO/gpU26e8ZKpGIFHKqtP54vVfR7RBiph8Uc0=` If you use `split`, it will remove the last `=` in value, so you get: key: `csrf_token_ae6261a96213c493a37ea69489ee39c8bc33a53cda7d95f84efa53146145d09c` value: `lnQptRUO/gpU26e8ZKpGIFHKqtP54vVfR7RBiph8Uc0` This is because `split` still removes all `=` characters, even if you use the `limit` parameter to limit it to the first 2 elements (as in the existing code). Solution is to not use `split` (I've used `slice` instead) ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)
-
Damien Simonin Feugas authored
##
📖 What's in there? Yesterday we didn't had time to address leftovers from #44045. Here it is. - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added (from [PR 43814](https://github.com/vercel/next.js/pull/43814)) - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## 🧪 How to test? Several tests cases added: - in dev mode, errors and warning: `NEXT_TEST_MODE=dev pnpm testheadless --testPathPattern edge-configurable-runtime` - in build mode, build error for pages on the `edge`: `NEXT_TEST_MODE=start pnpm testheadless --testPathPattern edge-configurable-runtime` Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Yixuan Xu authored
This option was initialial added in #8378. This pr removes `config.experimental.profiling` since this option is no longer used. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Sukka authored
Continues #44202, implements https://github.com/vercel/next.js/pull/44202#discussion_r1053678383. cc @styfle ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Abir Taheer authored
The existing example causes issues with eslint's `eslintimport/no-anonymous-default-export` rule that come pre-enabled with `create-next-app`. Added a name to the api handler function before setting it as the default export. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Tim Neutkens authored
-
Hannes Bornö authored
Test that server components can recover from syntax and component error. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jan Kaifer authored
-
Shu Uesugi authored
Module transpilation docs were missing from the [compilers documentation](https://nextjs.org/docs/advanced-features/compiler). The text was mostly copied from the [Beta docs](https://beta.nextjs.org/docs/api-reference/next.config.js#transpilepackages).
-
Tim Neutkens authored
-
Arda TANRIKULU authored
Use the stable GraphQL Yoga v3 in the GraphQL example, and also disable body parser for fully functionality as in GraphQL Yoga's recipe for Next.js; https://the-guild.dev/graphql/yoga-server/docs/integrations/integration-with-nextjs#exampleCo-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
김형록 authored
The files created when running the app using next-pwa should not be added to git, so I added them to `.gitignore`. Updated by referring to https://github.com/shadowwalker/next-pwa/blob/master/.gitignore.
-
BrandNewLifeJackie26 authored
Closes #44469 ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint`
-
- 01 Jan, 2023 2 commits
-
-
Tim Neutkens authored
-
Bradley Dirheimer authored
Added the types for req and res. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc] Here is the documentation followed [Nextjs Link](https://nextjs.org/docs/basic-features/typescript) Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
- 31 Dec, 2022 4 commits
-
-
IDrumsey authored
For the upgrade guide for 12 to 13, there's a link pointing to the next-image-to-legacy-image, but the fragment link isn't correct. See [this](https://nextjs.org/docs/upgrading#image-component:~:text=next%2Dimage%2Dto%2Dlegacy%2Dimage%3A) which links to `#rename-instances-of-nextimage` which doesn't look like it goes anywhere. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) **Do I need to run the `pnpm build && pnpm lint` for this?**
-
Lee Robinson authored
-
JJ Kasper authored
Fixes handling in isolated tests for windows and adds initial setup to run the main `app-dir` test suite. Also adds retrying when fetching test timings fails due to rate limiting. Closes: https://github.com/vercel/next.js/pull/44331
-
Nora Söderlund authored
Fixes #44452
-
- 30 Dec, 2022 3 commits
-
-
Junya Kono authored
Add pnpm command to execute npm script ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
france1 [ARCH] authored
use => uses
-
Lee Robinson authored
`<meta name="viewport" content="initial-scale=1.0, width=device-width" />` is added by default in `pages`.
-
- 28 Dec, 2022 1 commit
-
-
Dmitry authored
## Documentation / Examples On [Image Component Example README](https://github.com/vercel/next.js/tree/canary/examples/image-component) was a old link to index.js file, instead of index.tsx, changed old link to a new, now page exist, insteadof 404. - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc]
-
- 27 Dec, 2022 2 commits
-
-
Steven Eubank authored
Clarify requirement and move down, since Next.js versions <10 are already quite dated
-
조계진 authored
According to [Upgrade Guide](https://nextjs.org/docs/upgrading#remove-supercomponentdidcatch-from-pages_appjs), `componentDidCatch` has been deprecated and is no longer needed. So I propose that this line get deleted in [Custom App](https://nextjs.org/docs/advanced-features/custom-app) of docs. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
- 24 Dec, 2022 3 commits
-
-
Shu Ding authored
This PR adjusts the error message so it's more accurate and makes more sense. Current error: > You're importing a component that needs Component. New: > You’re importing a class component. NEXT-317 ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Tim Neutkens authored
-
Tim Neutkens authored
-
- 23 Dec, 2022 2 commits
-
-
Steven authored
- Fixes #36681
-
Shu Uesugi authored
When `modularizeImports` was moved out of experiimental [on this PR](https://github.com/vercel/next.js/pull/44240), `docs` and `examples` were not updated. - Update `modularize-imports` example by removing `experimental` from `next.config.js`, as it's currently failing when deployed - For docs: https://nextjs.org/docs/advanced-features/compiler#modularize-imports - Move `Modularize Imports` section outside of `Experimental Features` section - Remove `experimental` from code snippets - Added to version history, just like when SWC Minifier became stable. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-