- 20 Jan, 2023 1 commit
-
-
JJ Kasper authored
-
- 19 Jan, 2023 13 commits
-
-
JJ Kasper authored
-
Jiachi Liu authored
When `appDir` is enabled, `next/dynamic` with `ssr: false` didn't get correctly compiled with swc. The `server_components` condition in next_dynamic transform should respect to the server components compilation, but it was accidently turned on when server components is enabled. This PR fixes it that only turn on the flag when it's in server components compilation (when `is_server` option is `true`) reported by @MaxLeiter ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Hannes Bornö authored
-
Selene Blok authored
fixes https://github.com/vercel/next.js/issues/44316 fixes https://github.com/shikijs/shiki/issues/398Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
RD authored
Co-authored-by:
Shu Ding <g@shud.in> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
JJ Kasper authored
-
Hannes Bornö authored
-
Hannes Bornö authored
Before  After  Fixes NEXT-381 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Adil Ansari authored
-
JJ Kasper authored
-
Rinku Chaudhari authored
-
JJ Kasper authored
-
JJ Kasper authored
-
- 18 Jan, 2023 11 commits
-
-
Hannes Bornö authored
-
tom authored
-
JJ Kasper authored
-
Jan Kaifer authored
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
-
Jan Kaifer authored
We want reproductions to use the new and better code sandbox.
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
-
- 17 Jan, 2023 15 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
-
Jesse Zhu authored
-
Shu Ding authored
Currently the way our renderer injects CSS is to first track CSS imports on the module level, and then render these links on each layer. However, in a complex application it's possible that one CSS being imported in many modules, and in multiple layouts. This causes an issue of duplication. And if there are many rules the order could be messed up by that. This PR deduplicates CSS resources used by one entry (layout, page, error, ...) and all its parent layouts. If an entry is rendered, all its ancestors are rendered too. See test case for more details. Currently those two tests will all fail. Fixes #42862. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Minju Kim authored
-
Kristian Djaković authored
Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
JJ Kasper authored
-
Hannes Bornö authored
-
JJ Kasper authored
-
Tim Neutkens authored
-
Tim Neutkens authored
-
JJ Kasper authored
-