- 07 Mar, 2023 11 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
Follow-up to https://github.com/vercel/next.js/pull/45772 this ensures the rewrite header can be correctly set when a chained middleware rewrite is occurring. x-ref: [slack thread](https://vercel.slack.com/archives/C01RGMANU9Y/p1678074803731489) ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)
-
Sukka authored
Continues from #46380. The PR migrates the unit test cases from the original repo into the Next.js repo.
-
JJ Kasper authored
These utilities aren't needed so can be removed
-
JJ Kasper authored
This updates to no longer skip caching POST or authed requests with the fetch cache and instead we bail when `cookies()` or `headers()` is used prior which is a better heuristic to signal user specific data would be related to the fetch request. x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1678130069138849) ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)
-
JJ Kasper authored
Reverting temporarily as this breaks turbopack support for app dir x-ref: https://github.com/vercel/next.js/actions/runs/4349458918/jobs/7600147372 x-ref: https://github.com/vercel/next.js/actions/runs/4349607013/jobs/7600148420 Reverts vercel/next.js#46826
-
Hannes Bornö authored
Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Jan Kaifer authored
Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Hannes Bornö authored
Currently all helper functions are exported from huge utils files. This moves the helper functions to their own files, this approach aligns better with the rest of the codebase. The unit tests are split up and colocated with the function it tests. Also added some missing tests. Plus some overall cleanup, added comments and fixed types. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Shu Ding authored
This PR updates vendored React to the latest `@next` version, as well as corresponding changes to the manifest and module reference generation code. The new React version includes the following upstream changes: - 49f741046 Fix: Infinite act loop caused by wrong shouldYield (#26317) (Andrew Clark) - 106ea1c58 Support Iterables in Flight (#26313) (Sebastian Markbåge) - f905da227 [Flight] Send server reference error chunks to the client (#26293) (Hendrik Liebau) - e0241b660 Simplify Webpack References by encoding file path + export name as single id (#26300) (Sebastian Markbåge) - 25685d8a9 Codemod tests to waitFor pattern (9/?) (#26309) (Andrew Clark) - 64dde7082 Codemod tests to waitFor pattern (8/?) (#26308) (Andrew Clark) - 3cb5afb82 Codemod tests to waitFor pattern (7/?) (#26307) (Andrew Clark) - e98695db9 Codemod tests to waitFor pattern (6/?) (#26305) (Andrew Clark) - 9a52cc8bc Convert ReactLazy-test to waitFor pattern (#26304) (Andrew Clark) - 03462cfc7 [Fizz] External runtime: fix bug in processing existing elements (#26303) (mofeiZ) - faacefb4d Codemod tests to waitFor pattern (4/?) (#26302) (Andrew Clark) - 06460b6fb Remove unnecessary (and incorrect) code for compatibility with Paper in the Fabric version of GlobalResponderHandler (#26290) (Rubén Norte) - e64a8f403 Codemod tests to waitFor pattern (3/?) (#26299) (Andrew Clark) - ce8a72fd4 Codemod tests to waitFor pattern (2/?) (#26296) (Andrew Clark) - 1f1f8eb55 [Float][Fizz][Fiber]: Refactor <style> Resource implementation to group on flush (#26280) (Josh Story) - 5c633a48f Add back accidentally deleted test comments (#26294) (Andrew Clark) - b073104c2 [DevTools] improve troubleshooting in README (#26235) (Mengdi Chen) - fcf218791 [DevTools] Remove renderer.js from extension build (#26234) (Mengdi Chen) - b72ed698f Fixed incorrect value returned as public instance from reconciler (#26283) (Rubén Norte) - 25a8b9735 Codemod tests to waitFor pattern (1/?) (#26288) (Andrew Clark) - e52446733 New internal testing helpers: waitFor, waitForAll, waitForPaint (#26285) (Andrew Clark) - d49e0e0be Removed unused imperative events implementation from React Native renderer (#26282) (Rubén Norte) ---------
-
Ngô Đức Anh authored
This PR makes `typedRoutes` stricter by constraining generics in `Route` to type string. I've also made generating types for routes a bit more efficient by moving `redirects` and `rewrites`'s processing to the plugin's constructor since `rewrites` and `redirects` don't change in both dev and prod. I've also been trying to fix a bug where route types doesn't generate all the routes (some appear, some don't), but I've got no clues since that doesn't seem easy to reproduce (perhaps it only happens in my case?) ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
- 06 Mar, 2023 5 commits
-
-
Jan Kaifer authored
We recommend that users just opt into `edge` per page. This global default was an unfortunate pattern.
-
Hannes Bornö authored
Migrate examples using `@next/font` to `next/font`. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Irek Róg authored
Because there is a TS error when is set just a string: `TS2322: Type '() => string' is not assignable to type '(loadingProps: DynamicOptionsLoadingProps) => Element | null'. Type 'string' is not assignable to type 'Element'.`
-
Will Binns-Smith authored
Turbopack uses a different format for its css module classnames [0]. This adds and uses a helper function to the next-font tests to assert against these classnames when testing with Turbopack. Ideally these tests could be more behavioral (e.g. asserting on rendered dimensions), but these can't capture things like fallback fonts. [0] https://github.com/vercel/turbo/pull/3437
-
Shu Ding authored
Since the default export syntax is not `fnDecl` but `fnExpr` I added two new methods to abstract out all the transform logic and made both `visit_mut_fn_decl` and `visit_mut_fn_expr` use that. Next step is to support default exports without an ident (`export default async function () {}`). Fixes NEXT-768. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
- 05 Mar, 2023 8 commits
-
-
Steven authored
- Follow up to #46744
-
JJ Kasper authored
-
Federico Minaya authored
this fixes the same as #46493 but for [argon2](https://www.npmjs.com/package/argon2) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: --> ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Shu Ding authored
Since we have 2 server compilers (node and edge), the `serverActions` object will always get overridden by the second compilation during `next build`. Like the client reference manifest, we need to have 2 objects for each compiler and merge them when outputting the asset. Besides that, to avoid `export default` being tree-shaken as unused export, I changed the loader to use CJS `module.exports` instead. Can't easily figure out a proper way for now but we plan to create separate worker for the action endpoint and this will be gone then. Fixes NEXT-759, read NEXT-761 for the full future plan. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Jennifer Proust authored
Fixes #46789 ## Bug - [X] Related issues linked using `fixes #number` ## Feature - [X] Documentation added ## Documentation / Examples - [X] Make sure the linting passes by running `pnpm build && pnpm lint` - [X] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
JJ Kasper authored
Ensures we properly generate the 404 page when a path is being prefetched with middleware configured. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) Closes: https://github.com/vercel/next.js/issues/38239#issuecomment-1454928413
-
Shu Ding authored
When the project's TS config extends another base configuration, and the Next.js TS plugin was configured there, we always output this message:  This PR fixes that by checking the resolved TS options which contains plugins from parent configurations too. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) ---------
-
Tim Neutkens authored
Adds additional alias for `/src/mdx-components` which makes the resolving: - `/src/mdx-components` - `/mdx-components` - `@mdx-js/react` (this one doesn't support server components) Fixes NEXT-515 Fixes #45748 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: --> ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
- 04 Mar, 2023 11 commits
-
-
JJ Kasper authored
-
Tim Neutkens authored
The reported issue has a `pages` directory above the application directory. We can't detect that in eslint but this rule can just be disabled if the file is in a directory called `app/` which in the worst case disables this rule instead of opts the rule in as with the reported issue. Fixes NEXT-730 Fixes #46559 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
JJ Kasper authored
This ensures we properly handle rendering the `404` page when `notFound: true` is returned and middleware is present. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) Fixes: https://github.com/vercel/next.js/issues/38239 x-ref: https://github.com/vercel/next.js/issues/43772 --------- Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Shu Ding authored
Noticed some duplicated CSS resources in a large application and confirmed that this fixes it. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Jiachi Liu authored
Use some utils to match multiple dom nodes together #### Match multiple props for single DOM node ```tsx const matchDom = createDomMatcher(browser) await matchDom('meta', 'name="description"', { content: 'description' }) ``` #### Match multiple same pattern DOM nodes in html ```tsx const $ = await next.render$('html') const matchHtml = createHtmlMatcher($) await matchHtml('meta', 'name', 'property', { description: 'description', og: 'og:description' }) ``` #### Match same pattern DOM nodes in browser after hydration ```tsx const matchMultiDom = createMultiDomMatcher(browser) await matchMultiDom('meta', 'property', 'content', { description: 'description', 'og:title': 'title', 'twitter:title': 'title' }) ``` -
Tim Neutkens authored
Fixes #43605 Fixes NEXT-325 Fixes NEXT-193 This ensures that when the `fetch()` for the RSC payload gets redirected server-side to a URL that fails CORS (e.g. an external url). This catches the error and returns the url that was fetches to be hard-navigated. This also covers other cases like when the host can't be reached. Added a note to add a test for this later as it depends on having a deployment without CORS. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: --> ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
JJ Kasper authored
-
JJ Kasper authored
This ensures we pass through the original matcher source in the middleware manifest for posterity.
-
Steven authored
## Background In the early days, `next export` was created when Next.js was SSR-only in order to statically export your pages for self hosting where no server was available. However, around the time `getStaticProps()` and `getStaticPaths()` were introduced, Next.js began [automatically generating static pages](https://nextjs.org/docs/advanced-features/automatic-static-optimization) (SSG first and SSR opt-in) during `next build`. This meant there were very few reasons to use `next export` and it started to become a stale feature. ## Problem We Need To Solve Users targeting `next export` currently have a really bad experience. They start a new project and use all the features Next.js has to offer because they all features work with `next dev`. Then when development is finished and it comes time to deploy, running `next build && next export` will fail with errors for [unsupported features](https://nextjs.org/docs/advanced-features/static-html-export#unsupported-features). ## Solution This PR introduces a new configuration option, `output: 'export'`, to indicate that the user intends to run `next export`. With this change, Next.js can fail fast during `next dev` if any [unsupported features](https://nextjs.org/docs/advanced-features/static-html-export#unsupported-features) are used, thereby improving developer experience with instant feedback. ```js /** * @type {import('next').NextConfig} */ const nextConfig = { output: 'export', } module.exports = nextConfig ```
-
Shu Ding authored
Similar to #46328 but with `hasServerComponents: false` for the compiler so RSC syntax constrains don't apply here. Note that since we don’t bundle external modules in API routes, we can't resolve to `react-server` so that one will be tricky. Fixes NEXT-625 ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
JJ Kasper authored
x-ref: [slack thread](https://vercel.slack.com/archives/C017QMYC5FB/p1677875647422339) x-ref: [slack thread](https://vercel.slack.com/archives/C049YV4U2F6/p1677875992732789) ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)
-
- 03 Mar, 2023 5 commits
-
-
JJ Kasper authored
This ensures we properly encode chunks for app dir the same we do for pages. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) x-ref: https://github.com/vercel/next.js/pull/8435
-
Henrik Wenz authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: --> This PR fixes a incorrect type doc: [Web app manifests](https://developer.mozilla.org/en-US/docs/Web/Manifest) and [WebExtensions/manifest.json](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json?retiredLocale=de) are not related to each other. WebExtension manifest.json files are used in WebExtensions and are not directly related to WebApps. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Jiachi Liu authored
Related NEXT-472 When you have `app/page.js` and `pages/page.js`, the `pagePath` are the same, which is `/page`. This will result require cache conflicts. When you visit the `app/` page first, then the `pages/` page, the 2nd request will still get the app dir page module, which result in server error. Solution: use different cache key of pagePathCache for pages/ and app/ <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: --> ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)
-
Wyatt Johnson authored
For requests made via the edge runtime, they will not contain the `originalRequest` object used by the request storage to enable headers/cookie access. This uses the request object passed when in the edge runtime.
-
overlookmotel authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. In order to make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change that you're making: --> ## Bug - [ ] Related issues linked using `fixes #number` - [X] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Failing test for #35734.
-