- 13 Mar, 2023 17 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
This ensures our Proxy wrapping request fields works properly in the edge-runtime by explicitly binding to the correct request instance. x-ref: [slack thread](https://vercel.slack.com/archives/C03UR7US95F/p1678730563467089?thread_ts=1678662292.695769&cid=C03UR7US95F)
-
Shu Ding authored
This PR does two major changes: 1. Make sure both pages renderer and app renderer return `RenderResult`, no more `null`. This was achieved with a new `null` type in the constructor `new RenderResult(null)`, and a `.isNull()` method. 2. Remove all mutations of the `renderOpts` object inside renderers. To pass extra information out, they need to be attached to the `RenderResult` now. This also requires 1) to be done. These changes are the initial steps to the isolated rendering worker architecture. Besides those there're also some type improvements. Fixes NEXT-807. ---------
-
Johannes Obermair authored
Fixes #39330. I've not added a new test, but extended the existing test instead (and re-enabled it). It seems to me that a custom next/image config was not considered during static generation (which itself uses `next export`?) before. Adding the config to `renderOpts` in `packages/next/src/export/index.ts` resolves the issue.
-
Benjie authored
### Fixing a bug When a timeout occurs the `handleDisconnect` can be called twice on my machine (Chrome 110.0.5481.178). Once by the timeout code, and once by the `onerror` handler, possibly triggered by the `source.close()` call. This leads to every timeout triggering twice as many clients, which quickly explodes to websocket reconnections spamming the network tab of devtools. This trivial fix resolves the issue. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Abhiyan Dhakal authored
Fixes #46983. The type of `_mongoClientPromise` has been added as Promise<MongoClient> which fixes the error. … file @/examples/with-mongodb/lib/mongodb.ts  <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
John Daly authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Updating the `with-jest` example to make use of the automatic path alias feature that was added in https://github.com/vercel/next.js/pull/45815 I've also updated the dependencies in the example --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
JJ Kasper authored
Move `next-*` crates from Turbopack
-
JJ Kasper authored
-
zlrlyy authored
Co-authored-by:zhenglr <zhenglr@rd.netease.com>
-
Justin Ridgewell authored
Update workspace cargo deps Update cargo deps to point to local workspace Ignore too-many-arguments warnings Fix clippy errors Update pnpm workspaces exclude integration tests from unit tests CI rust-analyzer settings add rust flags and env vars
-
Tobias Koppers authored
-
Shu Ding authored
This is an initial implementation of POST-driven redirection handling: https://vercel.slack.com/archives/C035J346QQL/p1678321389089839. Highly experimental. Fixes NEXT-803, fixes NEXT-804.
-
LongYinan authored
Reduce `unwrap` and `clone` usages
-
Shu Ding authored
This is almost a rewrite of the transform to simply some logic. For a `"use server"` file we now simply annotate every exported identifier and will later do runtime checks. This is because that we can't statically know the source of exported values. This rewrite also makes it possible to annotate anonymous arrow functions. Thanks to @kdy1 for some of the suggestions here. Closes NEXT-708, closes NEXT-421.
-
konomae authored
Fix an anchor currently not working properly.
-
JJ Kasper authored
This ensures our `params` checking works properly with `app` dir. x-ref: [slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1678659475821299)
-
- 12 Mar, 2023 1 commit
-
-
Jiachi Liu authored
-
- 11 Mar, 2023 3 commits
-
-
Tim Neutkens authored
-
Jiachi Liu authored
Set the output bundle file path to `/<metadata route>/route.js` to align with other custom app routes, in order to make it easier being handled by app routes in both nextjs and vercel
-
Yangshun Tay authored
`mdx-bundler` is used for server-side transformation of MDX files and currently using it within server components will throw a `Module parse failed: Unexpected token` error. Adding `serverComponentsExternalPackages: ['mdx-bundler']` to `next.config.js` fixes the issue, but it's probably good to add to the default exclusion list as `mdx-bundler` is a relatively popular approach for using MDX in Next.js apps.
-
- 10 Mar, 2023 12 commits
-
-
Maksym Anisimov authored
Added auto-detection of image/x-icon content type by analyzing response buffer fixes https://github.com/vercel/next.js/discussions/45998Co-authored-by:
Steven <229881+styfle@users.noreply.github.com>
-
Tobias Koppers authored
### Description Keeps track of available modules when importing new chunk groups. Omits assets that are already available in the parent chunk group(s) when determining assets to be included in chunks. ### Testing Instructions Dynamic imports should not include modules that are already in the parent chunks <!-- When the below is checked (default) our PR bot will automatically assign labels to your PR based on the content to help the team organize and review it faster. --> - [x] Auto label fixes WEB-599
-
Jesse Koldewijn authored
fixes #46893 ### What? fixing compile issue reguarding the dompurify package. ### Why? To allow the usage of dompurify ### How? Added jsdom and canvas to the external packages list which are used by dompurify and throw errors if not added to this list.
-
Hannes Bornö authored
Add the new fonts to `next/font/google`.
-
OJ Kwon authored
### Description Another attempt to close WEB-659. The crux is same as previous PR, but attempt to change the location where it read config / bubble down the config values to the actual transform stage. Mainly, `enable_typescript_transform` is now accepting an option instead of boolean flag to down to `EcmaInputTransform::Typescript`, and `get_*_module_context()` reads the config value as needed.
-
Tim Neutkens authored
-
Tobias Koppers authored
# Bugfixes * https://github.com/vercel/turbo/pull/4149 * https://github.com/vercel/turbo/pull/4151Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jiachi Liu authored
Generate `/favicon.ico` route when favicon.ico is placed into `app/`. Still collect favicon metadata image information through metadata-image-loader but don't emit the file to static dist anymore. Also collect favicon through metadata routes, and render it as static routes. Also remove the `hash` we generated before, not needed anymore. Change metadata static routes rendering process: collect static metadata assets, read the buffer of the file data and return it in the response. Closes NEXT-791
-
Shu Ding authored
This PR adds basic support for default export of an async arrow function: ```js export default async (a, b) => { console.log(a, b) } ``` In upcoming PRs I'll refactor named export handling and inlined declarations. -
Shu Ding authored
This PR adds Zod to the precompiled libraries, and use it to create schemas for the router state tree for validation. In other planned features/changes, Zod will also be used to do run-time data validation. Fixes NEXT-135.
-
Tobias Koppers authored
### Description | input file | HTML pathname | Data pathname | | ------------------ | ------------- | ---------------- | | index.tsx | / | .../index.json | | blog.tsx | /blog | .../blog.json | | pricing/index.tsx | /pricing | .../pricing.json |
-
JJ Kasper authored
-
- 09 Mar, 2023 7 commits
-
-
JJ Kasper authored
-
Noemi authored
## Checklist - [ ] Related issues linked using `fixes #number` - no related issue exists, happy to open one if desired - [x] Tests added - not sure if specific tests are needed? there is an integration test for environment variables, and Next.js relies a lot on passing information through environment variables; i'd expect everything to break if this change broke environment variable handling - [x] Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md - no new errors, does not apply ### What? Re-assigning `process.env` substitutes the "magic object" that sets environment variables at the process level with an ordinary JavaScript object. This causes environment variables that are set after `process.env` is re-assigned to not be visible to native add-ons. See [this Node.js issue][issue] and [this reproduction case][repro] for details. [issue]: https://github.com/nodejs/node/issues/46996 [repro]: https://github.com/unflxw/nodejs-process-env-addons-repro ### Why? In general, paraphrasing the maintainer in the Node.js issue, re-assigning `process.env` is not a thing you should do. More specifically, I'm trying to use Next.js' experimental OpenTelemetry support with AppSignal's Node.js integration, which also uses OpenTelemetry. The AppSignal Node.js package sets environment variables in order to configure a long-running process, which is then launched through a native add-on. Because of the re-assignment of `process.env` that occurs early in Next.js' lifecycle process, by the time the AppSignal Node.js package sets environment variables, it's setting them in an ordinary JavaScript object that Next.js left in the global `process` object, not in the magic one created by the Node.js runtime. This means that these environment variables are not _actually_ being set for the process at the OS level, and therefore they're also not set for the native add-on, or for the long-running process it spawns. ### How? A `replaceProcessEnv` function is implemented that takes an environment object as an argument, and applies the difference between that environment object and the current environment to the existing `process.env` object. This function is used instead of re-assigning `process.env`. Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Seiry Yu authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: --> ## Bug fix #46948 - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
Seiry Yu <seiry@squareup.com>
-
JJ Kasper authored
This ensures we leverage the turbo remote cache when able to for the dev swc binary as well. x-ref: https://github.com/vercel/next.js/actions/runs/4378909387/jobs/7664237608
-
Justin Ridgewell authored
# New Features - https://github.com/vercel/turbo/pull/3975 # Bug Fixes - https://github.com/vercel/turbo/pull/4129 - https://github.com/vercel/turbo/pull/4134 - https://github.com/vercel/turbo/pull/4062 # Performance - https://github.com/vercel/turbo/pull/4093
-
Hannes Bornö authored
When the RSC compiler error was caused by an external package, make the error message display which import caused the error. Also don't show node_module files in the import trace. Continuation of https://github.com/vercel/next.js/pull/45484 Before  After  Updates the format of the files, from `app/page.js` to `./app/page.js` to align it with other import traces.  Closes NEXT-523
-
Hannes Bornö authored
Move error overlay recovery tests in `ReactRefreshLogBox.test.ts` to a new file. This is already done for the app router tests, but this does it for the old router as well. Makes `ReactRefreshLogBox.test.ts` faster to run.
-