- 21 Apr, 2023 16 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
Wait for the prompt to show up then enter the cursor change or "y" for prompt to avoid write to child process too early Example ``` Running pnpm release-stable... Releasing patch: cursor stay Enter newline Enter y Await child process... > nextjs-project@0.0.0 release-stable /home/runner/work/next.js/next.js > lerna version --force-publish lerna notice cli v4.0.0 lerna info ci enabled lerna info current version 13.3.1-canary.19 lerna WARN force-publish all packages lerna info Assuming all packages changed ? Select a new version (currently 13.3.1-canary.19) (Use arrow keys) ❯ Patch (13.3.1) Minor (13.4.0) Major (14.0.0) Prepatch (13.3.2-canary.0) Preminor (13.4.0-canary.0) Premajor (14.0.0-canary.0) Custom Prerelease Custom Version ? Select a new version (currently 13.3.1-canary.19) Patch (13.3.1) Changes: ```
-
vercel-release-bot authored
-
Jiachi Liu authored
Adding more logs for GA release job --------- Co-authored-by:Steven <steven@ceriously.com>
-
Jiachi Liu authored
Reverts vercel/next.js#48685 Temporary Revert again to investigate the hang job fix NEXT-1011
-
Jiachi Liu authored
Reland vercel/next.js#48383 fix NEXT-1011
-
Leah authored
### What? Fix snapshots that were no longer fulfilling the original purpose after prettier had its way. The `.prettierignore` also had the old `target/` directory (prior to the `Cargo.toml` move in #48198) so running `pnpm prettier-fix` formatted files in the `target/` directory
-
vercel-release-bot authored
-
Jiachi Liu authored
Reverts vercel/next.js#48383 fix NEXT-1011 revert and re-land later
-
JJ Kasper authored
x-ref: [slack thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1682069797616589)
-
Shu Ding authored
Closes #48653. It should either modify the TS config to add the Next.js plugin, or output a log if it can't (to avoid overriding the base config). <img width="920" alt="CleanShot-2023-04-21-Klqel8BO@2x" src="https://user-images.githubusercontent.com/3676859/233642532-5eed8d5d-d2c5-41e9-99bf-d0eb95685206.png">
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Sebastian Silbermann authored
That way users just have to just bump `@types/react` and `typescript` once TS 5.1. is out to get TS to no longer reject async components.
-
Nabeel Sulieman authored
`fetch-get` and `fetch-set` were typos. They should be `cache-get` and `cache-set`
-
Jimmy Lai authored
This PR implements new cache semantics for the app router on the client. ## Context Currently, on the App Router, every Link navigation is prefetched and kept forever in the cache. This means that once you visit it, you will always see the same version of the page for the duration of your navigation. ## This PR This PR introduces new semantics for how the App Router will cache during navigations. Here's a TL;DR of the changes: - all navigations (prefetched/unprefetched) are cached for a maximum of 30s from the time it was last accessed or created (in this order). - in addition to this, the App Router will cache differently depending on the `prefetch` prop passed to a `<Link>` component: - `prefetch={undefined}`/default behaviour: - the router will prefetch the full page for static pages/partially for dynamic pages - if accessed within 30s, it will use the cache - after that, if accessed within 5 mins, it will re-fetch and suspend below the nearest loading.js - after those 5 mins, it will re-fetch the full content (with a new loading.js boundary) - `prefetch={false}`: - the router will not prefetch anything - if accessed within 30s again, it will re-use the page - after that, it will re-fetch fully - `prefetch={true}` - this will prefetch the full content of your page, dynamic or static - if accessed within 5 mins, it will re-use the page ## Follow ups - we may add another API to control the cache TTL at the page level - a way to opt-in for prefetch on hover even with prefetch={false} <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> link NEXT-1011 -
Sebastian Silbermann authored
Required for https://github.com/vercel/next.js/pull/48641 [React 18 types changelog](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/56210) Revealed some bugs in `React.Children` typings that were hidden due to `{}` being part of `ReactNode` before 18.x types. The rest is mostly missing `children` props types.
-
- 20 Apr, 2023 14 commits
-
-
Dylan Jhaveri authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Jiachi Liu authored
### What `export const runtime = 'experimental-edge'` also work for pages. This PR add tests for that. Closes NEXT-426 Follow up for #46631 that to fully remove all related code of the `experimental.runtime`
-
vercel-release-bot authored
-
JJ Kasper authored
-
Tobias Koppers authored
### What? Adds image optimization to the next/image api for local requests ### Why? More similarity to production. Smaller image downloads from the browser ### How? see also https://github.com/vercel/turbo/pull/4649 fixes WEB-935 ### Turbopack updates * https://github.com/vercel/turbo/pull/4650 <!-- Tobias Koppers - reduce size of TypeType from 32bytes to 16bytes --> * https://github.com/vercel/turbo/pull/4648 <!-- Tobias Koppers - handle chunk register in the sync runtime.none correctly --> * https://github.com/vercel/turbo/pull/4609 <!-- OJ Kwon - fix(ecmascript): eval assignop to the ident --> * https://github.com/vercel/turbo/pull/4652 <!-- Tobias Koppers - allow to pass constant values to free var references --> * https://github.com/vercel/turbo/pull/4649 <!-- Tobias Koppers - Image processing improvements -->
-
Tobias Koppers authored
### What? This fixes a problem when the router fails to load the correct JS file from the page_loader and opts out to full refresh ### Why? The router behaves incorrect when `__NEXT_HAS_REWRITES` is missing in turbopack ### How? see also https://github.com/vercel/turbo/pull/4652 ### Turbopack changes * https://github.com/vercel/turbo/pull/4650 <!-- Tobias Koppers - reduce size of TypeType from 32bytes to 16bytes --> * https://github.com/vercel/turbo/pull/4648 <!-- Tobias Koppers - handle chunk register in the sync runtime.none correctly --> * https://github.com/vercel/turbo/pull/4609 <!-- OJ Kwon - fix(ecmascript): eval assignop to the ident --> * https://github.com/vercel/turbo/pull/4652 <!-- Tobias Koppers - allow to pass constant values to free var references --> * https://github.com/vercel/turbo/pull/4649 <!-- Tobias Koppers - Image processing improvements -->
-
Leah authored
### What? Seems I accidentally included the app root when I initially added it, but apps never have a page loader, so they should be excluded I also cleaned up the manifest a bit, and it now perfectly matches the one in next.js Fixes WEB-926
-
JJ Kasper authored
x-ref: [slack thread](https://vercel.slack.com/archives/C01LN7C5QR5/p1681914697254659)
-
Shu Ding authored
Add a test case for #48583.
-
Jiachi Liu authored
Follow up for #48489 As config is dropped and we can only check server components previously. We can remove it now
-
Shu Ding authored
This PR re-adds #48583, which was accidentally reverted in #48589 (unrelated) somehow.
-
Jan Kaifer authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tobias Koppers authored
### What? add support for blur placeholder generation to turbopack add `StructuredImageModuleType` which is used with `ModuleType::Custom` to allow importing an image as `{ url, width, height, blurDataURL, blurWidth, blurHeight }` in contrast to next.js with webpack this will also generate blur placeholder in development instead of using a _next/image reference. This should lead to more production-like experience (at the cost of a little bit of compilation time). turbo PR: https://github.com/vercel/turbo/pull/4621 ### Why? Turbopack was crashing on `placeholder="blur"` before. fixes WEB-534 ### Turbopack changes * https://github.com/vercel/turbo/pull/4521 <!-- OJ Kwon - feat(contextcondition): support InPath contextcondition --> * https://github.com/vercel/turbo/pull/4601 <!-- Alex Kirszenberg - Chunking Context Refactor pt. 3: Address PR comments from pt. 2 --> * https://github.com/vercel/turbo/pull/4623 <!-- Tobias Koppers - exclude turborepo from turbopack bench tests --> * https://github.com/vercel/turbo/pull/4399 <!-- Leah - support require.context --> * https://github.com/vercel/turbo/pull/4610 <!-- OJ Kwon - test(subset): add mdx test into subset --> * https://github.com/vercel/turbo/pull/4624 <!-- Tobias Koppers - run benchmarks on windows and macOS too --> * https://github.com/vercel/turbo/pull/4620 <!-- Alex Kirszenberg - Make ContainmentTree fully generic --> * https://github.com/vercel/turbo/pull/4600 <!-- Tobias Koppers - add getChunkPath method --> * https://github.com/vercel/turbo/pull/4621 <!-- Tobias Koppers - add turbopack-image --> * https://github.com/vercel/turbo/pull/4639 <!-- Tobias Koppers - restrict snapshot path for windows path length limit --> * https://github.com/vercel/turbo/pull/4641 <!-- Tobias Koppers - put webp behind a feature flag --> -
Tim Neutkens authored
Second try for #48561 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Sophie Alpert <git@sophiebits.com> Co-authored-by:
Shu Ding <g@shud.in>
-
- 19 Apr, 2023 10 commits
-
-
JJ Kasper authored
This adds the discussed updated cache handling for app dir for more fine grained control over the cached values. Also adds initial `revalidateTag` and `revalidatePath` exports from `next/server` although export location may change. Continuation of https://github.com/vercel/next.js/pull/47720 x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1681404363048459)
-
Quentin authored
### What? Some fields were missing from the `Manifest` type. Types were written according to [MDN](https://developer.mozilla.org/en-US/docs/Web/Manifest) and [W3C](https://www.w3.org/TR/appmanifest/#) documentation. ### Why? To improve developer experience with the new [File-Based Metadata API](https://nextjs.org/blog/next-13-3#file-based-metadata-api) for Manifest.
-
Ryo authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> closes #48416 ### What? Standardize the "Note" format in the Next.js documentation for improved consistency and readability. ### Why? There are currently four different variations of "Note" formatting in the documentation. Standardizing to a single format will improve the overall experience for users. ### How? Update all instances of "Note" in the documentation to follow the most common format, `**Note**:` (used in 27 files). This will involve updating the following variations: - `Note` (12 files) - `Note:` (20 files) - `**Note:**` (21 files) --------- Co-authored-by:
Steven <steven@ceriously.com>
-
JJ Kasper authored
-
Shu Ding authored
This PR corrects the file names of chunks in the flight manifest. Previously we assume that the chunk file is always named as `(requiredChunk.name || requiredChunk.id) + '-' + requiredChunk.hash` and located in `static/chunks`. This isn't always true (see the comment) especially when a chunk was generated via `import()`. Another mistake was that we assume that one chunk only generates one file, but it's actually possible that it depends on multiple files. This should address many of the "Chunk failed to load" errors. Closes [#47173](https://github.com/vercel/next.js/issues/47173), fixes NEXT-847 fix #47173
-
Leah authored
This enables the existing prettier config to auto apply to code inside the `next-swc` package
-
Shu Ding authored
Closes NEXT-684, closes #43396. This PR implements a temporary workaround to address the issue that some browsers are always caching CSS resources during the lifetime of a session. We re-introduce the versioning query to the resource to avoid that, and then use Mutation Observer to do GC manually on the client. Once Float handles that by itself, we can probably remove this. Note that correctly handling GC here is **required** for correctness, not an optimization. That's why it took us a while to address this (even this PR is still a temporary workaround). Imagine that if you have: ```css h1 { color: red; } ``` and then you changed it to: ```css h1 { font-size: 300px; } ``` During HMR, if we don't remove the old resources but only insert the new one, both will be applied and you will still see the `<h1>` in red, which is wrong. Here's a recording of this PR working correctly in Firefox: https://user-images.githubusercontent.com/3676859/233132831-b88e4d8d-aec9-48c4-9aa7-7c7a149b377d.mp4 -
OJ Kwon authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### How? Closes NEXT- Fixes # --> ### What? This PR changes to the `root` of the cargo workspace to the root of repo itself, allows next-swc and other rust codebase can use repo root as workspace root. ### Why? Currently cargo manifest for the next-swc is not placed under the root of the repo, which makes invocation to the tool requires to change cwd / or set cwd. Similarly needs to open editor to the root of the cargo manifest separately to able to utilize language server kicks in. Moving manifest to the root consolidates those, so can invoke either cli / or editor to the same root of the repo.
-
Toru Kobayashi authored
fixes #42729 According to #42729, the minimum Node.js version of Next is `14.18.0`, but some docs say `14.6.0`, and it's error-prone. https://github.com/vercel/next.js/issues/42729#issuecomment-1309947579 pointed out it's a bug rather than wrong documentation. But Node v14 is going to be EOF this month, so Next will update the minimum version in the next major release. https://github.com/nodejs/release#release-schedule So I feel it's enough to only fix the documentation rather than fixing the implementation to work with 14.6.0 as a temporary fix. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Steven <steven@ceriously.com>
-
JJ Kasper authored
-