- 24 Apr, 2023 4 commits
-
-
vercel-release-bot authored
-
Tim Neutkens authored
This reverts commit 1c007cee.
-
vercel-release-bot authored
-
Tim Neutkens authored
### What? Compiles Next.js core files using the same default target as client-side files, ensuring that `async`/`await` and such are not turned into generators. The client-side files are all opted into compilation during dev/build already so if you create a browserslist config that will still apply in the same way. This change only changes the output of the core files. ### How? Moved the default we use in Next.js into a separate `.js` file so that it can be imported from the taskfile-swc plugin, this way we're using the same defaults. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
- 23 Apr, 2023 6 commits
-
-
vercel-release-bot authored
-
Steven authored
Draft Mode is very similar to Preview Mode but doesn't include any additional data. This PR implements support for Draft Mode in `pages` and a future PR will implement support in `app`. fix NEXT-992
-
Afonso Jorge Ramos authored
Hey! Hope this can help anyone dealing with this in the future. I'm also using the `TinaMarkdown` provider to generate my MDX and one of the things that I've found helpful so that the image was better handled in the browser was to set position to `undefined`, as it was the only way to unset it from `absolute`, which was affecting the visual aspect of the page. Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
Sreetam Das authored
The TS plugin incorrectly gives a warning for the `reset` prop in the `global-error.tsx` file. This was previously reported and fixed for the `error.tsx` file. - https://github.com/vercel/next.js/issues/46573 - https://github.com/vercel/next.js/pull/46898 --- You can see a reproduction on [CodeSandbox](https://codesandbox.io/p/sandbox/summer-dawn-b0gydg?file=%2Fapp%2Flayout.tsx&selection=%5B%7B%22endColumn%22%3A16%2C%22endLineNumber%22%3A18%2C%22startColumn%22%3A16%2C%22startLineNumber%22%3A18%7D%5D) — `global-error.tsx`'s `reset` prop has the following warning: ``` Props must be serializable for components in the "use client" entry file, "reset" is invalid. ts(71007) ``` I haven't filed an issue for this yet since this was a simple enough fix, but happy to create one if needed :)
-
-
Wyatt Fry authored
"ran" is conjugated, which cannot be used after the verb "to be", only the infinitive "run" is correct here.
-
- 22 Apr, 2023 1 commit
-
-
Jiachi Liu authored
Reverts vercel/next.js#48688 fix NEXT-1011
-
- 21 Apr, 2023 20 commits
-
-
Shu Ding authored
Feedback form @MaxLeiter, that we shouldn't tell the user to add "use client" in this case: 
-
Shu Ding authored
When sending a multipart form data, we currently wait until the entire update finishes before we decode it via `decodeReply`. This way is universal in both runtimes (as we don't have `decodeReplyFromBusboy` in Edge), but also not efficient. This PR changes it to use `decodeReplyFromBusboy` in the Node runtime, which can decode the payload during streaming as well as file update support.
-
Shu Ding authored
Closes NEXT-228 Closes NEXT-227
-
Shu Ding authored
Same purpose as #48297, but without the React channel branching logic to make it easier to land. Since we have #48478 reverted, we only need to consider `pages` and `app` inside the require hook. > This PR aims to improve the current require hook by implementing two key changes. Firstly, it ensures that the initialization occurs at the top of the module level for correctness. Secondly, we now set the NEXT_PREBUNDLED_REACT environment variable at the process level to ensure that we don't mix the two types of rendering processes and we always resolve the correct React package. > > These improvements are made possible by the changes introduced in PR https://github.com/vercel/next.js/pull/47857. > > Closes [NEXT-231](https://linear.app/vercel/issue/NEXT-231). This will likely fix #45258 too. --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
vercel-release-bot authored
-
Jiachi Liu authored
Wait for the prompt to show up then enter the cursor change or "y" for prompt to avoid write to child process too early Example ``` Running pnpm release-stable... Releasing patch: cursor stay Enter newline Enter y Await child process... > nextjs-project@0.0.0 release-stable /home/runner/work/next.js/next.js > lerna version --force-publish lerna notice cli v4.0.0 lerna info ci enabled lerna info current version 13.3.1-canary.19 lerna WARN force-publish all packages lerna info Assuming all packages changed ? Select a new version (currently 13.3.1-canary.19) (Use arrow keys) ❯ Patch (13.3.1) Minor (13.4.0) Major (14.0.0) Prepatch (13.3.2-canary.0) Preminor (13.4.0-canary.0) Premajor (14.0.0-canary.0) Custom Prerelease Custom Version ? Select a new version (currently 13.3.1-canary.19) Patch (13.3.1) Changes: ```
-
vercel-release-bot authored
-
Jiachi Liu authored
Adding more logs for GA release job --------- Co-authored-by:Steven <steven@ceriously.com>
-
Jiachi Liu authored
Reverts vercel/next.js#48685 Temporary Revert again to investigate the hang job fix NEXT-1011
-
Jiachi Liu authored
Reland vercel/next.js#48383 fix NEXT-1011
-
Leah authored
### What? Fix snapshots that were no longer fulfilling the original purpose after prettier had its way. The `.prettierignore` also had the old `target/` directory (prior to the `Cargo.toml` move in #48198) so running `pnpm prettier-fix` formatted files in the `target/` directory
-
vercel-release-bot authored
-
Jiachi Liu authored
Reverts vercel/next.js#48383 fix NEXT-1011 revert and re-land later
-
JJ Kasper authored
x-ref: [slack thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1682069797616589)
-
Shu Ding authored
Closes #48653. It should either modify the TS config to add the Next.js plugin, or output a log if it can't (to avoid overriding the base config). <img width="920" alt="CleanShot-2023-04-21-Klqel8BO@2x" src="https://user-images.githubusercontent.com/3676859/233642532-5eed8d5d-d2c5-41e9-99bf-d0eb95685206.png">
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Sebastian Silbermann authored
That way users just have to just bump `@types/react` and `typescript` once TS 5.1. is out to get TS to no longer reject async components.
-
Nabeel Sulieman authored
`fetch-get` and `fetch-set` were typos. They should be `cache-get` and `cache-set`
-
Jimmy Lai authored
This PR implements new cache semantics for the app router on the client. ## Context Currently, on the App Router, every Link navigation is prefetched and kept forever in the cache. This means that once you visit it, you will always see the same version of the page for the duration of your navigation. ## This PR This PR introduces new semantics for how the App Router will cache during navigations. Here's a TL;DR of the changes: - all navigations (prefetched/unprefetched) are cached for a maximum of 30s from the time it was last accessed or created (in this order). - in addition to this, the App Router will cache differently depending on the `prefetch` prop passed to a `<Link>` component: - `prefetch={undefined}`/default behaviour: - the router will prefetch the full page for static pages/partially for dynamic pages - if accessed within 30s, it will use the cache - after that, if accessed within 5 mins, it will re-fetch and suspend below the nearest loading.js - after those 5 mins, it will re-fetch the full content (with a new loading.js boundary) - `prefetch={false}`: - the router will not prefetch anything - if accessed within 30s again, it will re-use the page - after that, it will re-fetch fully - `prefetch={true}` - this will prefetch the full content of your page, dynamic or static - if accessed within 5 mins, it will re-use the page ## Follow ups - we may add another API to control the cache TTL at the page level - a way to opt-in for prefetch on hover even with prefetch={false} <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> link NEXT-1011 -
Sebastian Silbermann authored
Required for https://github.com/vercel/next.js/pull/48641 [React 18 types changelog](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/56210) Revealed some bugs in `React.Children` typings that were hidden due to `{}` being part of `ReactNode` before 18.x types. The rest is mostly missing `children` props types.
-
- 20 Apr, 2023 9 commits
-
-
Dylan Jhaveri authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Jiachi Liu authored
### What `export const runtime = 'experimental-edge'` also work for pages. This PR add tests for that. Closes NEXT-426 Follow up for #46631 that to fully remove all related code of the `experimental.runtime`
-
vercel-release-bot authored
-
JJ Kasper authored
-
Tobias Koppers authored
### What? Adds image optimization to the next/image api for local requests ### Why? More similarity to production. Smaller image downloads from the browser ### How? see also https://github.com/vercel/turbo/pull/4649 fixes WEB-935 ### Turbopack updates * https://github.com/vercel/turbo/pull/4650 <!-- Tobias Koppers - reduce size of TypeType from 32bytes to 16bytes --> * https://github.com/vercel/turbo/pull/4648 <!-- Tobias Koppers - handle chunk register in the sync runtime.none correctly --> * https://github.com/vercel/turbo/pull/4609 <!-- OJ Kwon - fix(ecmascript): eval assignop to the ident --> * https://github.com/vercel/turbo/pull/4652 <!-- Tobias Koppers - allow to pass constant values to free var references --> * https://github.com/vercel/turbo/pull/4649 <!-- Tobias Koppers - Image processing improvements -->
-
Tobias Koppers authored
### What? This fixes a problem when the router fails to load the correct JS file from the page_loader and opts out to full refresh ### Why? The router behaves incorrect when `__NEXT_HAS_REWRITES` is missing in turbopack ### How? see also https://github.com/vercel/turbo/pull/4652 ### Turbopack changes * https://github.com/vercel/turbo/pull/4650 <!-- Tobias Koppers - reduce size of TypeType from 32bytes to 16bytes --> * https://github.com/vercel/turbo/pull/4648 <!-- Tobias Koppers - handle chunk register in the sync runtime.none correctly --> * https://github.com/vercel/turbo/pull/4609 <!-- OJ Kwon - fix(ecmascript): eval assignop to the ident --> * https://github.com/vercel/turbo/pull/4652 <!-- Tobias Koppers - allow to pass constant values to free var references --> * https://github.com/vercel/turbo/pull/4649 <!-- Tobias Koppers - Image processing improvements -->
-
Leah authored
### What? Seems I accidentally included the app root when I initially added it, but apps never have a page loader, so they should be excluded I also cleaned up the manifest a bit, and it now perfectly matches the one in next.js Fixes WEB-926
-
JJ Kasper authored
x-ref: [slack thread](https://vercel.slack.com/archives/C01LN7C5QR5/p1681914697254659)
-
Shu Ding authored
Add a test case for #48583.
-