- 04 May, 2023 29 commits
-
-
vercel-release-bot authored
-
JJ Kasper authored
-
Tim Neutkens authored
Co-authored-by:
Jimmy Lai <laijimmy0@gmail.com> Co-authored-by:
Shu Ding <g@shud.in>
-
Maia Teegarden authored
Closes WEB-918 Closes WEB-913
-
Jiachi Liu authored
Fixes #48962 Fixes #49009 Fixes #49107 ### Why For standalone mode the `fs.readFile` is executed for `route.js` when the module is loaded, then the fs operation aginst the wrong file path will break the proper module loading, then it fallbacks to `/_error` module. ### What We move the fs read operation to the first get then cache the buffer in the module level variable, so that `fs.readFile` won't be executed. As we already have prerender cache, the meta/body fs cache will be HIT and served
-
Jiachi Liu authored
### What Upgrade react/react-dom typing to latest ``` "@types/react": "18.2.5", "@types/react-dom": "18.2.3", ```
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? Use pre-rewrite URL for rendering ### Why? Rendering app pages needs the original user facing URL. ### Turbopack changes * https://github.com/vercel/turbo/pull/4818 <!-- Tobias Koppers - pass original url with content source data --> * https://github.com/vercel/turbo/pull/4817 <!-- Tobias Koppers - avoid errors in computing issue details -->
-
Tobias Koppers authored
### What? disable optimistic_updates So it no longer does that: > If Kodiak is merging an out-of-date pull request that has running status checks, update the pull request's branch without waiting for the running status checks to finish. The problem with that is that it cancels running checks and restarts them. Instead it waits for all running status checks before updating the PR. ### Why? This should avoid the case where a PR is updated again and again without yielding a result. It also saves some CI cost And it allows CI to finish and fill up the turborepo cache, which can potentially used for the next run.
-
Tobias Koppers authored
### What? RSC also needs a different next/dynamic on client side Co-authored-by:
Jiachi Liu <inbox@huozhi.im> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Shu Ding authored
Reorganize the test cases a bit by separating server/client graphs. And make sure that using `'use server'` inside a Client Component will result in a compilation error.
-
vercel-release-bot authored
-
Shu Ding authored
The value of `__NEXT_PRIVATE_PREBUNDLED_REACT` has to be a correct React channel.
-
Tobias Koppers authored
* https://github.com/vercel/turbo/pull/4815 <!-- Tobias Koppers - fix CSS HMR --> --------- Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jimmy Lai authored
- enables redirect for the edge - enables production tests link NEXT-1086
-
vercel-release-bot authored
-
Jiachi Liu authored
Fixes #48392 When passing down `Array<IconDescriptor>`, it should allow overriding `rel` prop of icon instead of always picking the default one fix NEXT-1085
-
Jiachi Liu authored
We picked `VERCEL_URL` env for `metadataBase` in preview mode, but also picking that on production, this could potentially use the unique build url for social images if you didn't set `metadataBase` We recommend to set the major/preferred domain to `metadataBase` if you're using social images, this PR help warn you in every env if you're missing that [slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1683150633962539?thread_ts=1683144147.664059&cid=C03KAR5DCKC)
-
Shu Ding authored
Currently we are always use an array for the `.$$bound` field of an action even if it's empty. This PR updates the transform to generate `null` in that case so we can do further optimizations. Note that `[]` and `null` are slightly different here similar to `f.bind`.
-
Sebastian Markbåge authored
This uses the new built-in progressive enhancement features of React. These always use `multipart/form-data` atm. When one comes in that's not a fetch, we can use `decodeAction` to get a resolved function. This also ensures that we can test this by passing disableJavaScript to tests. This disables JS for the context.
-
Shu Ding authored
Fixes #49055, fixes #48918. App dir will always require the server to run in the workers mode, so it can keep a separate Node.js process for pages. This PR updates the standalone server to initialize a "standalone server" (which works similar to `start-server`), and changes the tracked files to include Jest worker.
-
vercel-release-bot authored
-
Justin Ridgewell authored
A simple test case to ensure `cookies()` is usable inside App Routes, based on a prior bug report. Closes WEB-627 --------- Co-authored-by:Tobias Koppers <tobias.koppers@googlemail.com>
-
Tobias Koppers authored
### What? test case for https://github.com/vercel/turbo/pull/4787 --------- Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Tobias Koppers authored
### What? removes the ``` event - startup 3.643ms ``` message ### Why? no useful information in this message since it's just too fast Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Andrew Clark authored
Includes the following upstream changes: - [aef7ce554](https://github.com/facebook/react/commits/aef7ce554) [Flight] Progressively Enhanced Server Actions ([#26774](https://github.com/facebook/react/pull/26774)) (Sebastian Markbåge) - [c10010a6a](https://github.com/facebook/react/commits/c10010a6a) [Fizz] Gracefully handle suspending in DOM configs ([#26768](https://github.com/facebook/react/pull/26768)) (Sebastian Markbåge) - [f533cee8c](https://github.com/facebook/react/commits/f533cee8c) Add useFormStatus to Flight fixture ([#26773](https://github.com/facebook/react/pull/26773)) (Andrew Clark) - [2c1117a8d](https://github.com/facebook/react/commits/2c1117a8d) Reuse request so that a ReabableStream body does not become disturbed ([#26771](https://github.com/facebook/react/pull/26771)) (Andrew Gadzik) - [fa7a447b9](https://github.com/facebook/react/commits/fa7a447b9) [Fizz] Check for nullish values on ReactCustomFormAction ([#26770](https://github.com/facebook/react/pull/26770)) (Sebastian Markbåge) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
- 03 May, 2023 11 commits
-
-
Shu Ding authored
Adds proper `multipart/form-data` handling in the Edge runtime and fixes a bug (previously we are always using `serverActionsManifest.node`). For the form data, we just use `await webRequest.request.formData()` for now and will handle streaming later.
-
Shu Ding authored
Found this one being a bit random during dev, but it's trivial. See discussions: https://github.com/vercel/next.js/pull/49168#issuecomment-1533788373
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> link NEXT-920 --------- Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-
Shu Ding authored
Fixes #48948 ([repro](https://github.com/vercel/next.js/issues/48948#issuecomment-1533542001)). When running inside a custom server with app dir, we should always opt into the prebundled React with correct channels. Thanks @karlhorky for help testing it! Fixes #49169 too. --------- Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Steven authored
We have reports of users scrolling down the the bottom to copy/paste `domains` configuration, instead of using the safer `remotePatterns` configuration at the top. This PR collapses the older `domains` configuration behind a details toggle since it is only needed for older versions of Next.js prior to 12.3.0
-
Shu Ding authored
This makes sure that we are treating a module as in the server layer, if it's under the client layer but with file-level `"use server"`. Also makes sure we're catching errors like having both `"use server"` and `"use client"` directives presented.
-
Andrew Clark authored
Includes the following upstream changes: - [b7972822b](https://github.com/facebook/react/commits/b7972822b) useOptimisticState -> useOptimistic ([#26772](https://github.com/facebook/react/pull/26772)) (Andrew Clark) - [388686f29](https://github.com/facebook/react/commits/388686f29) Add "canary" to list of allowed npm dist tags ([#26767](https://github.com/facebook/react/pull/26767)) (Andrew Clark) - [8a25302c6](https://github.com/facebook/react/commits/8a25302c6) fix[dynamic-scripts-injection]: unregister content scripts before registration ([#26765](https://github.com/facebook/react/pull/26765)) (Ruslan Lesiutin) - [2c2476834](https://github.com/facebook/react/commits/2c2476834) Rename "next" prerelease channel to "canary" ([#26761](https://github.com/facebook/react/pull/26761)) (Andrew Clark) - [fa4314841](https://github.com/facebook/react/commits/fa4314841) Remove deprecated workflow key from Circle config ([#26762](https://github.com/facebook/react/pull/26762)) (Andrew Clark) - [5dd90c562](https://github.com/facebook/react/commits/5dd90c562) Use content hash for react-native builds ([#26734](https://github.com/facebook/react/pull/26734)) (Samuel Susla) - [559e83aeb](https://github.com/facebook/react/commits/559e83aeb) [Fizz] Allow an action provide a custom set of props to use for progressive enhancement ([#26749](https://github.com/facebook/react/pull/26749)) (Sebastian Markbåge) - [67f4fb021](https://github.com/facebook/react/commits/67f4fb021) Allow forms to skip hydration of hidden inputs ([#26735](https://github.com/facebook/react/pull/26735)) (Sebastian Markbåge) - [8ea96ef84](https://github.com/facebook/react/commits/8ea96ef84) [Fizz] Encode external fizz runtime into chunks eagerly ([#26752](https://github.com/facebook/react/pull/26752)) (Josh Story) - [491aec5d6](https://github.com/facebook/react/commits/491aec5d6) Implement experimental_useOptimisticState ([#26740](https://github.com/facebook/react/pull/26740)) (Andrew Clark) - [9545e4810](https://github.com/facebook/react/commits/9545e4810) Add nonce support to bootstrap scripts and external runtime ([#26738](https://github.com/facebook/react/pull/26738)) (Dan Ott) - [86b0e9199](https://github.com/facebook/react/commits/86b0e9199) Gate DevTools test to fix CI ([#26742](https://github.com/facebook/react/pull/26742)) (Andrew Clark) - [b12bea62d](https://github.com/facebook/react/commits/b12bea62d) Preinits should support a nonce option ([#26744](https://github.com/facebook/react/pull/26744)) (Josh Story) - [efbd68511](https://github.com/facebook/react/commits/efbd68511) Remove unused `initialStatus` parameter from `useHostTransitionStatus` ([#26743](https://github.com/facebook/react/pull/26743)) (Sebastian Silbermann) - [18282f881](https://github.com/facebook/react/commits/18282f881) Fix: Update while suspended fails to interrupt ([#26739](https://github.com/facebook/react/pull/26739)) (Andrew Clark) - [540bab085](https://github.com/facebook/react/commits/540bab085) Implement experimental_useFormStatus ([#26722](https://github.com/facebook/react/pull/26722)) (Andrew Clark) ---------
-
Francis Gulotta authored
## For Contributors I know it's an unstable api but this just makes it easier to test with. This uses the type of the callback to `unstable_cache` as the return type of `unstable_cache`.
-
Maia Teegarden authored
Allows webpack config so Turbopack can be used for dev and webpack can be used for production. Also warns if there is no corresponding Turbopack config (only a warning since webpack config could be prod specific) Closes WEB-984 <img width="647" alt="Screenshot 2023-05-03 at 12 32 08 PM" src="https://user-images.githubusercontent.com/2865858/236027314-4c762b4d-ebe4-486a-bd64-5215dcf60db6.png">
-
Maia Teegarden authored
Search for package manager lockfiles to find Turbopack root since `turbo.json` files can be nested now. ---------
-
JJ Kasper authored
This ensures we match behavior local and deployed and also cleans up naming of the methods. ---------
-