- 05 May, 2023 5 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
JJ Kasper authored
-
Tim Neutkens authored
## What? Removes `experimental.appDir` this was leftover from when I flipped the switch. Kept the config file as in the future we might add future flags and such. It also helps that it has the types comment included so you always get types. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
JJ Kasper authored
Only shows fetch request logs by default and allows opting into verbose request timings via experimental config. x-ref: [slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1683236293282549)
-
- 04 May, 2023 35 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
-
JJ Kasper authored
Updates the tag handling during a server action direct to pass through the revalidated tags for immediate revalidation as discussed. x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1683218335368759)
-
Shu Ding authored
This fixes an existing bug where there're Server Actions defined in both the "server" and "client" layers (client imported Actions). They have the same worker name as they exist in one route entry, but they're built into different modules and compiled differently (server and client layers). Because of that, each route entry can have 2 "action module entries". This PR adds the logic to differentiate that via a "layer" field so they don't conflict.
-
Jiachi Liu authored
Fixes #49162 When user configures the `basePath` in `next.config.js`, we need to apply it to metadata image path resolving fix NEXT-1087
-
Ivan Kryvorotenko authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change --> ### What? This is a follow-up to https://github.com/vercel/next.js/pull/46290 by @ijjk Currently, nextjs build resolves provided incrementalCacheHandlerPath over destDir (.next by default). And for standalone builds the custom cache can't be resolved and leads to runtime error. ### Why? This fix basically introduces support of incrementalCacheHandlerPath for the standalone build. ### How? incrementalCacheHandlerPath is now always resolved relatively to distDir, which should work for both default and standalone builds. Also, for convenience (and better testability) incrementalCacheHandlerPath can now be provided as a relative path to the project directory.
-
vercel-release-bot authored
-
JJ Kasper authored
This updates our dev logs to include request timings and also includes fetch timings in app directory to including info on whether the cache was leveraged or not allowing easier debugging of contributing factors to render times. In the future we can expand to include middleware timings separate as well to single that out along with timings for `getStaticProps` potentially as well. <details> <summary>Screenshot</summary>  </details> <details> <summary>Screenshot</summary>  </details> <details> <summary>Screenshot</summary>  </details> x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1681418590738249)
-
Justin Ridgewell authored
### What? Fixes serving images that are referenced by JS files inside the `/app` directory. ### Why? ### How? The `NextImageContentSource` attempts to fetch the image out of it's inner content source, and before we were only providing it with the `/public` and `/pages` directory's respective sources. Re: https://vercel.slack.com/archives/C046HAU4H7F/p1683220799917649
-
Jimmy Lai authored
-
vercel-release-bot authored
-
JJ Kasper authored
-
Tim Neutkens authored
Co-authored-by:
Jimmy Lai <laijimmy0@gmail.com> Co-authored-by:
Shu Ding <g@shud.in>
-
Maia Teegarden authored
Closes WEB-918 Closes WEB-913
-
Jiachi Liu authored
Fixes #48962 Fixes #49009 Fixes #49107 ### Why For standalone mode the `fs.readFile` is executed for `route.js` when the module is loaded, then the fs operation aginst the wrong file path will break the proper module loading, then it fallbacks to `/_error` module. ### What We move the fs read operation to the first get then cache the buffer in the module level variable, so that `fs.readFile` won't be executed. As we already have prerender cache, the meta/body fs cache will be HIT and served
-
Jiachi Liu authored
### What Upgrade react/react-dom typing to latest ``` "@types/react": "18.2.5", "@types/react-dom": "18.2.3", ```
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? Use pre-rewrite URL for rendering ### Why? Rendering app pages needs the original user facing URL. ### Turbopack changes * https://github.com/vercel/turbo/pull/4818 <!-- Tobias Koppers - pass original url with content source data --> * https://github.com/vercel/turbo/pull/4817 <!-- Tobias Koppers - avoid errors in computing issue details -->
-
Tobias Koppers authored
### What? disable optimistic_updates So it no longer does that: > If Kodiak is merging an out-of-date pull request that has running status checks, update the pull request's branch without waiting for the running status checks to finish. The problem with that is that it cancels running checks and restarts them. Instead it waits for all running status checks before updating the PR. ### Why? This should avoid the case where a PR is updated again and again without yielding a result. It also saves some CI cost And it allows CI to finish and fill up the turborepo cache, which can potentially used for the next run.
-
Tobias Koppers authored
### What? RSC also needs a different next/dynamic on client side Co-authored-by:
Jiachi Liu <inbox@huozhi.im> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Shu Ding authored
Reorganize the test cases a bit by separating server/client graphs. And make sure that using `'use server'` inside a Client Component will result in a compilation error.
-
vercel-release-bot authored
-
Shu Ding authored
The value of `__NEXT_PRIVATE_PREBUNDLED_REACT` has to be a correct React channel.
-
Tobias Koppers authored
* https://github.com/vercel/turbo/pull/4815 <!-- Tobias Koppers - fix CSS HMR --> --------- Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jimmy Lai authored
- enables redirect for the edge - enables production tests link NEXT-1086
-
vercel-release-bot authored
-
Jiachi Liu authored
Fixes #48392 When passing down `Array<IconDescriptor>`, it should allow overriding `rel` prop of icon instead of always picking the default one fix NEXT-1085
-
Jiachi Liu authored
We picked `VERCEL_URL` env for `metadataBase` in preview mode, but also picking that on production, this could potentially use the unique build url for social images if you didn't set `metadataBase` We recommend to set the major/preferred domain to `metadataBase` if you're using social images, this PR help warn you in every env if you're missing that [slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1683150633962539?thread_ts=1683144147.664059&cid=C03KAR5DCKC)
-
Shu Ding authored
Currently we are always use an array for the `.$$bound` field of an action even if it's empty. This PR updates the transform to generate `null` in that case so we can do further optimizations. Note that `[]` and `null` are slightly different here similar to `f.bind`.
-
Sebastian Markbåge authored
This uses the new built-in progressive enhancement features of React. These always use `multipart/form-data` atm. When one comes in that's not a fetch, we can use `decodeAction` to get a resolved function. This also ensures that we can test this by passing disableJavaScript to tests. This disables JS for the context.
-
Shu Ding authored
Fixes #49055, fixes #48918. App dir will always require the server to run in the workers mode, so it can keep a separate Node.js process for pages. This PR updates the standalone server to initialize a "standalone server" (which works similar to `start-server`), and changes the tracked files to include Jest worker.
-
vercel-release-bot authored
-