1. 21 Jul, 2023 3 commits
  2. 20 Jul, 2023 13 commits
    • vercel-release-bot's avatar
      v13.4.11-canary.1 · 0df8aac9
      vercel-release-bot authored
      0df8aac9
    • JJ Kasper's avatar
      Fix build side-effects from third-parties package (#52969) · e609e023
      JJ Kasper authored
      We shouldn't be generating src files during the build script as these
      can break publishing.
      e609e023
    • Jimmy Lai's avatar
      app-router: prefetching tweaks (#52949) · 55eebefb
      Jimmy Lai authored
      This PR tries to address some feedback around prefetching, like in #49607, where they were some warnings because we were over prefetching.
      
      The tweaks in this PR:
      - if there are no loading boundary below, we don't prefetch the full page anymore. I made that change a while ago but I think it wasn't the original intent from @sebmarkbage. Fixing that now. So now, we will prefetch the page content until the nearest loading boundary, only if there is any.
      - there's now a queue for limiting the number of concurrent prefetches. This is to not ruin the bandwidth for complex pages. Thanks @alvarlagerlof for that one.
      - also, if the prefetch is in the queue when navigating, it will get bumped.
      - bonus: fixes a bug where we were wrongly stripping headers in dev for static pages
      
      Test plan:
      <img width="976" alt="CleanShot 2023-07-20 at 17 53 43@2x" src="https://github.com/vercel/next.js/assets/11064311/2ea34419-c002-4aea-94df-57576e3ecb2e">
      In the screenshot you can see that:
      - only 5 requests at a time are authorised
      - when I clicked on 15, it got prioritised in the queue (did not cancel the rest)
      - the prefetch only included the content until the loading boundary
      Co-authored-by: 's avatarJJ Kasper <22380829+ijjk@users.noreply.github.com>
      55eebefb
    • Jiachi Liu's avatar
      Refine the not-found rendering process for app router (#52790) · cb24c555
      Jiachi Liu authored
      ### What
      
      This PR changes the flow of not-found rendering process. 
      
      ### Why
      
      `not-found.js` was rendered in two ways before:
      * 1 is SSR rendering the not-found as 404
      * 2 is triggering the error on RSC rendering then the error will be
      preserved in inline flight data, on the client it will recover the error
      and trigger the proper error boundary.
      
      The solution has been through a jounery:
      No top-level not found boundary -> introduce metadata API -> then we
      create a top level root not found boundary -> then we delete it due to
      duplicated rendering of root layout -> now this
      
      So the solution before this PR is still having a root not found boundary
      wrapped in the `AppRouter`, it's being used in a lot of places including
      HMR. As we discovered it's doing duplicated rendering of root layout,
      then we removed it and it started failing with rendering `not-found` but
      missing root layout. In this PR we redesign the process.
      
      ### How
      
      Now the rendering architecture looks like:
      
      * For normal root not-found and certain level of not-found boundary
      they're still covered by `LayoutRouter`
      * For other error renderings including not-found
      * Fully remove the top level not-found boundary, when it renders with
      404 error it goes to render the fallback page
      * During rendering the fallback page it will check if it should just
      renders a 404 error page or render nothing and let the error from inline
      flight data to trigger the error boundary
      
      pseudo code
      ```
      try {
        render AppRouter > PageComponent
      } catch (err) {
        create ErrorComponent by determine err
        render AppRouter > ErrorComponent
      }
      ```
      
      In this way if the error is thrown from top-level like the page itself
      or even from metadata, we can still catch them and render the proper
      error page based on the error type.
      
      The problematic is the HMR: introduces a new development mode meta tag
      `<meta name="next-error">` to indicate it's 404 so that we don't do
      refresh. This reverts the change brougt in #51637 as it will also has
      the duplicated rendering problem for root layout if it's included in the
      top level not found boundary.
      
      Also fixes the root layout missing issue:
      
      Fixes #52718
      Fixes #52739
      
      ---------
      Co-authored-by: 's avatarShu Ding <g@shud.in>
      cb24c555
    • Cassidy Williams's avatar
      Change "publically" to "publicly" in the routing docs (#52966) · 7a0297c2
      Cassidy Williams authored
      ### What and why?
      
      The word "publicly" should be spelled consistently across the documentation. It is spelled currently as "publically" in a few places.
      
      ### How?
      
      Fixed the spelling!
      7a0297c2
    • Shu Ding's avatar
      Fix client reference manifest for interception routes (#52961) · a96a9b07
      Shu Ding authored
      We have the logic to group the client compiler's entry names to make sure we generate one single manifest file for the page. This is complicated and requires a special step to "group" the entry names because a page can depend on a bunch of files from everywhere.
      
      And currently, the normalization of "entryName → groupName" doesn't cover interception routes' conventions (`(.)`, `(..)` and `(...)`). This PR fixes that.
      
      Closes #52862, closes #52681, closes #52958.
      a96a9b07
    • Jon Meyers's avatar
      examples: export `force-dynamic` from all dynamic routes (#52916) · 2b497413
      Jon Meyers authored
      ### What?
      
      Stop `with-supabase` template from throwing errors on build
      
      ### Why?
      
      Dynamic Routes now fail the build, rather than console.logging an error
      
      ### How?
      
      Export the following from any routes that use the `cookies` function
      
      ```
      export const dynamic = "force-dynamic";
      ```
      
      Install `encoding` as a dev dependency until this is fixed downstream
      2b497413
    • Daryll J. Reillo's avatar
      Update 06-lazy-loading.mdx: Incorrect filename in Example on "Importing Named Imports" (#52932) · 66f0983c
      Daryll J. Reillo authored
      The correct filename is seen on PagesOnly. But on AppOnly, the filename is not correct. It should be "hello" instead of "ClientComponent".
      
      line to change:
      from:
      import('../components/ClientComponent').then((mod) => mod.Hello)
      
      to:
      import('../components/hello').then((mod) => mod.Hello)
      
      
      line to change:
      from:
      import('../components/ClientComponent').then((mod) => mod.Hello)
      
      to:
      import('../components/hello').then((mod) => mod.Hello)
      66f0983c
    • Darshan Jain's avatar
      Allow general language codes in the Metadata API (#52920) · 8e3cd83d
      Darshan Jain authored
      Closes #52898
      
      LangCode Missing zh-Hans and zh-Hant
      
      | 'yo-NG'
        | 'zh-CN'
        | 'zh-Hans'   //added
        | 'zh-Hant'        //added
        | 'zh-HK'
        | 'zh-MO'
        | 'zh-SG'
        | 'zh-TW'
        | 'zu-ZA'
      
      
      https://github.com/vercel/next.js/blob/f5272acbe5628164257ef8e584c8a469a4af5cb8/packages/next/src/lib/metadata/types/alternative-urls-types.ts#L419Co-authored-by: 's avatarShu Ding <3676859+shuding@users.noreply.github.com>
      8e3cd83d
    • Balázs Orbán's avatar
      chore: add GitHub Action to manage "+1" comments (#52866) · df0330f7
      Balázs Orbán authored
      ### What?
      
      Adds a GitHub Action that automatically marks unhelpful comments as "off-topic".
      
      You can test it by adding off-topic comments to this issue: https://github.com/balazsorban44/next.js/issues/21
      
      https://github.com/balazsorban44/next.js/blob/17e3ec30689a2323161260c9b03bb7f51ed008f9/.github/actions/minus-one/src/index.mjs#L6
      
      ### Why?
      
      A common problem is when an issue thread receives "+1" comments, it usually encourages others to do the same. This makes the thread harder and harder for maintainers to read, without adding value to the discussion.
      
      ### How?
      
      When an issue receives a comment, we compare it to a list that we determine as off-topic. If it matches, we hide the comment.
      
      See: https://docs.github.com/en/graphql/reference/mutations#minimizecomment
      df0330f7
    • Tobias Koppers's avatar
      add edge support for next.rs API (#52885) · 84005941
      Tobias Koppers authored
      ### What?
      
      adds edge pages, apis, app pages and app routes to next.rs api
      
      ### Why?
      
      ### How?
      84005941
    • Zack Tanner's avatar
      fix: allow smooth scrolling if only hash changes (pages & app) (#52915) · 8664ffe2
      Zack Tanner authored
      We were preventing smooth scrolling to avoid jarring UX when `scroll-behavior: smooth` was set and the user navigates to another route ([PR](https://github.com/vercel/next.js/pull/40642) and [related comment](https://github.com/vercel/next.js/issues/51721#issuecomment-1623416600)). 
      
      This updates both pages & app router to restore smooth scroll functionality if the only the route hash changes.
      
      Fixes #51721
      Closes NEXT-1406
      8664ffe2
    • Zack Tanner's avatar
      improve error DX on pages with RSC build errors (#52843) · 4994a428
      Zack Tanner authored
      ### What?
      - Visiting a page in the app router without a proper component export doesn't show the dev overlay, but logs errors to the console
      - When it does show the error overlay (e.g. during an HMR event), the error message was sharing the module code itself rather than the component path, making it hard to debug
      
      ### Why?
      `createComponentTree` can throw these errors before the AppRouter tree is mounted, leaving the errors uncaught by the dev overlay.
      
      ### How?
      This wraps the server root in the `ReactDevOverlay` when in dev mode with a minimal "HMR" for when the server component is edited (to reload the page).
      
      Closes NEXT-308
      4994a428
  3. 19 Jul, 2023 16 commits
  4. 18 Jul, 2023 8 commits