- 21 Jul, 2023 3 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
JJ Kasper authored
Reverts vercel/next.js#52790 Reverting temporarily as this breaks turbopack's not found handling due to the app tree being generated there not having the necessary parallel routes in the `_not-found` entry x-ref: https://github.com/vercel/next.js/blob/0df8aac935741808ee6aee78a8b545b2c1405f29/packages/next-swc/crates/next-core/src/app_structure.rs#L677-L681 x-ref: https://github.com/vercel/next.js/actions/runs/5616458194/job/15220295829
-
- 20 Jul, 2023 13 commits
-
-
vercel-release-bot authored
-
JJ Kasper authored
We shouldn't be generating src files during the build script as these can break publishing.
-
Jimmy Lai authored
This PR tries to address some feedback around prefetching, like in #49607, where they were some warnings because we were over prefetching. The tweaks in this PR: - if there are no loading boundary below, we don't prefetch the full page anymore. I made that change a while ago but I think it wasn't the original intent from @sebmarkbage. Fixing that now. So now, we will prefetch the page content until the nearest loading boundary, only if there is any. - there's now a queue for limiting the number of concurrent prefetches. This is to not ruin the bandwidth for complex pages. Thanks @alvarlagerlof for that one. - also, if the prefetch is in the queue when navigating, it will get bumped. - bonus: fixes a bug where we were wrongly stripping headers in dev for static pages Test plan: <img width="976" alt="CleanShot 2023-07-20 at 17 53 43@2x" src="https://github.com/vercel/next.js/assets/11064311/2ea34419-c002-4aea-94df-57576e3ecb2e"> In the screenshot you can see that: - only 5 requests at a time are authorised - when I clicked on 15, it got prioritised in the queue (did not cancel the rest) - the prefetch only included the content until the loading boundary Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Jiachi Liu authored
### What This PR changes the flow of not-found rendering process. ### Why `not-found.js` was rendered in two ways before: * 1 is SSR rendering the not-found as 404 * 2 is triggering the error on RSC rendering then the error will be preserved in inline flight data, on the client it will recover the error and trigger the proper error boundary. The solution has been through a jounery: No top-level not found boundary -> introduce metadata API -> then we create a top level root not found boundary -> then we delete it due to duplicated rendering of root layout -> now this So the solution before this PR is still having a root not found boundary wrapped in the `AppRouter`, it's being used in a lot of places including HMR. As we discovered it's doing duplicated rendering of root layout, then we removed it and it started failing with rendering `not-found` but missing root layout. In this PR we redesign the process. ### How Now the rendering architecture looks like: * For normal root not-found and certain level of not-found boundary they're still covered by `LayoutRouter` * For other error renderings including not-found * Fully remove the top level not-found boundary, when it renders with 404 error it goes to render the fallback page * During rendering the fallback page it will check if it should just renders a 404 error page or render nothing and let the error from inline flight data to trigger the error boundary pseudo code ``` try { render AppRouter > PageComponent } catch (err) { create ErrorComponent by determine err render AppRouter > ErrorComponent } ``` In this way if the error is thrown from top-level like the page itself or even from metadata, we can still catch them and render the proper error page based on the error type. The problematic is the HMR: introduces a new development mode meta tag `<meta name="next-error">` to indicate it's 404 so that we don't do refresh. This reverts the change brougt in #51637 as it will also has the duplicated rendering problem for root layout if it's included in the top level not found boundary. Also fixes the root layout missing issue: Fixes #52718 Fixes #52739 --------- Co-authored-by:Shu Ding <g@shud.in>
-
Cassidy Williams authored
### What and why? The word "publicly" should be spelled consistently across the documentation. It is spelled currently as "publically" in a few places. ### How? Fixed the spelling!
-
Shu Ding authored
We have the logic to group the client compiler's entry names to make sure we generate one single manifest file for the page. This is complicated and requires a special step to "group" the entry names because a page can depend on a bunch of files from everywhere. And currently, the normalization of "entryName → groupName" doesn't cover interception routes' conventions (`(.)`, `(..)` and `(...)`). This PR fixes that. Closes #52862, closes #52681, closes #52958.
-
Jon Meyers authored
### What? Stop `with-supabase` template from throwing errors on build ### Why? Dynamic Routes now fail the build, rather than console.logging an error ### How? Export the following from any routes that use the `cookies` function ``` export const dynamic = "force-dynamic"; ``` Install `encoding` as a dev dependency until this is fixed downstream
-
Daryll J. Reillo authored
The correct filename is seen on PagesOnly. But on AppOnly, the filename is not correct. It should be "hello" instead of "ClientComponent". line to change: from: import('../components/ClientComponent').then((mod) => mod.Hello) to: import('../components/hello').then((mod) => mod.Hello) line to change: from: import('../components/ClientComponent').then((mod) => mod.Hello) to: import('../components/hello').then((mod) => mod.Hello) -
Darshan Jain authored
Closes #52898 LangCode Missing zh-Hans and zh-Hant | 'yo-NG' | 'zh-CN' | 'zh-Hans' //added | 'zh-Hant' //added | 'zh-HK' | 'zh-MO' | 'zh-SG' | 'zh-TW' | 'zu-ZA' https://github.com/vercel/next.js/blob/f5272acbe5628164257ef8e584c8a469a4af5cb8/packages/next/src/lib/metadata/types/alternative-urls-types.ts#L419Co-authored-by:
Shu Ding <3676859+shuding@users.noreply.github.com>
-
Balázs Orbán authored
### What? Adds a GitHub Action that automatically marks unhelpful comments as "off-topic". You can test it by adding off-topic comments to this issue: https://github.com/balazsorban44/next.js/issues/21 https://github.com/balazsorban44/next.js/blob/17e3ec30689a2323161260c9b03bb7f51ed008f9/.github/actions/minus-one/src/index.mjs#L6 ### Why? A common problem is when an issue thread receives "+1" comments, it usually encourages others to do the same. This makes the thread harder and harder for maintainers to read, without adding value to the discussion. ### How? When an issue receives a comment, we compare it to a list that we determine as off-topic. If it matches, we hide the comment. See: https://docs.github.com/en/graphql/reference/mutations#minimizecomment
-
Tobias Koppers authored
### What? adds edge pages, apis, app pages and app routes to next.rs api ### Why? ### How?
-
Zack Tanner authored
We were preventing smooth scrolling to avoid jarring UX when `scroll-behavior: smooth` was set and the user navigates to another route ([PR](https://github.com/vercel/next.js/pull/40642) and [related comment](https://github.com/vercel/next.js/issues/51721#issuecomment-1623416600)). This updates both pages & app router to restore smooth scroll functionality if the only the route hash changes. Fixes #51721 Closes NEXT-1406
-
Zack Tanner authored
### What? - Visiting a page in the app router without a proper component export doesn't show the dev overlay, but logs errors to the console - When it does show the error overlay (e.g. during an HMR event), the error message was sharing the module code itself rather than the component path, making it hard to debug ### Why? `createComponentTree` can throw these errors before the AppRouter tree is mounted, leaving the errors uncaught by the dev overlay. ### How? This wraps the server root in the `ReactDevOverlay` when in dev mode with a minimal "HMR" for when the server component is edited (to reload the page). Closes NEXT-308
-
- 19 Jul, 2023 16 commits
-
-
Wyatt Johnson authored
Fixes a bug where the edge runtime didn't support `basePath` with Custom App Routes. - Fixes #49661
-
Soheil Nazari authored
-
Darshan Jain authored
Fixes #52853 Lacking 'color' attribute in IconDescriptor Metadata ```diff export type IconDescriptor = { url: string | URL type?: string sizes?: string + color?: string // added the color attribute /** defaults to rel="icon" unless superseded by Icons map */ rel?: string media?: string /** * @see https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/fetchPriority */ fetchPriority?: 'high' | 'low' | 'auto' } ``` https://github.com/vercel/next.js/blob/v13.4.11-canary.0/packages/next/src/lib/metadata/types/metadata-types.ts#L99 -
Adam Hunter authored
-
Steven authored
- See current bug: https://nextjs.org/docs/app/api-reference/functions/generate-metadata#generatemetadata-function - Closes #52903
-
Antoine Bourin authored
-
Jiachi Liu authored
Upgrade `@vercel/og` to latest version https://github.com/vercel/og/releases/tag/0.5.9
-
JJ Kasper authored
-
-
Tobias Koppers authored
### What? * adds `Project.update` to update project options * fix manifest paths to be under `server` * pass `env` into project * handle and expose issues in all methods * expose server paths in WrittenEndpoint
-
Jiachi Liu authored
As we're using nodejs with latest version of 18.x on CI, there's a new behavior change of `url.fileURLToPath` that didn't join the paths as expected locally with node 16.x or 18.16 ``` /private/var/folders/mh/y8kwzkls6v3_w3_k6q384cw80000gn/T/next-install-b033b516612809c6fb0a0de77c6e50f7d7f8af34dfd3d01812b99345352dc992/node_modules/.pnpm/file+..+next-repo-7e52b07043e986127273a2d951e5c412b0dd45fb24eb34001bd372e2afff79db+packages+n_vyqu6i4c4i3efp5pqsaeaoe5s4/node_modules/next/dist/compiled/@vercel/og/noto-sans-v27-latin-regular.ttf ``` in the actions runner with node 18.17 it's ``` /tmp/next-install-8efaa47c1546bed07990d8f130decceb6536e1a36146e7885cb68e3c3dea21f7/node_modules/.pnpm/file+..+next-repo-9679355e05341947e7aa0b42c994e3ac_krcuriy4thl7zawouf7sswlrgy/node_modules/next/dist/compiled/@vercel/og/index.node.js/../noto-sans-v27-latin-regular.ttf ``` You can see that `index.node.js` is still present in the path as a folder which is unexpected ``` index.node.js/../ ``` x-ref: https://github.com/vercel/next.js/actions/runs/5600417148/jobs/10242827739?pr=52790
-
Steven Tey authored
Added clarification that runtime edge can be defined on Layout level too. Co-authored-by:
Steven <229881+styfle@users.noreply.github.com> Co-authored-by:
Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
-
Jimmy Lai authored
-
Joseph Garrone authored
-
Rinald authored
-
- 18 Jul, 2023 8 commits
-
-
Kévin Dunglas authored
### What? Uses `COPY --link` instructions in Docker examples. ### Why? This significantly [accelerates Docker builds and improves caching](https://www.howtogeek.com/devops/how-to-accelerate-docker-builds-and-optimize-caching-with-copy-link/). This instruction is supported for more than 1 year and is now supported by almost all modern Docker installations. We use it successfully for a while in [the API Platform distribution](https://github.com/api-platform/api-platform/blob/main/pwa/Dockerfile), which includes Next.js and is derived from these examples. ### How? By updating the existing examples.
-
Yagiz Nizipli authored
This pull request replaces `readdir` with `opendir` and simplifies the implementation. Co-authored-by:
Steven <steven@ceriously.com> Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-
Tobias Koppers authored
### What? refactoring see https://github.com/vercel/turbo/pull/5557 ### Turbopack Changes * https://github.com/vercel/turbo/pull/5506 <!-- Leah - feat(turbopack-ecmascript): implement acyclic SCC graph for ESM imports --> * https://github.com/vercel/turbo/pull/5557 <!-- Tobias Koppers - Ensure output assets reference only output assets -->
-
Wyatt Johnson authored
Renames the webpack layers to be more semantical: ``` server compiler: server layer → RSC layer client layer → SSR layer shared layer → shared layer client compiler: appClient layer → app browser layer ```
-
JJ Kasper authored
-
Janicklas Ralph authored
This PR Introduces `next/third-parties` - `@next/third-parties` is a new package in the Next.js monorepo. - The package contains collection of components that can be used to efficiently load third party libraries into your Next.js application. - This package uses [Third Party Capital](https://github.com/GoogleChromeLabs/third-party-capital/) under the hood to fetch the best loading recommendations. - This PR mainly sets up the package to run a script at build time to auto generate the components from [Third Party Capital](https://github.com/GoogleChromeLabs/third-party-capital/) config. Packages are grouped by company, for eg: `import { GoogleMapsEmbed } from '@next/third-parties/google'` cc: @housseindjirdeh @kara <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> ---------
-
OJ Kwon authored
### What? Minor update to next-swc to support `__INTERNAL_CUSTOM_TURBOPACK_BINDINGS` for the --experimental-turbo entrypoint as same as current --turbo.
-
vercel-release-bot authored
-