- 17 Aug, 2023 7 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Jiachi Liu authored
Reverts vercel/next.js#53578 This PR (#53578) will break client components test, revert it for now. Can repro by adding `"use client"` to `app/page.tsx` in `test/production/jest/server-only.test.ts` ``` FAIL app/page.test.jsx ● Test suite failed to run· Cannot find module 'private-next-rsc-mod-ref-proxy' from 'app/page.jsx'· Require stack: ``` -
vercel-release-bot authored
-
Jiwon Choi authored
- Added `has` to ResponseCookies in [edge-runtime/cookies#533](https://github.com/vercel/edge-runtime/pull/533) - Upgraded edge-runtime/cookies to 3.3.0 #54117 - Added a test case Fixes #54005 #54111
-
Will Binns-Smith authored
This: - Adds a simple, generic tracer in the client that can be subscribed to in order to report spans - Reports client spans through the HMR socket in the dev server - Receives these spans and includes them in `.next/trace` Closes WEB-1387
-
Max Leiter authored
### What? ~The `setTimeout(() => {}, 0)` was used in place of `setImmediate` due to lack of support in the Edge Runtime. This is no longer a problem.~ Not working like I expected. `ReadableStream.tee` should be widely supported as well as of [Node 16.5](https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream/tee#browser_compatibility) ### Why? Use the platform! ### How? Use the built-in `ReadableStream.tee()`
-
- 16 Aug, 2023 18 commits
-
-
vercel-release-bot authored
-
Will Binns-Smith authored
Note: depends on next Turbopack publish https://github.com/vercel/turbo/pull/5487 exports a reusable `handle_issues` function for reporting issues and erroring when failing issues are encountered. This uses it for `next build` with a failing severity level of error.
-
Zack Tanner authored
Accidentally left this in after making some changes in: - https://github.com/vercel/next.js/pull/54081
-
Dima Voytenko authored
The internal IPC fetches are an internal framework detail and they shouldn't pollute the tracing in a non-verbose mode. Examples of internal fetch output: <img width="600" alt="image" src="https://github.com/vercel/next.js/assets/726049/64a25c02-bf39-4f54-8fe3-86018c7720dc"> <img width="1369" alt="image" src="https://github.com/vercel/next.js/assets/726049/f8f1d65c-5444-42c7-9e7d-6cdf9865eace">
-
Balázs Orbán authored
### What? When cloning a `Request` with `NextRequest` the second argument needs to take precedence over the `Headers` set on the original request. ### Why? Follow-up of #53157 I checked the `Request` spec https://fetch.spec.whatwg.org/#request-class and following the order of execution, `init.headers` should indeed override the headers if the first param was `Request`. I verified this in the browser too: ```js const req1 = new Request("http://n", {headers: {"x-header": "foo"}}) const req2 = new Request(req1, {headers: {"x-header-2": "bar"}}) Object.fromEntries(req2.headers) // {x-header-2: "bar"} ``` So we should match `NextRequest` with this behavior. ### How? Pass the `init` to `super` when cloning the request. Closes NEXT-1521 Fixes #54094
-
Will Binns-Smith authored
This adds an **opt-in** feature to send a subset of trace spans and metadata to a remote http server. The url must be provided as an option like so: `next dev --experimental-upload-trace=http://localhost:3000/traces` These traces are derived from the tracing data stored at `.next/trace`. The request payload looks like this: ```json { "metadata": { "commit": "69b0a3366734182f4efce6c0089c2592044d7124", "mode": "dev", "pkgName": "nextjs-project", "arch": "arm64", "cpus": 10, "platform": "darwin" }, "traces": [ [ { "traceId": "2f041a20b06027ab", "name": "hot-reloader", "id": 1, "timestamp": 28712742599, "duration": 21, "tags": { "version": "13.4.14-canary.1" }, "startTime": 1691707223226 }, { "traceId": "2f041a20b06027ab", "parentId": 1, "name": "webpack-invalidated-server", "id": 63, "timestamp": 28713776446, "duration": 244628, "tags": { "trigger": "manual" }, "startTime": 1691707224260 }, { "traceId": "2f041a20b06027ab", "parentId": 1, "name": "webpack-invalidated-server", "id": 111, "timestamp": 28714080210, "duration": 115267, "tags": { "trigger": "manual" }, "startTime": 1691707224563 }, { "traceId": "2f041a20b06027ab", "parentId": 1, "name": "webpack-invalidated-server", "id": 168, "timestamp": 28715243617, "duration": 69471, "tags": { "trigger": "[project]/pages/index.tsx" }, "startTime": 1691707225727 }, { "traceId": "2f041a20b06027ab", "parentId": 1, "name": "client-hmr-latency", "id": 222, "timestamp": 1691707225727000, "duration": 72000, "tags": { "clientId": 1691707224946 }, "startTime": 1691707225799 }, { "traceId": "2f041a20b06027ab", "parentId": 1, "name": "webpack-invalidated-server", "id": 223, "timestamp": 28716999898, "duration": 47425, "tags": { "trigger": "[project]/pages/index.tsx" }, "startTime": 1691707227483 } ] ] } ``` Currently only events of type `client-hmr-latency`, `hot-reloader`, `webpack-invalid-client`, `webpack-invalidated-server` are included, as well as all root spans. Traces are expected to include the ancestry of any given span through the `parentId` property.
-
Zack Tanner authored
When an mpa navigation takes place, we currently push the user to the new route and suspend the page indefinitely (x-ref: #49058). When navigating back, if the browser opts into using the [bfcache](https://web.dev/bfcache/), it will remain suspended and `pushRef.mpaNavigation` will be true. This means that anything that would cause the component to re-render will trigger the mpa navigation again (such as hovering over another `Link`, as reported in #53347) This PR checks to see if bfcache is being used by observing `PageTransitionEvent.persisted` and if so, resets the router state to clear out `pushRef`. Closes NEXT-1511 Fixes #53347
-
Steven authored
Since Next.js already requires [`node@16.8.0`](https://github.com/vercel/next.js/blob/88b8d15f41f894011cf33af0b1f4a3fb24aed46b/packages/next/package.json#L319) or newer, we can drop this workaround for squoosh/wasm on apple silicon. - x-ref: https://github.com/vercel/next.js/pull/27031
-
Jiachi Liu authored
Merge the rendering of `<LayoutRouter>` component into one place, with different props in different branches.
-
Will Binns-Smith authored
This ensures that corepack uses the correct package manager and version for the tmpdir install as it does for the rest of the repo. It reads the value from the root `package.json`. Closes WEB-1401
-
Steven authored
Since Next.js already requires [`node@16.8.0`](https://github.com/vercel/next.js/blob/88b8d15f41f894011cf33af0b1f4a3fb24aed46b/packages/next/package.json#L319) or newer, we can drop old techniques for removing a directory recursively and instead rely on the native [`fs.promises.rm()`](https://nodejs.org/api/fs.html#fspromisesrmpath-options) function (available since `node@14.14.0`). x-ref: https://github.com/vercel/next.js/pull/34210
-
Steven authored
This PR refactors some types to remove `as any`, but the runtime logic is the same.
-
Jiachi Liu authored
### What & Why Previously when rendering the root `/_not-found` in production, we'll always override the parallel routes component children with not-found component, this will break the navigation in build mode from root 404 `/_not-found` path. ### How The new solution is to change the root `/_not-found` rendering strategy. Previously the loader tree of `/_not-found` look like this ```js ['', { children: ['not-found', {}, {}] }, { layout: ..., 'not-found': ...} ] ``` it's not a pretty valid tree, which could lead to problems during rendering. New solution is to change the children to render a page, but the page content is `not-found.js` component. The new tree of root not-found will look like ```js ['', { children: ['__PAGE__', {}, { page: ... // same as root 'not-found' }] }, { layout: ..., 'not-found': ...} ] ``` This change could fix the navigation on the root not-found page. Fixes #52264 -
Kiko Beats authored
Hello, This PR upgrades `edge-runtime` and associated packages, mostly fixing issues.
-
Donny/강동윤 authored
### What? Update swc crates to https://github.com/swc-project/swc/commit/023042dfb9c941e95f2fc0e1cd9b245d0cc64aa5 ### Why? To apply https://github.com/swc-project/swc/pull/7813 ### How? Closes WEB-1396 Fixes #54054
-
Tim Neutkens authored
With the latest changes in stable Next.js setting HOSTNAME is not longer required for the image to function correctly
👍 Fixes #54093 -
Balázs Orbán authored
Follow-up of #54048. We changed the lock action from waiting 1 month to 2 weeks, but the wording was not reflecting it.
-
Damien Simonin Feugas authored
### 🧐 What's in there? This is another attempt to allow testing server-only code with Jest. ### 🧪 How to test? There's an integration tests which can be triggered with `pnpm testheadless server-only` Here is a more comprehensive setup: <details> <summary><code>app/lib/index.ts</code></summary> ```ts import 'server-only' export function add(num1: number, num2: number) { return num1 + num2 } ``` </details> <details> <summary><code>app/lib/index.test.ts</code></summary> ```ts import { add } from '.' it('adds two numbers', () => { expect(add(1, 3)).toEqual(4) }) ``` </details> <details> <summary><code>app/client-component.tsx</code></summary> ```ts 'use client' import { useState } from 'react' export default function ClientComponent() { const [text, setText] = useState('not clicked yet') return <button onClick={() => setText('clicked!')}>{text}</button> } ``` </details> <details> <summary><code>app/client-component.test.tsx</code></summary> ```ts import { fireEvent, render, screen } from '@testing-library/react' import ClientComponent from './client-component' it('can be clicked', async () => { render(<ClientComponent />) const button = screen.getByRole('button') expect(button).toHaveTextContent('not clicked yet') await fireEvent.click(button) expect(button).toHaveTextContent('clicked!') }) ``` </details> <details> <summary><code>app/server-component.tsx</code></summary> ```ts import { add } from '@/lib' export default function ServerComponent({ a, b }: { a: number; b: number }) { return ( <code role="comment"> {a} + {b} = {add(a, b)} </code> ) } ``` </details> <details> <summary><code>app/server-component.test.tsx</code></summary> ```ts import { render, screen } from '@testing-library/react' import ServerComponent from './server-component' it('renders', () => { render(<ServerComponent a={2} b={3} />) expect(screen.getByRole('comment')).toHaveTextContent('2 + 3 = 5') }) ``` </details> <details> <summary><code>app/page.tsx</code></summary> ```ts import Link from 'next/link' import ClientComponent from './client-component' import ServerComponent from './server-component' export default function Page() { return ( <> <h1>Hello World</h1> <Link href="/dave">Dave?</Link> <p> <ClientComponent /> </p> <p> <ServerComponent a={5} b={2} /> </p> </> ) } ``` </details> <details> <summary><code>app/page.test.tsx</code></summary> ```ts import { render, screen } from '@testing-library/react' import Page from './page' it('greets', () => { render(<Page />) expect(screen.getByRole('link')).toHaveTextContent('Dave?') expect(screen.getByRole('heading')).toHaveTextContent('Hello World') expect(screen.getByRole('button')).toHaveTextContent('not clicked yet') expect(screen.getByRole('comment')).toHaveTextContent('5 + 2 = 7') }) ``` </details> <details> <summary><code>app/[blog]/page.tsx</code></summary> ```ts import { Metadata } from 'next' import Link from 'next/link' type Props = { params: { blog: string } } export async function generateMetadata({ params: { blog: title }, }: Props): Promise<Metadata> { return { title, description: `A blog post about ${title}` } } export default function Page({ params }: Props) { return ( <> <div> <Link href="/">Back</Link> </div> <h1>All about {params.blog}</h1> </> ) } ``` </details> <details> <summary><code>app/[blog]/page.test.tsx</code></summary> ```ts import { render, screen } from '@testing-library/react' import Page from './page' it('has the appropriate title', () => { const title = 'Jane' render(<Page params={{ blog: title }} />) expect(screen.getByRole('heading')).toHaveTextContent(`All about ${title}`) expect(screen.getByRole('link')).toHaveTextContent('Back') }) ``` </details> <details> <summary><code>app/layout.tsx</code></summary> ```ts export default function RootLayout({ children }) { return ( <html lang="en"> <body>{children}</body> </html> ) } ``` </details> <details> <summary><code>jest.config.js</code></summary> ```ts const nextJest = require('next/jest') const createJestConfig = nextJest({ dir: './' }) module.exports = createJestConfig({ testEnvironment: 'jsdom', setupFilesAfterEnv: ['<rootDir>/test-setup.ts'], }) ``` </details> <details> <summary><code>package.json</code></summary> ```ts { "name": "rsc-test", "version": "0.0.0", "private": true, "scripts": { "test": "jest" }, "devDependencies": { "@testing-library/jest-dom": "latest" } } ``` </details> <details> <summary><code>test-setup.ts</code></summary> ```ts import '@testing-library/jest-dom' ``` </details> The app should run and all test should pass. ###❗ Notes to reviewers #### The problem: 1. next/jest configures jest with a transformer ([jest-transformer](https://github.com/vercel/next.js/blob/canary/packages/next/src/build/swc/jest-transformer.ts)) to compile react code with next -swc 2. the transformers configures next -swc for a given environment: Server or Client, based on jest global environment 3. Based on the environment, next -swc checks for invalid usage of `import('server-only')` `“use client”`, `export const metadata` or `export async function generateMetadata` 4. Because the global test environment is either jsdom or node, the same test suite can not include both client and server components #### Possible mitigations *A. Using jest projects* When configured with [multiple projects](https://jestjs.io/docs/next/configuration/#projects-arraystring--projectconfig), Jest can launch different runners with different environment. This would allow running server-only code in node and client-only code in jsdom. However, it requires user to completely change their jest configuration. It would also require a different setup when scaffolding new app-directory project with create-next. *B. Using doc blocks* Jest allows changing the environment per test file [with docBlock](https://jestjs.io/docs/configuration#testenvironment-string). However, by the time jest is invoking next -swc on a source file to transform it, this information is gone, and next -swc is still invoked with the (wrong) global environment. The PR #52393 provides a workaround for files with `import('server-only')`, but does not allow testing pages with metadata. *C. Always compile for node* Our jest-transformer could always configure next -swc for server: - pass Server-specific validations `import('server-only')` `export const metadata` or `export async function generateMetadata` - does not complain about `"use client"` This is what this PR is about! Fixes #47299 Co-authored-by:Jiachi Liu <4800338+huozhi@users.noreply.github.com>
-
- 15 Aug, 2023 15 commits
-
-
OJ Kwon authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> ### What? Leaving a small note to the build steps to avoid regressions like https://github.com/vercel/next.js/issues/54017 later. Closes WEB-1386 --------- Co-authored-by:
Steven <steven@ceriously.com>
-
stefanprobst authored
Currently, Next.js enforces that `forceConsistentCasingInFileNames: true` is added to a user's `tsconfig.json`. This PR removes that behavior for CNA templates, and when the typescript version is >= 5.0.0, because since ts 5.0 `forceConsistentCasingInFileNames` is `true` by default. See https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/ related: https://github.com/vercel/next.js/issues/45617
-
OJ Kwon authored
### What? wasm-bindgen's serde deserialization is more strict to not automatically coerce non-optionable default values for the mdx configurations. Since these are required options anyway, consolidate to construct default options. Closes WEB-1384
-
Will Binns-Smith authored
This adds tags for `updatedModules` (an array of relative paths to changed modules that caused the hmr update) and `page` (the path to the updated page) to the `client-hmr-latency` event. Test Plan: Ran `next dev` in a test app, changed a source file, and observed that the `client-hmr-latency` span in `.next/trace` has correct `page` and `updatedModules` tags.
-
Willi-m authored
In https://nextjs.org/docs/app/building-your-application/data-fetching/fetching-caching-and-revalidating#opting-out-of-data-caching a single quote (`'`) is missing. 
-
Zack Tanner authored
### What? When navigating to a new page with fixed or sticky positioned element as the first element, we were bailing on scroll to top behavior, which often isn't expected. ### Why? Currently, we decide to bail on scroll to top behavior on navigation if the content that is swapped into view is visible within the viewport. Since fixed/sticky positioned elements are often intended to be relative to the current viewport, it's most likely not the case that you'd want it to be considered in this heuristic. For example, if you were scrolled far down on a page, and you navigated to a page that makes use of a sticky header, you would not be scrolled to the top of the page because that sticky header is technically visible within the viewport. ### How? I've updated the previous implementation that was intended to skip targeting invisible elements to also skip over fixed or sticky elements. This should help by falling back to the next level of the layout tree to determine which element to scroll to. I've deleted the `// TODO-APP` comments as I couldn't think of a scenario in which we'd need a global scrollTop handler -- if we've bailed on every element up the tree, it's likely the page wasn't scrollable. Some additional considerations: - Is the warning helpful or annoying? - Is the parallel route trade-off an acceptable one? (ie, a parallel modal slot might not be considered in the content visibility check unless if it’s fixed positioned) Closes NEXT-1393 Fixes #47475
-
Jiachi Liu authored
### What? Skip logging `/404` for pages routes in `next build` when app router root not-found is present ### Why? When app router's root not-found is used it can cover all the not found cases, and for static rendering it can already replace the `404.html`. So in the tree view we don't need to log the pages `/404` when those cases are covered by app router.
-
Balázs Orbán authored
Chat with @timneutkens - Lock closed issues after 14 days of inactivity - Hide comments "still happening" without a link we can verify
-
Tim Neutkens authored
This reverts commit 39c06ae9. Based on https://github.com/vercel/next.js/pull/53441#pullrequestreview-1578047015 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Zack Tanner authored
`getEntryKey` had some logic to remove `children` if it was part of the entry (originally it was intended to fix an issue with parallel slots that were used in place of a page, but wasn't working as intended). However, this breaks pages that are named `children`. Updating this again to implement what I think was the intended behavior in https://github.com/vercel/next.js/commit/4900fa21b078fd1ec1adc5d570fcfb560be8aeb6 which is to point to the correct entry when a parallel slot is used in place of a page component. - x-ref: #52362 Closes NEXT-1514 Fixes #53072
-
Steven authored
Deploy all examples for each release (canary or stable, but not PRs). Right now we only have one example that we deploy so we don't need to determine which ones changed.
-
Dima Voytenko authored
Followup on the https://github.com/vercel/next.js/pull/52520. The enhancements: 1. Both `fetch` and `http(s)` APIs are intercepted in the testmode. 2. The loopback mode that would allow the test-side to use any fetch-mocking library of their choice.
-
Matt Cowley authored
Partial fix for #54012: do not generate a blur image in the image loader when the image is detected to be animated, rather than returning the *entire* animated image as the blur image.
-
Steven authored
Update codeowners with `*img*` to add `styfle` In particular, this will match `get-img-props.ts`
-
vercel-release-bot authored
-