- 09 May, 2023 2 commits
-
-
vercel-release-bot authored
-
JJ Kasper authored
Uses the choice input type instead of requiring manually typing the values.
-
- 08 May, 2023 16 commits
-
-
Toru Kobayashi authored
fixes #47641 This adds a friendly error for loading a font error caused by the invalid `assetPrefix` setting. Current: <img width="747" alt="image" src="https://user-images.githubusercontent.com/250407/236685607-c03b6160-9e8c-4c88-80e1-714f6a140588.png"> This PR: <img width="890" alt="image" src="https://user-images.githubusercontent.com/250407/236685499-da4c3d69-0f97-458d-8709-dcc43475e0e9.png"> <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
JJ Kasper authored
This ensures we use the proper body stream when rewriting to an external resource as currently it tries to consume an already read body stream. Fixes: https://github.com/vercel/next.js/issues/48040
-
Shu Ding authored
This PR extends `invalid_server_react_dom_apis` with `experimental_useOptimistic` and `experimental_useFormStatus` to create early compile-time errors.
-
JJ Kasper authored
This ensures we properly strip conflicting headers from being forwarded when handling the redirect request/response in actions. x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1683218335368759) Fixes: ```sh failed to get redirect response TypeError: fetch failed at Object.fetch (node:internal/deps/undici/undici:11413:11) { cause: RequestContentLengthMismatchError: Request body length does not match content-length header at write (node:internal/deps/undici/undici:9907:41) at _resume (node:internal/deps/undici/undici:9885:33) at resume (node:internal/deps/undici/undici:9787:7) at connect (node:internal/deps/undici/undici:9776:7) { code: 'UND_ERR_REQ_CONTENT_LENGTH_MISMATCH' } } ```
-
Jiachi Liu authored
Fix the bad encoded buffer introduced in #49323
-
JJ Kasper authored
When revalidate isn't defined in the tree at all and a fetch without cache/revalidate fields is done we are incorrectly marking the initial revalidate period with a time based value when it should be `false`. This causes pages that should be fully static to revalidate unexpectedly. x-ref: [twitter thread](https://twitter.com/diegohaz/status/1655638433795014657) x-ref: [slack thread](https://vercel.slack.com/archives/C03S8ED1DKM/p1683566860136879)
-
vercel-release-bot authored
-
Shu Ding authored
This should fix the `requestAsyncStorage not available` error. [Related report](https://vercel.slack.com/archives/C03S8ED1DKM/p1683553422581859).
-
Jiachi Liu authored
-
Lee Robinson authored
To learn more
😄 Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Steven authored
- Reverts vercel/next.js#48291 - Fixes #49059 - TODO: move these tests to `./tests/e2e/*` to avoid flakes (that will be a follow up PR) fix NEXT-1092
-
vercel-release-bot authored
-
Jiachi Liu authored
-
Jimmy Lai authored
This PR wraps the server patch dispatcher with a transition, we generally want all router dispatch to go through one I'll follow up on tests properly later link NEXT-1096
-
vercel-release-bot authored
-
Tim Neutkens authored
## What? Removes the empty `next.config.js` warning. Given that `create-next-app` now ships with an empty config with the type definition comment the warning is no longer needed. ## How? Removed the warning, removed the tests. Fixes NEXT-1107
-
- 07 May, 2023 2 commits
-
-
Andrew Clark authored
Fixes a bug where `useFormStatus` crashed during SSR. Includes the following upstream changes: - [16d053d59](https://github.com/facebook/react/commits/16d053d59) Add useFormStatus to server rendering stub ([#26788](https://github.com/facebook/react/pull/26788)) (Andrew Clark) - [efb381bbf](https://github.com/facebook/react/commits/efb381bbf) [Release Script] Print a hint where to get the token ([#26783](https://github.com/facebook/react/pull/26783)) (dan) - [b00e27342](https://github.com/facebook/react/commits/b00e27342) Use native scheduler if defined in global scope ([#26554](https://github.com/facebook/react/pull/26554)) (Samuel Susla) - [783e7fcfa](https://github.com/facebook/react/commits/783e7fcfa) React DevTools 4.27.6 -> 4.27.7 ([#26780](https://github.com/facebook/react/pull/26780)) (Ruslan Lesiutin) - [377c5175f](https://github.com/facebook/react/commits/377c5175f) DevTools: fix backend activation ([#26779](https://github.com/facebook/react/pull/26779)) (Ruslan Lesiutin)
-
📝 Sanjaiyan Parthipan authored
-
- 06 May, 2023 1 commit
-
-
Jiachi Liu authored
typescript version could be helpful for determing user's problem with ts, especially typing with react
-
- 05 May, 2023 9 commits
-
-
Tim Neutkens authored
## What? Fixes a bug with iterating over the searchParams while `delete` and `append` are used. This is the minimal example of what happened: ```js const searchParams = new URLSearchParams('a=valueA&b=valueB&c=valueC') for(const key of searchParams.keys()) { console.log(key) if(key === 'b') { searchParams.delete('b') searchParams.append('bb', 'valueBB') } } ``` Output is: ``` a b bb ``` Instead of: ``` a b c bb ``` The reason seems to be that the iterator uses an internal count while iterating, e.g. the implementation in JavaScriptCore: https://github.com/WebKit/WebKit/blob/0743137c2f4f602963fc409ebc56ecd6690d204d/Source/WebCore/html/URLSearchParams.cpp#L155-L163 This can't be reproduced with `new Map()` or `new Set()`. This PR fixes it by only iterating over the keys that are known before the loop starts. Fixes an issue [reported by users](https://vercel.slack.com/archives/C03S8ED1DKM/p1683007482211449). <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> -
Shu Ding authored
The `app-link-gc` module should treat the link with just pathname as the href and full URL as the same resource. This avoids duplicate styles during HMR: <img width="482" alt="CleanShot 2023-05-05 at 18 12 12@2x" src="https://user-images.githubusercontent.com/3676859/236511257-af510ed2-8e21-430a-bf71-24931b10e5de.png"> [Related bug report (internal)](https://vercel.slack.com/archives/C03KAR5DCKC/p1683295788069859).
-
Leah authored
Fixes WEB-959
-
Shu Ding authored
This PR adds a test case to ensure that the server reference doesn't expose actual content of the original file in its sourcemap. Closes NEXT-1041.
-
vercel-release-bot authored
-
vercel-release-bot authored
-
JJ Kasper authored
-
Tim Neutkens authored
## What? Removes `experimental.appDir` this was leftover from when I flipped the switch. Kept the config file as in the future we might add future flags and such. It also helps that it has the types comment included so you always get types. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
JJ Kasper authored
Only shows fetch request logs by default and allows opting into verbose request timings via experimental config. x-ref: [slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1683236293282549)
-
- 04 May, 2023 10 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
-
JJ Kasper authored
Updates the tag handling during a server action direct to pass through the revalidated tags for immediate revalidation as discussed. x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1683218335368759)
-
Shu Ding authored
This fixes an existing bug where there're Server Actions defined in both the "server" and "client" layers (client imported Actions). They have the same worker name as they exist in one route entry, but they're built into different modules and compiled differently (server and client layers). Because of that, each route entry can have 2 "action module entries". This PR adds the logic to differentiate that via a "layer" field so they don't conflict.
-
Jiachi Liu authored
Fixes #49162 When user configures the `basePath` in `next.config.js`, we need to apply it to metadata image path resolving fix NEXT-1087
-
Ivan Kryvorotenko authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change --> ### What? This is a follow-up to https://github.com/vercel/next.js/pull/46290 by @ijjk Currently, nextjs build resolves provided incrementalCacheHandlerPath over destDir (.next by default). And for standalone builds the custom cache can't be resolved and leads to runtime error. ### Why? This fix basically introduces support of incrementalCacheHandlerPath for the standalone build. ### How? incrementalCacheHandlerPath is now always resolved relatively to distDir, which should work for both default and standalone builds. Also, for convenience (and better testability) incrementalCacheHandlerPath can now be provided as a relative path to the project directory.
-
vercel-release-bot authored
-
JJ Kasper authored
This updates our dev logs to include request timings and also includes fetch timings in app directory to including info on whether the cache was leveraged or not allowing easier debugging of contributing factors to render times. In the future we can expand to include middleware timings separate as well to single that out along with timings for `getStaticProps` potentially as well. <details> <summary>Screenshot</summary>  </details> <details> <summary>Screenshot</summary>  </details> <details> <summary>Screenshot</summary>  </details> x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1681418590738249)
-
Justin Ridgewell authored
### What? Fixes serving images that are referenced by JS files inside the `/app` directory. ### Why? ### How? The `NextImageContentSource` attempts to fetch the image out of it's inner content source, and before we were only providing it with the `/public` and `/pages` directory's respective sources. Re: https://vercel.slack.com/archives/C046HAU4H7F/p1683220799917649
-
Jimmy Lai authored
-