- 19 May, 2023 5 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
JJ Kasper authored
x-ref: [slack thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1684457147422049)
-
OJ Kwon authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> This PR updates turbopack to the latest.
-
Steven authored
- Fixes #49237 fix NEXT-1120 Co-authored-by:Wyatt Johnson <633002+wyattjoh@users.noreply.github.com>
-
- 18 May, 2023 8 commits
-
-
JJ Kasper authored
This removes the previous handling for the prebundled react env we were setting in favor of https://github.com/vercel/vercel/pull/9974 We need to wait to land this until https://github.com/vercel/vercel/pull/9974 has been rolled Fixes: https://github.com/vercel/next.js/issues/49169 Fixes: https://github.com/vercel/next.js/issues/49753 x-ref: https://github.com/vercel/next.js/issues/48948
-
Tim Neutkens authored
## What? @steven-tey noticed that on upstash.com that scrolling to hash keeps happening regardless of the hash being set: - Open site - Click `Pricing` which adds `#pricing` and scrolls to the `id="pricing"` - Click `About` - Click on the logo You'll notice that navigating back to the homepage ends up scrolling to the `id="pricing` instead of to the top of the page. ## How? This happened because we didn't reset the `hashFragment` and `segmentPaths` for scrolling when scroll was applied, which means it would keep that value in the state and would be applied as such on navigation. This PR ensures that besides setting `apply` to `false` we also reset the `hashFragment` and `segmentPaths`. Fixes NEXT-1205 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Steven authored
This PR fixes a warning that previous looked like the following: ``` Warning: fetch for [object Request] specified "cache: default" and "revalidate: 60", only one should be specified. ```
-
Steven authored
Reverts vercel/next.js#49959 since the PR [was failing CI](https://github.com/vercel/next.js/actions/runs/5015634314/jobs/8991545593#step:6:179) fix NEXT-634
-
Tim Neutkens authored
## What? Currently the error boundary state does not reset when a navigation happens because the `key` does not change. Because of that navigating using next/link when the error boundary is in the open state ends up not rendering the contents of the new navigation, instead it keeps the error boundary contents. ## How? This PR uses a pattern that is recommended in the React docs (setState during render) to reset the error boundary if the `usePathname` value has changed, it is used as a proxy for a new navigation. Fixes #47862 Fixes NEXT-963 Fixes #49736 Fixes #49732 Fixes #49599 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Maia Teegarden authored
Updated to latest app-playground code
-
Shu Ding authored
Since a server is always required for Server Actions, they won't work with static exports at all. fix NEXT-634 Co-authored-by:Jiachi Liu <inbox@huozhi.im>
-
Shu Ding authored
If running Next.js in the custom server with both app and pages directories presented, a standalone server needs to serve all traffic and the server running in main thread should be a no-op. (cc @ijjk). Fixes the problem described here: https://github.com/vercel/next.js/issues/49355#issuecomment-1537536063.
-
- 17 May, 2023 7 commits
-
-
Jiachi Liu authored
`@vercel/og` should also be treated as external package as precompiled one (x-ref: #48844) As it's ESModule, it could escalate the importee modules to become ESM as well, then `require()` won't be able to load the proper module, we need to switch to await the require result (just like **dynamic import**) for node module loader [slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1683577269970609?thread_ts=1683569728.697039&cid=C03KAR5DCKC)
-
JJ Kasper authored
This config shouldn't be needed in minimal mode as code is evaluated just-in-time
-
vercel-release-bot authored
-
JJ Kasper authored
It seems the build workers count calc change that was made in https://github.com/vercel/next.js/pull/47823 caused a regression in performance as we aren't utilizing as many workers as we previously did so this moves that change behind an experimental flag while additional tweaking is investigated. x-ref: https://github.com/vercel/next.js/pull/47823 Fixes: https://github.com/vercel/next.js/issues/49593
-
Alex Kirszenberg authored
`getSortedRoutes` is used in the `BuildManifestPlugin`, which I'm in the process of porting to Next.js Turbo as part of Next Build. As such, I ported it to Rust using GPT-4 (with manual review over the code). The resulting code is not particularly idiomatic nor optimized Rust code, but it passes all tests (similarly converted) and should be more than fast enough for now. In the process of porting, GPT-4 made some "suggestions" (read: it automatically and silently changed parts of the code) which actually fix some formatting issues with errors: https://github.com/vercel/next.js/pull/48298Co-authored-by:
Tobias Koppers <tobias.koppers@googlemail.com>
-
Alex Kirszenberg authored
This introduces a `NextMode` enum that controls which mode Next.js Turbo is currently running in: * `NextMode::Development`: `next dev` * `NextMode::Build`: `next build` Requires https://github.com/vercel/turbo/pull/4972 This also update Turbopack to `turbopack-230517.2` with the following changes: * https://github.com/vercel/turbo/pull/4972 <!-- Alex Kirszenberg - Configure React development flag, inherit NODE_ENV from execution context --> --------- Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jiachi Liu authored
metadataBase is using `process.env.PORT` to construct a host when there's no `metadataBase` specified in layout. Dev server needs to pass down the PORT env from the parent prcoess. Fixes #49807 Fixes #49859 Closes #49889
-
- 16 May, 2023 8 commits
-
-
Shu Ding authored
This makes sure that you can `.bind` a Server Action multiple times. Thanks to the feedback from @sophiebits: https://github.com/vercel/next.js/pull/49422#pullrequestreview-1419134304
-
Rodrigo Esteves authored
taken from google analytic's page: "_On July 1, 2023, this property will stop processing data. Starting in March 2023, for continued website measurement, migrate your original property settings to a Google Analytics 4 (GA4) property, or they'll be copied for you to an existing GA4 property, reusing existing site tags._" The package 'react-ga' doesn't support GA4, so i updated the package to 'react-ga4', the example continues primarily the same, the only differences is that specifying 'pageview' is now required instead of just setting the location of the pageview and the expection() function doesn't exist in this package. required changes are welcomed Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
OJ Kwon authored
### What? relateed to WEB-1048. Moving emotion to the plugin, deprecate enable_emotion option.
-
Shu Ding authored
Closes #49324. Default export should only be added in the loader generated boundary file when it actually exists. fix NEXT-1112
-
Alex Kirszenberg authored
-
Donny/강동윤 authored
### What? Updates `swc_core` to `v0.76.x`, which adds support for `Explicit Resource Management` (stage 3) ### Why? It's stage 3 ### How? Closes WEB-1040 --- turbopack counterpart: https://github.com/vercel/turbo/pull/4937Co-authored-by:
Tobias Koppers <1365881+sokra@users.noreply.github.com>
-
vercel-release-bot authored
-
Leah authored
### What? Adds support for `mdx-components` at the root/src directory. This is a feature `next-mdx` already has: https://github.com/vercel/next.js/tree/canary/packages/next-mdx#usage-1 Fixes WEB-1012 Depends on https://github.com/vercel/turbo/pull/4944 ### Turbopack updates * https://github.com/vercel/turbo/pull/4949 <!-- OJ Kwon - refactor(turbopack): deprecate single react_refresh options --> * https://github.com/vercel/turbo/pull/4944 <!-- Leah - add mdx `providerImportSource` option -->
-
- 15 May, 2023 8 commits
-
-
Dev Agrawal authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? Updates the `with-clerk` example to use the app router and latest version of `@clerk/nextjs` ### Why? ### How? Closes NEXT- Fixes # --> Updates the `with-clerk` example to use the app router and latest version of `@clerk/nextjs`
-
Rishabh Poddar authored
Update dependencies of our SDKs to point to the latest version ---------
-
OJ Kwon authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### Why? ### How? Closes NEXT- Fixes # --> ### What? WEB-1049. Removes separate enable_refresh options.
-
Leah authored
-
Travis Arnold authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Adds `@swc/core` to the default external server packages for use in packages within node_modules. This package is useful for generating documentation and is related to #48739. Ideally, this would be respected by the `serverComponentsExternalPackages` options. Co-authored-by:
JJ Kasper <jj@jjsweb.site> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Alex Kirszenberg authored
We specifically avoid running most transforms on foreign code without the `transpile_packages` option, but PostCSS transforms should be an exception.
-
Donny/강동윤 authored
### What? Along with https://github.com/swc-project/plugins/pull/182, this PR will allow using trace-level logging for debugging turboapck. ### Why? Requested by @sokra x-ref: https://vercel.slack.com/archives/C03EWR7LGEN/p1683738076476839 ### How? Closes WEB-1035
-
Shu Ding authored
Closes #49259. Note that even if we allow `.set` in the types, it will still error when called in wrong places (such as Server Components). fix NEXT-1090
-
- 13 May, 2023 4 commits
-
-
Fonger authored
This is a bug fix PR. We should respect referrerPolicy when preloading a priority next/image Reproduce codesandbox: https://codesandbox.io/p/sandbox/boring-fog-4o28oi As you can see, the image still request with `referer` header although we have `referrerPolicy="no-referrer" in img attribute. <img width="645" alt="image" src="https://github.com/vercel/next.js/assets/5862369/6a2779d3-e0e2-4dfe-80d2-c8a4243f430b">
-
Alexander Bluhm authored
This PR affects the `examples/app-dir-mdx` project. Currently, only an example of importing a `.mdx` file (`message.mdx`) into the `page.tsx` file is shown. However, a more common example would be using a `.mdx` file as a page, e.g., in a blog scenario. I added an example for this, enabled the page extension to allow `.mdx` pages, and changed the body's height, which is a cosmetic change for the newly created blog page.
-
JJ Kasper authored
This simplifies the implementation for the client router filter and makes the error rate configuring more accurate. Additional tests haven't been added as this is still a matter of probability and existing tests cover the client router behavior. Example scenario of filter size/false positives with an error rate of `0.01%`: ```sh entries: 128 filter size: 4986 bytes, gzip size: 627 bytes false positives with 100000 samples: 26 0.026% ``` x-ref: [slack thread](https://vercel.slack.com/archives/C04K237UHCP/p1683129488543039)
-
JJ Kasper authored
We shouldn't filter this from the router worker as this is where the dev server runs and should be able to allocate more memory. x-ref: [slack thread](https://vercel.slack.com/archives/C04MEB9L9RQ/p1683823794069839?thread_ts=1683756338.246099&cid=C04MEB9L9RQ)
-