- 23 May, 2023 1 commit
-
-
vercel-release-bot authored
-
- 22 May, 2023 11 commits
-
-
Jiachi Liu authored
Fix react and react-dom aliases are not properly set for `pages/` * Remove alias react-dom internals to `{}` in edge runtime as we're using server rendering stub as alias * Add `react$`, `react-dom$` missing aliases * Only apply alias to builtin react/react-dom when it's app dir assets. * Add `react|react-dom/package.json` resolving to require-hook * Fix hmr issue that sometimes it will perform a reload when a hard navigation is triggered -
JJ Kasper authored
This ensures we don't reference the wrong fetch global bypassing react's patched fetch so that it can properly fallback to react's fetch deduping when next cache is disabled for a specific fetch. x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1684518670927189?thread_ts=1682974724.765039&cid=C042LHPJ1NX) fixes: https://github.com/vercel/next.js/issues/50031
-
Steven authored
This `draftMode` prop was missing from the previous PR: - https://github.com/vercel/next.js/pull/48669 It was added on `GetStaticPropsContext` but not on `GetServerSidePropsContext` so this PR fixes it. ---------
-
JJ Kasper authored
Currently the edge runtime does not support static generation so this adds a warning when `force-static` is leveraged with `edge-runtime` as it will cause unexpected behavior. Support is being investigated so this isn't a hard error at the moment. x-ref: [slack thread](https://vercel.slack.com/archives/C03S8ED1DKM/p1684783403551589)
-
JJ Kasper authored
This ensures we properly persist env values set from `next.config.js` across workers. Fixes: https://github.com/vercel/next.js/issues/49541
-
Ibrahem Mahyob authored
- Resolves #50084 The context parameter in the getServerSideProps function lacked a type, which led to a compile-time error. To resolve this, the GetServerSidePropsContext type from next was used to properly type the context parameter. This ensures type safety and allows TypeScript to catch potential errors at compile time. Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
Dev Agrawal authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Fixed landing page responsiveness for smaller screens Sign in, Sign up, and User profile components centered on page Fixed demo URL in readme Added redirect to landing page after signout @perkinsjr --------- Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
vercel-release-bot authored
-
Tim Neutkens authored
## What? After landing #49855 I found a few more edge cases with not-found not behaving as expected: - When navigating directly to a not-found page (e.g. `/testabc`) the error boundary would not reset as there were multiple levels being triggered at the same time. - When running in production navigating back/forward to the not found page caused the page to become empty Both issues are fixed by this PR. I've added tests for both. ## How? - Ensures `asNotFound` is not set on the layout-router, it causes all levels to trigger not-found, even though only app-router needs it - Ensures navigations to 404 are always a mpaNavigation (browser navigation) instead of trying to do a client-side navigation (mirrors what we do in `pages`) Fixes NEXT-1209 Fixes NEXT-1218 Fixes #49823 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tobias Koppers authored
### What? follow up for https://github.com/vercel/next.js/pull/50137 ### Why? I accidentally merged the PR with broken tests
-
Donny/강동윤 authored
### What? This PR disables `tracing/max_level_info`. ### Why? Requested at https://vercel.slack.com/archives/C03EWR7LGEN/p1683789628715199?thread_ts=1683738076.476839&cid=C03EWR7LGEN ### How? Closes WEB-1080 Fixes #49949 Turbopack counterpart: https://github.com/vercel/turbo/pull/5049
-
- 21 May, 2023 3 commits
-
-
j0hnta authored
Fix typo
-
Darsh Patel authored
Fixes: #48712 Use node copyFile in the package.json script for cross-platform support Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
Mark Barton authored
spelling error
-
- 20 May, 2023 2 commits
-
-
Abhishek Kadam authored
### What? This commit makes sure `create-next-app` doesn't ignore user's git configuration (`init.defaultBranch`). ### Why? Hard coding configurations of a user is annoying (for the user). Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
OJ Kwon authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### Why? ### How? Closes NEXT- Fixes # --> ### What? WEB-654. This PR attempts to implement initial sass support in turbopack, via sass-loadder. Internally it points to sass-loader compiled in next.js (`next/dist/sass-loader..`) with next.config.js's option. Still it is not a complete implementation, for example sourceMap is not supported by upstream turbopack. PR requires turbopack side changes as well.
-
- 19 May, 2023 19 commits
-
-
vercel-release-bot authored
-
Karl Horky authored
Fixes #45943 ### What? Allow for type checking the return type of a Route Handler in the `app/` directory: [TypeScript Playground](https://www.typescriptlang.org/play?#code/MYewdgzgLgBAkgOQCoFEBKCCCAZAyjAXhlwE8BbAIxABsAKAcgEswoBTAJzAENqZ3WIAB3ARW9AJQAoSawAew9rGDUuECDARyoaAcMisAPACEQAExKEYAVzABrMCADuYAHwwtrMKfU6hI1jAA3pIwMADaiKgYOLgAugBcQSGhMCbmAPyJaSQANMkAvtKhoJBQ7FbAUCDstFQZWWYkcGCMsAA+MGBW1NQ5MMytib56os2tloH54kkpMBBWghy1jX0DUFLJoVAAFowQEcjoWHixE4WhhcnQXFCMwDAAVhDgBgBSz2DZLsvmie-g2VWLSgmRgw38Y3WiU0sm0un8bw+XxmKQA9KiYAABKAQAC0ckWlXx7HY1RgSF26j2nRAsGYMGojAoqNMIDIfEYAHNtrAHI4+lwvDBHAFgIL6LAuFZOWRPHSoAA6TYwErQPjw-RDDWiSzg-QKp7gH65frAqSzfhQKycTqsRwaLR60S0fh+fV1E2ukasc0wQqXAnVWAAMxslUY4BgAHEUEhaOJoY7tYZAlwKMBEgBGABMAGZ8m5AjB0dHPBw7jAuOxOVZZSwYIJVKJTMlGMGYLQALI3bYK9iC1lkeMwNwABgVAFZpkXlZbrWAHbCnawDR9aKn01m81NixjAKDkNPcJOqiQ9Kuq-EqBWSc5tMLhbtEq6NgVMrGDiXosm-9B3JYPHCkuwp6NKaoAkqwV4BvIQYwKGYDhpGMZINm8aJkuyZBLuGggDAnJluwFZVjWdawFYzatu2XY9n2A5ssOY6TtOMCzqwVp3kmj4roaYDrmmGYwDm+bTP+h6ASelZgBYZ5cMAwCsIIbAthcN5sfOi4Pt6z68a+76ft+si-iJ+5icewGSdJoGyfJimsC2hRAA)  ### Why? There is currently no nice way to enforce the return type of a Route Handler in the `app/` directory. This is possible with `NextApiResponse` in the `pages/` directory, because of this PR: - https://github.com/vercel/next.js/pull/7841 ### How? This implements a generic parameter for the `NextResponse` class, which can be used to pass a type argument when setting the return type for a Route Handler. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Shu Ding <g@shud.in> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
JJ Kasper authored
This removes `node-sass` from being explicitly marked as a peer dependency as it's not recommended anymore and `sass` is already marked as a `peerDependency`, further when auto-install peer dependencies is enabled it can cause this to be pulled in unexpectedly
-
Justin Ridgewell authored
This PR forwards the [new `ServerInfo`](https://github.com/vercel/turbo/pull/5018) struct to Turbopack's rendering processes, allowing it to initialize the requesting headers with the `x-forwarded-*` headers. These headers, and `x-forwarded-proto` in particular, are necessary for [NextAuth to work](https://github.com/nextauthjs/next-auth/blob/f62c0167/packages/next-auth/src/core/index.ts#L73-L76). These headers are initialized in the non-turbo server via [`http-proxy`](https://github.com/http-party/node-http-proxy/blob/9b96cd72/lib/http-proxy/passes/web-incoming.js#L58-L86). Fixes WEB-1064
-
Jiachi Liu authored
client refs are not correctly extracted as we're using regex to get the exports names from cjs file. The regex was extracting some bad names from the code source, this PR fixes the regex to make sure they extract the correct content Fixes NEXT-1213
-
Shu Ding authored
As explained in the comments, the `cookies()` API is a mix of request and response cookies. For `.get()` methods, we want to return the request cookie if it exists. For mutative methods like `.set()`, we return the response cookie type instead. fix #50049 fix NEXT-1211
-
Shu Ding authored
Currently the suffix logic is for pages so nothing happens in app dir. This PR changes it to **always** apply the `createSuffixStream(closeTag)` transform, to defer `</body></html>` to the end of the stream. fix #48372 fix NEXT-1200
-
Jiachi Liu authored
* Adding default metadata to root not found under root layout * Refactor the tests a bit, previously it only checks if the text existed in html, it actually exisits in flight response Fixes #49979 Closes NEXT-1207
-
Justin Ridgewell authored
https://github.com/vercel/turbo/pull/4895 renamed `ExportsValue` into `SubpathValue` --------- Co-authored-by:
Tobias Koppers <tobias.koppers@googlemail.com> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jiachi Liu authored
Reland #49959 as it was reverted in #50019 * Only error when runing `next export` or `output` is "export" * Add e2e test Closes NEXT-634
-
Shu Ding authored
For static member expressions like `foo.bar`, we currently treat it as one whole Ident `foo.bar` and pass it over the `$$bound` array as one value. That causes a problem where the Ident inside the function body needs to be converted, because it can no longer access to `foo`. Closes #49985. fix NEXT-1206
-
Wyatt Johnson authored
This serves to create the loader that will allow us to transition more of the rendering logic into each of the bundled entrypoints. This only applies to pages routes inside the `pages/` folder in the node environment. fix NEXT-985 --------- Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
OJ Kwon authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> This PR adjusts manifests for the next.js test with Turbopack, as I found upstream test keep changing and need to sync its latests state into the manifest. Manifest is now .js file contains 2 arrays, one for the enabled, and others for the disabled. Disabled doesn't mean it's always failing though.
-
vercel-release-bot authored
-
vercel-release-bot authored
-
JJ Kasper authored
x-ref: [slack thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1684457147422049)
-
OJ Kwon authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> This PR updates turbopack to the latest.
-
Steven authored
- Fixes #49237 fix NEXT-1120 Co-authored-by:Wyatt Johnson <633002+wyattjoh@users.noreply.github.com>
-
- 18 May, 2023 4 commits
-
-
JJ Kasper authored
This removes the previous handling for the prebundled react env we were setting in favor of https://github.com/vercel/vercel/pull/9974 We need to wait to land this until https://github.com/vercel/vercel/pull/9974 has been rolled Fixes: https://github.com/vercel/next.js/issues/49169 Fixes: https://github.com/vercel/next.js/issues/49753 x-ref: https://github.com/vercel/next.js/issues/48948
-
Tim Neutkens authored
## What? @steven-tey noticed that on upstash.com that scrolling to hash keeps happening regardless of the hash being set: - Open site - Click `Pricing` which adds `#pricing` and scrolls to the `id="pricing"` - Click `About` - Click on the logo You'll notice that navigating back to the homepage ends up scrolling to the `id="pricing` instead of to the top of the page. ## How? This happened because we didn't reset the `hashFragment` and `segmentPaths` for scrolling when scroll was applied, which means it would keep that value in the state and would be applied as such on navigation. This PR ensures that besides setting `apply` to `false` we also reset the `hashFragment` and `segmentPaths`. Fixes NEXT-1205 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Steven authored
This PR fixes a warning that previous looked like the following: ``` Warning: fetch for [object Request] specified "cache: default" and "revalidate: 60", only one should be specified. ```
-
Steven authored
Reverts vercel/next.js#49959 since the PR [was failing CI](https://github.com/vercel/next.js/actions/runs/5015634314/jobs/8991545593#step:6:179) fix NEXT-634
-