- 24 May, 2023 4 commits
-
-
vercel-release-bot authored
-
JJ Kasper authored
Follow-up to https://github.com/vercel/next.js/pull/48019 ensures we don't use arbitrary ports by incrementing favoring always getting a fresh free port instead. Also favors exact address for internal IPC requests instead of `localhost`.
-
JJ Kasper authored
This seems to be failing with the WASM builds so this reverts to allow further investigation x-ref: https://github.com/vercel/next.js/actions/runs/5062818601/jobs/9088828339 x-ref: https://github.com/vercel/next.js/actions/runs/5061364458/jobs/9085596546 x-ref: https://github.com/vercel/next.js/actions/runs/5062868910/jobs/9092170727 Reverts vercel/next.js#49972
-
- 23 May, 2023 21 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
A bad alias was introduced in #50128 Fixes #50225
-
Donny/강동윤 authored
### What? Implement a CJS optimizer for next-swc ### Why? x-ref: https://vercel.slack.com/archives/C02HY34AKME/p1684341093462309 Assuming most CJS files are transpiled from ESM, we can mimic tree-shaking using an AST transform. ### How? Closes WEB-1072 Fixes #48469 fix NEXT-1156 --------- Co-authored-by:
Shu Ding <g@shud.in>
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? Enable more test cases to run with turbopack ### Why? These test suites are passing and are not flaky.
-
Cowboy Ho authored
## Bug This fix closes #47083 issue This fix closes #47561 issue This fix closes #48376 issue **Invalid repetition PRs:** #47671 (this PR changing expired code) (This issue still exist on [v13.4.3-canary.1](https://github.com/vercel/next.js/releases/tag/v13.4.3-canary.1) - [x] Related issues linked using `fixes #number` ### What? When running `NODE_OPTIONS='--inspect' next dev`, the render server didn't start with `--inspect`. In some cases, the `--inspect` flag will be passed when `__NEXT_DISABLE_MEMORY_WATCHER` was set. ### Why? Since #47208 revamped some startup processes, the `NODE_OPTIONS` environment parameter is not passed down to the render server worker. ### How? Just add back the original startup process.  link NEXT-1176 --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Maia Teegarden authored
My computer ignored the casing change when copying things over, which causes resolution errors.
-
Shu Ding authored
This PR adds generated type definitions for `Link` hrefs with only search, hash or with a protocol. Closes #49825. fix NEXT-1203
-
Tobias Koppers authored
### What? align output path of turbopack and webpack ### Why? passing test cases ### Turbopack Changes * https://github.com/vercel/turbo/pull/5072 <!-- Tobias Koppers - improve asset path -->
-
vercel-release-bot authored
-
Jesse Koldewijn authored
fix: Added blockfrost-js, lucid-cardano & mongoose package to srvExtPackages to prevent issue #49783 from happening. (#49938) fixes #49783 ### What? Added the following packages to the server component exclusion list which prevents these packages from going through the currently default compile pipeline for apps that use the App Router. Packages added are: "@blockfrost/blockfrost-js", "@jpg-store/lucid-cardano" and "mongoose". (For instance, mongo was already in this exclusion list) ### Why? These packages are required by the "@emurgo/cardano-serialization-lib-nodejs" packages and break when not added to this list while using the app router. ### How? I've added these packages to the server-external-packages json file in the Next.js package's lib directory.
-
Tim Neutkens authored
## What? Ensures `NEXT_DYNAMIC_NO_SSR_CODE` has a unique error code value, this accidentally had the value for dynamic server usage (e.g. calling cookies()) which caused the warning to be shown as shown in #48442. ## How? Changed the digest value to something unique. Fixes NEXT-1125 Fixes #48442 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
JJ Kasper authored
This removes the `computeWorkerKey` from our static workers as this doesn't work in practice as efficiently as we hoped since a single page can have thousands of paths to render which won't be distributed to separate workers if the same worker key is returned. Fixes: https://github.com/vercel/next.js/issues/49593 **Before**  **After** 
-
Tobias Koppers authored
### What? * allow to apply existing pipeline * change webpack loader key to glob for more flexibility * add test cases * add special error message when using the old config syntax Old config: ```js experimental: { turbo: { loaders: { ".mdx": ["mdx-loader"] } } } ``` New config ``` js experimental: { turbo: { rules: { // key is a glob now // normal syntax will treat the result as ecmascript code "*.mdx": ["mdx-loader"], // glob allows more advanced matching "./images/**/*.png": { loaders: ["image-optimize-loader"], // result of loader will be handled in other steps // under the same name/path (here .png) // This will use the existing .png pipeline (static asset) // It might also use other rules matching .png. as: "*" }, "*.generate-image.js": { loaders: ["image-generation-loader"], // It also possible to pass this under a different name // into the pipeline. Here it will treat the result as png image as: "*.png" } } } } ``` ### Why? More flexibility and allowing to use the builtin module handling over non-js types. fixes WEB-1009 ### Turbopack changes * https://github.com/vercel/turbo/pull/4955 <!-- OJ Kwon - refactor(turbopack-ecmascript): deprecate enable_emotion, enable_styled* --> * https://github.com/vercel/turbo/pull/4880 <!-- Tobias Koppers - refactor webpack loader execution --> --------- Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Tim Neutkens authored
## What? Ensures the debugging variables are only assigned when the values change. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
vercel-release-bot authored
-
OJ Kwon authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### Why? ### How? Closes NEXT- Fixes # --> ### What? WEB-1086. This PR flips the way running next.js integration test with Turbopack, instead of using allowlist to run selectively enabled test now uses denylists. The immediate effect is now any new test being added (as a new file) will be executed with Turbopack by default, and should be manually excluded if it fails. Still, the number of tests we run remains same.
-
Justin Ridgewell authored
This adds the `node` condition, so that importing a node module that uses `exports` with a `node` specified will prioritize that file. Eg, [uuid](https://github.com/uuidjs/uuid/blob/4de23a60/package.json#L25-L31)'s `package.json` will now resolve to the `./dist/esm-node/index.js` in our SSR builds, instead of the default `./dist/esm-browser/index.js` Fixes WEB-1051
-
Tobias Koppers authored
### What? adds `NEXT_TURBOPACK_TRACING` env var to enable tracing. Writes into `.next/trace.log` There are 4 presets: * `NEXT_TURBOPACK_TRACING=overview` gives a overview of requests and modules processed. * `NEXT_TURBOPACK_TRACING=next` above plus details for next.js * `NEXT_TURBOPACK_TRACING=turbopack` above plus details for turbopack * `NEXT_TURBOPACK_TRACING=turbo-tasks` above plus details for turbo-tasks Published release builds will only allow `overview` to work, since all detailed instrumentation is statically disabled. see https://github.com/vercel/turbo/pull/4966 for more details ### Why? get more insight into build times ### Turbopack changes * https://github.com/vercel/turbo/pull/4995 * https://github.com/vercel/turbo/pull/5049 * https://github.com/vercel/turbo/pull/5053 * https://github.com/vercel/turbo/pull/4966
-
vercel-release-bot authored
-
- 22 May, 2023 11 commits
-
-
Jiachi Liu authored
Fix react and react-dom aliases are not properly set for `pages/` * Remove alias react-dom internals to `{}` in edge runtime as we're using server rendering stub as alias * Add `react$`, `react-dom$` missing aliases * Only apply alias to builtin react/react-dom when it's app dir assets. * Add `react|react-dom/package.json` resolving to require-hook * Fix hmr issue that sometimes it will perform a reload when a hard navigation is triggered -
JJ Kasper authored
This ensures we don't reference the wrong fetch global bypassing react's patched fetch so that it can properly fallback to react's fetch deduping when next cache is disabled for a specific fetch. x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1684518670927189?thread_ts=1682974724.765039&cid=C042LHPJ1NX) fixes: https://github.com/vercel/next.js/issues/50031
-
Steven authored
This `draftMode` prop was missing from the previous PR: - https://github.com/vercel/next.js/pull/48669 It was added on `GetStaticPropsContext` but not on `GetServerSidePropsContext` so this PR fixes it. ---------
-
JJ Kasper authored
Currently the edge runtime does not support static generation so this adds a warning when `force-static` is leveraged with `edge-runtime` as it will cause unexpected behavior. Support is being investigated so this isn't a hard error at the moment. x-ref: [slack thread](https://vercel.slack.com/archives/C03S8ED1DKM/p1684783403551589)
-
JJ Kasper authored
This ensures we properly persist env values set from `next.config.js` across workers. Fixes: https://github.com/vercel/next.js/issues/49541
-
Ibrahem Mahyob authored
- Resolves #50084 The context parameter in the getServerSideProps function lacked a type, which led to a compile-time error. To resolve this, the GetServerSidePropsContext type from next was used to properly type the context parameter. This ensures type safety and allows TypeScript to catch potential errors at compile time. Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
Dev Agrawal authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Fixed landing page responsiveness for smaller screens Sign in, Sign up, and User profile components centered on page Fixed demo URL in readme Added redirect to landing page after signout @perkinsjr --------- Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
vercel-release-bot authored
-
Tim Neutkens authored
## What? After landing #49855 I found a few more edge cases with not-found not behaving as expected: - When navigating directly to a not-found page (e.g. `/testabc`) the error boundary would not reset as there were multiple levels being triggered at the same time. - When running in production navigating back/forward to the not found page caused the page to become empty Both issues are fixed by this PR. I've added tests for both. ## How? - Ensures `asNotFound` is not set on the layout-router, it causes all levels to trigger not-found, even though only app-router needs it - Ensures navigations to 404 are always a mpaNavigation (browser navigation) instead of trying to do a client-side navigation (mirrors what we do in `pages`) Fixes NEXT-1209 Fixes NEXT-1218 Fixes #49823 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tobias Koppers authored
### What? follow up for https://github.com/vercel/next.js/pull/50137 ### Why? I accidentally merged the PR with broken tests
-
Donny/강동윤 authored
### What? This PR disables `tracing/max_level_info`. ### Why? Requested at https://vercel.slack.com/archives/C03EWR7LGEN/p1683789628715199?thread_ts=1683738076.476839&cid=C03EWR7LGEN ### How? Closes WEB-1080 Fixes #49949 Turbopack counterpart: https://github.com/vercel/turbo/pull/5049
-
- 21 May, 2023 3 commits
-
-
j0hnta authored
Fix typo
-
Darsh Patel authored
Fixes: #48712 Use node copyFile in the package.json script for cross-platform support Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
Mark Barton authored
spelling error
-
- 20 May, 2023 1 commit
-
-
Abhishek Kadam authored
### What? This commit makes sure `create-next-app` doesn't ignore user's git configuration (`init.defaultBranch`). ### Why? Hard coding configurations of a user is annoying (for the user). Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-