- 10 Jun, 2023 11 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
JJ Kasper authored
We publish multiple packages in parallel which can cause issues with the prepublish only script running as turbo clearing/restoring dist caches can causing files to be missing if a publish is in progress. We also don't need to run these as all packages are already built prior to publishing. This also includes fixes for release stats.
-
Shu Ding authored
This review comment was sent after merging the PR: https://github.com/vercel/next.js/pull/51067#discussion_r1224745071 The layer condition doesn't do anything if `hasServerComponents` is disabled.
-
vercel-release-bot authored
-
Pau Fernández authored
-
Arun S V authored
Fixed a typo in 'Scrolling to an id' section. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Michael Novotny authored
Replaces #50481 --------- Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com> Co-authored-by:
Lee Robinson <me@leerob.io>
-
Michael Novotny authored
Fixes #50227
-
Michael Novotny authored
This is to [avoid confusion](https://github.com/vercel/next.js/issues/32603#issuecomment-996751692) about being able to set Next.js's port via `.env`, which is currently not allowed.
-
OJ Kwon authored
### What? I noticed some deploy job fails at https://github.com/vercel/next.js/actions/runs/5222848985/jobs/9428961695#step:15:20 when there's no summary exists by missing necessary flags for the few platform targets.
-
- 09 Jun, 2023 29 commits
-
-
vercel-release-bot authored
-
JJ Kasper authored
This ensures we don't attempt streaming a response during revalidation in deployed environments. x-ref: https://github.com/vercel/next.js/pull/51062 x-ref: [slack thread](https://vercel.slack.com/archives/C03S8ED1DKM/p1686216024812579)
-
Delba de Oliveira authored
This PR removes manual HTML `<b>` tags in `<details><summary>...` titles. They are unnecessary because we add bold styling in CSS. Also did a tiny fix to some other unnecessary inline HTML.
-
Michael Novotny authored
Give a touch more context as to why one would want to use image optimization. Fixes #30220
-
Steven authored
- Fixes https://github.com/vercel/next.js/issues/47858 - Closes https://github.com/vercel/next.js/pull/50289 fix #47858 fix NEXT-1281 Co-authored-by:
Kevin Wolf <3157426+kevinwolfcr@users.noreply.github.com>
-
JJ Kasper authored
x-ref: https://github.com/vercel/next.js/pull/51062
-
Jiachi Liu authored
Like how we handled RSC loader transform before, we also apply swc loader to middleware to make sure the imports optimization is applied so og package won't be bundled Fixes #50492
-
JJ Kasper authored
This ensures we clear the RSC headers during revalidate when deployed so that the HTML revalidation isn't treated as the RSC revalidation.
-
Steven authored
These tests were disabled temporarily in PR #49088 so we can enable once again now.
-
Simon Podlipsky authored
### What? When `verbatimModuleSyntax: true` is set, `isolatedModules: true` are not allowed by TS ### Why? Next always adds `isolatedModules: true` which causes TS error. ### How? - Fixes #46509 fix NEXT-689 Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
Jiachi Liu authored
Wrap server inseration children with react key to avoid react key warning display
-
JJ Kasper authored
Noticed this case wasn't handled in pages so added additional test coverage and patched the case.
-
JJ Kasper authored
This makes sure we properly include headers in the cache key when a headers instance is used. x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1686234796532989)
-
Steven authored
Remove these dependencies since they appear to be unused - Closes https://github.com/vercel/next.js/pull/50928 - Closes https://github.com/vercel/next.js/pull/50123
-
Delba de Oliveira authored
-
Steven authored
This might fix the npm publish error ``` Error: Command failed with exit code 254 (Unknown system error -254): npm publish /home/runner/work/next.js/next.js/packages/next --access public --tag canary ``` https://github.com/vercel/next.js/actions/runs/5219901558/jobs/9422546478#step:11:9353
-
Michael Novotny authored
There are some incoming docs / MDX changes where prettier will throw an error when using the older version. Updating prettier before I bring in those changes. Looks like the most notable change is adding parentheses around `typeof` checks in TypeScript. **Before** ``` export type Locale = typeof i18n['locales'][number] ``` **After** ``` export type Locale = (typeof i18n)['locales'][number] ```
-
Jiachi Liu authored
We need to spread the module into an object instead of access the module exports that could not exist, to avoid triggering the warning. Fix the bad loader change introduced in #50548 ``` Attempted import error: './middleware.js' does not contain a default export (imported as ' mod'). - info Using locally built binary of @next/swc - warn You are using an experimental edge runtime, the API might change. - wait compiling... - warn ../../../../packages/next/dist/build/webpack/loaders/next-middleware-loader.js?abso lutePagePath=%2FUsers%2Fhuozhi%2Fworkspace%2Fnext.js%2Ftest%2Fe2e%2Fapp-dir%2Fapp%2Fmiddle ware.js&page=%2Fmiddleware&rootDir=%2FUsers%2Fhuozhi%2Fworkspace%2Fnext.js%2Ftest%2Fe2e%2F app-dir%2Fapp&matchers=! Attempted import error: './middleware.js' does not contain a default export (imported as ' mod'). - wait compiling... ```
-
Delba de Oliveira authored
There was some confusion about where to place it.
-
Jimmy Lai authored
Manifests tend to be really big and our strategy is to inline them in the edge function script itself and we're hitting some constraints this way. This PR switches this behaviour via inlining the script and creating a JS object at runtime instead, with the hope that the parsing time will be faster as JSON.parse is very well optimised in V8. The end goal ofc is to have smaller manifests but this should be a good stopgap. link NEXT-1273
-
Alain Kaiser authored
### Fix Typo in Metadata API Description #### Description: This PR fixes a minor typo in the description of the Metadata API. #### Changes: - Fixed typo in the Metadata API description. **File:** `docs/02-app/01-building-your-application/05-optimizing/04-metadata.mdx` **Old Sentence:** > Next.js has a Metadata API that can used to define your application metadata (e.g. `meta` and `link` tags inside your HTML `head` element) for improved SEO and web shareability. **New Sentence:** > Next.js has a Metadata API that can be used to define your application metadata (e.g. `meta` and `link` tags inside your HTML `head` element) for improved SEO and web shareability. This change helps improve the readability and understanding of the documentation for readers and users. #### Checks: - [x] Followed the Docs Contribution Guide - [x] Linting passes (`pnpm build && pnpm lint`)
-
Jiachi Liu authored
Encode the state tree where the content could contain unicode when request the RSC payload, to avoid the fetch failure due to bad encoding for headers Fixes #48728 fix NEXT-1258
-
Balázs Orbán authored
### What? Hide internal API. ### Why? Ref: https://vercel.slack.com/archives/C035J346QQL/p1669125601246609?thread_ts=1669125167.045259&cid=C035J346QQL ### How? Mark the internal property with `@internal` so it's not shown by IntelliSense. Related #47894
-
vercel-release-bot authored
-
Kevin Ang authored
This PR fixes the erroneous `revalidateTag` import on certain examples. It was imported from `next/server`, but should be imported from `next/cache` instead. Co-authored-by:Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Taylor Bryant authored
This PR fixes some small typos in the Contribution Guide.
-
Tyler Lutz authored
Co-authored-by:Lee Robinson <me@leerob.io>
-
PatrickCodes_ authored
Added a TS and JS switcher. Previously the code snippet did not have a switcher. The file extension was .js when the code was TypeScript which made it confusing to try to read. --------- Co-authored-by:Lee Robinson <me@leerob.io>
-
JJ Kasper authored
After enabling Draft Mode, `router.refresh()` was incorrectly causing the page to crash and do a full page refresh. This PR fixes this case. Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-