- 15 Jun, 2023 18 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Valentin Politov authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
-
Milan K authored
## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Hi Next.js team, This PR aims to update examples/auth0 with Auth0 V2 and fix profile api console error. https://github.com/auth0/nextjs-auth0/blob/v2.0.0/V2_MIGRATION_GUIDE.md Thanks for the review.
-
Hank Lin authored
Refer to [here](https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams/toString#examples) The `searchParams.toString()` doesn't include the question mark. Co-authored-by:
Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
-
Tom authored
fixes #51332 ### What? Changed the link to the latest official Strapi example with Next.js (+ App Router), Tailwind and TypeScript. ### Why? The current example will be archived. See related blog post: https://strapi.io/blog/introducing-the-new-strapi-starter-with-nextjs13-tailwind-and-typescript > We'd also like to address what this means for older Strapi starters. Due to limited bandwidth, we've decided to support only this new Strapi Starter officially, and all other starters will be archived. ### How? .
-
Shu Ding authored
Our shared layer matcher doesn't contain `next/dist/esm`, which breaks Server Actions when there're cookie/header accesses. Closes #50099. Fix NEXT-1229
-
Tobias Koppers authored
### What? update Turbopack and sync dependencies with turbo ### Turbopack changes * https://github.com/vercel/turbo/pull/5303
-
Nicolás Figueroa authored
### What? * **Facebook pixel implementation with the new `app folder` structure.** * The pixel script can now be kept in the public folder. * The Facebook script can be placed in the `layout.js` file * A component called `FacebookPixel` is provided to handle the initial script setup and manage `PageView` events when the page changes. * Classic implementation with `pages` folder now is in `_pages` ### Why? To provide an example of implementing the new `app folder` structure with Next.js ˆ13, which includes using the new files like `layout`, `page`, etc. ### How? Utilizing the `next/script` package and the `layout.js` file to initialize the Facebook pixel when the application starts and manage subsequent events. ### Evidence of Implementation: Here are some examples that demonstrate the successful implementation of the Facebook pixel using the new `app folder` structure and `Next.js ˆ13` Tracking main page `app/page.js` <img width="399" alt="image" src="https://github.com/vercel/next.js/assets/26902419/fd3baee8-363d-4f2c-b949-517409ad36de"> <img width="2105" alt="image" src="https://github.com/vercel/next.js/assets/26902419/7d91d786-cd31-4c21-bb79-7e9a78fb1c3b"> Tracking another path `app/about/page.js` <img width="333" alt="image" src="https://github.com/vercel/next.js/assets/26902419/dda7bc05-6fb5-482d-8a6a-d981a08c66e1"> <img width="2102" alt="image" src="https://github.com/vercel/next.js/assets/26902419/b0392d6e-31fe-42d1-a7b4-ca38879dde94"> navigation between pages with `next/link` <img width="2098" alt="image" src="https://github.com/vercel/next.js/assets/26902419/21115bee-a77f-4467-bb25-c95e2850cda2">
-
vercel-release-bot authored
-
JJ Kasper authored
x-ref: [slack thread](https://vercel.slack.com/archives/C04MEB9L9RQ/p1686787663510239?thread_ts=1686770561.895939&cid=C04MEB9L9RQ)
-
mknichel authored
This PR updates `.vercel.approvers` files to fix some validation errors and to more closely match desired behavior for assigning and notifying members of the team for reviews that was discussed on an internal Slack thread. - Owners files for `.cargo/` and `.config/` are moved to their respective directories instead of being placed at the root. - Fixes the `@vercel/next-js` team name (it uses a dash instead of a period) - Adds `:notify` to reviewers so that all of the people listed are notified of the pull request, but only a single person would be requested as a reviewer. - `@vercel/web-tooling:optional` was made optional so that they are not requested for any change to `pnpm-lock.yaml` but still have the ability to approve PRs that modify it. ---------
-
JJ Kasper authored
Reverts vercel/next.js#51308
-
OJ Kwon authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> ### What? WEB-1183 Context: https://vercel.slack.com/archives/C04KC8A53T7/p1686768648161459?thread_ts=1686763527.218549&cid=C04KC8A53T7 We'd like to avoid false positives to the test cases if test supposed to run turbopack (having __INTERNAL_ flags) but somehow test fixture does not run turbopack correctly.
-
vercel-release-bot authored
-
JJ Kasper authored
x-ref: [slack thread](https://vercel.slack.com/archives/C04MEB9L9RQ/p1686788708114089?thread_ts=1686770561.895939&cid=C04MEB9L9RQ) Reverts vercel/next.js#50936
-
Shu Ding authored
Make sure we are using `var` instead of `const` as we always put the new appended statements to the end of the module body, but they can still be referenced before in the HOC case in the runtime. This causes a runtime error. Tl;dr: `a = 1; var a` is fine, but `a; const a = ...` will result in a compilation error. Closes #49344.
-
JJ Kasper authored
Instead of temporarily disabling flakey or unpatched tests in deploy mode this continues to run all tests and see all failures at once. x-ref: https://github.com/vercel/next.js/actions/runs/5272454654/jobs/9536161644
-
- 14 Jun, 2023 22 commits
-
-
JJ Kasper authored
Closes: https://github.com/vercel/next.js/issues/51309 Reverts vercel/next.js#51179
-
JJ Kasper authored
It's valid to want to output JSON instead of HTML for the bundle analyzer so we can expose this specific config the same as `openAnalyzer`. cc @mknichel
-
vercel-release-bot authored
-
-
-
JJ Kasper authored
This fails when run during a release since the new version isn't published yet x-ref: https://github.com/vercel/next.js/actions/runs/5266469610/jobs/9520466217
-
Shu Ding authored
Remove the Server CSS manifest and related logic, and use the chunkGroup CSS files instead for each entry to inject stylesheet links. Why was that manifest needed in the first place? When implementing CSS collection for RSC and nested layout initially, we collect CSS imports at each layer and create corresponding client entries. But then soon got hit by the problem of duplication and improper tree-shaking. Two layers can have the same CSS imported so we solved it in a way that "if an upper layer imports this module, skip it in child layers". Note that this is deduped by module, so we need to keep the information of "layer (entry) → CSS modules" somewhere, in a manifest. Another reason is that we create the client entry before Webpack optimizes modules, so we can inject the client entry into the same compilation. But that means the collected client modules from the server layer are not properly optimized (DCE). **This is a general issue at the moment that's not specifically related to CSS, although using that manifest to collect DCE'd info and join the original collected CSS files with that info temporarily solved it.** That's why I disabled some tests related to font CSS collection and want to improve it in a more general way. Why is that not needed anymore? Main reason is to keep a good balance between duplication and number of chunks, and delegate the decision to Webpack's splitChunks plugin. It is not possible to get to a point of 0 duplication unless we ship every CSS module as a single chunk. And since in #50406 we made the duplication better but at the chunk asset level, instead of the original module level. Prior work: #50406, #50610.
-
Michael Novotny authored
Adds suggestions from #51063, which didn't get applied before merge.
-
mPaella authored
### What? Fixes https://github.com/vercel/next.js/issues/50129 ### Why? The current denormalization of app dir paths doesnt account for the normalization done in `normalizeAppPath`, causing build log outputs for certain paths such as anything under a route groups to be incorrect ### How? There's 2 ways this could be fixed: 1.) Denormalize the app dir paths by reading the `app-path-routes-manifest.json` and mapping back to the original file path 2.) (what I chose to do) Normalize the keys of `appBuildManifest` ### Result App dir paths, including route groups, now have their correct output size <img width="494" alt="image" src="https://github.com/vercel/next.js/assets/93682696/0eee79b8-7d60-4c88-b07a-dfb750aa9592"> --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
bri authored
Ran script `update-google-fonts`, adding these fonts to `next/font/google`: - [Instrument Sans](https://fonts.google.com/specimen/Instrument+Sans) - [Noto Sans Nag Mundari](https://fonts.google.com/noto/specimen/Noto+Sans+Nag+Mundari) - [Wix Madefor Display](https://fonts.google.com/specimen/Wix+Madefor+Display) - [Wix Madefor Text](https://fonts.google.com/specimen/Wix+Madefor+Text) and updating these fonts: - [Radio Canada](https://fonts.google.com/specimen/Radio+Canada) (added `canadian-aboriginal` subset) Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
tom authored
This PR adds a dark mode to the error overlay which respects the browsers color scheme. I just did this because I was blinded by the dev overlay a lot today and thought this change might be appreciated. Screenshot (dark mode): <img width="2056" alt="image" src="https://user-images.githubusercontent.com/17279485/233201837-0d005e10-d73f-4ddd-9f4a-285829ec63b1.png"> Screenshot (retained light mode): <img width="1064" alt="image" src="https://user-images.githubusercontent.com/17279485/233202019-83ec79d8-d2ca-44c8-bc0a-7696355dfe72.png"> Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Max Proske authored
Compose v1 has reached EOL, and will no longer be included with Docker after June 2023: https://www.docker.com/blog/docker-desktop-4-19/
-
Shu Ding authored
Currently the Server Action function with `"use server"` must be an async function as it's required by the compiler, even if it returns a promise already.
-
-
Tyler Lutz authored
Removes extra 'the' in the documentation Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Gideon authored
fix Fastly and Gumlet heading level
-
JJ Kasper authored
The `domain` value is meant to be a hostname and not include `http` or port so this ensures we validate it doesn't contain `:` unexpectedly causing invalid behavior. Closes: https://github.com/vercel/next.js/issues/49656 x-ref: https://github.com/vercel/next.js/issues/24991#issuecomment-870418366 --------- Co-authored-by:
Jiachi Liu <inbox@huozhi.im>
-
Wyatt Johnson authored
This cleans up some setup functions within the route modules, improves logic around headers, and handles the case where the URL is invalid better for routes using the request adapters.
-
OJ Kwon authored
### What? Minor fix to remove guards to the config since turbopack have this feature enabled.
-
Shu Ding authored
Similar to tags and paths, when `cookies().set()` is called we have to invalidate the client router cache as well so routes with `cookies().get()` will not holding the stale data. This is critical for auth and other scenarios. In the future we can have an optimization to only invalidate routes that actually rely on cookies, similar to paths.
-
Delba de Oliveira authored
Bring back #related-links and fix broken link in fonts page
-
Delba de Oliveira authored
-