- 20 Sep, 2023 15 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Shu Ding authored
Specific case: https://twitter.com/shuding_/status/1704220735726633205 > import { User, User as foo } from 'lucide-react' In your codebase so `User` got imported twice
-
Jiachi Liu authored
### After
💅 <img width="109" alt="image" src="https://github.com/vercel/next.js/assets/4800338/f90d15a1-ac6e-4fe1-8241-d9e40e9d2e0e"> ### Before <img width="143" alt="image" src="https://github.com/vercel/next.js/assets/4800338/fbc09a29-cac2-459d-8a96-d1a5948947cc"> -
Tim Neutkens authored
Can't verify this because there is no clear reproduction and I can't reproduce it when manually trying, but this will probably fix #55649. Not sure how they exit the process that it doesn't clean up on the Node.js side though
🤔 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jiachi Liu authored
When errors are thrown in middleware it could re-send headers for the same response ``` Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client at __node_internal_captureLargerStackTrace (node:internal/errors:490:5) at new NodeError (node:internal/errors:399:5) at ServerResponse.setHeader (node:_http_outgoing:645:11) at origSetHeader (/next.js/packages/next/src/server/base-server.ts:777:16) at ServerResponse._res.setHeader (/next.js/packages/next/src/server/base-s erver.ts:777:16) at setHeader (/next.js/packages/next/src/server/base-http/node.ts:84:15) at renderErrorImpl (/next.js/packages/next/src/server/base-server.ts:2790: 11) at <anonymous> (/next.js/packages/next/src/server/base-server.ts:2777:19) at trace (/next.js/packages/next/src/server/lib/trace/tracer.ts:213:14) at DevServer.renderError (/next.js/packages/next/src/server/base-server.ts :2776:24) at DevServer.renderError (/next.js/packages/next/src/server/next-server.ts :1299:18) at DevServer.handleRequestImpl (/next.js/packages/next/src/server/base-ser ver.ts:1185:23) { code: 'ERR_HTTP_HEADERS_SENT' } ``` Migrate middleware-errors test to e2e test to avoid flaky assertion due to duplicated logging collected in integration test. Closes NEXT-1629 -
vercel-release-bot authored
-
Balázs Orbán authored
### What? Bump these packages to their latest. (Bumped `satori` too to avoid multiple versions in the repo) ### Why? Follow-up of https://github.com/vercel/next.js/pull/55187 ### How? Updated the original package applying the changes from #55187 Closes NEXT-1639 Fixes #55604 [Slack thread](https://vercel.slack.com/archives/C03S8ED1DKM/p1695169119558899)
-
GabenGar authored
- remove the slash before `pathname` (already included in the value). - add `search` and `hash` values in redirected url: - retains these values on redirect - they already have `?` and `#` respectively Co-authored-by:Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
-
vercel-release-bot authored
-
Mayank authored
Snyk has created this PR to upgrade next from 13.4.7 to 13.4.19. See this package in npm: https://www.npmjs.com/package/next See this project in Snyk: https://app.snyk.io/org/mayank1513/project/e72076fc-8d2c-4d92-ac05-133865d727f0?utm_source=github&utm_medium=referral&page=upgrade-pr <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
snyk-bot <snyk-bot@snyk.io> Co-authored-by:
Balázs Orbán <info@balazsorban.com>
-
Wyatt Johnson authored
In JS, Promise's are used to help manage async tasks and control flows. When code calls methods on a promise like `.then()`, `.catch()`, or `.finally()` the results of the promise are forwarded to the callback as soon as they're resolved. This serves to make a change to the promise creation such that we do not await on the promise until we're within the try/finally block. This will ensure that the promise will always be added to the map before it's resolved or rejected and it's cleanup (removing it from the active promises) is also completed. This additionally introduces a new `scheduleOnNextTick` method and polyfill for `Promise.withResolvers()`. `scheduleOnNextTick` is based on the scheduling algorithm used by https://github.com/graphql/dataloader which utilizes a `Promise.resolve()` combined with `process.nextTick` in order to schedule an operation to occur after the promises have resolved (see [graphql/dataloader](https://github.com/graphql/dataloader/blob/d336bd15282664e0be4b4a657cb796f09bafbc6b/src/index.js#L213-L255)) The `Promise.withResolvers()` polyfill is an implementation of a soon-to-be-landed spec for inside-out promises. [Read the spec](https://tc39.es/proposal-promise-with-resolvers/)
-
Zack Tanner authored
These are quick so we can do it in one run Follow up to https://github.com/vercel/next.js/pull/55621
-
Zack Tanner authored
This runs unit tests separate from the `test-dev` task to make it a bit more obvious these are running, and allow for an easy way to add any unit-test specific behavior in the future [slack x-ref](https://vercel.slack.com/archives/C04DUD7EB1B/p1695150908857269)
-
Zack Tanner authored
Update React from d6dcad6a8 to 2807d781a. ### React upstream changes - https://github.com/facebook/react/pull/27387 - https://github.com/facebook/react/pull/27386 - https://github.com/facebook/react/pull/27385 - https://github.com/facebook/react/pull/27379 - https://github.com/facebook/react/pull/27382 Closes NEXT-1637
-
- 19 Sep, 2023 24 commits
-
-
Quentin authored
## Fixing a bug ### What? On these versions, SIGINT signals are `string`, exit callback recieves code `number` ### How? We use code argument to quit process for `event`, and exit with code `0` for `SIGINT` and `SIGTERM` signals Fixes #55605 Co-authored-by:Jiachi Liu <4800338+huozhi@users.noreply.github.com>
-
Jiachi Liu authored
Closes #55611
-
OJ Kwon authored
### What? PR migrates next-dev's api tests to use next.js integration tests, as well as enabling few more image tests. Closes WEB-1599
-
Balázs Orbán authored
### What? Continues #55525 Adding filtering for repro validation checks ### Why? #55589 should not have been closed ### How? https://github.com/balazsorban44/nissuer/commit/ecbf8b42139fc1442f134ed4671b71db5f04715c
-
Jake Boone authored
[As of Bun v1.0.0](https://bun.sh/blog/bun-v1.0#changelog-since-v0-8), `bun dev` runs the "dev" script from package.json. Therefore, as with Yarn and pnpm, the "run" command is not necessary. This PR changes the `create-next-app` README templates to show `bun dev` instead of `bun run dev`.
-
Mayank authored
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-GRAPHQL-5905181Co-authored-by:
snyk-bot <snyk-bot@snyk.io> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Mayank authored
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-GRAPHQL-5905181Co-authored-by:
Snyk bot <19733683+snyk-bot@users.noreply.github.com>
-
Maia Teegarden authored
Closes WEB-1607
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Tobias Koppers authored
Closes WEB-1608
-
vercel-release-bot authored
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? makes sure that styled-jsx is always bundled as it contains `react` and it being external would break the react vendoring
-
Tobias Koppers authored
### What? Makes sure that errors that have no user code in stack trace still show an stack trace Closes WEB-1605
-
Jiachi Liu authored
`isAppLayer` condition was missing `app-metadata-route` layer, made it as a util now like other webpack layer utils, add metadata route layer to the group. Then `React.cache` can be available there. Also update regex to be compatible across platform Fixes #55561 Closes NEXT-1635
-
Maia Teegarden authored
Closes WEB-1600 Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Shu Ding authored
This addresses the case mentioned in https://github.com/vercel/next.js/pull/54925#pullrequestreview-1616315332. We can't optimize the case where we can't statically determine the type of the `useState` argument as it can be a function: `useState(() => ...)`.
-
Shu Ding authored
Follow-up for #55310.
-
Balázs Orbán authored
### What? Moving maintenance to a separate repository. ### Why? I want to make these actions reusable in other projects as they seem to work well in the Next.js repository. ### How? The code is moved to https://github.com/balazsorban44/nissuer I tested it on my fork, and all the following functionality is preserved: https://github.com/balazsorban44/next.js/issues/56 - [x] Close/lock/comment without a valid reproduction link - [x] Minimize "+1" - [x] Add labels based on user selection - [x] Add comment based on the maintainer's label (eg.: "please add a complete reproduction")
-
Zack Tanner authored
This consolidates how we're evaluating when to opt into `react@experimental` since it's sprinkled in a lot of spots. Also adds a new flag to opt into the experimental channel Closes NEXT-1632
-
Shu Ding authored
Feedback from https://github.com/vercel/next.js/issues/48748#issuecomment-1714292279. As per my testing, an App Router route of ```tsx 'use client' import { Button } from 'mui-core' export default function Page() { return <Button>Hi</Button> } ``` was improved from `2.4s (1221 modules)` to `1458ms (649 modules)` for the local dev.
-
romeobravo authored
### What? Fix heading hierarchy in revalidateTag documentation (https://nextjs.org/docs/app/api-reference/functions/revalidateTag) ### Why? Makes it consistent with https://nextjs.org/docs/app/api-reference/functions/revalidatePath
-
- 18 Sep, 2023 1 commit
-
-
vercel-release-bot authored
-