- 25 Sep, 2023 7 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Jimmy Lai authored
Should fix the problem surfaced in https://github.com/vercel/next.js/issues/43548#issuecomment-1732416492 The scenario in which this breaks is when we're asking the app renderer to generate a prefetch payload statically. The renderer was not checking if there were loading.js below the current rendering level, which is the root when statically rendering, so it would always render null, which was incorrect. Tested out with the original repro https://next-instant-loading-8nv6psqod-feedthejim.vercel.app
-
Tim Neutkens authored
Still some failing tests but it's a start. Adds the env vars used to support trailing slash, base path and asset prefix. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tim Neutkens authored
I noticed that running the script to pull in the results wasn't deterministic between test runs, this ensures the list, passing, pending, and errors are all sorted, which makes the diff only include what actually changed between runs. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Jiachi Liu authored
### What #51394 introduced a pretty strict type of return value of route type that causing failure with `next build`. There're few ways of writing a app route, it could contain few return values based on the usage: * return a `Response` or promise of it * return `NextResponse` of promise of it, since it's extended from `Response`, same type * use `redirect()` or `notFound(), since it returns `never`, and the below code is not reached, the handler itself could still return void. e.g. using `redirect` in a `GET` route We loosed the type so `redirect()` can be still allowed without specifying the return value there. Related typescript issue: https://github.com/microsoft/TypeScript/issues/16608#issuecomment-309327984 ### How * Re-enable the bail on types / build error in the app-routes tests * Separate the tests, move runtime erroring ones to `test/e2e/app-dir/app-routes-errors` * Add new case to app-routes tests of mixed return value Closes #55623 Related #55604
-
Tim Neutkens authored
This option only has a process.env replacement. Ensures `test/development/client-navigation` can run for Turbopack. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
- 24 Sep, 2023 4 commits
-
-
Vũ Văn Dũng authored
### Why? There is already an example of handling query parameters (`searchParams`) in route handler, but it's quite hidden (in [Opting out of caching](https://nextjs.org/docs/app/building-your-application/routing/route-handlers#opting-out-of-caching)). It made it hard for many developers to figure out how to do that: [there](https://discord.com/channels/752553802359505017/1127781032242974790) [are](https://discord.com/channels/752553802359505017/752647196419031042/1143181251856044042) [several](https://discord.com/channels/752553802359505017/752647196419031042/1146007247630106704) [people](https://discord.com/channels/752553802359505017/752647196419031042/1154623267164917861) who couldn't find that section in the documentation. (Linked are messages in the Next.js Discord server.) Therefore this PR adds an example to the route handler documentation on how to do that, so developers can take reference more easily.
-
Mostafa Gouda authored
In the new next.js v13.5 blog post, the [other improvements section](https://nextjs.org/blog/next-13-5#other-improvements) mentions: > [Improvement] Server Actions now work with fully static routes (including revalidating data with ISR) In the forms and mutation docs page, the [good to know section](https://nextjs.org/docs/app/building-your-application/data-fetching/forms-and-mutations#how-server-actions-work) mentions: > Currently, if a route uses a Server Action, it is required to [render dynamically](https://nextjs.org/docs/app/building-your-application/rendering/server-components#server-rendering-strategies). I have changed the good to know section to convey the new improvement mentioned in the v13.5 blog post
-
Tim Neutkens authored
Moves the client-navigation test suite to be isolated as part of test/development. Tried to make the minimal amount of changes neccesary to ensure the tests pass first before using the newer `NextInstance` methods. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
João de Vasconcelos authored
Just a one word change to fix the example in https://nextjs.org/docs/app/api-reference/file-conventions/metadata/opengraph-image#generate-images-using-code-js-ts-tsx
-
- 23 Sep, 2023 8 commits
-
-
Dom Sip authored
Currently the image props section is broken: https://nextjs.org/docs/pages/api-reference/components/image Reverts vercel/next.js#55776 fixes: [#55869](https://github.com/vercel/next.js/issues/55869)
-
Tim Neutkens authored
Ensures this warning is in line with the other warnings for removed config.
-
Tim Neutkens authored
Noticed this was combining two objects but it can just be created as one object.
-
Jiachi Liu authored
Re-enable the disabled test
-
Tim Neutkens authored
Noticed that the error happens to be caught accidentally and doesn't bubble up because of that.
-
vercel-release-bot authored
-
Zack Tanner authored
This fixes some scenarios where executing a server action after navigation can cause the action to behave incorrectly (double submitting, not resolving). There are two separate issues: - `canonicalUrl` and `pendingNavigatePath` were not constructed using the same function (`createHrefFromUrl`) so in certain situations they'd be comparing different values - a fulfilled inFlightServerAction should not be invoked again Closes NEXT-1655 Closes NEXT-1654 Fixes #55845 Fixes #55814 Fixes #55805
-
Deepa Subramanian authored
Made changes as suggested by the reporter. ```json filename="tsconfig.json or jsconfig.json" { "compilerOptions": { "module": "esnext", "moduleResolution": "node", "baseUrl": "./", "paths": { "@/components/*": ["components/*"] } } } ``` ```json filename="package.json" { "scripts": { "dev": "next dev", "build": "next build", "start": "next start", "cypress:open": "cypress open" } } ```
-
- 22 Sep, 2023 18 commits
-
-
Wyatt Johnson authored
This swaps the existing minifier for the Next.js runtime bundling from [terser](https://github.com/terser/terser) over to [swc](https://swc.rs/docs/configuration/minification). This small change has slightly decreased development file sizes, and dramatically decreased the time it takes to bundle the runtime. The results below were ran once on my MacBook Pro (M1 Pro). ## Compilation Speed About 3 times faster - `next_bundle_pages_dev`: improved from 7.28s to 1.85s. - `next_bundle_pages_turbo`: improved from 7.28s to 1.85s. - `next_bundle_pages_prod`: improved from 7.28s to 1.93s. - `next_bundle_server`: improved from 7.28s to 2.68s. - `next_bundle_app_turbo`: improved from 8.09s to 2.89s. - `next_bundle_app_turbo_experimental`: improved from 7.74s to 2.77s. - `next_bundle_app_prod`: improved from 7.86s to 2.77s. - `next_bundle_app_dev`: improved from 9.41s to 2.86s. - `next_bundle_app_prod_experimental`: improved from 8.01s to 3.12s. - `next_bundle_app_dev_experimental`: improved from 9.11s to 3.58s. - `next_bundle`: improved from 9.50s to 3.69s. ## File Sizes About the same, small improvements in development bundle sizes ```shell # Using terser 692K packages/next/dist/compiled/next-server/app-page-experimental.runtime.dev.js 460K packages/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js 460K packages/next/dist/compiled/next-server/app-page-turbo-experimental.runtime.prod.js 436K packages/next/dist/compiled/next-server/app-page-turbo.runtime.prod.js 672K packages/next/dist/compiled/next-server/app-page.runtime.dev.js 436K packages/next/dist/compiled/next-server/app-page.runtime.prod.js 68K packages/next/dist/compiled/next-server/app-route-experimental.runtime.dev.js 48K packages/next/dist/compiled/next-server/app-route-experimental.runtime.prod.js 48K packages/next/dist/compiled/next-server/app-route-turbo-experimental.runtime.prod.js 48K packages/next/dist/compiled/next-server/app-route-turbo.runtime.prod.js 68K packages/next/dist/compiled/next-server/app-route.runtime.dev.js 48K packages/next/dist/compiled/next-server/app-route.runtime.prod.js 28K packages/next/dist/compiled/next-server/pages-api-turbo.runtime.prod.js 28K packages/next/dist/compiled/next-server/pages-api.runtime.dev.js 28K packages/next/dist/compiled/next-server/pages-api.runtime.prod.js 64K packages/next/dist/compiled/next-server/pages-turbo.runtime.prod.js 68K packages/next/dist/compiled/next-server/pages.runtime.dev.js 64K packages/next/dist/compiled/next-server/pages.runtime.prod.js 204K packages/next/dist/compiled/next-server/server.runtime.prod.js # Using swc 684K packages/next/dist/compiled/next-server/app-page-experimental.runtime.dev.js 460K packages/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js 460K packages/next/dist/compiled/next-server/app-page-turbo-experimental.runtime.prod.js 436K packages/next/dist/compiled/next-server/app-page-turbo.runtime.prod.js 660K packages/next/dist/compiled/next-server/app-page.runtime.dev.js 436K packages/next/dist/compiled/next-server/app-page.runtime.prod.js 68K packages/next/dist/compiled/next-server/app-route-experimental.runtime.dev.js 48K packages/next/dist/compiled/next-server/app-route-experimental.runtime.prod.js 48K packages/next/dist/compiled/next-server/app-route-turbo-experimental.runtime.prod.js 48K packages/next/dist/compiled/next-server/app-route-turbo.runtime.prod.js 68K packages/next/dist/compiled/next-server/app-route.runtime.dev.js 48K packages/next/dist/compiled/next-server/app-route.runtime.prod.js 28K packages/next/dist/compiled/next-server/pages-api-turbo.runtime.prod.js 28K packages/next/dist/compiled/next-server/pages-api.runtime.dev.js 28K packages/next/dist/compiled/next-server/pages-api.runtime.prod.js 64K packages/next/dist/compiled/next-server/pages-turbo.runtime.prod.js 68K packages/next/dist/compiled/next-server/pages.runtime.dev.js 64K packages/next/dist/compiled/next-server/pages.runtime.prod.js 204K packages/next/dist/compiled/next-server/server.runtime.prod.js ```
-
Justin Ridgewell authored
### What? Updates `run-test.js` to allow running individual test cases inside a test file. ### Why? So that we can dramatically increase Turbopack's test coverage. Turbopack has implemented most (but not all) necessary features from the webpack bundles. But a single failing test case would prevent us from running any case inside a test file. With case filtering, we're able to run the cases we know will pass and prevent regressions on those. ### How? Case filtering is only exposed via the `NEXT_EXTERNAL_TESTS_FILTERS` ENV, which points to a JSON file containing a map of test files with the test cases inside those files that are known to pass. The known-passing test cases can be updated after Turbopack's daily integration test run by running `test/build-turbopack-tests-manifest.js`, which will update the `test/turbopack-tests-manifest.json` manifest. Closes WEB-1640 Co-authored-by:Tobias Koppers <1365881+sokra@users.noreply.github.com>
-
Tim Neutkens authored
Uses satisfies to check the next-swc-loader options passed. Found a few mismatches and implicit default, made sure they match up the same default values but set explicitly. This will need a thorough double-check. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Lee Robinson authored
This PR shows how to use a new React hook `useFormState` in the context of the [Forms and Mutations](https://nextjs.org/docs/app/building-your-application/data-fetching/forms-and-mutations) docs. It also updates the forms example (`next-forms`) to show the recommended patterns for loading / error states. Related: https://github.com/vercel/next.js/pull/55399 --- Co-authored-by:
John Pham <johnphammail@gmail.com>
-
vercel-release-bot authored
-
Daigo Shitara authored
removed unnecessary parentheses Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
Deepa Subramanian authored
``` Pages and Layouts The Pages Router has a file-system based router built on the [concept of pages](https://nextjs.org/docs/pages/building-your-application/routing/pages-and-layouts). ``` Change requested: Here `concept of pages` hyperlinks routes to the current page. This bit confusing for someone trying to learn next.js. removing the hyperlink to the text would make clear.
-
Will Binns-Smith authored
This: - Updates to the latest api change for `StdError` in `error_generic_member_access` rust-lang/rust#99301 - Updates `pathfinder_simd` for compatiblity Closes WEB-1636
-
Tim Neutkens authored
Noticed these values are already included in WebpackLayerName so the extra type is not needed.
-
OJ Kwon authored
### What? This PR enables basic support for next.config.js's `distDir` config. PR have two main pieces, one for honoring distDir and construct output path other than `.next`, and secondly assign `process.env.__NEXT_DIST_DIR` to client / edge. The latter increased size of PR bit as had to downstream to the compile_define calls. Corresponding tests are enabled to verify its behavior. Closes WEB-1610
-
Will Binns-Smith authored
This regressed in #55063 Closes WEB-1643
-
Tim Neutkens authored
This package has been legacy for multiple years and has been marked deprecated, this check is no longer useful. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tim Neutkens authored
These methods have been landed for multiple years now, it's fine to remove the legacy checks for `unstable_`.
-
Tim Neutkens authored
Narrowing down the webpack config a bit. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Leah authored
-
Zack Tanner authored
The IPC request to `imageOptimizer` assumed the server was listening on http, so this updates it to pull the protocol from `getRequestMeta` instead. This also adds the option to pass in a path to the CA Root so that the dev server can add it to `NODE_EXTRA_CA_CERTS` Closes NEXT-1646 Fixes #55706
-
Jiachi Liu authored
`__NEXT_PREBUNDLED_REACT` is replaced by `__NEXT_EXPERIMENTAL_REACT` as we're bundling built-in react for app router
-
- 21 Sep, 2023 3 commits
-
-
vercel-release-bot authored
-
OJ Kwon authored
### What? Minor improvement to test fixture to clean up the instance if explicitly specified to continue test. This is required to run turbopack related tests. Closes WEB-1634
-
Jiachi Liu authored
For progress spinner, only log new line when `process.stdout.isTTY` ## After  ## Before  Adding extra space make sure there's loading bar between prefix text and spinner  Closes NEXT-1647
-