- 17 Sep, 2024 1 commit
-
-
JJ Kasper authored
-
- 11 Sep, 2024 1 commit
-
-
JJ Kasper authored
This removes our invalid revalidate default fallback when a revalidate value isn't returned from render as render should always return a valid value. We also already have an invariant when an invalid revalidate value is returned we just need to ensure that case could be hit properly. This also fixes some invalid test cases which were sending invalid headers. x-ref: [slack thread](https://vercel.slack.com/archives/C0676QZBWKS/p1726061828198529?thread_ts=1720714625.621179&cid=C0676QZBWKS)
-
- 10 Sep, 2024 3 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
-
Wyatt Johnson authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change Closes NEXT- Fixes # --> This creates a new `SharedRevalidateTimings` type that is safe to share amongst different points within the framework for sharing revalidation timings. This is a precursor to #64313 which freezes loaded manifests. Using the `SharedRevalidateTimings` type, we no-longer have to modify the in-memory instance of the prerender manifest to share the revalidation timings for different routes. Closes NEXT-3083
-
- 18 Oct, 2023 5 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
-
Jiachi Liu authored
-
Josh Story authored
-
- 16 Oct, 2023 7 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Tobias Koppers authored
-
vercel-release-bot authored
-
Tim Neutkens authored
Looked for `webpack(config` in the test suites and disabled the ones that are testing webpack specifically. There are a few more that are not skipped as they should be implemented for Turbopack.
-
OJ Kwon authored
Closes WEB-1702 This PR implements initial support for the `next/dynamic` in Turbopack, more specifically resolving some hydration errors and other components boot up cases. Previously, turbopack had partial next/dynamic support via its own mode (https://github.com/vercel/next.js/pull/56389/files#diff-e1af4f79cb88a73f819a25443d15ed4b1ffabcbb879256caa59b751fad46d7c4L68), which does a transform against `next/dynamic` wrapped import to embed dynamically resolvable chunk ids like (https://github.com/vercel/next.js/blob/ad42b610c25b72561ad367b82b1c7383fd2a5dd2/packages/next-swc/crates/next-transform-dynamic/tests/fixture/wrapped-import/output-turbo-dev-server.js). However, since next.js relies on static path to the chunks to the dynamic import and passing those ids in between client-server to ensure component load (and avoid hydration errors), it doesn't work out of the box. This PR changes turbopack's behavior to closely mimic what current next.js's webpack plugin does, by 1. Traverse the module graph, find out `dynamic(import())` 2. Generate chunks for those imports, creates a partial LoadableManifest per each imports 3. Merge partial manifest into a single `react-loadable-manifest.json` 4. For the id, use static (Webpack mode) instead of dynamic so we can embed it in `react-loadable-manifest` as well as next.js can use it to pass it between server-client context. I left a small comment to the implementation (https://github.com/vercel/next.js/pull/56389/files#diff-bf12ed2c69d0bc89a06884779da4ae44967eb8becada031dea12bedef28e2622R155) for the lifecycle of this feature in case to fix further. This makes to pass most of the basic next-dynamic related integration tests, except if the import have webpack specific features like https://github.com/vercel/next.js/blob/ad42b610c25b72561ad367b82b1c7383fd2a5dd2/test/development/basic/next-dynamic/pages/dynamic/multiple-modules.js#L5. --------- Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-
Kiko Beats authored
It bumps Edge Runtime to include the latest fixes, such as: - https://github.com/vercel/edge-runtime/pull/622 - https://github.com/vercel/edge-runtime/pull/640Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
- 15 Oct, 2023 2 commits
-
-
vercel-release-bot authored
-
Joris Tirado authored
-
- 14 Oct, 2023 8 commits
-
-
Balázs Orbán authored
-
vercel-release-bot authored
-
Diana Gouveia authored
fix cypress script name typo to run `cypress:open` as declared on package.json script example
-
Tim Neutkens authored
Since Turbopack doesn't use eval-source-map the CSP nonce will pass correctly, nice improvement over the current state where you can't check CSP in dev.
-
Tim Neutkens authored
This ensures the tests pass in both webpack and Turbopack. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tim Neutkens authored
This ensures `import url from 'url'` works in the edge runtime when using Turbopack. It also ensures the stubs for fetch / object.assignare applied to the client and edge compilation.
-
Jiachi Liu authored
x-ref: https://github.com/vercel/next.js/issues/56038#issuecomment-1762855556 x-ref: https://github.com/vercel/next.js/issues/56038#issuecomment-1746864558 http header `connection` could still fail the image requests while running next build
-
Tim Neutkens authored
Fixes a bunch of the Turbopack test failures for `test/e2e/app-dir/app/index.test.ts`. Not sure how this passed with webpack before as the dep was indeed missing.
-
- 13 Oct, 2023 13 commits
-
-
JJ Kasper authored
This ensures our `readFile` handling for tracing we previously had is maintained. Test deployment with the provided reproduction can be seen here: https://react-pdf-repro-jeqgyhmek-vtest314-ijjk-testing.vercel.app/ Fixes: https://github.com/vercel/next.js/issues/56676
-
vercel-release-bot authored
-
vercel-release-bot authored
-
VAS authored
Fixed a typo - docs/04-architechture/supported-browsers.mdx Changes(s) made - Fixed a typo for improving clarity [includes -> include] 'your dependencies includes' -> 'your dependencies include' Please review and merge it.
-
JJ Kasper authored
x-ref: https://github.com/vercel/next.js/actions/runs/6502354559
-
Surav Shrestha authored
`Enviroment -> Environment` --------- Co-authored-by:Steven <steven@ceriously.com>
-
Tim Neutkens authored
This implements support for `export const preferredRegion = ['sfo1', 'lhr1']` in Turbopack. Previously this caused an error.
-
Leah authored
### Description - Adds the page path to the middleware template (and also uses the template from the next.js loader) - ESM aliases for the edge context - Fix for the process polyfill to make it possible to import from `dist/esm` - Fix for the `server-only`/`client-only` aliases Closes WEB-1779
-
Balázs Orbán authored
### What? Adding back `x-forwarded-*` headers. ### Why? Starting with #52492, these headers were lost. ### How? We can populate these headers before executing a request. Closes NEXT-1663 Fixes #55942
-
Alex Yang authored
### What? If the custom server uses `app.render(xxx)` will render the normal js files as server components in dev mode and cause 404 error when loading every non-HTML file. ### How? Fixes https://github.com/nodejs/help/issues/4253, fixes https://github.com/vercel/next.js/issues/50270
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? app code is different from pages code and need to be in a separate layer ### Why? Otherwise it tries to share chunks and will cause conflicting writes ### How? Closes WEB-1778
-
vercel-release-bot authored
-