- 30 Oct, 2023 15 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Josh Story authored
Update React from 8c8ee9ee6 to 0c6348758 - https://github.com/facebook/react/pull/27627 - https://github.com/facebook/react/pull/27624 - https://github.com/facebook/react/pull/27610 - https://github.com/facebook/react/pull/27592 - https://github.com/facebook/react/pull/27593 - https://github.com/facebook/react/pull/27588 - https://github.com/facebook/react/pull/27591 - https://github.com/facebook/react/pull/27587 Update @types/react to 18.2.33 Update @types/react-dom to 18.2.14
-
JJ Kasper authored
Seems this command is causing intermittent issues and we don't actually need this information so removes it
-
moka-ayumu authored
### What? If the version of `autoprefixer` is 10.0.0 and the version of `tailwindcss` is less than 3.3.0, the error `RangeError: Maximum call stack size exceeded` occurs when you create with tailwindcss & typescript and run it. ### Why? The exact reason is unknown, but it appears to be a compatibility issue. Also, currently configuring tailwindcss with ts makes the tailwind config file in ts, which is supported since tailwindcss version 3.3.0. (In js, it works even if you set the version of `autoprefixer` to 10.0.1 and lower the version of tailwindcss.) ### How? Simply default the minimum version of `autoprefixer` to 10.0.1 and the minimum version of `tailwindcss` to 3.3.0.
-
Leah authored
### What? Previously the matching just used the last match for children which could lead to empty groups or groups without page matches overriding the actual page. This PR makes sure this doesn't happen and emits an issue (which unfortunately doesn't get displayed yet) in case there are 2 `page` matches which would go into the children slot. Closes WEB-1895
-
vercel-release-bot authored
-
Zack Tanner authored
This removes the ignores for dev react bundles which was added as an optimization but causes issues when react is imported from an ESM module since all requires are being analyzed for named exports. Fixes #57582
-
Jiachi Liu authored
Displaying hints of "missing default export" if you didn't properly export the `default` handler for og image ``` ▲ Next.js 14.0.1-canary.2 - Local: http://localhost:3000 ✓ Ready in 1089ms ✓ Compiled /opengraph-image/[[...__metadata_id__]]/route in 211ms (44 modules) ⨯ Error: Default export is missing in "/Users/huozhi/workspace/next.js/test/e2e/app-dir/metadata-dynam ic-routes/app/opengraph-image.tsx" at eval (webpack:///app/opengraph-image.tsx?3407:11:1) at (app-metadata-route)/../../../../packages/next/dist/build/webpack/loaders/next-metadata-route-lo ader.js?page=%2Fopengraph-image%2F%5B%5B...__metadata_id__%5D%5D%2Froute&isDynamic=1!./app/opengraph-im age.tsx?__next_metadata_route__ (/Users/huozhi/workspace/next.js/test/e2e/app-dir/metadata-dynamic-rout es/.next/server/app/opengraph-image/[[...__metadata_id__]]/route.js:362:1) at __webpack_require__ (/Users/huozhi/workspace/next.js/test/e2e/app-dir/metadata-dynamic-routes/.n ext/server/webpack-runtime.js:33:42) ```
-
Alexandre Spehler authored
## Description Updating the URL for the Google Tag Manager in the Next.js documentation for [Third Party Libraries](https://nextjs.org/docs/pages/building-your-application/optimizing/third-party-libraries). We were using https://developers.google.com/maps/documentation/embed/embedding-map, which redirected to the documentation for embedding Google Maps. ## Implementation - Replacing https://developers.google.com/maps/documentation/embed/embedding-map by https://developers.google.com/tag-platform/tag-manager
-
AZM authored
Updated typo <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? Updated one of the most common typos ### Why? Improve the quality of documentation for readers. ### How? neccessary -> necessary Closes NEXT- Fixes # -->
-
Niaz Morshed Nayeem authored
### Fixing a bug - Related issues linked using `fixes #57533` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### What? If there is a `middleware.js` or `middleware.ts` file in Next.JS 14, running `next build` shows the following warning: ``` ./node_modules/next/dist/esm/shared/lib/router/utils/app-paths.js A Node.js module is loaded ('url' at line 3) which is not supported in the Edge Runtime. Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime Import trace for requested module: ./node_modules/next/dist/esm/shared/lib/router/utils/app-paths.js ``` This PR will remove the warning. Closes NEXT- Fixes #57533
-
Dak Washbrook authored
### What? The Next.js TS Plugin generally supports the named exports for the pages and layouts. Currently the TS Plugin doesn't support the new viewport export. See: https://nextjs.org/docs/app/building-your-application/upgrading/codemods#use-viewport-export ### How? Added the `viewport` export to the `constants.ts`. Closes #57680
-
Tarik authored
Typo fix
-
Vercel Release Bot authored
This auto-generated PR updates font data with latest available
-
- 29 Oct, 2023 3 commits
-
-
vercel-release-bot authored
-
Joel Hooks authored
Co-authored-by:
Lee Robinson <me@leerob.io> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Boris Besemer authored
-
- 28 Oct, 2023 6 commits
-
-
vercel-release-bot authored
-
Joel Hooks authored
Co-authored-by:
Lee Robinson <me@leerob.io> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Kunal Agrawal authored
Fixes #57593
-
Anthony Zheng authored
-
Hugo Maestá authored
-
JJ Kasper authored
This is a native module so exteranlize it by default
-
- 27 Oct, 2023 16 commits
-
-
vercel-release-bot authored
-
mknichel authored
This PR fixes an issue where sometimes the `.next/trace` file would not be written at the end of a build. The process was not waiting for the write stream to be flushed before closing, losing the contents of the trace, which was especially visible when using `experimental-compile`.
-
mknichel authored
This PR adds two simple tags to the `.next/trace` output for the `next-build` span to keep track of parameters to the build step when looking at build traces, and a `isTurbotrace` for the tracing step.
-
Dima Voytenko authored
Implement OTEL propagation according to the OpenTelemetry API per https://opentelemetry.io/docs/specs/otel/context/api-propagators/. Any configured propagator should work with this API, including `W3CTraceContextPropagator` (https://www.w3.org/TR/trace-context/). Alternative to the https://github.com/vercel/next.js/pull/56891. /cc @sfirrin
-
Lee Robinson authored
Following the documentation: ``` ▲ commerce/ npx @next/codemod@latest next-og-import . Invalid transform choice, pick one of: - name-default-component - add-missing-react-import - withamp-to-config - url-to-withrouter - cra-to-next - new-link - next-image-to-legacy-image - next-image-experimental - built-in-next-font ```
-
xixinRunBoy authored
example/active-class-name: the Nav.tsx's style has not taken effect change <style jsx> to <style jsx global> Co-authored-by: chenxixin <chenxixin>
-
vinay authored
Co-authored-by:
Lee Robinson <me@leerob.io> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Kunall Banerjee authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Nothing too crazy, just pointing the demo to the right URL. The previous URL is dead/unreachable.
💖 -
Fatih Kalifa authored
Previously options and link for tag manager refers to maps embed documentation
-
Hirotomo Yamada authored
params from `{}` to `{ slug: [] }`. Fixes #57027 -
Gonzalo Pozzo authored
This adds a new `Good to know` box to explain how to programmatically redirect in Client Components to avoid people using `redirect` inside handlers.  Co-authored-by:
Lee Robinson <me@leerob.io>
-
Jack Howard authored
-
ChanHui authored
### What? When I ran `npx create-next-app --example with-turbopack` and installed dependencies using `yarn`, I found an typescript error(`'SomeComponent' cannot be used as a JSX component.`). <img src="https://github.com/vercel/next.js/assets/51700274/f6c7e478-c0b1-4ea2-996f-4c0c78e3bb4b" width=400 /> and I realized that the bug is due to the version of @types/react(18.0.x). you can check this issue on [here](https://github.com/vercel/next.js/issues/42292#issuecomment-1594351684) too. ### Why? It seems that there is an error occurring in the @types/react version 18.0.x. ### How? It would be good to change the @types/react version to 18.2.8 in the next.js examples. I think this change will resolve [this issue](https://github.com/vercel/next.js/issues/55080#issue-1884846177) [NestJS documentation](https://nextjs.org/docs/app/building-your-application/configuring/typescript#async-server-component-typescript-error) also states to upgrade the version. Co-authored-by:
Lee Robinson <me@leerob.io> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Zoe-Bot authored
Fix bug in example code. Loading with `'` can not be built with the default ESLint rules: ```ssh ./src/app/reviews/loading.tsx 4:15 Error: `'` can be escaped with `'`, `‘`, `'`, `’`. react/no-unescaped-entities 4:26 Error: `'` can be escaped with `'`, `‘`, `'`, `’`. react/no-unescaped-entities ```
-
Houssein Djirdeh authored
Adds `with-google-maps-embed` example in `examples/` directory to show how to use the `<GoogleMapsEmbed />` component from _@next/third-parties_. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Houssein Djirdeh authored
Adds `with-youtube-embed` example in `examples/` directory to show how to use the `<YouTubeEmbed />` component from _@next/third-parties_. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-