- 31 Oct, 2023 23 commits
-
-
vercel-release-bot authored
-
Shu Ding authored
You can read the removed comments to get some context here. Based on the community feedback, we're removing this compile-time error and instead, it will be a runtime error only when it gets accessed by React and found it missing in the manifest. In the future, we'll need: - Converting the client references created this way to be specific errors. So they'll only throw in that certain case. - Or have a prepass compilation to collect all the references globally. This way we can support any kind of layer change. Related: https://twitter.com/trashh_dev/status/1719016700191150550.
-
Steven authored
-
SADIK KUZU authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Jiachi Liu authored
Remove the unnecessary condition as we always use `route.page` for `reportTrigger`
-
Jiachi Liu authored
This reverts commit bd2e8732.
-
Jiachi Liu authored
-
vinay authored
Update `Explore the Next.js 13 playground.` --> `Explore starter templates for Next.js`
-
Jimmy Lai authored
bumping the vendored otel package
-
Zack Tanner authored
Currently we publish a release in GitHub before it's actually fully published to npm. This moves the undraft step until after the publish is finished
-
Zack Tanner authored
Removes some usernames that our PR labeler webhook shouldn't apply to
-
Tim Neutkens authored
Makes it easier to convert to TypeScript later when it has a consistent return type. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
mknichel authored
This PR adds a tag to the `next-build` span to identify whether the build is using the webpack build workers and/or has a custom webpack config which can be used during debugging traces. 
-
Maia Teegarden authored
@vercel/web-tooling -> @vercel/turbopack
-
Rodrigo authored
Hi, I added a key in the map iteration of scripts in Youtube Embed. I use the index as a key but maybe there are a better solution about this like script.url + index
🤔 There isn't open related issues with this PR as this moment. ```js {scripts?.map((script, index) => ( <Script key={index} src={script.url} strategy={scriptStrategy[script.strategy] as ScriptProps['strategy']} stylesheets={stylesheets} /> ))} ``` -
vinay authored
Co-authored-by:Jiachi Liu <inbox@huozhi.im>
-
vercel-release-bot authored
-
Justin Ridgewell authored
### What? This PR adds an hourly workflow that will update the test manifest used when testing with Turbopack. ### Why? To ensure we don't regress any test suites. ### How? I use the existing `scripts/update-fonts-data-workflow.js` workflow script which will execute a script, then create a PR with the current working tree. If any pending automated PRs exist, they will be closed when a new one is opened.
-
Nhan Doan authored
### What? The default template generated from `create-next-app` still says **Next.js 13**. <img width="1053" alt="image" src="https://github.com/vercel/next.js/assets/2561973/1413dcda-d73d-43a9-ba47-8322cf193c52"> ### Why? Next.js 14 is released.
-
Jimmy Lai authored
Stumbled upon this while investigating. The previous configuration did not make a lot of sense. On Node, fs reads can be expensive so it's best to avoid them as much as possible. The current configuration would create chunks eagerly for nothing, leading to sub optimal perf. The only reason we want chunk on the server is to avoid reloading common parts between entrypoints, so I'm changing the config to reflect that.
-
Vadim Korolik authored
This is a native module that uses node.js features, so it should be externalized by default. Related to #52091 cc @deltaepsilon
-
mknichel authored
[.next/trace] Serialize trace info across workers to preserve .next/trace with webpackBuildWorker (#57761) This PR sets up the webpack build workers (webpackBuildWorker: true) to serialize debug trace information across the worker boundary so that it can appear in the final .next/trace file at the end of the build. Currently, when webpackBuildWorker is turned on, all traces that appear under the webpack compilation are lost. After this PR, they will appear in the trace file just like when the workers are not enabled.
-
Jiachi Liu authored
For app router bundling layers "SSR rendering" and "browser" layer, which are used for server side rendering and client, we should still apply the module resolving rules to all assets since we bundled everything, removed the default exclude conditions as they'll not apply the rules to node_modules. That could cause the mismatch resolving for package. E.g. You have two dual packages A and B are both compatible for ESM and CJS, and both have default export. B is depent on A, but when you import B in a client component that will be SSR'd, it's picking up the CJS asset like the case described in #57584 . Fixes #57584 Closes NEXT-1702
-
- 30 Oct, 2023 17 commits
-
-
vercel-release-bot authored
-
OJ Kwon authored
### What? Wraps up metadata-dynamic-routes tests fixes for the turbopack. There is 1 remaining failing test due to lacks of supporting `import.meta.url` which need to be addressed separately. I spent amount of time why turbopack cannot find the route for the dynamic metadata for a certain route. In the end, found there are mismatching expectations for the route due to different hash for the certain route. We do use the same djb2 hash between next.js and turbopack both, so it was quite confusing why we don't get deterministic hash. After trying some experiments, found out root cause was how 2 different runtimes handle overflow for given type of numbers. In rust + turbpack we use u32 and do 32-bit hash calculation for given string, while in js we implicitly used number type as is, in result overflow occurs with default 53-bit float. Originally I tried to adjust hash in turbopack side to preserve js hash as-is, but so far I found it was non trivial to do so as rust there's no out of the box types we can coerce to the js number type. In result, unlike other fixes in turbopack this PR changes how js hash is being generated. I hope this woulndn't be a breaking changes; expect so since this is a metadata specific hash that we do not have written spec for it. Closes WEB-1890
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Josh Story authored
Update React from 8c8ee9ee6 to 0c6348758 - https://github.com/facebook/react/pull/27627 - https://github.com/facebook/react/pull/27624 - https://github.com/facebook/react/pull/27610 - https://github.com/facebook/react/pull/27592 - https://github.com/facebook/react/pull/27593 - https://github.com/facebook/react/pull/27588 - https://github.com/facebook/react/pull/27591 - https://github.com/facebook/react/pull/27587 Update @types/react to 18.2.33 Update @types/react-dom to 18.2.14
-
JJ Kasper authored
Seems this command is causing intermittent issues and we don't actually need this information so removes it
-
moka-ayumu authored
### What? If the version of `autoprefixer` is 10.0.0 and the version of `tailwindcss` is less than 3.3.0, the error `RangeError: Maximum call stack size exceeded` occurs when you create with tailwindcss & typescript and run it. ### Why? The exact reason is unknown, but it appears to be a compatibility issue. Also, currently configuring tailwindcss with ts makes the tailwind config file in ts, which is supported since tailwindcss version 3.3.0. (In js, it works even if you set the version of `autoprefixer` to 10.0.1 and lower the version of tailwindcss.) ### How? Simply default the minimum version of `autoprefixer` to 10.0.1 and the minimum version of `tailwindcss` to 3.3.0.
-
Leah authored
### What? Previously the matching just used the last match for children which could lead to empty groups or groups without page matches overriding the actual page. This PR makes sure this doesn't happen and emits an issue (which unfortunately doesn't get displayed yet) in case there are 2 `page` matches which would go into the children slot. Closes WEB-1895
-
vercel-release-bot authored
-
Zack Tanner authored
This removes the ignores for dev react bundles which was added as an optimization but causes issues when react is imported from an ESM module since all requires are being analyzed for named exports. Fixes #57582
-
Jiachi Liu authored
Displaying hints of "missing default export" if you didn't properly export the `default` handler for og image ``` ▲ Next.js 14.0.1-canary.2 - Local: http://localhost:3000 ✓ Ready in 1089ms ✓ Compiled /opengraph-image/[[...__metadata_id__]]/route in 211ms (44 modules) ⨯ Error: Default export is missing in "/Users/huozhi/workspace/next.js/test/e2e/app-dir/metadata-dynam ic-routes/app/opengraph-image.tsx" at eval (webpack:///app/opengraph-image.tsx?3407:11:1) at (app-metadata-route)/../../../../packages/next/dist/build/webpack/loaders/next-metadata-route-lo ader.js?page=%2Fopengraph-image%2F%5B%5B...__metadata_id__%5D%5D%2Froute&isDynamic=1!./app/opengraph-im age.tsx?__next_metadata_route__ (/Users/huozhi/workspace/next.js/test/e2e/app-dir/metadata-dynamic-rout es/.next/server/app/opengraph-image/[[...__metadata_id__]]/route.js:362:1) at __webpack_require__ (/Users/huozhi/workspace/next.js/test/e2e/app-dir/metadata-dynamic-routes/.n ext/server/webpack-runtime.js:33:42) ```
-
Alexandre Spehler authored
## Description Updating the URL for the Google Tag Manager in the Next.js documentation for [Third Party Libraries](https://nextjs.org/docs/pages/building-your-application/optimizing/third-party-libraries). We were using https://developers.google.com/maps/documentation/embed/embedding-map, which redirected to the documentation for embedding Google Maps. ## Implementation - Replacing https://developers.google.com/maps/documentation/embed/embedding-map by https://developers.google.com/tag-platform/tag-manager
-
AZM authored
Updated typo <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? Updated one of the most common typos ### Why? Improve the quality of documentation for readers. ### How? neccessary -> necessary Closes NEXT- Fixes # -->
-
Niaz Morshed Nayeem authored
### Fixing a bug - Related issues linked using `fixes #57533` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### What? If there is a `middleware.js` or `middleware.ts` file in Next.JS 14, running `next build` shows the following warning: ``` ./node_modules/next/dist/esm/shared/lib/router/utils/app-paths.js A Node.js module is loaded ('url' at line 3) which is not supported in the Edge Runtime. Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime Import trace for requested module: ./node_modules/next/dist/esm/shared/lib/router/utils/app-paths.js ``` This PR will remove the warning. Closes NEXT- Fixes #57533
-
Dak Washbrook authored
### What? The Next.js TS Plugin generally supports the named exports for the pages and layouts. Currently the TS Plugin doesn't support the new viewport export. See: https://nextjs.org/docs/app/building-your-application/upgrading/codemods#use-viewport-export ### How? Added the `viewport` export to the `constants.ts`. Closes #57680
-
Tarik authored
Typo fix
-
Vercel Release Bot authored
This auto-generated PR updates font data with latest available
-