- 07 Dec, 2023 11 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
-
vercel-release-bot authored
-
Jiachi Liu authored
-
vercel-release-bot authored
-
Raphaël Badia authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes #58087 --> fixes #58087 Currently in Next 14, everyone has fullURL flag turned to true, this PR reverts the condition. --------- Co-authored-by:
Jiachi Liu <inbox@huozhi.im>
-
Tomas Fagerbekk authored
Fixes ability to run `NODE_OPTIONS='--inspect' next dev` as described in [docs](https://nextjs.org/docs/pages/building-your-application/configuring/debugging), by removing inspect option from NODE_OPTIONS arg passed to worker process. This bug seem to have been introduced in 7d93808c as a part of a some refactoring. See how `getNodeOptionsWithoutInspect` is no longer used. Fixes #55862 --------- Co-authored-by:
Jiachi Liu <inbox@huozhi.im>
-
Zack Tanner authored
### What? While scrolled on a page, and when following a link to a new page and clicking the browser back button or using `router.back()`, the scroll position would sometimes restore scroll to the incorrect spot (in the case of the test added in this PR, it'd scroll you back to the top of the list) ### Why? The refactor in #56497 changed the way router actions are processed: specifically, all actions were assumed to be async, even if they could be handled synchronously. For most actions this is fine, as most are currently async. However, `ACTION_RESTORE` (triggered when the `popstate` event occurs) isn't async, and introducing a small amount of delay in the handling of this action can cause the browser to not properly restore the scroll position ### How? This special-cases `ACTION_RESTORE` to synchronously process the action and call `setState` when it's received, rather than creating a promise. To consistently reproduce this behavior, I added an option to our browser interface that'll allow us to programmatically trigger a CPU slowdown. h/t to @alvarlagerlof for isolating the offending commit and sharing a minimal reproduction. Closes NEXT-1819 Likely addresses #58899 but the reproduction was too complex to verify.
-
Jiachi Liu authored
-
Vercel Release Bot authored
This auto-generated PR updates the integration test manifest used when testing Turbopack.
-
Tim Neutkens authored
## What? - Add support for `experimental.externalDir` -- Was already supported, just makes Turbopack not fail on that config option - Skipped `with-babel` test because it tests Babel - Skipped `swc-warnings` test because it tests Babel - Skipped `config-resolve-alias` as it tests webpack config - Skipped `undefined-webpack-config` as it tests webpack config <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-1817
-
- 06 Dec, 2023 24 commits
-
-
vercel-release-bot authored
-
quisi.do authored
Co-authored-by:Jiachi Liu <inbox@huozhi.im>
-
Zack Tanner authored
### What? Visiting an edge catch-all route incorrectly truncates multiple parameters ### Why? The params are currently coerced into a `ParsedURLQuery`-like format by calling `Object.fromEntries` on `searchParams`, but this doesn't consider multiple param values assigned to the same key ### How? Rather than use `fromEntries`, this uses an existing util to get the path into `ParsedURLQuery` format. Closes NEXT-1814 Fixes #59333
-
Zack Tanner authored
### What? When running a [multi-zone](https://github.com/vercel/next.js/tree/canary/examples/with-zones) app in dev, app pages would infinitely reload ### Why? The HMR upgrade request would fail and get caught into a retry loop. In the multi-zone case, they fail because the upgrade request would be sent again for a request that had already been upgraded. This resulted in a "server.handleUpgrade() was called more than once with the same socket" error, causing the upgrade request to fail. Every time a retry occurred, the page would trigger a full refresh since certain HMR errors cause the browser to reload. ### How? This ensures the upgrade handler only responds to requests that match the configured basePath. Closes NEXT-1797 Fixes #59161 Fixes #56615 Fixes #54454
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? remove expensive unused code Closes PACK-2108
-
Tobias Koppers authored
* https://github.com/vercel/turbo/pull/6716 <!-- Tobias Koppers - add support for export renaming in side effects optimization --> * https://github.com/vercel/turbo/pull/6718 <!-- Tobias Koppers - cache the chunking work -->
-
Vercel Release Bot authored
This auto-generated PR updates the integration test manifest used when testing Turbopack.
-
Tobias Koppers authored
### What? Reduce the number of function calls ### Why? Performance on incremental builds ### How? Closes PACK-2104
-
vercel-release-bot authored
-
Tim Neutkens authored
## What? Noticed constants.js was included in the client-side bundle. This ensures only the needed constants are included. ## How? Created a separate file for client-side constants. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-1789
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? Code update for refactoring in https://github.com/vercel/turbo/pull/6590 Closes PACK-2043
-
Tobias Koppers authored
### What? add tracing to the module graph walking Closes PACK-2090
-
Zack Tanner authored
This is a continuation from https://github.com/vercel/next.js/pull/58783 to remove the remaining code related to static prefetching.
-
Zack Tanner authored
Reverts vercel/next.js#58596 This is failing lint checks [x-ref](https://github.com/vercel/next.js/actions/runs/7109843046/job/19355454595)
-
Justin Pfifer authored
Co-authored-by:
Justin Pfifer <justin.pfifer@carvana.com> Co-authored-by:
Lee Robinson <me@leerob.io>
-
Peter Kellner authored
-
Thoushif Aazam Shaik authored
-
Jackie authored
-
Willem-Jaap authored
`updateItem` is the name of the action, not the passed prop. The correct property name is `myAction`.
-
Jiwon Choi authored
This PR removes guidance to invalid URL
-
Mustafa Çor authored
-
Wyatt Johnson authored
This makes some critical modifications to the app render pipeline when PPR has been enabled for pages with segments defining: ```js export const dynamic = "force-dynamic" ``` Importantly, it no longer modifies the revalidation time to zero for those pages, and now falls back to the provided default revalidation time. When static render occurs, if the page being rendered has a segment config defining `dynamic === "force-dynamic"`, then it will postpone at the root of the component tree. This ensures that no render code is executed for the page, as the entirety of the tree will have postponed. This fixes the bug where the flight prefetch wasn't generated correctly as well.
-
- 05 Dec, 2023 5 commits
-
-
vercel-release-bot authored
-
Shu Ding authored
Most of them can now be handled by `optimizePackageImports` as I manually tested them locally. The main benefit is that structural updates from these libs won't affect our internal configurations anymore, as they're automatic with the new approach. The little downside is that the automatic way is a bit slower than the `modularizeImports` config as it needs to do extra analyzation. But overall, this is a good direction. Depends on #59254.
-
Zack Tanner authored
### What? Using an interception marker next to a dynamic segment does not behave properly when deployed to Vercel ### Why? The named route regex that gets created is not accounting for the interception marker, which is causing the non-intercepted route to match the intercepted serverless function. ### How? This factors in the interception marker when building the named route regex so that the non-intercepted route regex properly matches when loading the non-intercepted page. Deployment verified here: https://test-intercept-mu.vercel.app/ Closes NEXT-1786 Fixes #54650
-
vercel-release-bot authored
-
Shu Ding authored
Fixes #57624. The recent issue was an unexpected side effect caused by https://github.com/vercel/next.js/commit/305bb015060e82be3e6ae59a3d063c11a3e207f9, which only affects specific packages like `@mui/material`. The problem was that the entry file of `@mui/material` has `"use client"` at top, which affects the compilation result to output reference info only (when on the RSC layer), instead of keeping the original export statements. And the fix here is to ignore all layer info and React specific transforms here, as barrel optimization isn't related to all these framework features at all. To keep all directives unchanged, the SWC transform needs to parse and pass that info to the Webpack loader. This PR adds a test to ensure that `@mui/material` is working as expected (less than 1500 modules compiled). Without this feature it'll be ~2400 modules. Closes NEXT-1793, closes NEXT-1762.
-