- 24 Mar, 2024 2 commits
-
-
vercel-release-bot authored
-
Tim Neutkens authored
## What? Verified this passes now with Turbopack in dev even. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-2907
-
- 23 Mar, 2024 3 commits
-
-
vercel-release-bot authored
-
Vercel Release Bot authored
This auto-generated PR updates the development integration test manifest used when testing Turbopack.
-
OJ Kwon authored
### What Followup for the unsupported imports in edge to inject corresponding context only. Closes PACK-2824
-
- 22 Mar, 2024 13 commits
-
-
vercel-release-bot authored
-
Andrew Gadzik authored
This fixes an issue when playwright spawns a new page from the same context (a popup window) where requests were not being proxied correctly Co-authored-by:Shu Ding <g@shud.in>
-
Janka Uryga authored
-
OJ Kwon authored
Closes PACK-2822
-
OJ Kwon authored
### What This PR reenables reverted PR #63491, with fixing unexpectedly mark supported node.js internals as unsupported. Tried to add test cases for the supported case but hitting https://vercel.slack.com/archives/C03EWR7LGEN/p1711128538909549, need separate investigation.
-
Jiachi Liu authored
`react-dom` also contains a `react-server` condition that need to be picked up in RSC bundle layer, like what we did for react. This will ensures the server runtime smaller and you don't accidentally use the client apis on server side. Closes NEXT-2898 --------- Co-authored-by:Janka Uryga <lolzatu2@gmail.com>
-
tang authored
Add description that custom servers cannot be applied to standalone output mode Co-authored-by:
JJ Kasper <jj@jjsweb.site> Co-authored-by:
Steven <steven@ceriously.com>
-
이동현 authored
-
vercel-release-bot authored
-
Kiko Beats authored
-
Tim Neutkens authored
## What? Since the work that Shu did for optimizing large barrel dependencies marking lodash as external is no longer required. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-2899
-
Tim Neutkens authored
## What? Adds a test for a reported problem where sass-loader fails with `Null check operator used on a null value`. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-2889
-
Tobias Koppers authored
### What? You can pass `--max_old_space_size=` with underscores instead of dashes which wasn't handled yet. ### Why? ### How? Closes PACK-2817
-
- 21 Mar, 2024 14 commits
-
-
vercel-release-bot authored
-
Will Binns-Smith authored
Includes vercel/turbo#7800
-
vercel-release-bot authored
-
Jiachi Liu authored
### What * Remove the erroring of force-dynamic is not able to use during static generation * Export the route segments properly in sitemap conventions ### Why We discovered this error is showing up when users are using force-dynamic with generating multi sitemaps. When you have a dynamic `route /[id]/route.js` , and you have generateSitemaps defined which is actually using `generateSitemaps` under the hood , then you set the route to dynamic with `export dynamic = 'force-dynamic'`. We should keep the route still as dynamic. `generateStaticParams` is only for generating the paths, which is static in build time. And the `force-dynamic` is going to be applied to each generated path. Closes NEXT-2881
-
Andrew Gadzik authored
Followup on https://github.com/vercel/next.js/pull/52520 and https://github.com/vercel/next.js/pull/54014 **Enhancements** - Removes `--experimental-test-proxy` CLI argument from `next dev` and `next start` - Adds a new experimental config option `testProxy?: boolean` - Instead of throwing an error, return the `originalFetch` response if the current request context does not contain the `Next-Test-*` HTTP headers **Why?** These changes allow us to write mixed Integration + E2E tests within the same Playwright process. ```ts // some-page.spec.ts test.describe('/some-page', () => { test('some integration test', async ({ page, next }) => { // by using the `next` fixture, playwright will send the `Next-Test-*` HTTP headers for // every request in this test's context. next.onFetch(...); await page.goto(...); await expect(...).toBe('some-mocked-value'); }); test('some e2e test', async ({ page }) => { // by NOT using the `next` fixture, playwright does not send the `Next-Test-*` HTTP headers await page.goto(...); await expect(...).toBe('some-real-value'); }); }) ``` Now I can run `next dev` and locally develop my App Router pages AND run my Playwright tests against instead of having to, - run `next dev` to locally develop my change - ctrl+c to kill server - run `next dev --experimental-test-proxy` to locally run my integration tests --------- Co-authored-by:
Sam Ko <sam@vercel.com>
-
Maël Nison authored
This PR upgrades `enhanced-resolve` to `5.16.0` so as to benefit from https://github.com/webpack/enhanced-resolve/pull/301, recently merged. Without this diff, importing dependencies from files from external PnP projects would fail. It's a little niche, but I'm working on a documentation website that leverages that to allow deploying multiple websites from the same template. Co-authored-by:
Sam Ko <sam@vercel.com> Co-authored-by:
Steven <steven@ceriously.com>
-
FoSuCloud authored
- Fixes https://github.com/vercel/next.js/issues/63542Co-authored-by:
yelipei <yelipei@qianxin.com> Co-authored-by:
Steven <steven@ceriously.com>
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? It's causing `__import_unsupported` is not defined in `instrumentation` context
-
Steven authored
This ensures that the instrumentation hook for Node.js will run immediately during `next start` instead of waiting for the first request like does it `next dev`. However, if there is a separate instrumentation hook for Edge, that will still be lazy evaluated and wait until the first request. Fixes #59999 Fixes NEXT-2738
-
Tim Neutkens authored
## What? Test fix for Turbopack, the paths are slightly different. Fixes 1 test. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-2888
-
OJ Kwon authored
### What This PR implements runtime warning for dynamic codes (`eval`, `Function`...) in edge runtime. Webpack uses middleware plugin to replace / wrap codes, in case of Turbopack we don't have equivalent, so creating a new transform visitor and run it if the context is edge. Since sandbox augments global fn (__next_*), transform simply wraps the expr if it matches to the condition. Closes PACK-2804
-
Will Binns-Smith authored
This causes Turbopack to fail and communicate when a file with an unhandled or unregistered extension is built. Test Plan: `TURBOPACK=1 pnpm test-dev test/development/basic/hmr.test.ts` Closes PACK-2803
-
Balázs Orbán authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-2798
-
- 20 Mar, 2024 8 commits
-
-
vercel-release-bot authored
-
JJ Kasper authored
Looks like we were only documenting the `missing` matcher use case although `has` is also supported and we weren't mentioning they can combined as well. x-ref: [slack thread](https://vercel.slack.com/archives/C06LDQYNPV0/p1710704436247789) Closes NEXT-2883 --------- Co-authored-by:
Zack Tanner <zacktanner@gmail.com>
-
Cody Olsen authored
Most notably it updates `typescript` to `5.4.2` now that Sanity Studio is updated to support the [more aggressive reduction of intersections between type variables and primitive types](https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/#more-aggressive-reduction-of-intersections-between-type-variables-and-primitive-types)
-
Balázs Orbán authored
-
OJ Kwon authored
### What Followup for https://github.com/vercel/next.js/pull/63491, adjust fixture setup to work with turbopack. Closes PACK-2790
-
Balázs Orbán authored
-
Tobias Koppers authored
### What? Make CI more stable Closes PACK-2799
-
Juan Settecase authored
### What? Following up with [this suggestion](https://github.com/vercel/next.js/discussions/53540) I went ahead and implemented the proposal for the Next.js team to merge it if they agree. Things to keep in mind: - Google has [three different ways](https://developers.google.com/search/docs/specialty/international/localized-versions#methods-for-indicating-your-alternate-pages) to do this. The three of them are equivalent - Google seems to be the only search engine supporting this approach. The rest of them should ignore it ### Why? This is supported by [Google](https://developers.google.com/search/docs/specialty/international/localized-versions#example_2) to better understand the site when the same page is available in multiple languages. ### How? - I added a new key to the `MetadataRoute.Sitemap` type called `alternates` which accepts just one sub key `languages` similar to the current one in the [Metadata](https://nextjs.org/docs/app/api-reference/functions/generate-metadata#alternates) object - I updated the `resolveSitemap` method to process the new key and generate the expected sitemap - I updated the related tests and documentation to reflect the new syntax --------- Co-authored-by:
Jiachi Liu <inbox@huozhi.im>
-