1. 11 Jun, 2024 7 commits
    • vercel-release-bot's avatar
      v14.2.4 · 30784418
      vercel-release-bot authored
      30784418
    • Janka Uryga's avatar
      [not a backport] fix lint errors · 0538a0dc
      Janka Uryga authored
      0538a0dc
    • Janka Uryga's avatar
      fix: app-router prefetch crash when an invalid URL is passed to Link (#66755) · 2807fb48
      Janka Uryga authored
      Closes [#66650](https://github.com/vercel/next.js/issues/66650)
      Closes NEXT-3520
      
      - Make Link not throw during prefetch if it received an invalid `href`
      (see [#66650](https://github.com/vercel/next.js/issues/66650))
      - Throw in dev mode if an invalid link was passed to `router.prefetch`
      -- this matches current prod behavior
      - (previously, we'd immediately exit out of `router.prefetch`, so the
      user would see no indication that this'd fail in prod)
      
      If an invalid URL was passed to `<Link>`, the whole app would crash and
      show "A client-side exception occurred". A failed prefetch should not
      bring down the whole app.
      
      Note that This preserves the current behavior of explicit
      `router.prefetch(url)` throwing an error if `url` is invalid. We may
      want to adjust this in the future, but that could be considered a
      breaking change, so I'm leaving it out for now. This only affects
      `Link`, which was intended to catch any errors thrown from
      `router.prefetch`, but that bit was accidentally broken.
      2807fb48
    • JJ Kasper's avatar
      Add timeout/retry handling for fetch cache (#66652) · efb476e2
      JJ Kasper authored
      As discussed this adds handling to timeout at a max of 500ms for fetch
      cache request and retries a max of 3 times due to network instability.
      This also adds cache service tests and fixes a case we've been trying to
      track down where we were seeing `undefined` cache URL values which made
      debugging fetches tricky.
      # Conflicts:
      #	packages/next/src/server/base-server.ts
      #	packages/next/src/server/lib/incremental-cache/fetch-cache.ts
      #	packages/next/src/server/web/spec-extension/unstable-cache.ts
      efb476e2
    • Jiachi Liu's avatar
      Use addDependency to track metadata route file changes (#66714) · c16a3f99
      Jiachi Liu authored
      Use `addDependency` to track the file path passed to
      `next-metadata-route-loader`
      
      NOTE: We cannot apply the `next-metadata-route-loader` directly to the
      metatda convention source files, since the json file could be processed
      by json loader (Related previous fix #62615)
      
      Previously when we passed down the file path as argument to the loader,
      which sort of breaking the caching of webpack as the actual resource
      path is string, it's not tracked as a dependency. This change fixed the
      bad caching issue of static metadata routes. Based on the above reason
      we use `addDependency` here to track the dependency change
      
      Closes NEXT-3521
      Closes #65755
      c16a3f99
    • JJ Kasper's avatar
      Fix inconsistency with 404 getStaticProps cache-control (#66674) · 942e45a7
      JJ Kasper authored
      While investigating unexpected stale responses when leveraging
      `getStaticProps` on the 404 page noticed we have an inconsistency
      between local and deployed due to `Cache-Control` being set to
      `no-store, must-revalidate` even though a revalidate period is provided.
      The inconsistency also differs between the HTML response and the data
      response `_next/data` which causes even more unexpected behavior. To
      avoid this behavior, this replaces the handling to ensure we honor the
      originally provided revalidate period during `notFound: true` for the
      `Cache-Control` header.
      
      Validated against provided reproduction here
      https://github.com/fusdev0/next-notfound-revalidate
      Deployment:
      https://vercel.live/link/next-notfound-revalidate-govzskknf-vtest314-ijjk-testing.vercel.app/fallback-blocking/fasdf
      
      Prior PR for prior context that introduced this
      https://github.com/vercel/next.js/pull/19165
      
      x-ref: [slack
      thread](https://vercel.slack.com/archives/C0676QZBWKS/p1717492459342109)
      # Conflicts:
      #	packages/next/src/server/base-server.ts
      942e45a7
    • Karim Shehadeh's avatar
      Prevent append of trailing slash in cases where path ends with a file extension (#66636) · 9728a35d
      Karim Shehadeh authored
      ### What
      
      Skip adding trailing slash for file pattern like same origin urls
      
      ### Why
      
      Fixes #66635
      
      Next.js will not append trailing slash for file like pattern urls when
      `trailingSlash` is enabled. This PR aligns the behavior of the metadata
      trailing slash appending with next-server route handling.
      
      ---------
      Co-authored-by: 's avatarJiachi Liu <inbox@huozhi.im>
      9728a35d
  2. 10 Jun, 2024 2 commits
  3. 06 Jun, 2024 4 commits
  4. 05 Jun, 2024 3 commits
  5. 04 Jun, 2024 2 commits
    • Zack Tanner's avatar
      lock CNA tests to 14.2.3 · 564b620d
      Zack Tanner authored
      564b620d
    • Zack Tanner's avatar
      fix: ensure route handlers properly track dynamic access (#66446) · 85bb8728
      Zack Tanner authored
      In #60645, dynamic access tracking was refactored but we erroneously
      stopped tracking dynamic access in route handlers. Request proxying, as
      well as tracking segment level configs (such as `export const dynamic =
      'force-dynamic'`), were only enabled during static generation. This was
      an unintended breaking change that consequently caused dynamic access to
      not properly bail from data cache in various circumstances.
      
      This adds some more rigorous testing for route handlers, as this seems
      to be a fairly large gap in our fetch cache testing currently.
      
      This PR is easiest to review with [whitespace
      disabled](https://github.com/vercel/next.js/pull/66446/files?w=1).
      85bb8728
  6. 24 Apr, 2024 1 commit
  7. 23 Apr, 2024 9 commits
    • JJ Kasper's avatar
      Clean-up fetch metrics tracking (#64746) · a230be48
      JJ Kasper authored
      This ensures we only track fetch metrics in development mode as that's
      the only time we report them currently, this also adds an upper limit on
      how many metrics we store per-request as previously this was unbounded,
      on top of that this ensures we don't keep tracking fetch metrics after
      the request has ended as we only report on request end, and finally this
      adds a clean-up to the reference we attach to the request object
      containing the fetch metrics once we have used them.
      
      Closes: https://github.com/vercel/next.js/issues/64212
      
      Closes NEXT-3159
      a230be48
    • Jeffrey Zutt's avatar
      fix: remove traceparent from cachekey should not remove traceparent from original object (#64727) · 73c2d634
      Jeffrey Zutt authored
      ### What?
      
      I submitted PR #64499 , it got merged, but it contains a mistake.
      I'm terribly sorry about this!
      
      By removing the traceparent from the cachekey, we mistakenly removed the
      header from the original object.
      Causing the actual request to be executed without the traceparent
      header.
      
      ### Why?
      
      Creating a cachekey should not alter the original object.
      
      ### How?
      
      Flip the arguments for Object.assign
      
      ---------
      Co-authored-by: 's avatarJeffrey <jeffrey@jeffreyzutt.nl>
      Co-authored-by: 's avatarJJ Kasper <jj@jjsweb.site>
      73c2d634
    • Zack Tanner's avatar
      fix root page revalidation when redirecting in a server action (#64730) · dd441911
      Zack Tanner authored
      When a server action triggers a redirect, we're incorrectly applying a
      refresh marker to the segment they were on, rather than the segment they
      were being redirected to. As a result, when revalidation occurs (via
      `revalidateX` or `router.refresh()`), the top-level segment would be
      replaced with data for an incorrect segment.
      
      For example, if triggering a redirect action from `/redirect` to `/`,
      the router state tree would save a reference to `/redirect`. The next
      time a refresh or revalidate happens, it'd refresh the segment data for
      `/redirect` instead of `/`.
      
      Fixes #64728
      
      
      Closes NEXT-3156
      dd441911
    • Zack Tanner's avatar
      prevent erroneous route interception during lazy fetch (#64692) · 8b4c2347
      Zack Tanner authored
      When the router cache can't find a cache node for the requested segment,
      it performs a request to the server to get the missing data. This
      request to the server currently will always include the `next-url`
      header, and on soft-navigations, the router will route the request to
      the intercepted handler. This lazy fetch is treated as a soft navigation
      by the server, and will incorrectly return data for the intercepted
      route.
      
      Similar to the handling in `router.refresh`, and the server action
      reducer, we should not include the `next-url` header if there's no
      interception route currently in the tree, as otherwise we'll be
      erroneously triggering the intercepted route.
      
      Fixes #64676
      Closes NEXT-3146
      8b4c2347
    • Sam Ko's avatar
      fix(fetch-cache): fix additional typo, add type & data validation (#64799) · d6a7ca0e
      Sam Ko authored
      This PR fixes the fetch cache, which currently is not using the fetch
      cache when it exists (the tags were not getting set properly), and tags
      have not updated.
      
      (Before)
      
      https://github.com/vercel/next.js/assets/28912696/74d8f592-0698-4ae4-be4b-30cffb1ffe11
      
      (After)
      
      https://github.com/vercel/next.js/assets/28912696/af12b13a-46c6-41c3-9ac3-20e1ec44a865
      
      - https://github.com/vercel/next.js/pull/64786
      - https://github.com/vercel/next.js/pull/63547
      
      Closes NEXT-3173
      d6a7ca0e
    • Jiachi Liu's avatar
      Fix next/image usage in mdx (#64875) · 4a6b511c
      Jiachi Liu authored
      ### What
      
      Apply the react aliases for app dir also to the files with
      `pagesExtension`
      
      ### Why
      
      In the page bundle of mdx page:
      
      In RSC layer react is referencing to the insatlled react 18.2.0 's
      `jsx-runtime` to create each JSX element. The react 18.2 JSX runtime
      access `propTypes` of the component type and then it crashes 💥
      In RSC layer it should use the built-in react canary's `jsx-runtime`.
      
      The reason that it didn't use the built-in one is we're using customized
      `pageExtension` `["mdx"]` for mdx, where we didn't apply all these rules
      for the files with `pageExtension`, but only the js and ts files by
      default.
      
      For mdx specifically, we cannot only applied to
      `(page|layout|route).[page extension]` cause every mdx file needs to
      have proper resolution. Since this doesn't break transform, it's safe to
      apply for all files with page extension.
      
      Fixes #58888 
      
      Closes NEXT-3187
      4a6b511c
    • Jiachi Liu's avatar
      Fix mixed exports in server component with barrel optimization (#64894) · 04cc13c0
      Jiachi Liu authored
      ### What
      
      * Remove the change added in #64467, but still kept tests.
      * Add more tests for mixed imports (component and function) from shared
      component with `optimizePackageImports`
      
      ### Why
      
      The fix in #64467 was not correct, as mixing `export *` with `"use
      client"` should error if Next.js detect it properly.
      When there's mixed exports, that a shared function will become a client
      reference if the target file inherits the client boundary.
      
      The original issue #64467 fixed was actually related to tree-shaking,
      which is fixed in #64681.
      
      Closes NEXT-3197
      04cc13c0
    • Jiachi Liu's avatar
      fix: mixing namespace import and named import client components (#64809) · 8d01d496
      Jiachi Liu authored
      ### What
      
      Reported by @MaxLeiter, when you mixing named import and wildcard import
      to a client component, and if you clone the module it will missed others
      exports except the named ones. This lead to an issue that rendered React
      element type is `undefined`.
      
      ### Why
      
      We're using a tree-shaking strategy that collects the imported
      identifiers from client components on server components side. But in our
      code `connection.dependency.ids` can be undefined when you're using
      `import *`. So for that case we include all the exports.
      
      In the flight client entry plugin, if we found there's named imports
      that collected later, and the module is already being marked as
      namespace import `*`, we merge the ids into "*", so the whole module and
      all exports are respected.
      
      Now there're few possible cases for a client component import:
      
      During webpack build, in the outout going connections, there're
      connection with empty imported ids (`[]`), cannot unable to detect the
      imported ids (`['*']`) and detected named imported ids (`['a', 'b',
      ..]`). First two represnt to include the whole module and all exports,
      but we might collect the named imports could come later than the whole
      module. So if we found the existing collection already has `['*']` then
      we keep using that regardless the collected named imports. This can
      avoid the collected named imports cover "exports all" case, where we
      will expose less exports for that collection module lead to the
      undefined component error.
      
      Closes NEXT-3177
      8d01d496
    • Jiachi Liu's avatar
      Fix: resolve mixed re-exports module as cjs (#64681) · de84e3ae
      Jiachi Liu authored
      ### Why
      
      If you have a client entry that mixing `default` re-export and `*`
      re-export, atm we cannot statically analyze all the exports from this
      the boundary, unless we can apply barrel file optimization for every
      import which could slow down speed.
      
      ```js
      // index.js
      'use client'
      export * from './client'
      export { default } from './client'
      ```
      
      Before that happen we high recommend you don't mixing that and try to
      add the client directive to the leaf level client module. We're not able
      to determine what the identifiers are imported from the wildcard import
      path. This would work if we resolved the actual file but currently we
      can't.
      
      ### What
      
      When we found the mixing client entry module like that, we treat it as a
      CJS client module and include all the bundle in client like before what
      we have the client components import optimization.
      
      Ideally we could warn users don't apply the client directive to these
      kinda of barrel file, and only apply them to where we needed.
      
      
      Fixes #64518 
      Closes NEXT-3119
      de84e3ae
  8. 17 Apr, 2024 12 commits
    • vercel-release-bot's avatar
      v14.2.2 · c850e4a6
      vercel-release-bot authored
      c850e4a6
    • Benjamin Woodruff's avatar
      hotfix(turbopack): Update with patch for postcss.config.js path resolution on Windows (#64677) · a340d9e9
      Benjamin Woodruff authored
      Not 100% sure I did this process right for a hotfix, but this new tag
      should be exactly the same as what's currently in the 14-2-1 branch,
      except with this one PR:
      
      * https://github.com/vercel/turbo/pull/7995 <!-- Benjamin Woodruff -
      fix(turbopack-node) postcss.config.js path resolution on Windows -->
      
      ---
      
      In turbo, I ran
      
      ```
      git switch --detach turbopack-240411.3
      git switch -c bgw/hotfix-turbopack-14-2-1
      git cherry-pick e7a5c60a3b899d0c4293589c2844016da82442f7
      git push origin HEAD
      ```
      
      I then ran the GitHub action for the nightly release process for that
      new branch:
      https://github.com/vercel/turbo/actions/workflows/turbopack-nightly-release.yml
      (it seems like this just cuts a tag, I wonder for hotfixes if we should
      manually cut the tag so it's named differently)
      
      In the nextpack repository:
      
      ```
      pnpm next-link turbopack-240417.2
      ```
      a340d9e9
    • Jiachi Liu's avatar
    • Zack Tanner's avatar
      fix incorrect refresh request when basePath is set (#64589) · 12982efa
      Zack Tanner authored
      `initialCanonicalUrl` differs from the `canonicalUrl` that gets set on
      the client, such as when there's a basePath set.
      
      This hoists the `canonicalUrl` construction up so we can re-use it when
      adding refetch markers to the tree.
      
      This also renames `pathname` -> `path` since it also includes search
      params. I added a test to confirm no extra erroneous fetches happened in
      both cases.
      
      Fixes #64584
      
      
      Closes NEXT-3130
      12982efa
    • Zack Tanner's avatar
      add pathname normalizer for actions (#64592) · 6f27f944
      Zack Tanner authored
      This adds a normalizer to handle `.action` invokes (when in minimal
      mode). This PR by itself does not do anything of note, but will be
      hooked up in a future PR in the [Next.js
      builder](https://github.com/vercel/vercel/tree/main/packages/next).
      
      <!-- Thanks for opening a PR! Your contribution is much appreciated.
      To make sure your PR is handled as smoothly as possible we request that
      you follow the checklist sections below.
      Choose the right checklist for the change(s) that you're making:
      
      ## For Contributors
      
      ### Improving Documentation
      
      - Run `pnpm prettier-fix` to fix formatting issues before opening the
      PR.
      - Read the Docs Contribution Guide to ensure your contribution follows
      the docs guidelines:
      https://nextjs.org/docs/community/contribution-guide
      
      ### Adding or Updating Examples
      
      - The "examples guidelines" are followed from our contributing doc
      https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
      - Make sure the linting passes by running `pnpm build && pnpm lint`. See
      https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
      
      ### Fixing a bug
      
      - Related issues linked using `fixes #number`
      - Tests added. See:
      https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
      - Errors have a helpful link attached, see
      https://github.com/vercel/next.js/blob/canary/contributing.md
      
      ### Adding a feature
      
      - Implements an existing feature request or RFC. Make sure the feature
      request has been accepted for implementation before opening a PR. (A
      discussion must be opened, see
      https://github.com/vercel/next.js/discussions/new?category=ideas)
      - Related issues/discussions are linked using `fixes #number`
      - e2e tests added
      (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
      - Documentation added
      - Telemetry added. In case of a feature if it's used or not.
      - Errors have a helpful link attached, see
      https://github.com/vercel/next.js/blob/canary/contributing.md
      
      
      ## For Maintainers
      
      - Minimal description (aim for explaining to someone not on the team to
      understand the PR)
      - When linking to a Slack thread, you might want to share details of the
      conclusion
      - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
      - Add review comments if necessary to explain to the reviewer the logic
      behind a change
      
      ### What?
      
      ### Why?
      
      ### How?
      
      Closes NEXT-
      Fixes #
      
      -->
      
      
      Closes NEXT-3131
      6f27f944
    • Jiachi Liu's avatar
      Fix ASL bundling for dynamic css (#64451) · 8d18e0c7
      Jiachi Liu authored
      For app page rendering on edge, the `AsyncLocalStorage` (ALS) should be
      bundled as same instance across layers. We're accessing the ALS in
      `next/dynamic` modules during SSR for preloading CSS chunks. There's a
      bug that we can't get the ALS store during SSR in edge, I digged into it
      and found the root cause is:
      
      We have both import paths:
      `module (rsc layer) -> request ALS (shared layer)`
      `module (ssr layer) -> request ALS (shared layer)`
      
      We expect the ALS to be the same module since we're using the same layer
      but found that they're treated as different modules due to applying
      another loader transform on ssr layer. They're resulted in the same
      `shared` layer, but with different resource queries. This PR excluded
      that transform so now they're identical across layers.
      
      For webpack, we aligned the loaders applying to the async local storage,
      so that they're resolved as the same module now.
      
      For turbopack, we leverage module transition, sort of creating a new
      `app-shared` layer for these modules, and apply the transition to all
      async local storage instances therefore the instances of them are only
      bundled once.
      To make the turbopack chanegs work, we change how the async local
      storage modules defined, separate the instance into a single file and
      mark it as "next-shared" layer with import:
      
      ```
      any module -> async local storage --- use transition, specify "next-shared" layer ---> async local storage instance
      ```
      
      Closes NEXT-3085
      8d18e0c7
    • Will Binns-Smith's avatar
      Turbopack: Allow client components to be imported in app routes (#64520) · 3709dd9b
      Will Binns-Smith authored
      Resolves #64412
      
      This adds a client transition to the app route `ModuleAssetContext` and
      the corresponding transforms so that client components can be safely
      imported and referenced (as their proxies) in app routes.
      
      Test Plan: Added an integration test
      
      
      Closes PACK-2964
      3709dd9b
    • Jiachi Liu's avatar
      fix: filter out middleware requests in logging (#64549) · 373fbba4
      Jiachi Liu authored
      When middleware.js is present, the logging is duplicated. We should
      filter out the 1st middleware request and only log the actual one going
      through request handler / renderer
      
      Closes NEXT-3125
      373fbba4
    • Zack Tanner's avatar
      fix refresh behavior for discarded actions (#64532) · 2f8e096c
      Zack Tanner authored
      When an action is marked as "discarded", we enqueue a refresh, since the
      navigation event will be invoked immediately without waiting for the
      action to finish. We refresh because it's possible that the discarded
      action triggered some sort of mutation/revalidation, and we want the
      router to still be able to respond to that new data.
      
      However there's a bug in this logic -- it'll only enqueue the refresh
      action if there were no other actions in the queue, ignoring the case
      where something is still in the queue. This makes sure that the refresh
      is handled after `runRemainingActions` finishes.
      
      When adding a test for the server component case (which doesn't hit this
      refresh branch), I noticed `LayoutRouter` caused React to suspend
      indefinitely, because it got stuck in the `use(unresolvedThenable)`
      case. We should only suspend indefinitely if we kicked off a the
      `SERVER_PATCH` action, as otherwise it's possible nothing will ever
      break out of that branch.
      
      Fixes #64517
      Closes NEXT-3124
      2f8e096c
    • Jiachi Liu's avatar
      Fix cjs client components tree-shaking (#64558) · 6838f579
      Jiachi Liu authored
      ## What
      
      Determine if the client module is a CJS file and `default` export is
      imported, then we include the whole module instead of using webpack
      magic comments to only extract `default` export.
      
      ## Why
      
      Unlike ESM, The `default` export of CJS module is not just `.default`
      property, we need to include `__esModule` mark along with `default`
      export to make it function properly with React client module proxy
      
      
      Fixes #64518
      Closes NEXT-3119
      6838f579
    • Tobias Koppers's avatar
      disable production chunking in dev (#64488) · 282de734
      Tobias Koppers authored
      ### What?
      
      The production chunking plugin shouldn't be enabled in development
      
      ### Why?
      
      It doesn't handle HMR yet
      
      
      Closes PACK-2956
      282de734
    • Jiwon Choi's avatar
      fix(next): `Metadata.openGraph` values not resolving basic values when `type` is set (#63620) · 1b931ce7
      Jiwon Choi authored
      ### What?
      
      The string value of `Metadata.openGraph.emails` throws error:
      
      ```tsx
      export const metadata = {
        openGraph: {
          type: 'article',
          emails: 'author@vercel.com',
        },
      };
      ```
      
      Error:
      
      ```sh
      r.map is not a function
      ```
      
      The type is:
      
      ```tsx
      type OpenGraphMetadata = {
        // ...
        emails?: string | Array<string>
      }
      ```
      
      ### Why?
      
      Basic values such as `emails` and `phoneNumbers` were not included when
      `ogType` was set while resolving the values.
      
      ### How?
      
      Include basic values when resolving the metadata.
      
      Fixes #63415
      1b931ce7