- 23 Jul, 2024 10 commits
-
-
vercel-release-bot authored
-
Zack Tanner authored
### What We don't currently provide any observability into fetch metrics during SSG, which can be useful to diagnose slow builds or SSG errors related to data dependencies. ### Why `trackFetchMetrics` is disabled outside of `development`, and we do not currently surface that information anywhere during build. ### How This removes the `trackFetchMetrics` bailout during static generation. Additionally, it updates the export worker to track the fetch metrics it collected during rendering as part of the export result. The build step then uses these results to write the results (keyed by page) to `.next/diagnostics/fetch-metrics.json`. **Note: this is currently gated by the presence of env var: `NEXT_DEBUG_BUILD`** <details> <summary>Example File</summary> ```json { "/": [ { "start": 1721760882192, "url": "https://next-data-api-endpoint.vercel.app/api/random?page", "cacheReason": "auto no cache", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882466, "idx": 2 } ], "/hooks/use-search-params/with-suspense": [], "/strip-header-traceparent": [ { "start": 1721760882191, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882402, "idx": 2 }, { "start": 1721760882408, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "revalidate: 50", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882408, "idx": 3 }, { "start": 1721760882408, "url": "https://next-data-api-endpoint.vercel.app/api/echo-headers", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882702, "idx": 4 } ], "/unstable-cache/fetch/no-cache": [ { "start": 1721760882215, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "fetchCache = force-no-store", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882426, "idx": 3 } ], "/unstable-cache/fetch/no-store": [ { "start": 1721760882229, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "fetchCache = force-no-store", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882432, "idx": 3 } ], "/variable-revalidate/encoding": [ { "start": 1721760882199, "url": "https://next-data-api-endpoint.vercel.app/api/utf8-encoding", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882440, "idx": 3 }, { "start": 1721760882201, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882442, "idx": 3 }, { "start": 1721760882449, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "revalidate: 10", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882449, "idx": 4 } ], "/variable-revalidate/headers-instance": [ { "start": 1721760882193, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882426, "idx": 3 }, { "start": 1721760882192, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882431, "idx": 3 }, { "start": 1721760882435, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "revalidate: 10", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882435, "idx": 5 }, { "start": 1721760882434, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882553, "idx": 5 } ], "/variable-revalidate/post-method": [ { "start": 1721760882295, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882494, "idx": 3 }, { "start": 1721760882294, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "POST", "end": 1721760882497, "idx": 3 }, { "start": 1721760882502, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "revalidate: 10", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882502, "idx": 5 }, { "start": 1721760882501, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "POST", "end": 1721760882617, "idx": 5 }, { "start": 1721760882619, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "POST", "end": 1721760882739, "idx": 6 }, { "start": 1721760882741, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "POST", "end": 1721760882848, "idx": 7 }, { "start": 1721760882850, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "auto no cache", "cacheStatus": "skip", "status": 200, "method": "POST", "end": 1721760883028, "idx": 8 } ], "/no-config-fetch": [ { "start": 1721760882299, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "auto no cache", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882499, "idx": 2 } ], "/variable-revalidate/revalidate-3": [ { "start": 1721760882347, "url": "https://next-data-api-endpoint.vercel.app/api/random?page", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882534, "idx": 3 }, { "start": 1721760882537, "url": "https://next-data-api-endpoint.vercel.app/api/random?page", "cacheReason": "revalidate: 3", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882537, "idx": 4 }, { "start": 1721760882347, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882541, "idx": 4 }, { "start": 1721760882544, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "revalidate: 10", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882544, "idx": 5 } ], "/variable-revalidate/revalidate-360-isr": [ { "start": 1721760882358, "url": "https://next-data-api-endpoint.vercel.app/api/random?page", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882484, "idx": 3 }, { "start": 1721760882358, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882532, "idx": 4 }, { "start": 1721760882535, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "revalidate: 10", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882535, "idx": 5 }, { "start": 1721760882485, "url": "https://next-data-api-endpoint.vercel.app/api/random?a=b", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882607, "idx": 5 }, { "start": 1721760882610, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "fetchCache = force-no-store", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882748, "idx": 7 } ], "/_not-found": [], "/variable-revalidate/authorization": [ { "start": 1721760882460, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "revalidate: 10", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882473, "idx": 3 }, { "start": 1721760882475, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "revalidate: 10", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882475, "idx": 4 }, { "start": 1721760882460, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "auto no cache", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882583, "idx": 4 } ], "/articles/works": [], "/blog/tim/first-post": [], "/blog/seb/second-post": [], "/blog/styfle/first-post": [], "/blog/styfle/second-post": [], "/blog/tim": [ { "start": 1721760882785, "url": "https://example.vercel.sh/", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882882, "idx": 2 } ], "/blog/seb": [ { "start": 1721760882783, "url": "https://example.vercel.sh/", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882831, "idx": 2 } ], "/blog/styfle": [ { "start": 1721760882785, "url": "https://example.vercel.sh/", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882873, "idx": 2 } ], "/force-cache": [ { "start": 1721760882781, "url": "https://next-data-api-endpoint.vercel.app/api/random?a1", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882889, "idx": 2 }, { "start": 1721760882890, "url": "https://next-data-api-endpoint.vercel.app/api/random?b2", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760883000, "idx": 3 }, { "start": 1721760883001, "url": "https://next-data-api-endpoint.vercel.app/api/random?c3", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760883106, "idx": 4 }, { "start": 1721760883107, "url": "https://next-data-api-endpoint.vercel.app/api/random?d4", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "cacheWarning": "Specified \"cache: force-cache\" and \"revalidate: 3\", only one should be specified.", "status": 200, "method": "GET", "end": 1721760883212, "idx": 5 }, { "start": 1721760883213, "url": "https://next-data-api-endpoint.vercel.app/api/random?d4", "cacheReason": "cache-control: no-cache (hard refresh)", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760883213, "idx": 6 } ], "/no-store/static": [], "/force-static/first": [], "/force-static/second": [], "/hooks/use-pathname/slug": [], "/hooks/use-search-params/force-static": [], "/force-static-fetch-no-store": [ { "start": 1721760882844, "url": "https://next-data-api-endpoint.vercel.app/api/random?page", "cacheReason": "cache: no-store", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882994, "idx": 2 }, { "start": 1721760882995, "url": "https://next-data-api-endpoint.vercel.app/api/random?page", "cacheReason": "revalidate: 0", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882996, "idx": 3 }, { "start": 1721760882996, "url": "https://next-data-api-endpoint.vercel.app/api/random?page", "cacheReason": "cache: no-cache", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760882996, "idx": 4 } ], "/gen-params-dynamic-revalidate/one": [], "/isr-error-handling": [], "/ssg-draft-mode": [ { "start": 1721760882919, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "auto no cache", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760883020, "idx": 2 } ], "/ssg-draft-mode/test": [ { "start": 1721760882918, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "auto no cache", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760883072, "idx": 2 } ], "/ssg-draft-mode/test-2": [ { "start": 1721760882919, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "auto no cache", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760883030, "idx": 2 } ], "/variable-config-revalidate/revalidate-3": [ { "start": 1721760882917, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "revalidate: 9", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882917, "idx": 2 } ], "/variable-revalidate-stable/revalidate-3": [], "/variable-revalidate/cookie": [ { "start": 1721760882919, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "revalidate: 10", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882921, "idx": 3 }, { "start": 1721760882923, "url": "https://next-data-api-endpoint.vercel.app/api/random?layout", "cacheReason": "revalidate: 10", "cacheStatus": "hit", "status": 200, "method": "GET", "end": 1721760882923, "idx": 4 }, { "start": 1721760882919, "url": "https://next-data-api-endpoint.vercel.app/api/random", "cacheReason": "auto no cache", "cacheStatus": "skip", "status": 200, "method": "GET", "end": 1721760883068, "idx": 4 } ], "/partial-gen-params-no-additional-lang/en/first": [], "/partial-gen-params-no-additional-lang/en/second": [], "/partial-gen-params-no-additional-lang/en/3": [], "/partial-gen-params-no-additional-lang/fr/first": [], "/partial-gen-params-no-additional-lang/fr/second": [], "/partial-gen-params-no-additional-lang/fr/3": [], "/partial-gen-params-no-additional-slug/en/first": [], "/partial-gen-params-no-additional-slug/en/second": [], "/partial-gen-params-no-additional-slug/en/85": [], "/partial-gen-params-no-additional-slug/fr/first": [], "/partial-gen-params-no-additional-slug/fr/second": [], "/partial-gen-params-no-additional-slug/fr/85": [] } ``` </details> Closes NDX-96 -
JJ Kasper authored
Small follow-up to https://github.com/vercel/next.js/pull/68076 ensuring we use the values from our next public env result.
-
JJ Kasper authored
This ensures we invalidate the experimental trace result when Next.js versions mismatch or our global hash differs as these changes should re-build everything to be safe we aren't missing an important change. Closes: NDX-104
-
Willem-Jaap authored
### What? This PR adds updates the command name and adds argument types to the `next` script to improve internal DX, code quality and correctness.
-
Gary Borton authored
I noticed in some local profiles that a significant % of the build was being spent in the `metadataResolver` function of `next-app-loader`. It seems to be spending a good chunk of its time inside `fileExistsInDirectory`. It looks like this was already updated to have some level of caching (>99% of calls _do_ hit a cache already), but that a significant number of calls are reaching out to the filesystem but don't have to. For my build in particular, `36685` calls made it to the filesystem, of which `35545 (~97%)` _could_ have been cached. ~~Because the cache here isn't shared between instances, this change would only reduce the cache misses by `~29191 (~79%)`. I think this can be optimized further, but I'm wary of trying to make this change myself.~~ ^ I've updated to get us to the 97% case by stuffing compilation in a WeakMap. Some risk of something holding onto a compilation that shouldn't be as a side effect. I've also added a comment to the code to point this out. Additionally, I spotted that `getFilesInDir` returns an array, but is only ever used in a place that immediately converts it to a set. I've updated to return the set directly,
🤞 that we can save some gc cycles as well. Below are two 60 second profiles. In each, I've disabled webpack parallelism, and added a local cache that writes cache items directly to the filesystem. I've also preloaded the entire cache into memory _before_ the profiles so that I'm looking as closely at the raw CPU work as I can. **Before** <img width="1642" alt="image" src="https://github.com/user-attachments/assets/d27fea21-278f-4dbd-8b33-405fda3c9d08"> **After**  <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:Zack Tanner <1939140+ztanner@users.noreply.github.com> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Tim Neutkens authored
Fixes a bunch of CSS related tests that were written based on the `.next` folder instead of the rendered page, added snapshots for Turbopack. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Zack Tanner authored
Clarifies that static vs dynamic resources now influence the static / dynamic staleTime that is used which should hopefully be more intuitive. Reference PR: - https://github.com/vercel/next.js/pull/67868 Also updates the JSDoc for `<Link />` since it was fairly out of date and lacking any info about app router behavior. --------- Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Will Binns-Smith authored
In larger apps, when compilation can take time and endpoints are often build concurrently, `endpoint_server_changed_subscribe`’s subscription to turbotasks can result in unnecessary calls of the JS callback even when turbotasks input has not changed. This wraps subscribing to issues and diagnostics in `endpoint_server_changed_subscribe` within a turbotasks function that ensures that inputs are properly consistent (e.g. diagnostics have been sorted and are value-equal) so this callback is not called unnecessary. Test Plan: Navigate within a large app and verify `serverComponentChanges` messages are not sent through the web socket connection and the browser does not perform unnecessary fetch requests to rsc endpoints. ### Turbopack Changes * https://github.com/vercel/turbo/pull/8777 <!-- Tobias Koppers - merge InProgressDirty into InProgress --> * https://github.com/vercel/turbo/pull/8785 <!-- Tobias Koppers - fix watcher bug with file creation --> * https://github.com/vercel/turbo/pull/8793 <!-- Tobias Koppers - get rid of notify-debouncer in favor of our own debouncing --> * https://github.com/vercel/turbo/pull/8805 <!-- Tobias Koppers - impl Ord for Diagnostics and Issue so they are sorted correctly --> --------- Co-authored-by:
Tobias Koppers <tobias.koppers@googlemail.com>
-
Sebastian Silbermann authored
-
- 22 Jul, 2024 13 commits
-
-
Lee Robinson authored
Closes https://github.com/vercel/next.js/issues/67834.
-
vercel-release-bot authored
-
Niklas Mischkulnig authored
It currently looks like this <img width="1236" alt="Bildschirmfoto 2024-07-22 um 10 09 05" src="https://github.com/user-attachments/assets/6ddb73b7-18f3-4e60-9505-0befb0014253">
-
Sebastian Silbermann authored
-
Sebastian Silbermann authored
-
Sebastian Silbermann authored
-
hrmny authored
### Why? In preparation for moving all turbopack crates Also makes them easier to work with in general. Closes PACK-3164
-
darthmaim authored
-
Josh Story authored
Refactors the `createMetadataComponents` function to convey readiness via a promise `metadataReady` rather than a renderable component `<MetadataOutlet>`. I also moved the resolution out of the render and into the factory function because we generally only want to do this resolution once and later we may retry the RSC render and it is wasteful to recompute the resolved value. I am instrumenting the ready promise with `status` and `value` so that in a future update React can unrwap the value synchronously. This isn't very important right now but in the future we will want to take advantage of it.
-
Janka Uryga authored
Our `pre-push` hook blocks accidental pushes to `canary` (see https://github.com/vercel/next.js/pull/66030 for context). This can be a bit annoying if the target remote is a fork -- we don't really need to protect those, we only care about the main repo. This PR changes the hook to only block pushes if the target remote is `vercel/next.js`. I also improved the branch checking logic to check if the _remote_ branch is `canary` -- previously, we'd only check the currently checked-out branch name, which means the hook wouldn't catch `git push origin mybranch:canary` (assuming `mybranch` is the currently checked out branch)
-
Tim Neutkens authored
When this test was in `test/integration` it tried to hack around Sass always being installed. By leveraging the test isolation helpers we can just opt to not installing `sass` which ensures it matches reality. This doesn't fix the test with Turbopack enabled yet but it does highlight the real error, instead of showing a strange resolving error about a non-existent sass-begone package. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tim Neutkens authored
Implements support for `reactProductionProfiling` and `--profile` for Turbopack build. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Jiachi Liu authored
-
- 21 Jul, 2024 7 commits
-
-
vercel-release-bot authored
-
かがみ authored
Co-authored-by:Lee Robinson <me@leerob.io>
-
Eng Zer Jun authored
Signed-off-by:
Eng Zer Jun <engzerjun@gmail.com> Co-authored-by:
Lee Robinson <me@leerob.io>
-
Yuri van Geffen authored
Co-authored-by:Lee Robinson <me@leerob.io>
-
Mustafa Ekrem KENTER authored
Co-authored-by:Lee Robinson <me@leerob.io>
-
Allan Chau authored
Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com> Co-authored-by:
Delba de Oliveira <delbabrown@gmail.com>
-
Navid Nourani authored
-
- 20 Jul, 2024 6 commits
-
-
vercel-release-bot authored
-
Hendrik Liebau authored
-
Tim Neutkens authored
This deps were missing but are used
👍 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> -
Tim Neutkens authored
The path is still correct just more specific, so changed the test to match both. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Hendrik Liebau authored
x-ref: [Flakiness Metrics](https://app.datadoghq.com/ci/test-runs?query=test_level%3Atest%20env%3Aci%20%40git.repository.id%3Agithub.com%2Fvercel%2Fnext.js%20%40test.service%3Anextjs%20%40test.suite%3A%2APrerender%2A%20%40test.status%3Afail&agg_m=count&agg_m_source=base&agg_t=count¤tTab=overview&eventStack=&fromUser=false&index=citest&start=1720809000422&end=1721413800422&paused=false) As part of this PR I'm also changing the new `patchFile` option to not automatically retry. This should be handled by the call site.
-
Sebastian Silbermann authored
Ensure "[Fast Refresh] rebuilding" logs have a matching "[Fast Refresh] done" log in Webpack (#67968)
-
- 19 Jul, 2024 4 commits
-
-
vercel-release-bot authored
-
Mark Knichel authored
-
Sebastian Silbermann authored
-
Zack Tanner authored
This particular test was failing because build logs were being piped to stderr, despite being successful. This ensures `next.cliOutput` captures both `stdout` and `stderr`.
-