- 23 Oct, 2024 1 commit
-
-
vercel-release-bot authored
-
- 22 Oct, 2024 24 commits
-
-
vercel-release-bot authored
-
Josh Story authored
Component stacks in dev are sourcemapped and currently there is a bug that prevents the right function name from showing up which interrupts our ability to detect incomplete metadata in dev
-
Tim Neutkens authored
Changes `--turbo` -> `--turbopack` to avoid confusion. - Updated docs - Updates create-next-app -- For create-next-app it's a rename as otherwise there is an ordering problem with the prompts - For the CLI `next dev --turbo` is still supported, will eventually be a warning in a future version to swap with `--turbopack` but is not a requirement today, can be handled automatically by the upgrade codemod - New CLI flag: `next dev --turbopack` <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Will Binns-Smith <wbinnssmith@gmail.com>
-
Benjamin Woodruff authored
**This is a** *(mostly)* **machine-generated PR.** This uses a much updated version of the ast-grep based codemod script from #70927, which can now match a bunch more patterns. Codemod scripts: https://github.com/vercel/turbopack-resolved-vc-codemod/tree/90518e64cfaf9328546ff4688692f16f54d4fc3e I did a small bit of cleanup after running the script with: ```bash sg -U --pattern '$OBJ.resolve().await?.to_resolved().await?' -r '$OBJ.to_resolved().await?' ``` Notable additions since last time are: - Runs the compiler/fixer in a loop a few times, as fixing an issue often allows compilation to get further, creating new errors. - Can apply compiler-suggested edits (usually these are manual derefs needed with `*`) - Knows how to rewrite `$OBJ.cell()` to `$OBJ.resolved_cell()` - Knows how to rewrite `Vc::cell($ARG)` to `ResolvedVc::cell($ARG)` - Knows how to rewrite `$TYPE::cell($ARG)` to `$TYPE::resolved_cell($ARG)`. - Knows how to add `.to_resolved().await?` to expressions.
-
Cody Olsen authored
-
Sebastian "Sebbie" Silbermann authored
Now `pnpm debug` is like `pnpm next` with `NODE_OPTIONS=--inspect`
-
Jiachi Liu authored
-
Benjamin Woodruff authored
Caught this missing implementation when the codemod in #71172 tried to convert this test to use `ResolvedVc`. This implementation just forwards to the one on `Vc`. I don't think we need an explicit test case for `Vc` inside of a struct, because the plan is to codemod away virtually every instance of this. Co-authored-by:Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
-
Jiachi Liu authored
The note of `onRequestError` API is outdated, it's available on v15 stable now Fixes #71634
-
Steven authored
There was an extra backtick causing a format error. https://nextjs.org/docs/app/api-reference/components/image#src <img width="664" alt="image" src="https://github.com/user-attachments/assets/2792e71b-f3a7-4790-80a0-eecb5210753a">
-
Ivan Vasilov authored
Co-authored-by:Lee Robinson <me@leerob.io>
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Jiachi Liu authored
-
vercel-release-bot authored
-
Niklas Mischkulnig authored
A regression from https://github.com/vercel/turborepo/pull/8748 Closes PACK-3312 Previously, it treated imports to `something.mjs` as importing `something.mts` with a fallback to `something.js`. But it should obviously instead fallback to the original extension `mjs`, which is also what tsc does: ``` Found 'package.json' at 'input/package.json'. ======== Resolving module './src/foo.mjs' from 'input/index.js'. ======== Explicitly specified module resolution kind: 'NodeNext'. Resolving in CJS mode with conditions 'require', 'types', 'node'. Loading module as file / folder, candidate module location 'input/src/foo.mjs', target file types: TypeScript, JavaScript, Declaration. File name 'input/src/foo.mjs' has a '.mjs' extension - stripping it. File 'input/src/foo.mts' does not exist. File 'input/src/foo.d.mts' does not exist. File 'input/src/foo.mjs' does not exist. File 'input/src/foo.mjs.ts' does not exist. File 'input/src/foo.mjs.tsx' does not exist. File 'input/src/foo.mjs.d.ts' does not exist. File 'input/src/foo.mjs.js' does not exist. File 'input/src/foo.mjs.jsx' does not exist. Directory 'input/src/foo.mjs' does not exist, skipping all lookups in it. ======== Module name './src/foo.mjs' was not resolved. ======== ```
-
Jiachi Liu authored
-
Janka Uryga authored
Our patched `console.error` tries to skip internal router errors by checking `isNextRouterError(error)`. however, if one of those happened on the server and got replayed on the client, it gets logged differently -- it's prefixed with the `[ Server ]` badge. this changes the position where the actual error object is in `args` and thus messes up our detection, so we end up printing it out (instead of hiding it like we should) This PR adds a check that attempts to match replayed server errors (following [similar logic from react devtools](https://github.com/facebook/react/blob/65a56d0e99261481c721334a3ec4561d173594cd/packages/react-devtools-shared/src/backend/flight/renderer.js#L88-L93)) and thus also filter out router errors that originated on the server Closes #71555
-
Jiwon Choi authored
### Why? When handling the `opengraph-image` size exceeding the limit, we mapped with string literal between Rust and JavaScript. The Rust string literal contains backslashes `\` on Windows, incompatible with JavaScript string syntax. Fixes #71582 --------- Co-authored-by:Donny/강동윤 <kdy1997.dev@gmail.com>
-
Jiwon Choi authored
### Why? Since ESLint v9 was unblocked, we no longer need to pin installing v8 when running `next lint` for the first time.
-
Niklas Mischkulnig authored
Closes PACK-3304 This was originally done in https://github.com/vercel/next.js/pull/63209 But I don't think this is correct. Without this change, the added test fails with ``` Error: failed to pipe response at pipeToNodeResponse (/next.js/packages/next/dist/server/pipe-readable.js:126:15) at async handleRequest (/next.js/packages/next/dist/server/lib/router-server.js:275:24) at async requestHandlerImpl (/next.js/packages/next/dist/server/lib/router-server.js:384:13) at async Server.requestListener (/next.js/packages/next/dist/server/lib/start-server.js:142:13) { [cause]: TypeError [ERR_INVALID_URL]: Invalid URL at new NodeError (node:internal/errors:405:5) at new URL (node:internal/url:676:13) at /next.js/test/tmp/next-test-1729241452365-597/.next/server/edge/chunks/ssr/[project]_packages_next_dist_compiled_fd94e8._.js:31684:26 { input: '/_next/static/media/noto-sans-v27-latin-regular.7e1666d1.ttf', code: 'ERR_INVALID_URL' } } ``` (because the `blob:` prefix is missing for the font static URL)
-
Zack Tanner authored
This applies similar handling from #71567 to show dynamic IO errors during client navigations. This also adds a redbox test case for the initial SSR render.
-
Jiwon Choi authored
### Why? Reuse `process.cwd` value. This is good for slight perf and future extensible when we add `cwd` option.
-
Josh Story authored
Previously the `prerender` function for Fizz was gated to experimental but in our latest React sync we now have access to it in the canary channel. This updates the prerender pathway for non-experimental react to use `prerender` rather than `renderToReadableStream`. `prerender` has a few benefits in that it does breadth first rendering at Suspense boundaries so you can ensure fallback UIs are fully rendered wherever possible if you end up abortint the render. currently stacked on #71579
-
- 21 Oct, 2024 15 commits
-
-
Jiachi Liu authored
-
vercel-release-bot authored
-
Hendrik Liebau authored
This PR removes the extra wrapper functions and `.bind()` calls from the action entrypoint loader. Instead, the loader module now only re-exports the actions from the original module using the IDs as export names. This ensures that the same action instance will always remain identical. It also unblocks the combined usage of `"use cache"` and `"use server"` functions. --------- Co-authored-by:Shu Ding <g@shud.in>
-
Zack Tanner authored
`NEXT_PAGE_EXPORT_ERROR` and `NEXT_STATIC_GEN_BAILOUT` shouldn't show up in failed build logs as they'll point to an internal stack not related to user code. This updates the code that throws the `ExportPageError` to instead exit the worker when `prerenderEarlyExit` is true (which is the default) so that the page export error doesn't leak into the outer error handler which is meant for user errors. For static generation bailout errors, we'll log the error message (if it exists) otherwise there's nothing to log as the stack would point to internal framework code. This also removes a redundant log that is already printed as a prerender error.
-
Vercel Release Bot authored
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-65a56d0e-20241020` to `19.0.0-rc-69d4b800-20241021`** [diff facebook/react@65a56d0e...69d4b800](https://github.com/facebook/react/compare/65a56d0e...69d4b800) <details> <summary>React upstream changes</summary> - https://github.com/facebook/react/pull/31313 </details>
-
Josh Story authored
Implements this in a simpler manner with just { once: true } on the event registration -
Zack Tanner authored
This needs to be updated to specify the version.
-
Sam Ko authored
## Why? For PPR (experimental), user's should just opt to use v15 canary if they want to try out PPR. Removing the v14 mention reduces this confusion. - x-ref: https://vercel.slack.com/archives/C05KYT5S9FF/p1729264052080029?thread_ts=1729263181.989139&cid=C05KYT5S9FF
-
vercel-release-bot authored
-
Josh Story authored
makeHangingPromise returns a promise that rejects when an AbortSignal aborts. If too many are created however Node warns about a possible memory leak. We shouldn't increase the max count becuase this may prevent detection of legitmate memory leaks in user code. As an alternative we delegate aborts through a weakmap and attach only a single listener. This is trivially slower and more memory but safer semantics. This code only runs during revalidate and build so it does not have a perf impact on production streaming use cases.
-
Jiwon Choi authored
### Why? `@next/font` is deprecated and need to be replaced with `next/font`.
-
Jiwon Choi authored
### Why? When running next-upgrade, `next-request-geo-ip` requires to install `@vercel/functions` and `built-in-next-font` makes `@next/font` no longer needed. We added a prompt to ask user whether to (un)install it at https://github.com/vercel/next.js/pull/71038 but it prompts even if there were no transform occurred. This is unnecessary layer so we only prompt when there's a change caused from the codemod. ### No Modification https://github.com/user-attachments/assets/3acfdb24-c8e7-4189-9c81-4765ce748822 ### With Modification https://github.com/user-attachments/assets/f44a8b1c-c75a-4446-afc8-f74111de939d ---------
-
Josh Story authored
Reverts vercel/next.js#71566 which relands #71526 merge after 15 is released
-
vercel-release-bot authored
-
vercel-release-bot authored
-