- 24 Oct, 2024 7 commits
-
-
vercel-release-bot authored
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> This changes the generated source map to not do the "webpack://next/dist/<file>" and instead use the relative path. this allows us to use the vanilla ignoreList "node_modules" config to also also ignore those files  
-
turbopack://[project]/...`file://...`Will Binns-Smith authored
This makes working with devtools more straightforward, reduces our own overhead when tracing stack frames in the error overlay, etc. Generated code from Turbopack or Next.js still use `turbopack://[turbopack]` or `turbopack://[next]` respectively. Test Plan: - [x] Update tests - [x] CI - [x] https://github.com/vercel/next.js/blob/475bdb1f743bf0b3552b40f85b615d87f4ae4904/test/development/app-dir/source-mapping/README.md --------- Co-authored-by:
Benjamin Woodruff <benjamin.woodruff@vercel.com> Co-authored-by:
Tobias Koppers <tobias.koppers@googlemail.com>
-
Sebastian Markbåge authored
Turbopack doesn't recognize webpack:// and so errors otherwise. We don't need source maps for internals. <img width="774" alt="Screenshot 2024-10-23 at 10 13 02 PM" src="https://github.com/user-attachments/assets/72ec2ecc-7fbb-4a2a-9978-8d8c365ab966">
-
Jiachi Liu authored
### What When there's a replay console error showed up, display it in error overlay. #### Server Component Page <img width="480" alt="image" src="https://github.com/user-attachments/assets/7af65809-1e0e-4aa0-bffb-bc95a376fb02"> #### Server Component Page with Client Components <img width="480" alt="image" src="https://github.com/user-attachments/assets/1f8bd507-3e0f-43f3-9240-07c4aec16ab4"> --------- Co-authored-by:
Sebastian Markbage <sebastian@calyptus.eu>
-
Steven authored
This PR adds two experimental flags to configure sharpjs settings that may improve cpu for image optimization.
-
Jiachi Liu authored
-
- 23 Oct, 2024 33 commits
-
-
Vercel Release Bot authored
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-28668d39-20241023` to `19.0.0-rc-1631855f-20241023`** [diff facebook/react@28668d39...1631855f](https://github.com/facebook/react/compare/28668d39...1631855f) <details> <summary>React upstream changes</summary> - https://github.com/facebook/react/pull/31340 </details>
-
vercel-release-bot authored
-
Sam Ko authored
## Why? The `turbo` config is still experimental in v15. - Fixes https://github.com/vercel/next.js/issues/71750 - Related PR: https://github.com/vercel/next.js/pull/71755
-
Jiachi Liu authored
-
Sebastian Markbåge authored
This lets us show Server Components (and Host Components) in the Parent Stack passed to errors. <img width="1039" alt="Screenshot 2024-10-23 at 12 51 10 PM" src="https://github.com/user-attachments/assets/5912e750-b544-403d-8d5a-bce91c01b3a8">
-
Josh Story authored
We ended up with up to three prerender passes as we added support for new use cases like lazy module initializaiton. This update refactors the PPR pathway to have at most two renders. I will follow up with a refactor of the non-ppr pathway next.
-
Jiachi Liu authored
-
JJ Kasper authored
-
Maia Teegarden authored
### What? Fixes code examples for configuring Turbopack. Turbopack Dev is stable, but we're keeping the configuration options under `experimental` until Turbopack Build is stable as well. Most of these options will not change, but we didn't want a combination of experimental and stable options. Closes PACK-3324
-
vercel-release-bot authored
-
Hendrik Liebau authored
Similar to how #71669 fixed a race condition when setting the manifests singleton regarding the server action manifests, this PR fixes the same race condition for the client reference manifests.
-
Josh Story authored
-
Vercel Release Bot authored
-
Zack Tanner authored
`easy` and `just` are failing lint checks.
-
Sebastian Markbåge authored
-
Sam Ko authored
## Why? Let's clarify this is only available in canary. We need to remove it from the stable docs later.
-
Josh Story authored
It will be quite common to attempt to access data during prerendering and encounter the error that indicates you did not provide a Suspense boundary to define fallback UI. This change updates the error message and includes a link to a new docs page which explains how to handle this error. --------- Co-authored-by:Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Jiachi Liu authored
-
Jiwon Choi authored
### Why? 1. When `next dev --turbo` existed, it added `--turbopack` since it was looking for existing `--turbopack` only. 2. When there's no `"dev"` script found in package.json, inform the user we weren't able to enable Turbopack for them. - https://github.com/vercel/next.js/releases/tag/v15.0.1-canary.3 ## Test Plan ### Suggest Turbopack ``` pnpm test:upgrade-fixture bin/__testfixtures__/suggest-turbopack ``` ```diff "scripts": { - "dev": "next dev" + "dev": "next dev --turbopack" }, ``` ### Change `--turbo` to `--turbopack` ``` pnpm test:upgrade-fixture bin/__testfixtures__/change-turbo-to-turbopack ``` CLI output includes: ```
✔ Replaced "--turbo" with "--turbopack" in your dev script. ``` ```diff "scripts": { - "dev": "next dev --turbo" + "dev": "next dev --turbopack" }, ``` -
Sebastian "Sebbie" Silbermann authored
-
Can Temizyurek authored
Closes https://github.com/vercel/next.js/issues/71675. Co-authored-by:
Zack Tanner <1939140+ztanner@users.noreply.github.com>
-
Can Temizyurek authored
Closes https://github.com/vercel/next.js/issues/71679Co-authored-by:
Zack Tanner <1939140+ztanner@users.noreply.github.com>
-
Tim Neutkens authored
This page was showing the outdated default. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
vercel-release-bot authored
-
Zack Tanner authored
Since `console.error` is intercepted, this can be frustrating when a 3p library that hasn't updated to use the async APIs triggers a warning. This keeps the error behavior when `dynamicIO` is enabled and warns in other cases.
-
Jiwon Choi authored
next-codemod: add empty `pnpm-workspace.yaml` to test fixtures to bypass PNPM workspace checks (#71726) ### Why? Since dep installation within next-codemod runs `pnpm install` on the Next.js repo, it installs in the workspace root scope during testing. We could add a layer for testing like adding a flag `--no-workspace`, but it will reduce confidence between the actual running and testing. Therefore added an empty `pnpm-workspace.yaml` file to each fixture. ### How? By doing this, both installation and testing will have same environment of running, `pnpm install` only. To prevent created `pnpm-lockfile` to be shipped, gitignored it. This way, we keep things simple and make sure tests match real-world use better. The empty `pnpm-workspace.yaml` files make `pnpm` treat each fixture separately, which is closer to how it'll work for users.
-
Jiachi Liu authored
-
Sebastian "Sebbie" Silbermann authored
`npm view` prints a notice when a new update is available to `stderr` tricking us into thinking there was an error. ``` npm notice npm notice New minor version of npm available! 10.7.0 -> 10.9.0 npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.9.0 npm notice To update run: npm install -g npm@10.9.0 npm notice ``` Running with `--silent` avoids these unrelated warnings (see https://github.com/npm/npm/issues/2040#issuecomment-3504495). ## Test plan https://github.com/vercel/next.js/pull/71718
-
Jiachi Liu authored
-
Miguel da Mota authored
This PR fixes #71706. When having an error client side and there is a `basePath` defined, the basePath is being used to locate the sourcemap of the given file which results in an error. With these changes the `basePath` gets removed from the `filename` passed to `findSourceMapURL` If you have questions, feel free to ask!
-
Hendrik Liebau authored
-
Prakhar Shukla authored
### Why? During the next-codemod upgrade, when the `dev` script is missing, it throws while reading `.includes` the undefined value. Fixes #71597 --------- Co-authored-by:Jiwon Choi <devjiwonchoi@gmail.com>
-
Jiwon Choi authored
### Why? When handling the opengraph-image size exceeding the limit, we mapped with string literal between Rust and JavaScript. The Rust string literal contains backslashes `\` on Windows, incompatible with JavaScript string syntax. Following up on #71615. Fixes #71582
-