- 26 Oct, 2024 3 commits
-
-
vercel-release-bot authored
-
Sergey Rubanov authored
-
Antonis Angelis authored
-
- 25 Oct, 2024 14 commits
-
-
vercel-release-bot authored
-
Sebastian "Sebbie" Silbermann authored
-
Will Binns-Smith authored
The `.next/trace` file contains trace events spanning multiple traces from different sessions. This changes our upload process to only send trace events for the current session that’s ending. Before this change, we would send a single set of metadata for many traces, but these older session traces could have been invoked with different parameters like `mode`, `isTurboSession`, etc. Because of this, we started including `isTurboSession` as a span attribute on spans, but this value was dependent on an environment variable that wasn’t always set. In this case, the top-level `next-dev` span never had the correct value. This makes it so the metadata, now always determined at upload time, always reflects the session sent, and never any others. Other bugs fixed: - Trace events within a single logical session had different trace ids because of worker threads. This aligns them. - Because we upload traces out-of-process, the Telemetry `sessionId` did not reflect the real session id of other analytics sent. This passes it along to the external process. Test Plan: In a test app, using `NEXT_TRACE_UPLOAD_DEBUG=1` and a running Otel server: - Start a non-turbopack dev session and end it. Verify trace events are sent with `isTurboSession: false` and note the trace id. - Start a turbopack dev session and end it. Verify trace events are sent with `isTurboSession: true` and note events are sent for this trace, and not the previous one. - Start a build and verify trace events are sent with `mode: build` and `isTurboSession: false` and that no older trace events are sent. Closes PACK-3338
-
Hendrik Liebau authored
-
Sebastian "Sebbie" Silbermann authored
-
Benjamin Woodruff authored
Generated using a version of https://github.com/vercel/turbopack-resolved-vc-codemod using Anthropic Claude Sonnet 3.5 (`claude-3-5-sonnet-20241022`) for more complicated errors we don't have hardcoded logic for. - Part 1: #70927 - Part 2: #71172 I kept running the script until I ran out of tokens (the tier 1 rate limit is 1M input tokens). I'll keep improving how I'm calling the LLM (there's still a lot of room for improvement from my side), and try running it again tomorrow to fix more things. This fixes 13 struct field types. There are still 271 struct fields remaining that need to be codemodded.
-
Josh Story authored
The second render should not use the first render's abort signal to determine trackable nature of observed errors
-
Zack Tanner authored
This `resolvePendingHotUpdate` in the `SERVER_COMPONENT_CHANGES` event seems to be causing a race where an error would come through in a fast refresh response and then the overlay would be cleared. I'm not really sure why we were resolving a pending hot update here because we already call it on `handleSuccessfulHotUpdateWebpack` and `tryApplyUpdate` but I'm consistently seeing correct behavior without this.
-
JJ Kasper authored
This ensures we are properly caching fetch inside of use cache even if it uses `Authorzation` and comes after cookies() access.
-
Amy Burns authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Jiachi Liu authored
-
Benjamin Woodruff authored
I can believe that the non-collapsed if might be slightly more readable, but once you have to silence the lint with `#[allow(clippy::collapsible_if, reason = "readablility")]`, it's no longer worth it. Closes PACK-3326
-
Benjamin Woodruff authored
A binding is probably needed here to control what scope it's evaluated in and/or avoid potentially evaluating the expression multiple times. `match` was being used to create the binding, but it's easier to read as a `let`, and the two versions should be equivalent. Closes PACK-3325
-
Tobias Koppers authored
### What? Performance optimization
-
- 24 Oct, 2024 23 commits
-
-
vercel-release-bot authored
-
Josh Story authored
Updates the heuristic to scoping prerender caches during dev. A cache scope will be created for every request if one does not already exist. If the request is a server action we create a new one. existing caches already expire after 30 seconds (unchanged) This updates the prefetch cache purge to be 5 seconds since so we don't mask short lifetime caches This also adds cache tracking to the first RSC render of the validation render. This means we now need to always do a second render regardless of whether there is a sync abort.
-
vercel-release-bot authored
-
Ismael authored
-
Sebastian "Sebbie" Silbermann authored
-
Jiwon Choi authored
Removed `"use cache"` directive on the before example of the code snippet.
-
Zack Tanner authored
This clears segment config errors that are corrected in development mode when using `dynamicIO`.
-
Zack Tanner authored
Follow-ups to #71812
-
vercel-release-bot authored
-
Rich Haines authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Shu Ding authored
This PR simplifies our `flight-client-entry-plugin` to not re-compute the server reference IDs because they're already provided in `buildInfo` via our SWC transform. It's also a small performance win depending on the number of Server Actions in the project. Cherry-picked from #71463.
-
Jiachi Liu authored
-
Sebastian "Sebbie" Silbermann authored
-
Jiachi Liu authored
-
Tim Neutkens authored
Incorrectly mentions `(beta)`, it's been moved to stable in Next.js 15
👍 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> -
Jiachi Liu authored
-
Jiwon Choi authored
-
Donny/강동윤 authored
### What? Preserve the original import specifier when tree shaking, so the import analyzers after tree shaking can work. ### Why? This is required for `next/dynamic`. ### How? Closes PACK-3307
-
Josh Story authored
refines the error message for non-prerenderable holes while prerendering as well as the docs
-
vercel-release-bot authored
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> This changes the generated source map to not do the "webpack://next/dist/<file>" and instead use the relative path. this allows us to use the vanilla ignoreList "node_modules" config to also also ignore those files  
-
turbopack://[project]/...`file://...`Will Binns-Smith authored
This makes working with devtools more straightforward, reduces our own overhead when tracing stack frames in the error overlay, etc. Generated code from Turbopack or Next.js still use `turbopack://[turbopack]` or `turbopack://[next]` respectively. Test Plan: - [x] Update tests - [x] CI - [x] https://github.com/vercel/next.js/blob/475bdb1f743bf0b3552b40f85b615d87f4ae4904/test/development/app-dir/source-mapping/README.md --------- Co-authored-by:
Benjamin Woodruff <benjamin.woodruff@vercel.com> Co-authored-by:
Tobias Koppers <tobias.koppers@googlemail.com>
-
Sebastian Markbåge authored
Turbopack doesn't recognize webpack:// and so errors otherwise. We don't need source maps for internals. <img width="774" alt="Screenshot 2024-10-23 at 10 13 02 PM" src="https://github.com/user-attachments/assets/72ec2ecc-7fbb-4a2a-9978-8d8c365ab966">
-