- 30 Oct, 2024 40 commits
-
-
vercel-release-bot authored
-
Chris Drifte authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change Closes NEXT- Fixes # --> ### What? Explicitly mentions `--inspect=0.0.0.0` and its use case. ### Why? NextJS apps are commonly run inside docker containers when self-hosting. In this case, the example in the docs will not work as expected, blocking users who are not familiar with the --inspect flag. ### How? Added a "Good to Know" content block. Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Sasha Aickin authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> ### What? Currently, the `router.push` method does not sanitize URL arguments, which can cause cross-site scripting (XSS) bugs in next.js sites through the running of untrusted code in a JavaScript URL. This was reported as #50093 and was closed, with an explanation that it is the developer's responsibility to sanitize `router.push` input. This PR is an addition to the next.js docs to document that issue and let developers know that they cannot send untrusted or unsanitized URLs into `router.push`. ### Why? Cross-site scripting bugs can be quite high severity, as they often allow attackers to steal credentials and data. Furthermore, the API most similar to `router.push` in the web API, `history.pushState`, does not accept JavaScript URLs, so developers might reasonably not know that they need to sanitize `router.push` input. Searching through public github repos finds more than 1,000 projects that may be vulnerable to this issue, so I believe it's a pretty widespread misunderstanding of the API.
-
Jiachi Liu authored
-
Eric Spishak-Thomas authored
As it is currently with a literal type, this type isn't very useful. As https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#literal-inference explains, TypeScript infers these types on middleware configs as strings, so middleware configs aren't inferred as this type. This can be fixed by adding `as const` after the string literal, but that is annoying to do everywhere (it also isn't currently supported by Next.js: https://github.com/vercel/next.js/blob/89ee26cc76de11c7110dda17389fcfa50c9dbe36/packages/next/src/build/analysis/extract-const-value.ts#L103). By removing this type restriction, this type will be more useful. This is safe to do because this type isn't currently being used anywhere (it never matches) and Next.js already carefully checks/verifies the type of this middleware config object at build time, so will still find any issues then. Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
루밀LuMir authored
##
📚 Fixed typos Hello, I've fixed redundant double spaces in `test/.stats-app/app`. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Jude Gao authored
Context - I only fixed webpack codepath for https://github.com/vercel/next.js/pull/72056 - But we ended up merging it despite the fact the CI would fail due to Github incident https://www.githubstatus.com/incidents/9yk1fbk0qjjc Notes - `middleware.rs` only runs in build time for production turbopack build - without this fix, the test would fail on 404 for prod mode, but would land on Chat page for dev mode
-
Jiwon Choi authored
### Why? - Next.js uses [AsyncLocalStorage.snapshot](https://github.com/vercel/next.js/blob/c32e2802097c03fd9f95b1dae228d6e0257569c0/packages/next/src/server/app-render/async-local-storage.ts#L60) function. - `AsyncLocalStorage.snapshot` [was added in](https://nodejs.org/api/async_context.html#static-method-asynclocalstoragesnapshot) Node.js `19.8.0`, `18.16.0`. - However, the supported Node.js version range was `>= 18.18.0`. - Which allowed Node.js `< 19.8.0` to be used, and causing an error:  > Image Source: https://x.com/smakosh/status/1851565997804667253 ### How? Modified the version range as `"^18.18.0 || ^19.8.0 || >= 20.0.0"`. Confirmed that >= 20 are fully compatible so far. ### Things to Consider Should we limit the upper to prevent deprecated/breaking changes? If so, what would be the suitable upper-limit version?
-
Seoheeda authored
Correct typo from 'errror' to 'error'. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
hackerman authored
Ory: https://www.ory.sh/docs/getting-started/integrate-auth/nextjs Ory GitHub: https://github.com/ory --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Angel P authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? Add unstable version to `unstable_after` ### Why? This lets users reading the documentation see the experimental/unstable icon and tooltip when viewing the documentation ### How? Closes NEXT- Fixes # --> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Salim Absi authored
The searchParams type must be wrapped in a `Promise` within synchronous components/pages to ensure they can be safely passed to React's `use()` hook <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
dorianb authored
The typescript switcher show a .js extension. changed to tsx. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Alexander Mandrov authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
LIU HANCHENG authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> The fix in https://github.com/vercel/next.js/pull/70680 is still misleading. `missingSuspenseWithCSRBailout` is valid in `14` and invalid in `Above 14`. Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
oschleic authored
Small docs import statement fix Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Danzel Artamadja authored
The `cookieStore` was initialized from `cookies()` So when calling methods use `cookieStore.get` instead of `cookieStore().get`. Applies for all other methods --------- Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
kyktommy authored
### What? Nextjs 15 changed generateMetadata params type. It will cause build error when follow the docs. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Dominik Koch authored
The `treeshaking` property in the turbo config docs wasn't using camel case like the property it represents. So to be inline with the property names I changed to the correct name/casing. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Zack Tanner authored
After adding validation that fixing invalid segment configs (when DIO is enabled), it revealed that errors weren't being displayed in Turbopack, because `setHMRServerError` wasn't implemented. This refactors the implementation to use the existing server component transform when validating if the segments are valid. This has the benefit of highlighting precisely where the segment is coming, making it easier to remove. The test that was skipped in Turbopack is also re-enabled. <details> <summary>Screenshot</summary>  </details>
-
Zack Tanner authored
This isn't currently passing as the Turbopack Build handling is missing - we'll fix forward. Skipping temporarily to unblock CI. (GitHub actions had an incident when #72056 ran CI so this was not caught by checks)
-
Josiah Wiebe authored
The "Examples" heading was not being rendered correctly [on this docs page](https://nextjs.org/docs/app/api-reference/file-conventions/page#displaying-content-based-on-params). All this does is fix the whitespace character to allow the MDX to be rendered properly. Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
루밀LuMir authored
##
📚 Fixed typos Hello, I've fixed unnecessay double space in `http.rs`. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Vercel Release Bot authored
-
MrMeshky authored
### What? This PR updates the Edge Runtime documentation to clarify the use of capitalization and improves formatting consistency. ### Why? To maintain documentation clarity and consistency, ensuring accurate information and readability across the documentation. --------- Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
루밀LuMir authored
##
📚 Fixed typos Hello, I've fixed redundant double space in `middleware-plugin.ts`. I think it is a typo. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Jude Gao authored
For a given path expression, we want it to optionally match a `.json` suffix. However, the original implementation was flawed: The path `/:id` was altered to `/:id(.json)?`, which then converted to the Regex pattern `^(?:\/(.json))?[\/#\?]?$`. This Regex incorrectly matched only `/` or `/_json` — clearly not the intended result. The fix involved adjusting the way we append the `.json` suffix. Instead of `/:id(.json)?`, we now use `/:id{(\\.json)}?`, which converts to the Regex `^(?:\/([^\/#\?]+?))(\.json)?[\/#\?]?$`. This pattern correctly matches both cases, with or without the `.json` suffix. ----- Fixes https://github.com/vercel/next.js/issues/53840 Fixes https://github.com/vercel/next.js/issues/55558 Closes DX-2088 -
Mayur authored
current [link](https://workos.com/docs/user-management) for WorkOS point to Node.js document, This update ensures all links lead directly to their respective Next.js integration pages. Also updated link for Stytch and Kinde auth link to point to appropriate docs page. Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
루밀LuMir authored
##
📚 Improving Documentation Hello, I’ve updated the `02-jest.mdx` documentation with the following improvements: 1. I added the comment, `"The content of this doc is shared between the app and pages router."` This document is used by both the Pages Router and App Router, and I found this comment in other files within the `docs` directory. 2. ~~I introduced `<PagesOnly>` and `<AppOnly>` components. Previously, when clicking links in the App Router page, it would navigate to the Pages Router documentation. I’ve modified this so that links open in the App Router documentation when viewed there.~~ 3. Additional typo corrections: 1. Removed colons (`:`) from headings, as they aren’t used in other docs. 2. Added missing double quotes (`"`). --------- Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
루밀LuMir authored
##
📚 Improving Documentation Hello, I've fixed `testing` to `Testing`. (lowercase to uppercase)  In other documents, `T` is always uppercase as shown in the screenshot above. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Artem Zakharchenko authored
## What The way Next.js re-defines a global `WebSocket` property makes it non-configurable. No other agents, such as API mocking libraries, are able to re-defined it. This [causes issues](https://github.com/mswjs/msw/issues/2339) for Next.js users. # Why Because the way the `WebSocket` property descriptor is set in Next.js doesn't allow that property to be configured anymore (and neither does it have a setter): https://github.com/vercel/next.js/blob/de4f197e2fde19526ee019fbebb068e962b58fc0/packages/next/src/server/node-environment-baseline.ts#L11-L15 ## How This can be solved by setting `configurable: true` on the object descriptor. Generally, I'd advise against such restrictive descriptors for globals Next.js doesn't own, like fetch or WebSocket. Try adhering to how such globals are defined in Node.js—configurable and often with setters: ``` > Object.getOwnPropertyDescriptor(global, 'WebSocket') { get: [Function: get WebSocket], set: [Function: set WebSocket], enumerable: false, configurable: true } ```
-
AliReza authored
### Description: This PR updates the Dockerfile in the `examples/with-docker` folder to include the `.npmrc` file in the dependency copy command. ### Original Command: ```dockerfile # Install dependencies based on the preferred package manager COPY package.json yarn.lock* package-lock.json* pnpm-lock.yaml* ./ ``` ### Updated Command: ```dockerfile # Install dependencies based on the preferred package manager COPY package.json yarn.lock* package-lock.json* pnpm-lock.yaml* .npmrc ./ ``` ### Reason for Change: Including `.npmrc` allows for custom npm configurations, such as `legacy-peer-deps=true`. Without this option, some installations can fail due to unresolved peer dependencies, particularly for projects with older dependencies. This update ensures that any additional configurations specified in `.npmrc` are applied during installation, improving Docker build consistency and stability for projects with custom npm requirements. ### Diff: ```diff - COPY package.json yarn.lock* package-lock.json* pnpm-lock.yaml* ./ + COPY package.json yarn.lock* package-lock.json* pnpm-lock.yaml* .npmrc ./ ``` --------- Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Rich Haines authored
This PR clarifies scroll behavior when components are added to a page that do not contain visible elements. This PR adds a note to the `Link` docs explaining how Next.js traverses the DOM and bypasses certain components looking for a scrollable element. Fixes: https://linear.app/vercel/issue/DOC-3391/add-guidance-on-metadata-placement-and-page-scroll-with-link --------- Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Hendrik Liebau authored
We already propagate tags from `fetch` calls to the work unit store. For `revalidateTag` to work properly for `fetch` calls in `"use cache"`, we also need to consider the other direction, and add tags from the work unit store to the tags that are used for the fetch cache entry in the cache handler. fixes #71924
-
Will Binns-Smith authored
The Google fonts API requires this. Previously, `get_stylesheet_url` trusted that the weight axis inputs were sorted correctly, which they may not be. This PR creates and uses two new enums: - `FontAxesWeights`, to capture weights as ints, and moves the responsibility of sorting weights into `get_stylesheet_url` itself. - `VariantValue` to wrap each value for variants, as these can be either a string (an expression representing a variable font weight range) or a `u16`, representing a fixed font weight. This allows us to defer stringifying these until format time while still comparing them for ordering. Test Plan: Added a unit test for `get_stylesheet_url`. Closes PACK-3359
-
Hendrik Liebau authored
"like" => "likely"
-
Vercel Release Bot authored
This auto-generated PR updates font data with latest available
-
Jam Balaya authored
## Summary According to [Adding examples](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md), `auth-app` project name is needed. ### Adding or Updating Examples - [x] The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - [x] Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Jam Balaya authored
## Summary The old analyze command use `yarn build`. This happens an error with node, pnpm and bun. ### Adding or Updating Examples - [x] The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - [x] Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
-
JJ Kasper authored
When `pages/500` uses `getStaticProps` we can honor statically generating the page but we can't send a `Cache-Control` with `stale-while-revalidate` as we shouldn't be caching errored pages ever. This ensures we handle that case and add a regression test for it.
-