- 05 Dec, 2024 3 commits
-
-
vercel-release-bot authored
-
eps1lon authored
-
Sebastian "Sebbie" Silbermann authored
-
- 07 Nov, 2024 19 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Niklas Mischkulnig authored
The MDX was invalid after https://github.com/vercel/next.js/pull/72399 causing next-site deploy failures (I'm not entirely sure if this is where the `</AppOnly>` should go, feel free to correct that) Closes PACK-3416
-
Delba de Oliveira authored
Closes: - https://linear.app/vercel/issue/DOC-3695/page-project-structure This PR: - Splits the page between the app/pages and the router docs. - Merge the colocation page from BYA.
-
Benjamin Woodruff authored
Dashmap 6.x claims fairly large performance improvements: > This release contains performance optimizations, most notably 10-40% gains on Apple Silicon but also 5-10% gains when measured in Intel Sapphire Rapids. -- https://github.com/xacrimon/dashmap/releases/tag/v6.0.0 I don't think this means too much for us because while `turbo-tasks` uses dashmap pretty heavily, we spend more time actually doing computations than in `turbo-tasks`, so it's a fraction of a fraction. Still, here's a fairly unscientific (noisy environment, inside a VM) benchmark on my macbook using a microbenchmark that's designed to hit `turbo-tasks` extremely hard (much more so than would happen in realistic scenarios): ``` $ TURBOPACK_BENCH_STRESS=yes cargo bench -p turbo-tasks-memory -- fibonacci/200 Compiling turbo-tasks-memory v0.1.0 (/home/bgw.linux/next.js/turbopack/crates/turbo-tasks-memory) Finished `bench` profile [optimized] target(s) in 2.80s Running benches/mod.rs (target/release/deps/mod-7b9a423ac1e10dce) Gnuplot not found, using plotters backend Benchmarking turbo_tasks_memory_stress/fibonacci/200: Warming up for 3.0000 s Warning: Unable to complete 2000 samples in 5.0s. You may wish to increase target time to 91.9s, or reduce sample count to 100. turbo_tasks_memory_stress/fibonacci/200 time: [33.008 ms 33.108 ms 33.208 ms] thrpt: [605.31 Kelem/s 607.13 Kelem/s 608.97 Kelem/s] change: time: [-2.0573% -1.6309% -1.2221%] (p = 0.00 < 0.05) thrpt: [+1.2373% +1.6580% +2.1005%] Performance has improved. Found 44 outliers among 2000 measurements (2.20%) 2 (0.10%) low mild 38 (1.90%) high mild 4 (0.20%) high severe ``` Any potential improvement to realistic topline numbers are going to be <1% and thus too small to measure (especially since I don't have a low-noise way of measuring Apple Silicon where most of the benefits supposedly are, only x86-64). Closes PACK-3411
-
Wyatt Johnson authored
-
Arfa Ahmed authored
docs(parallel-routes): update 11-parallel-routes.mdx example for modal closing - Updated `11-parallel-routes.mdx` to replace `'...'` with `null` in the `page.tsx` return statement inside the slot for closing the modal when navigating using `Link`. - Also applied the same change in the `default.tsx` file to ensure consistent behavior in the example.   <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Arfa Ahmed authored
docs(route-handlers): add TS/JS `switcher` to `Route Resolution` section in `Route Handlers` (#72222) This PR fixes issue on the [Route Handlers](https://nextjs.org/docs/canary/app/building-your-application/routing/route-handlers) documentation page: Missing switcher for TS codeblock in [Route Resolution](https://nextjs.org/docs/canary/app/building-your-application/routing/route-handlers#route-resolution) section.  <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Tobias Koppers authored
### What? cleanup Closes PACK-3393
-
Jam Balaya authored
## Summary Remove redundant `#` from [error pages](https://github.com/vercel/next.js/tree/canary/errors). ## Description Follow up #52038 and #72263. Updated [template.txt](https://github.com/vercel/next.js/blob/canary/errors/template.txt) and clarified the header deps. Then rewrite as per the template. ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guideCo-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Alexander Lyon authored
### What? This is a 2nd prefactor for adding node-file-trace into turbopack. When implementing this, we have a few options namely: - a) expose turbotrace (node-file-trace-rs) as a napi library and try to insert it into the current codebase - b) expose turbotrace and try to reuse the turbo backend - c) move turobtrace into the rust process and do it in parallel with everything else We chose c We have already ripped out the js code path, this PR nukes the now-orphaned node-file-trace rust binary and napi bindings. ### Why? The crate is unmaintained and probably will not be used in its current form.
-
Mayur authored
This PR updates the link for the Cloudflare Auto Minify feature, as it has been deprecated. Cloudflare now recommends disabling this feature to avoid potential issues. The link and related references have been modified to reflect this update and ensure accurate information for users. Co-authored-by:Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Jonas Aschenbrenner authored
Related to https://github.com/vercel/next.js/discussions/72424. I wasn't able to test if the added "Terminal" switcher works, because I don't know how to run the docs locally. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Donny/강동윤 authored
### What? Add an option to disable SWC minfiier for turbopack builds. ### Why? Disabling minification was useful for debugging and @sokra suggested adding it as an option under `experimental.turbo`. ### How? Closes PACK-3371
-
Donny/강동윤 authored
### What? ### Why? ### How? Closes NEXT- Fixes #
-
Benjamin Woodruff authored
Noticed while looking through our lockfile that we were pulling in an extra version of clap because of this old version of criterion. Clap (particularly these older versions) is a pretty notoriously heavy crate, though we'd only need to compile it when building the benchmark targets. Tested with: ``` TURBOPACK_BENCH_STRESS=yes cargo bench -p turbo-tasks-memory scope_stress ``` Closes PACK-3407
-
Vercel Release Bot authored
This auto-generated PR updates font data with latest available
-
Benjamin Woodruff authored
I noticed we were using a pretty old version of indexmap, this updates that. `indexmap 1.9.3` still exists in the lockfile as there are some other dependencies we have (mostly `wasmer`) that pull it, but as those dependencies are updated, we'll get rid of it. I specified the lower version range bound as `2.5.0` instead of `2.6.0` because I wanted to avoid introducing [yet another minor version of hashbrown](https://github.com/indexmap-rs/indexmap/blob/master/RELEASES.md), which might *slightly* help with compilation times. This is just a lower bound, so eventually we'll end up on `2.6.0` (or a later version) if dependency asks for it. Closes PACK-3406
-
Will Binns-Smith authored
- @vercel/devlow-bench@0.3.3 Closes PACK-3391
-
- 06 Nov, 2024 18 commits
-
-
Jam Balaya authored
## What? Add [`syntax`](https://docs.docker.com/reference/dockerfile/#syntax) parser directive to the first line of the [Dockerfile](https://docs.docker.com/reference/dockerfile/). ## Why? To declare the Dockerfile syntax version to use for the build. If unspecified, [BuildKit](https://docs.docker.com/build/buildkit/) uses a bundled version of the Dockerfile frontend. ## How? Append `# syntax=docker.io/docker/dockerfile:1` to the top of the [Dockerfile](https://docs.docker.com/reference/dockerfile/). Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Sam Ko authored
## Why? We're not documenting a way to manually move files to `.next/standalone` for `output: 'standalone'`.
-
Andrew Clark authored
In the last PR (#72367) I got confused and incorrectly assumed that initialRSCPayload was a client Flight value, not a server value. Which meant it was actually re-rendering the Server Components again, rather than reusing the result from the page render. Instead, I need to decode this value from the full page Flight stream, like I did originally. (Except we still don't need to do it once per segment, just once per page.) To avoid another unecessary decoding of the page stream, I've moved the segment rendering tasks so that they are spawned from inside the render that generates the tree metadata response. The size of the diff is bit misleading; mostly this involves just rearranging the code so that it executes in a slightly different order.
-
Janka Uryga authored
the `next_font_loaders` transform replaces imports from `next/font` with slightly different ones. unfortunately it was inserting these imports **at the top** of the file, which broke the `server_actions` transform because it expects "use server"/"use cache" directives to be the first item in the file. this PR changes the logic in the font transform to insert the import in the place where the original `next/font` import occurred instead of at the top of the file. (i suppose that we could just reorder the transforms and run `server_actions` before `next_font_loaders`, but this feels more robust) Fixes #72179
-
Jiachi Liu authored
-
Andrew Clark authored
Based on: - #72418 --- When PPR is enabled, prefetch streams may contain references that never resolve, because that's how we encode dynamic data access. In the decoded object returned by the Flight client, these are reified into hanging promises that suspend during render, which is effectively what we want. The UI resolves when it switches to the dynamic data stream (via useDeferredValue(dynamic, static)). However, the Flight implementation currently errors if the server closes the response before all the references are resolved. As a cheat to work around this, we wrap the original stream in a new stream that never closes, and therefore doesn't error.
-
Andrew Clark authored
The only difference between createFromFetch and createFromReadableStream is that createFromFetch accepts a promise for a fetch, and createFromReadableStream accepts a Flight ReadableStream (e.g. response.body). Since we're doing other stuff with the response object anyway there's not much point using the slightly higher-level form.
-
Eric Spishak-Thomas authored
This utility was added in https://github.com/vercel/next.js/pull/70731 but incorrectly said there was a match even if `has` and `missing` didn't match. This also updates the test utility to automatically set the `Host` header when constructing a request (if the URL has a host). <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Mark Knichel <7355009+mknichel@users.noreply.github.com> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Jam Balaya authored
## Summary Change `upate` to `update` ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guideCo-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Benjamin Woodruff authored
Revert "feat(turbopack): Add an env var to debug-print the fast refresh invalidation reason (#72296)" (#72421) Not sure why this is happening, but @kdy1 bisected this commit to a null pointer assertion error in napi: https://vercel.slack.com/archives/C03EWR7LGEN/p1730901839682439?thread_ts=1730899709.760659&cid=C03EWR7LGEN Reverting until I can repro and root cause. Closes PACK-3402
-
Niklas Mischkulnig authored
Previously, this ignore comment was not respected by Turbopack ```js export function foo(plugin) { return require(/* turbopackIgnore: true */ plugin) } ``` - Read ignore comments in analyzer test runner for generating `resolved-effects.snapshot` - visit exported declarations when collecting magic comments Closes PACK-3403 -
Niklas Mischkulnig authored
Part of NFT ~~Dynamic requests such as `require("./"+ something)` often match too many files. If we cannot process a matched file with the Turbopack rules, then it's really an unreachable case anyway. This removes the error in that case.~~ This doesn't change the behavior of regular bundling, but makes `primary_modules_raw_iter` not throw the error. - [x] Cleanup API: add the boolean into `.process()`? Or should this be passed differently? - [ ] ~~Should this be a warning instead for user code?~~ -
Ye Zhenrong authored
Title: Fix typo in .gitignore file: change "commiting" to "committing" (single "t" to double "t") Description: This pull request addresses a minor typo in the .gitignore file, where the word "commiting" was corrected to "committing" by changing a single "t" to a double "t". This change ensures that the spelling is consistent with standard English usage. Checklist: I have run pnpm prettier-fix to ensure the code is properly formatted. I have reviewed the [Docs Contribution Guide](https://nextjs.org/docs/community/contribution-guide) to ensure my changes adhere to the guidelines. Related Issues: None Notes: This change does not affect functionality or require additional testing. No additional documentation is required for this typo fix. - Fixes https://github.com/vercel/next.js/issues/72378Co-authored-by:
Sam Ko <sam@vercel.com>
-
Will Binns-Smith authored
The `turbopack/` directory includes miscellaneous JavaScript packages that should be published to npm. This was handled in https://github.com/vercel/turbo/tree/5fc75a38477e9f810bc4ee8aba4c741425fe2342 before Turbopack moved to the Next.js repo. Test Plan: Run workflow manually or with this PR and verify the publish xtask is run. Closes PACK-3390
-
Vercel Release Bot authored
-
vercel-release-bot authored
-
Hendrik Liebau authored
If an ESM module only includes a `'use client'` directive and no exports, which is the case for one of the modules that are included in `@chakra-ui/system` for example, we must not try to add `registerClientReference` statements for this module. This is a regression from #71968. fixes #72358 closes #72359
-
Steven authored
This setting was originally added in PR https://github.com/vercel/next.js/pull/44881 and then removed in PR https://github.com/vercel/next.js/pull/65846 however it seems like it may still be useful in some cases. The [sharp docs](https://sharp.pixelplumbing.com/api-constructor) are not very clear: > false to use random access, true to use sequential reads. Some operations will do this automatically. Let's add it back as an experimental setting so we can measure performance.
-