- 08 Nov, 2024 4 commits
-
-
vercel-release-bot authored
-
Tobias Koppers authored
-
vercel-release-bot authored
-
Alexander Lyon authored
Adds tracing settings to the various contexts that are used for nft There are cases where we need to know whether tracing is useful, this PR sets up that state ahead of the next one(s) which actually take advantage of them. Closes PACK-3377
-
- 07 Nov, 2024 36 commits
-
-
Zack Tanner authored
Need to investigate why this flakes only in Turbopack. Disabling in that context for now.
-
Sam Ko authored
## Why? The current error message when you have have a set `weight: ['400', '700']` and set `axes: ['wdth']` for a variable font is confusing—it should mention to correct your weight property (e.g., `weight: 'variable'` or nothing at all for `weight`). - Fixes https://github.com/vercel/next.js/issues/72413
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? switches the database for persistent caching from lmdb to rocksdb. ### Why? * No preallocated sparse file which cause problems * Compression support * Multiple files instead of a big single file * Better performance
-
Jiachi Liu authored
-
Jam Balaya authored
## Description At #72178, [TypeScript](https://nextjs.org/docs/app/api-reference/config/typescript) docs was moved. So update the old URLs. ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide --------- Co-authored-by:
Zack Tanner <1939140+ztanner@users.noreply.github.com>
-
Jam Balaya authored
# Summary Update [`example.test.ts`](https://github.com/vercel/next.js/blob/canary/test/examples/examples.test.ts) and [`turbopack-dev-examples-manifest.json`](https://github.com/vercel/next.js/blob/canary/test/turbopack-dev-examples-manifest.json) by removing deleted examples. ## Descriptions [examples: cleanup #57845](https://github.com/vercel/next.js/pull/57845) deleted ... - amp-first - amp-story - data-fetch - fast-refresh-demo - hello-world-esm - progressive-render - using-router - with-app-layout - with-env-from-next-config-js - with-loading [updated the example of modularize-imports to utilize the App Router #69771](https://github.com/vercel/next.js/pull/69771) deleted ... - modularize-imports [docs: Add docs on CSP and nonce generation #54601](https://github.com/vercel/next.js/pull/54601/files) deleted ... - styled-jsx-with-csp [Updated the example of with-draft-js to utilize the App Router. #70045](https://github.com/vercel/next.js/pull/70045) deleted ... - with-draft-js [Remove deprecated library example #62813](https://github.com/vercel/next.js/pull/62813) deleted ... - with-react-with-styles [Remove with-reasonml-todo example #62812](https://github.com/vercel/next.js/pull/62812/files) deleted ... - with-reasonml-todo [Remove with-semantic-ui example #62811](https://github.com/vercel/next.js/pull/62811/files) deleted ... - with-semantic-ui [Updated the example of with-vercel-fetch to utilize the App Router. #70069](https://github.com/vercel/next.js/pull/70069) deleted ... - with-vercel-fetch Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Jam Balaya authored
## Description At #72178, [ESLint](https://nextjs.org/docs/app/api-reference/config/eslint) docs was moved. So update the old URLs. ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guideCo-authored-by:
Zack Tanner <1939140+ztanner@users.noreply.github.com>
-
Zack Tanner authored
If a user creates a custom fetch implementation in module scope, the logic to preload entries during `next start` will result in fetch not being patched before the userland implementation. As a result, it won't opt into any caching heuristics from our patched fetch. Fixes #71881 (in addition to the other PR in this stack)
-
Jam Balaya authored
## Description At #68771, [`api-routes`](https://github.com/vercel/next.js/tree/canary/examples/api-routes) example was renamed [`route-handlers`](https://github.com/vercel/next.js/tree/canary/examples/route-handlers). However, [`.gitignore`](https://github.com/vercel/next.js/blob/canary/examples/api-routes/.gitignore) wasn't deleted and a new [`.gitignore`](https://github.com/vercel/next.js/blob/canary/examples/route-handlers/.gitignore) file isn't updated. In addition, some `api-routes` names exist in the other place. That's why I update those. ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guideCo-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Will Binns-Smith authored
This commit is empty as it exists only to trigger the publish workflow: https://github.com/vercel/next.js/blob/e0ce7da7123fdd1047e8b04ff55c403f540e166b/.github/workflows/build_and_deploy.yml#L561 - @vercel/devlow-bench@0.3.3 Closes PACK-3420
-
Alexander Lyon authored
A small PR to start inserting nft on the critical path. This is only enabled in production builds and implements the bare minimum to get NFT outputs by inserting it into the server assets. Followed up by another PR and inserts more hooks / flags elsewhere in the APIs.
-
Will Binns-Smith authored
Following #72360, this adds the necessary options in GitHub Actions to allow npm to publish the packages with provenance (authenticity/signing). Closes PACK-3419
-
Josh Story authored
When we warmup we are trying to fill caches so the actual dev dynamic render can have the right environment for logs to help with debugging. If we have no inflight cache reads/fills happening there is no reason to continue the warmup. This change updates the warmup function to wait for the cacheSignal to indicate it is complete before aborting. This should not alter any program behavior but is observable if you contrive a very slow prefetch request like awaiting a setTimeout inside loading.tsx This allows us to remove the dev only property tracking the prerenderResumeCache in the request store type. I also moved the prerender->render cache conversion into the warmup function since it leaks less about the implementation generatlized the name since it being a cache from a warmup is sort of an implementation detail from the render interface perspective so we'll just call it a devRenderResumeCache. still quite the mouthful
-
Karl Horky authored
- https://github.com/vercel/next.js/pull/72241#discussion_r1832894901 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> ### What? 1. Fix the incorrect statement added in #72241, as per @timneutkens' comment here: - https://github.com/vercel/next.js/pull/72241#discussion_r1832894901 2. Remove the outdated "good to know" section stating that Turbopack requires `mdxjs-rs` and is not compatible with `@next/mdx` ### Why? The docs are currently incorrect ### How? Edit [remark and rehype plugins](https://nextjs.org/docs/app/building-your-application/configuring/mdx#remark-and-rehype-plugins) section on docs page --------- Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-
Josh Story authored
This completes the refactor to eliminate a requestStore scoped around prerenders. Now we only scope requestStore around dynamic renders. If you are prerendering then the workUnitAsyncStorage will only have a prerneder store or undefined. While it is possible to shadow stores because you can enter a cache scope from a render or prerender it generally should never be the case that you enter a prerender from a request or enter a request from a prerender. These are effectively top level scopes. This should not change any program behavior stacked on #72212
-
Sebastian "Sebbie" Silbermann authored
Old assertions hid a lot of issues and didn't really tell us what changed. `TODO(veil)` to make TODOs easier searchable
-
Sebastian "Sebbie" Silbermann authored
-
Niklas Mischkulnig authored
This should have been part of #70998 when the Rust NAPI function were removed Closes PACK-3415
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Niklas Mischkulnig authored
The MDX was invalid after https://github.com/vercel/next.js/pull/72399 causing next-site deploy failures (I'm not entirely sure if this is where the `</AppOnly>` should go, feel free to correct that) Closes PACK-3416
-
Delba de Oliveira authored
Closes: - https://linear.app/vercel/issue/DOC-3695/page-project-structure This PR: - Splits the page between the app/pages and the router docs. - Merge the colocation page from BYA.
-
Benjamin Woodruff authored
Dashmap 6.x claims fairly large performance improvements: > This release contains performance optimizations, most notably 10-40% gains on Apple Silicon but also 5-10% gains when measured in Intel Sapphire Rapids. -- https://github.com/xacrimon/dashmap/releases/tag/v6.0.0 I don't think this means too much for us because while `turbo-tasks` uses dashmap pretty heavily, we spend more time actually doing computations than in `turbo-tasks`, so it's a fraction of a fraction. Still, here's a fairly unscientific (noisy environment, inside a VM) benchmark on my macbook using a microbenchmark that's designed to hit `turbo-tasks` extremely hard (much more so than would happen in realistic scenarios): ``` $ TURBOPACK_BENCH_STRESS=yes cargo bench -p turbo-tasks-memory -- fibonacci/200 Compiling turbo-tasks-memory v0.1.0 (/home/bgw.linux/next.js/turbopack/crates/turbo-tasks-memory) Finished `bench` profile [optimized] target(s) in 2.80s Running benches/mod.rs (target/release/deps/mod-7b9a423ac1e10dce) Gnuplot not found, using plotters backend Benchmarking turbo_tasks_memory_stress/fibonacci/200: Warming up for 3.0000 s Warning: Unable to complete 2000 samples in 5.0s. You may wish to increase target time to 91.9s, or reduce sample count to 100. turbo_tasks_memory_stress/fibonacci/200 time: [33.008 ms 33.108 ms 33.208 ms] thrpt: [605.31 Kelem/s 607.13 Kelem/s 608.97 Kelem/s] change: time: [-2.0573% -1.6309% -1.2221%] (p = 0.00 < 0.05) thrpt: [+1.2373% +1.6580% +2.1005%] Performance has improved. Found 44 outliers among 2000 measurements (2.20%) 2 (0.10%) low mild 38 (1.90%) high mild 4 (0.20%) high severe ``` Any potential improvement to realistic topline numbers are going to be <1% and thus too small to measure (especially since I don't have a low-noise way of measuring Apple Silicon where most of the benefits supposedly are, only x86-64). Closes PACK-3411
-
Wyatt Johnson authored
-
Arfa Ahmed authored
docs(parallel-routes): update 11-parallel-routes.mdx example for modal closing - Updated `11-parallel-routes.mdx` to replace `'...'` with `null` in the `page.tsx` return statement inside the slot for closing the modal when navigating using `Link`. - Also applied the same change in the `default.tsx` file to ensure consistent behavior in the example.   <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Arfa Ahmed authored
docs(route-handlers): add TS/JS `switcher` to `Route Resolution` section in `Route Handlers` (#72222) This PR fixes issue on the [Route Handlers](https://nextjs.org/docs/canary/app/building-your-application/routing/route-handlers) documentation page: Missing switcher for TS codeblock in [Route Resolution](https://nextjs.org/docs/canary/app/building-your-application/routing/route-handlers#route-resolution) section.  <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Tobias Koppers authored
### What? cleanup Closes PACK-3393
-
Jam Balaya authored
## Summary Remove redundant `#` from [error pages](https://github.com/vercel/next.js/tree/canary/errors). ## Description Follow up #52038 and #72263. Updated [template.txt](https://github.com/vercel/next.js/blob/canary/errors/template.txt) and clarified the header deps. Then rewrite as per the template. ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guideCo-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Alexander Lyon authored
### What? This is a 2nd prefactor for adding node-file-trace into turbopack. When implementing this, we have a few options namely: - a) expose turbotrace (node-file-trace-rs) as a napi library and try to insert it into the current codebase - b) expose turbotrace and try to reuse the turbo backend - c) move turobtrace into the rust process and do it in parallel with everything else We chose c We have already ripped out the js code path, this PR nukes the now-orphaned node-file-trace rust binary and napi bindings. ### Why? The crate is unmaintained and probably will not be used in its current form.
-
Mayur authored
This PR updates the link for the Cloudflare Auto Minify feature, as it has been deprecated. Cloudflare now recommends disabling this feature to avoid potential issues. The link and related references have been modified to reflect this update and ensure accurate information for users. Co-authored-by:Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Jonas Aschenbrenner authored
Related to https://github.com/vercel/next.js/discussions/72424. I wasn't able to test if the added "Terminal" switcher works, because I don't know how to run the docs locally. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Donny/강동윤 authored
### What? Add an option to disable SWC minfiier for turbopack builds. ### Why? Disabling minification was useful for debugging and @sokra suggested adding it as an option under `experimental.turbo`. ### How? Closes PACK-3371
-
Donny/강동윤 authored
### What? ### Why? ### How? Closes NEXT- Fixes #
-
Benjamin Woodruff authored
Noticed while looking through our lockfile that we were pulling in an extra version of clap because of this old version of criterion. Clap (particularly these older versions) is a pretty notoriously heavy crate, though we'd only need to compile it when building the benchmark targets. Tested with: ``` TURBOPACK_BENCH_STRESS=yes cargo bench -p turbo-tasks-memory scope_stress ``` Closes PACK-3407
-
Vercel Release Bot authored
This auto-generated PR updates font data with latest available
-