- 26 Feb, 2025 36 commits
-
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Zack Tanner authored
When you disable the dev indicator, either with `devIndicators: false` or clicking the hide button, we still show a minimized version so you can open up the error overlay. That version should also be dismissible within the current browser session. https://github.com/user-attachments/assets/bbf114c1-2c73-4051-8fbc-dbd93acb7f64
-
Terry Sutton authored
-
Jiwon Choi authored
### Why? Since the docs button can link to related React docs, rephrase the title to "related documentation" instead of "related Next.js docs".
-
PapatMayuri authored
This PR updates the remove-console example for using the App Router. Here are the changes that have been made: - I renamed the pages folder and moved it to the app folder. - Added the layout.tsx file as part of the App Router. - Updated the package.json file. CC: @samcx --------- Co-authored-by:
MayuriPapat25 <mayuri.papat@qed42.com> Co-authored-by:
samcx <sam@vercel.com>
-
Sam Ko authored
## Why? We should clarify that React will **not** attempt to patch mismatched text content when using `suppressHydrationWarning`. - Related: https://github.com/reactjs/react.dev/pull/7651 - x-ref: https://github.com/vercel/next.js/discussions/75890
-
Jude Gao authored
**Test** Generate a prod build, and search `AppDevOverlayErrorBoundary` in the build output. --- Before the change, `main-app` has an occurrence of `AppDevOverlayErrorBoundary`.  After the change, there should be 0 occurrences: 
-
Hendrik Liebau authored
-
Jiachi Liu authored
-
Jiwon Choi authored
### Why? The Node.js icon's gradient was breaking when opening the preferences tab. It is because they shared the same `clipPath` id as `#a`. ### How? Modified the SVG ids unique by adding a prefix of their filename and what they're for. ### Before https://github.com/user-attachments/assets/842e8b0b-975f-424c-b867-675df57e4f4c ### After https://github.com/user-attachments/assets/03292fae-1dcd-4d1f-a8b0-8edb98f14aee
-
Andrew Clark authored
The result of certain kinds of prefetches may depend on the current URL at the time it is initiated. This is true if for links that are intercepted, or links that are prefetched using a dynamic request (e.g. `prefetch={true}`). So, whenever the location changes, we should re-prefetch all the links using the updated value. In most cases, this will not result in any new network requests — only if the prefetch result actually varies on one of these inputs. For similar reasons, we also re-prefetch links whenever the client cache is revalidated by a Server Action. As part of the implementation, we must be able to enumerate over all the currently visible links. I've added a Set to track this. -
Hendrik Liebau authored
Follow-up fix for #76130. This avoids unnecessary calls to the tags service when no tags are used.
-
Andrew Clark authored
This implements Next's scroll-to-new-page behavior in the Segment Cache. The LayoutRouter expects an array of segment paths that represents every page in the new route tree. In the old implementation, this is generated by the `generateSegmentsFromPatch` function. In the new implementation, I've chosen to generate this array during the main tree traversal that happens in `startPPRNavigation`. As a future improvement, we should use the same segment path type that we use to access Segment Cache entries; there's no reason to have two representations of the same concept.
-
JJ Kasper authored
When configuring a body with `NextRequest` in node runtime without the `duplex: 'half'` option it can throw an error un-necessarily since it's an extension of the node `Request` instance. This auto-configures `duplex: 'half'` when using `NextRequest` for easier migration from edge -> node runtime for middleware. ```sh TypeError: RequestInit: duplex option is required when sending a body. at new Request (/opt/rust/undici-runtime.js:40:31096) ``` x-ref: [slack thread](https://vercel.slack.com/archives/C07LQPFERGF/p1740490607381379) -
Zack Tanner authored
Uses `label` rather than `h2` for preference options for better accessibility.
-
JJ Kasper authored
This aims to avoid the below error with globally installing `turbo` with `npm` by using `pnpm dlx` the same as we are for the DataDog CLI. ```sh Run npm i -g turbo@2.3.3 && node ./scripts/pull-turbo-cache.js x86_64-unknown-linux-musl npm error code ENOTEMPTY npm error syscall rename npm error path /root/.local/share/fnm/node-versions/v[18](https://github.com/vercel/next.js/actions/runs/13537303233/job/37831195809#step:15:19).20.4/installation/lib/node_modules/turbo ``` x-ref: [slack thread](https://vercel.slack.com/archives/C04KC8A53T7/p1740004625721209)
-
Jiwon Choi authored
Adjusted them to pass WCAG color contrast AAA.
-
Zack Tanner authored
- Updates the `devIndicators` documentation to reflect the new API - Removes an outdated screenshot for explaining how to use the Node.js inspector -- the image itself wasn't adding much clarity and having to keep it in sync with UI updates isn't ideal. Closes DOC-4281 Closes DOC-4282
-
Jiwon Choi authored
### Why? The disabled button was hard to distinguish from clickable buttons before hovering. | Light | Dark | |--------|--------| |  |  | Closes NDX-917
-
Jiwon Choi authored
It's ignore-listed. ```diff - Ignored-listed + Ignore-listed ```  x-ref: https://developer.chrome.com/docs/devtools/settings/ignore-list
-
Jiachi Liu authored
-
Artem Zelenov authored
Co-authored-by:Jiachi Liu <inbox@huozhi.im>
-
Hendrik Liebau authored
-
Hendrik Liebau authored
The test was moved out of `failed` in #76472, but still fails with Turbopack and React 18.3.1. For posterity: Known failed tests are excluded [here](https://github.com/vercel/next.js/blob/91e61592a3137ad3bcc67f876f3e5eac8e51d7e9/test/get-test-filter.js#L81). Running React 18 tests for the update PRs like #76472 is addressed in #76544. closes #76535
-
Zack Tanner authored
Uses a dedicated icon rather than showing the icon corresponding with the system value.  
-
Zack Tanner authored
Forgot to remove this -- since the custom select hover state is styled by the parent, we don't want hover effects on the select itself.
-
vercel-release-bot authored
-
Zack Tanner authored
Adds user preferences for: - Toggling theme (localstorage) - Position (localstorage) - Hiding the overlay (existing dev session heuristic) https://github.com/user-attachments/assets/0f08ce66-4107-4751-80d3-a42d3315966a  
-
Jiwon Choi authored
-
Zack Tanner authored
Fixes a typo
-
Vercel Release Bot authored
This auto-generated PR updates the production integration test manifest used when testing Turbopack.
-
Vercel Release Bot authored
This auto-generated PR updates the development integration test manifest used when testing Turbopack.
-
Janka Uryga authored
Split out of #76184 because it got a bit involved and i want to do it in isolation. Removes dead code from the forked implementations of Form for app and pages dir. There's some shared utils but not much. Mostly involves removing code for prefetching and server actions from the pages implementation. Also took this opportunity to fix some stuff for pages: - improve error messages, previously they were linking to `/app/` docs - use `React.forwardRef`: technically, you can use React <19 in pages, where `forwardRef` is still needed
-
Benjamin Woodruff authored
refactor(CI): Assign tests to groups round-robin instead of sequentially when we don't have timings (#76462) Our CI runs tests in parallel across multiple groups. We want test groups to all take similar amounts of time to decrease overall latency, and to reduce the chance of test group timeouts in CI. There's logic here to assign intelligently to groups based on previous test timing information, but if there's no timing information for whatever reason (e.g. we don't currently use timings for rspack/turbopack integration tests), then we were assigning them to groups sequentially. Because tests with similar paths tend to have similar performance characteristics, it's better to assign every nth test to each group, similar to round-robin assignment.
-
Will Binns-Smith authored
Test Plan: `pnpm test-dev-rspack test/development/acceptance/error-recovery.test.ts`
-
- 25 Feb, 2025 4 commits
-
-
Sebastian "Sebbie" Silbermann authored
-
cassian-goode authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
Sam Ko <sam@vercel.com>
-
Sachin Hegde authored
Small grammatical improvement on the cookieStore API docs. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
Sam Ko <sam@vercel.com>
-
Boyan Bratvanov authored
Fix typo. Co-authored-by:Sam Ko <sam@vercel.com>
-