- 07 Jan, 2025 21 commits
-
-
vercel-release-bot authored
-
Manoj M S authored
chore(examples): updated the example of with-styled-components-rtl to utlize the App router (#74180) This PR updates the with-styled-components-rtl example to use the App Router. Here are the changes that have been made: - Renamed the `pages` folder to the `app` folder. - Converted the `index.tsx` to `page.tsx` file as part of the App Router. - Created `layout.tsx` in app directory, merging functionality from both ` _app.tsx` and `_document.tsx`: - `ThemeProvider` setup from `_app.tsx` - `RTL` and `styled-components` setup from `_document.tsx` - Created `lib/registry.tsx` for styled-components server-side rendering and moved styled-components server-side rendering logic from `_document.tsx` - Updated the package.json file. The following actions were performed as part of this PR: - Ran `pnpm prettier-check` with no issues found. - Executed the `pnpm check-examples` script. CC: @samcx --------- Co-authored-by:samcx <sam@vercel.com>
-
Sam Ko authored
## Why? It turns out the `react/self-closing-comp` rule is not necessary to cover for JSX tags that are not properly closed.
-
Vercel Release Bot authored
-
Manoj M S authored
This PR updates the with-react-jss example to use the App Router. Here are the changes that have been made: - Renamed the `pages` folder to the `app` folder. - Converted the `index.tsx `to `page.tsx` file as part of the App Router. - Created `layout.tsx` in app directory, merging functionality from both `_app.tsx` and `_document.tsx`: - Wraps content with `StyledComponentsRegistry` - Created `app/registry.tsx` for JSS setup: - Moved JSS Provider and SheetsRegistry from _document.tsx - Moved style cleanup logic from _app.tsx - Handles server-side style generation - Updated the package.json file. The following actions were performed as part of this PR: - Ran `pnpm prettier-check` with no issues found. - Executed the `pnpm check-examples` script. CC: @samcx --------- Co-authored-by:samcx <sam@vercel.com>
-
Wyatt Johnson authored
Prerender errors triggered during development should be rethrown by the `unstable_rethrow` api. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Jiwon Choi authored
This PR allows `.stories.tsx` files to be viewed as nested when they share the same filename with `.ts` and `.tsx`, similar to the `.test.` files. https://github.com/user-attachments/assets/8e280369-984d-4d33-b91a-392b3c18b5d9
-
Will Binns-Smith authored
While many use case-specific graphs belong in Next.js, this primitive should be kept in Turbopack as it will be used for other core usecases like chunking. Test Plan: CI
-
JJ Kasper authored
This ensures we don't lose tags added to a page before `notFound()` is called as otherwise a fetch on the page that has been revalidated won't be able to be applied correctly if dropped from a `notFound()` call. This was broken recently in the refactors of handling rendering in app-render as it worked correctly in `v14`. x-ref: [slack thread](https://vercel.slack.com/archives/C04V3E1UYNQ/p1736200963684869) Closes https://linear.app/vercel/issue/ENET-1381 Closes https://linear.app/vercel/issue/NEXT-3946 Closes https://github.com/vercel/next.js/issues/73973 Closes https://github.com/vercel/next.js/issues/66540
-
vercel-release-bot authored
-
Tim Neutkens authored
## What? Skips the websocket ping for Turbopack. Currently the ping is only used by the webpack integration to keep track of "active" entrypoints that are still being viewed. Entrypoints that are no longer viewed will be disposed from the webpack compiler. With Turbopack this mechanism is not used and it keeps the entrypoints around. Removing the ping makes the websocket events easier to monitor and read while debugging. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Janka Uryga authored
this comment is a useful explanation, but was accidentally lost in #52846, when a bunch of loader stuff was unified between webpack and turbopack see: https://github.com/vercel/next.js/pull/52846/files#diff-173d1bc6424869c0d3c43f8fba124186427d03e5bd056587f141886a0075b1d3L699-L700
-
Jiwon Choi authored
This PR added style for Toolbar buttons, and moved files to `Errors/error-overlay-toolbar`. Will follow up with TBD: - Replace the Node.js button with the "Debugging" Icon - Add Docs Button? ### Light  ### Dark  Closes NDX-601 Closes NDX-602
-
Tobias Koppers authored
### What? updates shadow-rs dependency, which fixes the build.rs caching problem: https://github.com/baoyachi/shadow-rs/pull/195/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R40 Also prints the git version during the build
-
Jiachi Liu authored
-
Janka Uryga authored
Fixes #74062 (`jotai` ran into this error [when they added `"type": "commonjs"` to their package.json](https://github.com/pmndrs/jotai/discussions/2579#discussioncomment-9812492)) > this is a bug in the transform we do when a `'use client'` directive is encountered. I think what's happening is that we're creating a virtual file that uses ESM import/export syntax, but it's called proxy.js (not proxy.mjs), so the `"type": "commonjs" `makes turbopack "correctly" upset at the ESM syntax. https://github.com/vercel/next.js/issues/74062#issuecomment-2555922867 The (slightly kludgy) solution is to use `proxy.mjs` or `proxy.cjs` to force the module format, bypassing the issue where `proxy.js` changes meaning depending on `package.json#type`.
-
Noel Kim (김민혁) authored
-
Vercel Release Bot authored
-
Sam Ko authored
## Why? Updating from `STALE_TOKEN` to `RELEASE_BOT_TOKEN` because `STALE_TOKEN` has expired.
-
Sam Ko authored
## Why? - Update React in reproduction example templates to stable v19 - Switch `.ts` for `next.config` - Fixes https://github.com/vercel/next.js/issues/74422
-
Vercel Release Bot authored
This auto-generated PR updates font data with latest available
-
- 06 Jan, 2025 18 commits
-
-
vercel-release-bot authored
-
Jude Gao authored
## What? Added accessibility improvements to the error overlay voting buttons by making their icons properly hidden from screen readers. ## Why? To enhance accessibility for users relying on screen readers by preventing redundant icon announcements while maintaining the clear button labels "Mark as helpful" and "Mark as not helpful". ## How? - Added `ComponentProps<'svg'>` type to ThumbsUp and ThumbsDown components to allow passing SVG attributes - Spread props to SVG elements to enable aria attributes - Added test coverage to ensure icons have `aria-hidden="true"`
-
Jude Gao authored
Improved a11y (aria-live, aria-label) and simplified loading/error state to prevent double firing when feedback buttons get clicked multiple times while loading.
-
Abhijeet Singh authored
### Improving Documentation I was just upgrading from Next.js v13 to v14 following this guide: https://nextjs.org/docs/app/building-your-application/upgrading/version-14 npm installation throws the below error: ```sh npm error code ERESOLVE npm error ERESOLVE unable to resolve dependency tree npm error npm error While resolving: blog@0.0.8 npm error Found: react@19.0.0 npm error node_modules/react npm error react@"19.0.0" from the root project npm error npm error Could not resolve dependency: npm error peer react@"^18.2.0" from next@14.2.21 npm error node_modules/next npm error next@"14.2.21" from the root project npm error npm error Fix the upstream dependency conflict, or retry npm error this command with --force or --legacy-peer-deps npm error to accept an incorrect (and potentially broken) dependency resolution. ``` The react version for Next.js v14 should be pinned to react@18.
-
Jude Gao authored
Fast-follow to @acdlite's comment https://github.com/vercel/next.js/pull/74473#discussion_r1902087835
-
T authored
-
Jiachi Liu authored
-
Jude Gao authored
We're adding a new feature to the error overlay that allows developers to rate the current error message. Developers can rate the error message by clicking on the thumb up or down icon in the error overlay footer. This pull request adds the click handler for the error rating buttons. When the buttons are clicked, the click handler calls a previously implemented internal API endpoint. The endpoint is connected to the usual Next.js Telemetry. To test the UI, run `pnpm storybook` and go to http://localhost:6006/?path=/story/erroroverlaylayout--default. https://github.com/user-attachments/assets/6daf6e64-e8bb-4e5e-b282-082086f1e529
-
Jiwon Choi authored
This PR added the error type label. ### Light  ### Dark  Closes NDX-607
-
Jiwon Choi authored
This PR separated the error message component. ### Light  ### Dark  Closes NDX-608
-
Sebastian "Sebbie" Silbermann authored
i.e. the stack will now include the actual test util in the test that failed not just a single frame from util internals. New stack for e.g. a failed `waitForElementByCSS`: ```diff ● app dir - navigation with Suspense in nested layout › resolves data after client navigation to a nested layout with Suspense page.waitForSelector: Timeout 1000ms exceeded. Call log: - waiting for locator('[data-testid="nested-resolved"]') 423 | return this.chain(() => { 424 | return page > 425 | .waitForSelector(selector, { timeout, state: 'attached' }) | ^ 426 | .then(async (el) => { 427 | // it seems selenium waits longer and tests rely on this behavior 428 | // so we wait for the load event fire before returning at waitForSelector (lib/browsers/playwright.ts:425:10) + at BrowserInterface.chain (lib/browsers/base.ts:17:23) + at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:423:17) + at Object.waitForElementByCss (e2e/app-dir/navigation-layout-suspense/navigation-layout-suspense.test.ts:17:19) ``` Ideally we'd just display the stack starting by `at Object.waitForElementByCss` but that would mean passing a sync error from each `this.chain` callsite and this may actually hide internal errors and I'm not sure of the interaction with actual chaining e.g. `browser.waitForElementByCSS().click().waitForElementByCSS()`. This is improves readability of CI errors by a lot with minimal changes. -
Jiachi Liu authored
### What When there's a async client component used in the component tree, it's not available to display the component stack whether you enable react owner stack or not. It's likely a bug in `React.captureOwnerStack`. We update the existing test here to ensure the error is surfaced when the mistake is comitted. We also assert on the snapshots of component stack but leave it as a TODO now since the component stack of errored component (the async client component) is not displayed. Related to NDX-475
-
-
Delba de Oliveira authored
Closes: https://linear.app/vercel/issue/DOC-3906/page-mutating-data --------- Co-authored-by:
Lee Robinson <me@leerob.io>
-
Wyatt Johnson authored
This breaks a few functions down that were using array methods before to use for loops instead. Reducing the amount of functions created should improve performance a tiny bit. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Jiachi Liu authored
-
Jiachi Liu authored
-
Vercel Release Bot authored
-
- 03 Jan, 2025 1 commit
-
-
vercel-release-bot authored
-