- 16 Feb, 2025 2 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
### What For PPR deployment we shouldn't disbale the PPR config inside of Next.js but let infra determine when to pass down the PPR cache. If we disable it inside Next.js it could lead to other error when the infra tries to get the cache in dynamic-resume.
-
- 15 Feb, 2025 2 commits
-
-
vercel-release-bot authored
-
Sebastian "Sebbie" Silbermann authored
-
- 14 Feb, 2025 24 commits
-
-
vercel-release-bot authored
-
Lachlan Campbell authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md --> While this behavior is not clearly a bug, when I'm debugging print styling in Next.js, seeing the Next.js dev overlay UI is distracting and unnecessary: <img width="766" alt="image" src="https://github.com/user-attachments/assets/e7a5420d-2f17-4286-8f98-7db33d23dddb"> A few lines of CSS can hide it in that context only. I don't think this CSS rule needs an integration test, but let me know if so. --- **Jiwon:** Since the dev indicator will always be visible, it is a good default to hide it when printing. --------- Co-authored-by:
devjiwonchoi <devjiwonchoi@gmail.com>
-
Jiwon Choi authored
### Why? Since it may conflict with other utils or the app's shortcuts, we disable it until we find a good way to solve the issue. | Light | Dark | |--------|--------| |  |  | Closes NDX-835
-
Boris Besemer authored
-
Josh Story authored
root params exposes request data and thus must be disallowed from caches unless the cache also implicitly keys the entries on the root params values. For now we will simply disallow this pattern. we will implement a strategy in the future which will allow root params to be called from inside a cache scope once we can sufficiently key the cache entries by the root params values read. The same problem will arise with variants in the future so we will eventually need to implement support The implementation removes rootParams from the workStore. This is an invitation to accidentally leak request data into cache scopes. Now rootParams are conveyed on the workUnitStore and the cache store types don't define it. closes NAR-89
-
Jiwon Choi authored
### Why? There's a width mismatch for symbols used in Geist Mono font font-weight over 600. | Before | After | |--------|--------| |  |  | ### How? Use font-weight `500` for bold for now. Closes NDX-821
-
Jiwon Choi authored
The tooltip from the `title` property was missing when the docs button was disabled. Closes NDX-798 --------- Co-authored-by:Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>
-
Jiwon Choi authored
This PR added style for no version info found. | _______ | Before | After | |--------|--------|--------| | Light |  |  | | Dark |  |  |
-
Niklas Mischkulnig authored
A refactor to use less `Box<dyn ModuleReference>` The snapshots changed because this changes the order of references to the internal parts (they are now in order as opposed to arbitrary order) The next PR will be the one leverage this to remove `CodeGenerateable` from `EsmAssetReference`
-
Vercel Release Bot authored
Co-authored-by:Sebastian Sebbie Silbermann <sebastian.silbermann@vercel.com>
-
Jiwon Choi authored
-
Niklas Mischkulnig authored
Get rid of `CodeGenerateable` for `EsmExports` and all references, except for `EsmAssetReference`, which unfortunately represents 99% of all references, but is also the most complicated one (esp regarding order and tree shaking). ``` testing against 0293c96cf32 canary 71d8bfcc 14.8gb 529.67s user 81.57s system 883% cpu 1:09.18 total mischnic/codegen-fewer-tasks 72eba1ead2 14.8gb 533.13s user 82.01s system 874% cpu 1:10.32 total mischnic/codegen-fewer-tasks don't store twice 14.6gb 529.85s user 82.35s system 875% cpu 1:09.90 total ```
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? This function is only called chunk_group and cells a big list of chunk items
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? * try to avoid cloning AST during code generation, pass final_read_hint * fix tree shake ident on code generation
-
vercel-release-bot authored
-
Tobias Koppers authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tobias Koppers authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tobias Koppers authored
### What? * add tracing to turbopack-tests * remove env-filter from turbopack-cli * add empty feature list
-
Tobias Koppers authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tobias Koppers authored
### What? Return the correct ident() from tree shaken modules
-
Tobias Koppers authored
### What? There are cases where two write tasks write to the same file. This can happen e. g. when two different image source files with the same content are used and end up with the same content hashed filename. But since dependency tracking is disabled for one off builds, this results in an invalidation of the first write task when the second write task effect is executed. And an invalidation will panic in dependency-tracking-disabled mode. This change only invalidates other write tasks when they write a different content and keeps writes with the same content intact. This should avoid the panic as no task is invalidated.
-
Tobias Koppers authored
### What? * fix active counting when balancing edges * release lock correctly to avoid a deadlock
-
- 13 Feb, 2025 12 commits
-
-
Jiachi Liu authored
### What This PR forcedly disables the streaming metadata on vercel deployment when PPR is enabled on the target route. There're still some work need to be done on infra side, so we only let non-PPR mode and self-hosting PPR (mostly local testing) be controlled by `streamingMetadata` flag. Once the blocker is gone, then we can re-enable it
-
Lee Robinson authored
Follow up from https://github.com/vercel/next.js/pull/75750.
-
vercel-release-bot authored
-
Ícaro Guerra authored
-
Sebastian "Sebbie" Silbermann authored
-
Benjamin Woodruff authored
Looks like this was overlooked when updating our CI configs to work around the recent corepack issue. https://github.com/vercel/next.js/actions/runs/13279886936/job/37075996177 
-
Jiwon Choi authored
### Why? Since the `hello-world` app is also used for the default debugging app, I used to add a config when testing a relevant feature and removed it after. Hence, just added a config. https://github.com/vercel/next.js/blob/959a31214341d1ea00c0f00bcc8fc6f6a9c7b6fc/.vscode/launch.json#L11
-
Jude Gao authored
### What? When you enable both Turbopack, and the new dev overlay, you will see that the dev overlay is frozen and the network tab shows that it is fetching the stack frames API indefinitely. ### Why? During our migration to the new development overlay, we implemented a refactor to ensure that logic for handling runtime errors is executed consistently, even in the case of build-time errors. This change involves invoking the getErrorByType function for build errors. However, this function attempts to retrieve stack frames for the build-time error, inadvertently triggering Turbopack to initiate a rebuild. Once Turbopack completes the rebuild process, it dispatches a Hot Module Replacement (HMR) event to indicate the presence of a new error. This event prompts getErrorByType to attempt fetching the stack frames again, which in turn causes Turbopack to rebuild once more. This creates an endless loop of rebuilding and error signaling. You can repro it by running ``` __NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY='true' TURBOPACK=1 pnpm testonly-dev test/development/acceptance-app/editor-links.test.ts ``` with the test file change in this PR. (Important to add that. Otherwise the test would still complete successfully) ### How? Do not run the runtime error logic for build errors. Closes NDX-816
-
Wyatt Johnson authored
This handles when the rewrite destination is not a valid URL (as it's a pattern anyways, containing characters like `:` for patterns like `:subdomain.google.com` which wouldn't be valid). This uses the existing escaping behaviour to extract the url parts. Fixes https://github.com/vercel/next.js/issues/75956
-
Jiachi Liu authored
-
Jiwon Choi authored
The test failed since https://github.com/vercel/next.js/pull/75882 was merged with a lot of test changes, but https://github.com/vercel/next.js/pull/75768 didn't rebase.
-
Wyatt Johnson authored
This fixes a bug with the experimental PPR debugging where it previously always failed in production because the hydration script was always invoked even when the stream was terminated early due to the debugging state. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-