- 23 Feb, 2025 16 commits
-
-
vercel-release-bot authored
-
Hendrik Liebau authored
This allows us to better track fixes and changes to the build output tree view. To avoid flakiness, and needing to update the snapshots frequently, I've stubbed to file sizes and omitted the chunks from the snapshotted output. Because those details affect the column sizes, we can't just blank them out when reading the CLI output (which was [my first approach](https://github.com/vercel/next.js/pull/76342/commits/d7ee6b46f651aad61e4981936456e2f7558c2f7e)). So instead, we already stub them during the generation of the output if `__NEXT_PRIVATE_DETERMINISTIC_BUILD_OUTPUT` is defined.
-
Jiwon Choi authored
This PR added the README for the dev overlay for future contributors. [**View Preview**](https://github.com/vercel/next.js/blob/9136b280a3e194b81c1ea9e4aa7236eeb895a843/packages/next/src/client/components/react-dev-overlay/README.md) Closes NDX-656 --------- Co-authored-by:
Lee Robinson <lee@leerob.com>
-
Zack Tanner authored
Currently when you select "Hide Dev Tools", if an error comes in you won't see the error indicator anymore. This follows the same treatment as when the indicator is disabled in next config, which is to only show you errors, and not the regular indicator/popover.
-
Jiwon Choi authored
-
Jiachi Liu authored
-
Jiachi Liu authored
### What In non-PRR mode, we keep the original behavior that metadata is blocking but stream the rest. Previously we also do the full dynamic rendering for both non-PPR and PPR pages, which is required for PPR pages to discard the postpone cache but not necessary for non-PPR pages. This PR align the behavior as before. Closes NDX-881
-
Jiwon Choi authored
-
Sebastian "Sebbie" Silbermann authored
-
Jiwon Choi authored
### Why? The types of unit tests and stories were included in the package. Exclude them by using `tsconfig.declaration.json` when `pnpm run types` during production build. | Before | After | |--------|--------| |  |  | Closes NDX-747 --------- Co-authored-by:
Sebastian Sebbie Silbermann <sebastian.silbermann@vercel.com>
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Jiwon Choi authored
### Why? The error overlay's bottom stack count was wrong. ### Before https://github.com/user-attachments/assets/24f09416-38a9-4b47-8a59-269e9855f851 ### After https://github.com/user-attachments/assets/9f0dff66-e40c-4e68-afda-d149d1b8d895 Closes NDX-827 --------- Co-authored-by:
Zack Tanner <1939140+ztanner@users.noreply.github.com>
-
Niklas Mischkulnig authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Niklas Mischkulnig authored
Pass the `ChunkGroupType::{Entry, Evaluated}` to the graph. We will need this information for the `ChunkGroup`s
-
- 22 Feb, 2025 10 commits
-
-
vercel-release-bot authored
-
Will Binns-Smith authored
Passes an additional 4 tests for Rspack. Rspack error messages included trailing whitespace when written to the DOM, so these are stripped out.
-
Jiwon Choi authored
-
Jiwon Choi authored
### Why? When clicking the dialog and tabbing, the `<a>` tag inside the Terminal component was focusable but was missing an outline. ### How? To have a unified outline for the focused `<a>` tag, use the css var `--focus-ring`. This gives a unified style and also fixes this issue. ### Before https://github.com/user-attachments/assets/7a3b7e45-c9e8-42f5-84fb-9ac4cf203d24 ### After https://github.com/user-attachments/assets/6309f153-1fe2-4087-a81e-49ff0e51e3fd Closes NDX-856
-
Jiwon Choi authored
This PR removed the unused base style.
-
Jiwon Choi authored
### Why? Our internal comments in the css literal templates, are being shipped to the client along with the dev overlay, which is a bad practice. https://github.com/vercel/next.js/blob/7f5a1d39e8a94b0b424ef9538be9dd2802e6ccb6/packages/next/src/client/components/react-dev-overlay/ui/components/errors/error-overlay-bottom-stack/index.tsx#L104-L107 ### How? Added minifying css util that includes removing comments. | Before | After | |--------|--------| |  |  | - Renamed `noop` util to `css`. - Added minifying in `css` util. - Added unit test for `css` util. - Removed unnecessary `css` util usage as it's only required for the entry point (where it injects to `<style>` tag). - Updated README (will follow up to improve). Note: This loses the benefit of VS Code extension `styled-components.vscode-styled-components`, so dropping it from recommendations. | Before | After | |--------|--------| |  |  | Closes NDX-750 Closes NDX-839
-
Jiachi Liu authored
-
강노아 authored
### What? Restore the missing Cursor editor case in dev-overlay code that was accidentally dropped during code migration. ### Why? The Cursor editor support (for the "Open in Editor" feature when clicking error line numbers) that was previously added in PR (#76151) was inadvertently omitted during the code migration process in commit [b20b272](https://github.com/vercel/next.js/pull/76291/commits/b20b272c1b3206de827905d21865381c499f487f). This case was originally present around line 186 but was accidentally dropped during the dev-overlay restructuring. ### How? Add back the missing 'Cursor' case in launch-editor.ts to ensure error line numbers can properly open in Cursor editor:
-
Jiachi Liu authored
The merge timing causes the test failing, update the new property for new test
-
Jude Gao authored
This was a style regression: We wanted to use a grey'd out color to indicate building and the full brightness one for rendering. Original PR before regression: https://github.com/vercel/next.js/pull/74833
-
- 21 Feb, 2025 14 commits
-
-
Jiachi Liu authored
-
vercel-release-bot authored
-
Sebastian "Sebbie" Silbermann authored
-
wangsijie authored
### What? Add [Logto](https://logto.io) to the auth libraries list. ### Why? Logto has official Next.js SDK with a well documented quick start guide. Logto is an open-source Auth0 alternative for modern apps and SaaS products, supporting OIDC, OAuth 2.0 and SAML open standards for authentication and authorization. ### How? Co-authored-by:
Zack Tanner <1939140+ztanner@users.noreply.github.com>
-
Zack Tanner authored
This looks like leftover code from when we were running a multi-process architecture.
-
Jiachi Liu authored
-
Sebastian "Sebbie" Silbermann authored
-
JJ Kasper authored
This aims to alleviate an npx cache issue occurring causing datadog script to fail to execute with `'datadog-ci' is not recognized as an internal or external command` x-ref: https://github.com/vercel/next.js/actions/runs/13455042696/job/37598937307#step:36:44
-
Andrew Clark authored
This null check was added as an incidental change in #75981 but I'm not convinced it's actually necessary. Even if it is, it needs to be fixed in the caller, because it means the type is incorrect. I have a suspicion that it was added before the fix to `useMergedRef` landed here: https://github.com/vercel/next.js/pull/75088 If it turns out that this argument is still sometimes `null`, it suggests that there's a bug in `useMergedRef` and we need to fix it there.
-
vercel-release-bot authored
-
Tobias Koppers authored
### What Use a statistical calculation to determine if it's worth to merge chunks or not. And prioritize by that.
-
Tobias Koppers authored
### What? Instead of not looking for further merge candiates when the min chunk size has reached, continue to merge with small chunks that are in all of these chunk groups.
-
Jiachi Liu authored
-
Tobias Koppers authored
### What? only merge small chunks when they occur in multiple overlapping chunk groups. All unmergable small chunks will go into a leftover chunk which combines all non-shared chunks.
-