- 24 Feb, 2025 23 commits
-
-
vercel-release-bot authored
-
loopy authored
### What This PR fixes a duplicate description of the `scroll` parameter in the [Link component API documentation](https://nextjs.org/docs/pages/api-reference/components/link#disable-scrolling-to-the-top-of-the-page). ### Why The section describing the `scroll` parameter included duplicated information, which might confuse readers. Removing the redundancy improves clarity and ensures the documentation remains concise. ### Changes - Removed the duplicate `scroll` parameter description in the `Link` component documentation. Co-authored-by:
loopy-lim <loopy@jnu.ac.kr> Co-authored-by:
Sam Ko <sam@vercel.com>
-
Jam Balaya authored
## Description Some people are baffled by [JavaScript files with JSX code](https://nextjs.org/docs/community/contribution-guide#language-and-filename) in [contribution guide](https://nextjs.org/docs/community/contribution-guide) due to mismatch the extension.  Therefore, add the note like the below attention. > [!NOTE] > - Make sure to use **`js`** extension with **JSX** code at JavaScript files. > - For example, ```jsx filename="app/layout.js" ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide Closes #74175 Co-authored-by:
Sam Ko <sam@vercel.com>
-
Jiachi Liu authored
-
JJ Kasper authored
Continuation of https://github.com/vercel/next.js/pull/75624 this adds the same support for turbopack and enables the related test suites.
-
Michael Wenzel authored
-
vercel-release-bot authored
-
Vercel Release Bot authored
-
Sebastian "Sebbie" Silbermann authored
-
Janka Uryga authored
This PR attempts to add typechecking to the server actions tests fixtures in order to add an extra layer of validation against compiler bugs. (there's a couple!). Unfortunately the tests were pretty loosey-goosey around undefined variables, so there's a lot of noise in adding missing imports for `Button` etc. i tried to call out the interesting changes via PR comments. Note that this is a bit limited, because we often have to rely on typescript inferring some sensible types for the outputs -- see e.g. the issue with `24/output.js` mentioned below. In case typescript can't infer sensible types for something, we can just exclude that file from checking. this seems to be pretty rare, so i think it's okay. We should also definitely add typechecking to the other fixture folders, but this PR is already big, so i want to do that piecemeal. ### TODO - [x] invoke the typechecker in CI - added a `check-compiler-fixtures` script that runs as part of `types-and-precompiled` (open to feedback, maybe this isn't the right place?) - [x] figure out how to make `tsc` error on `crates/next-custom-transforms/tests/fixture/server-actions/server-graph/51/output.js`, where we're referencing a non-existent variable `$$RSC_SERVER_ACTION_0`. right now, it emits no errors - this is a compiler bug, and i want to catch bugs like this in the future - solution: https://github.com/vercel/next.js/pull/75944 - [x] figure out why `tsc` is complaining about a type mismatch in `crates/next-custom-transforms/tests/fixture/server-actions/server-graph/24/output.js` - we can work around this by loosening the types for `registerServerReference`, but i'd rather we didn't have to do that - this seems to be a bizarre TS behavior where `fn.bind(...)` makes all the params optional in JS files. ignoring this for now
-
Sebastian "Sebbie" Silbermann authored
-
Tobias Koppers authored
### What? Avoid instantiation modules with empty import context. This avoid duplicate modules due to that. add a test case for splitting based on module order.
-
Tobias Koppers authored
### What? When assets are removed from the compilation, they should be treated as not existing again
-
Jiachi Liu authored
-
Jiachi Liu authored
-
Sebastian "Sebbie" Silbermann authored
-
Jiachi Liu authored
-
Sebastian "Sebbie" Silbermann authored
-
Tobias Koppers authored
Turbopack: rename reverse topological to postorder topological, fix async referenced modules (#76429) ### What? * move iter_neighbors into shared file, rename to iter_neighbors_rev * fix async referenced modules by filtering by chunking type * rename reverse topological to postorder topological
-
stefanprobst authored
-
Will Binns-Smith authored
-
Tobias Koppers authored
### What? * Fix pages graph entrypoints * Fix chunk_group_info computation for merged * Fix client_shared_entries in graph * chunk_group_info: continue walking across graphs
-
Donny/강동윤 authored
-
- 23 Feb, 2025 17 commits
-
-
Will Binns-Smith authored
This uses `normalModule.type` to determine the source module’s type rather than accessing a value on `normalModule.parser`, which doesn’t exist with rspack.
-
vercel-release-bot authored
-
Hendrik Liebau authored
This allows us to better track fixes and changes to the build output tree view. To avoid flakiness, and needing to update the snapshots frequently, I've stubbed to file sizes and omitted the chunks from the snapshotted output. Because those details affect the column sizes, we can't just blank them out when reading the CLI output (which was [my first approach](https://github.com/vercel/next.js/pull/76342/commits/d7ee6b46f651aad61e4981936456e2f7558c2f7e)). So instead, we already stub them during the generation of the output if `__NEXT_PRIVATE_DETERMINISTIC_BUILD_OUTPUT` is defined.
-
Jiwon Choi authored
This PR added the README for the dev overlay for future contributors. [**View Preview**](https://github.com/vercel/next.js/blob/9136b280a3e194b81c1ea9e4aa7236eeb895a843/packages/next/src/client/components/react-dev-overlay/README.md) Closes NDX-656 --------- Co-authored-by:
Lee Robinson <lee@leerob.com>
-
Zack Tanner authored
Currently when you select "Hide Dev Tools", if an error comes in you won't see the error indicator anymore. This follows the same treatment as when the indicator is disabled in next config, which is to only show you errors, and not the regular indicator/popover.
-
Jiwon Choi authored
-
Jiachi Liu authored
-
Jiachi Liu authored
### What In non-PRR mode, we keep the original behavior that metadata is blocking but stream the rest. Previously we also do the full dynamic rendering for both non-PPR and PPR pages, which is required for PPR pages to discard the postpone cache but not necessary for non-PPR pages. This PR align the behavior as before. Closes NDX-881
-
Jiwon Choi authored
-
Sebastian "Sebbie" Silbermann authored
-
Jiwon Choi authored
### Why? The types of unit tests and stories were included in the package. Exclude them by using `tsconfig.declaration.json` when `pnpm run types` during production build. | Before | After | |--------|--------| |  |  | Closes NDX-747 --------- Co-authored-by:
Sebastian Sebbie Silbermann <sebastian.silbermann@vercel.com>
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Jiwon Choi authored
### Why? The error overlay's bottom stack count was wrong. ### Before https://github.com/user-attachments/assets/24f09416-38a9-4b47-8a59-269e9855f851 ### After https://github.com/user-attachments/assets/9f0dff66-e40c-4e68-afda-d149d1b8d895 Closes NDX-827 --------- Co-authored-by:
Zack Tanner <1939140+ztanner@users.noreply.github.com>
-
Niklas Mischkulnig authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Niklas Mischkulnig authored
Pass the `ChunkGroupType::{Entry, Evaluated}` to the graph. We will need this information for the `ChunkGroup`s
-