- 26 Feb, 2025 9 commits
-
-
vercel-release-bot authored
-
Zack Tanner authored
Adds user preferences for: - Toggling theme (localstorage) - Position (localstorage) - Hiding the overlay (existing dev session heuristic) https://github.com/user-attachments/assets/0f08ce66-4107-4751-80d3-a42d3315966a  
-
Jiwon Choi authored
-
Zack Tanner authored
Fixes a typo
-
Vercel Release Bot authored
This auto-generated PR updates the production integration test manifest used when testing Turbopack.
-
Vercel Release Bot authored
This auto-generated PR updates the development integration test manifest used when testing Turbopack.
-
Janka Uryga authored
Split out of #76184 because it got a bit involved and i want to do it in isolation. Removes dead code from the forked implementations of Form for app and pages dir. There's some shared utils but not much. Mostly involves removing code for prefetching and server actions from the pages implementation. Also took this opportunity to fix some stuff for pages: - improve error messages, previously they were linking to `/app/` docs - use `React.forwardRef`: technically, you can use React <19 in pages, where `forwardRef` is still needed
-
Benjamin Woodruff authored
refactor(CI): Assign tests to groups round-robin instead of sequentially when we don't have timings (#76462) Our CI runs tests in parallel across multiple groups. We want test groups to all take similar amounts of time to decrease overall latency, and to reduce the chance of test group timeouts in CI. There's logic here to assign intelligently to groups based on previous test timing information, but if there's no timing information for whatever reason (e.g. we don't currently use timings for rspack/turbopack integration tests), then we were assigning them to groups sequentially. Because tests with similar paths tend to have similar performance characteristics, it's better to assign every nth test to each group, similar to round-robin assignment.
-
Will Binns-Smith authored
Test Plan: `pnpm test-dev-rspack test/development/acceptance/error-recovery.test.ts`
-
- 25 Feb, 2025 31 commits
-
-
Sebastian "Sebbie" Silbermann authored
-
cassian-goode authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
Sam Ko <sam@vercel.com>
-
Sachin Hegde authored
Small grammatical improvement on the cookieStore API docs. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by:
Sam Ko <sam@vercel.com>
-
Boyan Bratvanov authored
Fix typo. Co-authored-by:Sam Ko <sam@vercel.com>
-
vercel-release-bot authored
-
Benjamin Woodruff authored
chore(CI): Only update areweturboyet datasets for other bundlers from canary branch results (#76449) #76361 fixes areweturboyet runs for rspack on canary. We should just gather data from canary to avoid any confusion going forward.
-
Jiachi Liu authored
-
Jiwon Choi authored
### Why? When users want to hide the dev indicator, they might be frustrated if it reappears every reload. Hence, make a default to hide it for the current server session or a day. Closes NDX-890 --------- Co-authored-by:Zack Tanner <1939140+ztanner@users.noreply.github.com>
-
PapatMayuri authored
This PR updates the with-urql example for using the App Router. Here are the changes that have been made: - I renamed the pages folder and moved it to the app folder. - Added the layout.tsx file as part of the App Router. - Updated the package.json file. CC: @samcx --------- Co-authored-by:
MayuriPapat25 <mayuri.papat@qed42.com> Co-authored-by:
samcx <sam@vercel.com>
-
Jiwon Choi authored
-
Tim Neutkens authored
Add an event for if webpack plugins customized or not. While investigating adding this I found that when webpack config is added it does not propagate the event data because the build workers are opted out of. I've fixed that bug in this PR as it prohibited the new event from working. I've added a test for both the found bug as well as the newly added event. - [x] Add event for webpack plugin customization - [x] Fix reporting of features when webpack customization is added (bug found while working on adding the event) - [x] Add test for reporting features when webpack customization is added <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Jiwon Choi authored
### Why? Previously, `--size-4` was 16px in rem, but it wasn't intuitive. Therefore, changed to `--size-16`.
-
Jiwon Choi authored
-
Zack Tanner authored
The docs here differ depending on which router you're using. This wires the router type into overlay state so we can render different information in the popover.
-
Zack Tanner authored
The static indicator was added in the new dev overlay but wasn't hooked up to pages router. This wires that up so they're properly marked static/dynamic. Closes NDX-897
-
Zack Tanner authored
Noticed this was not matched by the existing glob since it expects things to be in `app-/**`
-
Zack Tanner authored
This renames the functions associated with setting the ISR status (used for the static indicator in the error overlay) to be more generic, in preparation for it being used by pages router.
-
Jiachi Liu authored
-
Andrew Clark authored
The highest-level layout in a route tree is referred to as the "root" layout. When it changes, we perform a full-page (MPA-style) navigation. To implement this for the Segment Cache, I moved the `isNavigatingToNewRootLayout` check from `navigateReducer` into `startPPRNavigation`. Rather than run the `isNavigatingToNewRootLayout` check on every navigation, I combined it with the route tree traversal we already perform when diffing the tree on navigation. In the common case, navigation happens inside the root layout. If we discover a root layout before the first new segment is reached, we don't have to do anything extra. The only special case is when a root parameter changes. Although this triggers a re-render of that segment, it shouldn't cause the root layout to be treated as different for the purposes of deciding whether to trigger an MPA navigation. It's only in this case where we need to switch to a different tree traversal (isNavigatingToNewRootLayout).
-
Jiachi Liu authored
-
JJ Kasper authored
Optimization for node middleware bundling ensuring that we bundle all dependencies by default instead of externalizing like we do for pages routes. The `serverExternals` config is still applied for this configuration so if any packages need externalizing they still can be.
-
Jiwon Choi authored
### Why? As of Cursor [v0.46](https://www.cursor.com/changelog/agent-is-ready-and-ui-refresh), the `.cursorignore` file also skips AI generation in addition to disabling indexing. To disable indexing only, should use `.cursorindexingignore`. I don't think we want to use `.cursorignore` for disabling AI generation, so I just renamed it to `.cursorindexingignore`.
-
Will Binns-Smith authored
Previously we only handled the eval sourcemaps case where the module id was encoded into the source url. This handles cases when the `file://` protocol is used, such as with Rspack. Test Plan: `pnpm test-dev-rspack test/development/acceptance-app/rsc-runtime-errors.test.ts`
-
Andrew Clark authored
The Form component should not need to check at runtime whether it's running in Pages or App Router — this is a build-time condition. The implementation is different enough that we might as well fork the implementations at the module level. I used #73019 as a reference, since that PR did the same thing for Link. I have not changed anything in implementation itself; I'll leave that for subsequent PRs. All I've done is duplicate the existing module, fix the imports, and update the bundler configuration to resolve to the appropriate module. There should be no observable change in behavior.
-
Benjamin Woodruff authored
Use the reusable configs defined in #76251 for rspack. Development tests: https://github.com/vercel/next.js/actions/runs/13514384329 Production tests: https://github.com/vercel/next.js/actions/runs/13514385828 Patch the `build-rspack-dev-tests-manifest.js` script: ``` diff --git a/test/build-rspack-dev-tests-manifest.js b/test/build-rspack-dev-tests-manifest.js index 22f8401ef7..8cc5ed4af6 100644 --- a/test/build-rspack-dev-tests-manifest.js +++ b/test/build-rspack-dev-tests-manifest.js @@ -91,7 +91,10 @@ async function fetchLatestTestArtifact() { const res = JSON.parse(stdout) for (const artifact of res.artifacts) { - if (artifact.expired || artifact.workflow_run.head_branch !== 'canary') { + if ( + artifact.expired || + artifact.workflow_run.head_branch !== 'bgw/round-robin-tests' + ) { continue } ``` ``` node test/build-turbopack-dev-tests-manifest.js ``` Inspect the generated JSON: https://gist.github.com/bgw/35b7f9d09cd95f64087a69ff5c7f8972
-
Zack Tanner authored
We added `--api` support to create-next-app via #68130. This documents that option. Closes DOC-4221
-
Jiwon Choi authored
### Why? The color contrast for the error label does not satisfy AAA of WCAG color contrast standards. Even though it is AA, the text is small and is generally hard to read. | Before | After | |--------|--------| |  |  | | Before | After | |--------|--------| |  |  | --- EDIT
😂 | Before | After | |--------|--------| |  |  | Closes NDX-901 -
Zack Tanner authored
The `i18n` configuration was supported in app router to assist with incremental migration, but it's only meant to be used for pages router. There are some bugs that can pop up when attempting to use it with app router. Disabling `i18n` configuration entirely for any app router paths will be handled in a separate PR: the goal for this PR is to signal that it's unsupported in app router.
-
Janka Uryga authored
This PR changes the server action generated code a bit to work around a typescript bug and remove some false positives we got while typechecking: https://github.com/microsoft/TypeScript/issues/61165 The trick is that typescript seems to look for *exactly* `Object.defineProperty(obj, 'literal', { value: ... })`, and changing any part of the expression bypasses the bug, so we can just use `Object['defineProperty']` instead.
-
Vercel Release Bot authored
Co-authored-by:Sebastian Sebbie Silbermann <sebastian.silbermann@vercel.com>
-
Sebastian "Sebbie" Silbermann authored
-