- 25 Nov, 2025 9 commits
-
-
nextjs-bot authored
-
Jam Balaya authored
## Summary Correct spelling errors in the cms-agilitycms example, including the image prop spelling and dependency imports. Bug Fixes: - Fix misspelled intersectionTreshold prop to intersectionThreshold in the Image component and its useInView configuration Enhancements: - Rename dependancies.ts to dependencies.ts and update requireComponentDependancyByName to requireComponentDependencyByName across API and component imports ### Adding or Updating Examples - [x] The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - [x] Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.mdCo-authored-by:
Joseph <joseph.chamochumbi@vercel.com>
-
Niklas Mischkulnig authored
It's very flakey with Webpack
-
Joseph authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? Fixes grammar and typos in the TypeScript configuration documentation. ### Why? To improve the clarity and correctness of the documentation. ### How? - Removed an unnecessary article ("the") on line 38. - Corrected a preposition ("on" to "in") on line 128. - Fixed subject-verb agreement ("need" to "needs") on line 158. Closes NEXT- Fixes # --> --- [Slack Thread](https://vercel.slack.com/archives/C07BS1WEYAZ/p1764105619569089?thread_ts=1764105619.569089&cid=C07BS1WEYAZ) <a href="https://cursor.com/background-agent?bcId=bc-732fcdec-b21b-4ce1-9c26-b10386636edc"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a> <a href="https://cursor.com/agents?id=bc-732fcdec-b21b-4ce1-9c26-b10386636edc"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> Co-authored-by:
Cursor Agent <cursoragent@cursor.com>
-
Jam Balaya authored
## Summary Fix typos in package documentation and templates Documentation: - Correct spelling of “bindings” in [next-swc README](https://github.com/vercel/next.js/blob/canary/packages/next-swc/README.md) - Update [gitignore](https://github.com/vercel/next.js/blob/canary/packages/create-next-app/templates/app-api/ts/gitignore) template in create-next-app app-api/ts setup ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guideCo-authored-by:
Joseph <joseph.chamochumbi@vercel.com>
-
Florian Liebig authored
### What? Within Issue https://github.com/vercel/next.js/issues/48040 / PR #49487 the middleware proxy for external rewrites was fixed. Unfortunately, this does not work when you change the headers in your middleware (according to https://vercel.com/templates/next.js/edge-functions-modify-request-header) ### Why? We still have issues with the latest canary ### How? Unfortunately I was not able to find the issue, just recreating the bug in a testcase --------- Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-
Jam Balaya authored
## Summary Delete the entire [with-windicss](https://github.com/vercel/next.js/tree/canary/examples/with-windicss) directory and its contents ## Why? [windicss](https://github.com/windicss/windicss) is [sunsetting](https://windicss.org/posts/sunsetting.html). ## Adding or Updating Examples - [x] The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - [x] Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md cc: @samcx Co-authored-by:
Joseph <joseph.chamochumbi@vercel.com>
-
Luke Sandberg authored
Enable the filesystem cache in canary builds in preparation for enabling it by default in the next release. It can still be disabled by explicitly setting the option to `false`. Flipping it for all users is deferred to #85975 so as not to interfere with potential patch releases. Also fix the filesystem caching test that was accidentally disabled in #84632 due to the file rename.
-
Jude Gao authored
Follow up to https://github.com/vercel/next.js/pull/86273 The typed routes test was checking for `/project/[slug]` in the `RedirectRoutes` type, but this route doesn't actually exist in the test fixture anymore. The test fixture only has redirects defined for `/blog/[category]/[[...slug]]`. When Next.js generates the typed routes during the build, it only includes routes that actually exist in the project structure. The test was expecting a route that wasn't present, which would cause the test to fail if the generated types were correct. This removes `/project/[slug]` from the expected `RedirectRoutes` type so the test expectations match what's actually generated. Also includes a minor formatting fix in `apps/bundle-analyzer/next-env.d.ts` to use consistent semicolons and double quotes per the project's style guidelines.
-
- 24 Nov, 2025 13 commits
-
-
nextjs-bot authored
-
Vercel Release Bot authored
This auto-generated PR updates the production integration test manifest used when testing Rspack.
-
nextjs-bot authored
-
Niklas Mischkulnig authored
Eventual consistency strikes again We already had the infrastructure here to store a result in the swc visitor.
-
Jiachi Liu authored
-
sam authored
Note: new PR description written by @timneutkens ## What? Improves the detection of Google Tag Manager vs Google Analytics. As indicated by the author of this PR it was confusing that when you have Google Tag Manager set up it gives you an error message saying you're adding Google Analytics even though it's Tag Manager. I've updated the PR to have a separate message for Google Tag Manager and expanded the error message docs too. It also mentioned `next/script` in a bunch of places even though the error doc recommends `@next/third-parties`. I've updated all cases to refer to `@next/third-parties` instead. <details> <summary>Previous PR description</summary> Google has multiple products with similar names: the "Google Tag" and "Google Tag Manager". Google Tag Manager uses `gtm.js` whereas the "Google Tag" uses `gtag`. Google Analytics previously used `analytics.js` (<2017) and is now delivered via the "Google Tag". Google Tag: `www.googletagmanager.com/gtag/js` Google Tag Manager: `www.googletagmanager.com/gtm.js` The `next-script-for-ga.ts` rule's matching list (`SUPPORTED_HTML_CONTENT_URLS`) includes `gtm.js` which means when a developer adds Google Tag Manager to their NextJS website, they'll receive the warning and be encouraged to swap from `gtm.js` to `gtag`. A developer asleep at the wheel (...me) may think... > I'm using Google Analytics via Google Tag Manager, and NextJS is suggesting I swap `gtm.js` for `gtag` because it will improve performance. `gtag` sounds like it is part of "Google Tag Manager" so I am going to follow the instructions so that my website is faster. However, `gtag` is **not** compatible with `gtm.js` (they're different products with similar names and similar purposes) and so making this change will cause very confusing Google Tag Manager behaviour. I am suggesting that `gtm.js` is removed completely from the rule, because anyone using `gtm.js` should not be following these instructions. A separate rule could be added specifically for Google Tag Manager, that does not refer to `gtag`. </details> --------- Co-authored-by:Tim Neutkens <tim@timneutkens.nl>
-
Jam Balaya authored
## Summary Fix typos in code, styles, and documentation across multiple example projects Chores: - Correct variable name typo in the with-slate example (edtorState→editorState) - Fix CSS/SASS class name misspellings (populer→popular, Serach→Search, serachSelector→searchSelector) - Update example documentation and comments to fix English typos (Data SOUCE→SOURCE, accessiblity→accessibility, exchanges, doesn't, deploying, validates, quickly) ### Adding or Updating Examples - [x] The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - [x] Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.mdCo-authored-by:
Joseph <joseph.chamochumbi@vercel.com>
-
Muhammed Al-Dulaimi authored
Closes https://github.com/vercel/next.js/issues/86386 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Joseph <sephxd1234@gmail.com> Co-authored-by:
Joseph <joseph.chamochumbi@vercel.com>
-
Hendrik Liebau authored
With this PR we are restructuring how the Next.js compiler transforms server function modules (`'use server'` or `'use cache'` directive at the top of the file). The workaround for skipping the registration of exported `'use cache'` functions is removed. All exported server functions are now properly registered during visitor traversal, which fixes incorrect server reference information bytes in server reference IDs in some circumstances (see #86292 for example). We're also adding support for string literal exports, e.g.: ```js 'use server' async function foo() {} export { foo as '📙 ' } ``` -
nextjs-bot authored
-
Sebastian "Sebbie" Silbermann authored
-
Tobias Koppers authored
This reverts commit 2d80f1a2. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Tobias Koppers authored
### What? * add support for multiple options for chunk suffix * Use FromScriptSrc chunk suffix to avoid depending on deployment id * fix passing chunk suffix to WebWorkers initial chunks
-
- 23 Nov, 2025 2 commits
-
-
nextjs-bot authored
-
Tobias Koppers authored
This reverts commit 23b741a9. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
- 22 Nov, 2025 5 commits
-
-
nextjs-bot authored
-
Andrew Clark authored
If a navigation happens while a prefetch for a segment is still pending, we intentionally don't wait for the prefetch to complete before sending a navigation request, because we don't know yet whether the prefetch response will be complete or partial. So, we immediately send a new navigation request for the data, even at the risk of some duplication, in order to avoid a waterfall. However, there is one case where it's safe to assume the prefetch response will be complete — when the prefetch is initiated via `<Link prefetch={true}>` (or, equivalently, the "full" option supported by router.prefetch()). In this case, the client explicitly instructs the server not to omit any dynamic or runtime data. Therefore, it's OK to skip over it during the navigation request. -
nextjs-bot authored
-
Tobias Koppers authored
Reverts vercel/next.js#86339
-
Vercel Release Bot authored
This auto-generated PR updates the production integration test manifest used when testing Rspack.
-
- 21 Nov, 2025 11 commits
-
-
Jimmy Lai authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? Updated the `Layouts and auth checks` section in the authentication documentation (`docs/01-app/02-guides/authentication.mdx`). ### Why? The previous example demonstrating authentication checks within layouts was confusing and contradicted the documentation's own advice against this pattern. This update aims to provide clearer, recommended approaches for implementing authentication checks. ### How? - Removed the misleading layout-based authentication example. - Introduced a new subsection with an example showing authentication checks in a page component. - Added another new subsection with an example demonstrating authentication checks in a leaf component. - Enhanced the "Good to know" section with a reminder about the necessity of authorization checks for Server Actions. Closes NEXT- Fixes # --> --- [Slack Thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1763685748449029?thread_ts=1763685748.449029&cid=C03KAR5DCKC) <a href="https://cursor.com/background-agent?bcId=bc-f490a8eb-8f55-4a85-a31a-357adb24c09a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a> <a href="https://cursor.com/agents?id=bc-f490a8eb-8f55-4a85-a31a-357adb24c09a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> Co-authored-by:
Cursor Agent <cursoragent@cursor.com>
-
nextjs-bot authored
-
Joseph authored
- Adjust nested behavior - Include conditional calls to cacheLife --------- Co-authored-by:Ismael <ismael@vercel.com>
-
Zack Tanner authored
Adds logs to collectSegmentError when verbose logging is enabled to help identify errors that occur during this phase.
-
nextjs-bot authored
-
Zack Tanner authored
…cy (#86355)" This reverts commit 5b97f1f7. Investigating if it fixes broken publishes.
-
Niklas Mischkulnig authored
This is generally better for performance
-
JJ Kasper authored
-
Hendrik Liebau authored
By sending the dynamic validation errors to the browser via WebSocket, instead of rendering a validation outlet into the dynamic dev render stream, we can avoid artificially delaying the spawned validation to implicitly wait for the different chunks (static, runtime, and dynamic), without blocking the dev render stream, and instead wait explicitly for all chunks to accumulate. Previously, we were using React's console replaying to get full fidelity error stacks in the browser (including inspectable virtual server modules). Now, we're using the same underlying mechanism by sending a separate RSC stream through the WebSocket that contains only the errors. In the browser, the received errors are then logged with `console.error`, which also triggers that they're displayed in a collapsed Redbox, as was the case before with the replaying. --------- Co-authored-by:Janka Uryga <lolzatu2@gmail.com>
-
Niklas Mischkulnig authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Niklas Mischkulnig authored
The list was getting long...
-