- 18 Mar, 2026 8 commits
-
-
nextjs-bot authored
-
Hendrik Liebau authored
[Flakiness metrics](https://app.datadoghq.com/ci/test/runs?query=test_level%3Atest%20%40git.repository.id%3A%22github.com%2Fvercel%2Fnext.js%22%20%40test.status%3A%22fail%22%20%40test.name%3A%22basePath%20should%20use%20urls%20with%20basepath%20in%20router%20events%20for%20hash%20changes%22&agg_m=count&agg_m_source=base&agg_t=count¤tTab=overview&eventStack=&fromUser=false&index=citest&start=1773244604685&end=1773849404685&paused=false) After upgrading Playwright in #91250 (which brought some performance improvements), some tests are now exposed to be missing retries around assertions. `test/e2e/basepath/router-events.test.ts` is one of those tests, and this PR adds a `retry` around the event log assertion. We're also replacing the deprecated `check` utility with `retry` when waiting for the router to be ready.
-
Joseph authored
Just a complementary note to the TS config reference.
-
nextjs-bot authored
-
Richard Zhang authored
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Updates the Subresource Integrity (SRI) documentation to reflect that the feature is now supported on both Webpack and Turbopack bundlers. Previously, the documentation stated that SRI was "only available with webpack bundler". This has been updated to remove that restriction following the implementation in PR #90152. ### Changes - Removed webpack-only limitation from SRI documentation in Content Security Policy guide - Removed `experimental.sri.algorithm` from the list of unplanned Turbopack features Fixes the documentation to align with the current implementation. <!-- CURSOR_AGENT_PR_BODY_END --> [Slack Thread](https://vercel.slack.com/archives/D0AGHCN7K2T/p1771984911390169?thread_ts=1771984911.390169&cid=D0AGHCN7K2T) <div><a href="https://cursor.com/agents/bc-0b4d6ed8-9e06-5c78-9a4d-b352a7c2e97d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-0b4d6ed8-9e06-5c78-9a4d-b352a7c2e97d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --------- Co-authored-by:
Cursor Agent <cursoragent@cursor.com> Co-authored-by:
Richard Zhang <richardjzhang@users.noreply.github.com> Co-authored-by:
Joseph <joseph.chamochumbi@vercel.com>
-
Josh Story authored
The depth-based instant validation previously only iterated URL-consuming segments as potential shared/new boundaries. Route groups between URL segments were invisible — when a route group layout with Suspense was shared in a client navigation, its Suspense appeared to cover blocking code in the validation render even though it wouldn't in reality. This adds a second dimension to the validation iteration: group depth. At each URL depth, we now also step through route group boundaries. A new `discoverValidationDepths` function walks the LoaderTree and returns an array where each entry represents the max group depth at that URL depth. The validation loop iterates from deepest group depth to shallowest within each URL depth, stopping on the first error. Key design decisions: - URL depth and group depth counters are advanced before the boundary check, making the boundary condition a simple `nextUrlDepth > depth && currentGroupDepth >= groupDepth` - The synthetic `(slot)` segment that Next.js inserts for parallel slots is excluded from group depth counting since it doesn't represent a real navigation boundary - Group depths are discovered from the LoaderTree rather than the URL pathname, making the tree the source of truth for validation bounds
-
Zack Tanner authored
This improves the blocked-request warning so it names the actual dev resource being requested and gives clearer guidance on how to allow it. When the source host is known, the message includes an inline `allowedDevOrigins` config snippet; when the source is missing or opaque, it explains why Next.js cannot infer a host to allow.
-
Benjamin Woodruff authored
This defaults to `true`: https://doc.rust-lang.org/cargo/reference/profiles.html#debug Nobody on the team uses a debugger often enough for this to be worth the time tradeoff: https://kobzol.github.io/rust/rustc/2025/05/20/disable-debuginfo-to-improve-rust-compile-times.html I'm gathering some rough numbers, and I'll add them to the PR. After `cargo clean` and one `cargo build -p next-napi-bindings` with each profile (Linux arm64): ``` du -sh target/* 4.0K target/CACHEDIR.TAG 7.9G target/debug 14G target/dev-with-debug 7.5M target/generated ``` This is nearly half the size. Due to cargo quirks, the `dev` profile defaults to the `target/debug` directory. Of course, any disk size wins you get are more than offset if you need to use a debugger and end up with an additional profile. ``` hyperfine -w 1 -r 5 -p 'cargo clean' 'cargo build --profile dev-with-debug -p next-napi-bindings' 'cargo build -p next-napi-bindings' ``` ...pending... (this is on https://github.com/bgw/benchmark-scripts/, on my M2 Macbook inside of a Linux VM this takes closer to 2m20s)
-
- 17 Mar, 2026 32 commits
-
-
Benjamin Woodruff authored
- More profiles means more bloat to the `target` directory and more cold builds. - There's no practical use case where we'd be okay with the performance hit of `debug-assertions` and not okay with the performance hit of `lto = false`. Neither profile was suitable for benchmarking. - `release-with-assertions-no-lto` is too long to type and was giving me carpal tunnel.
-
Luke Sandberg authored
Instead of allocating a scratch buffer for every shard, buffer them in a thread local.
-
nextjs-bot authored
-
Benjamin Woodruff authored
All the stuff in this file is either better documented elsewhere or out-of-date and misleading.
-
Zack Tanner authored
This removes the warn-only default behavior and enforces the dev-origin guard by default. Cross-origin requests to internal dev resources now block unless they match the built-in local allowlist or an explicit `allowedDevOrigins` entry. The tests are expanded to cover default blocking, configured-but-not-allowlisted hosts, missing Referer in the no-cors path, and same-site requests without an Origin, and the docs are updated to match the new behavior.
-
Tim Neutkens authored
## Move `adapterPath` from experimental to stable Graduates `adapterPath` from `experimental.adapterPath` to a top-level `NextConfig` option, following the same pattern used for `cacheHandlers`, `cacheComponents`, `typedRoutes`, and other options that moved out of experimental. ### Changes - **Type definition** (`config-shared.ts`): Added `adapterPath` to `NextConfig` interface, marked `ExperimentalConfig.adapterPath` as `@deprecated`, moved default value to top-level in `defaultConfig`, updated `NextConfigRuntime` and `getNextConfigRuntime` - **Zod schema** (`config-schema.ts`): Added `adapterPath` to top-level `configSchema` - **Backward compat** (`config.ts`): Added `warnOptionHasBeenMovedOutOfExperimental` call so existing `experimental.adapterPath` configs still work with a deprecation warning, updated `applyModifyConfig` to read from `config.adapterPath` - **Runtime references**: Updated `build/index.ts`, `app-page.ts`, `app-route.ts`, `pages-handler.ts` to use `config.adapterPath` / `nextConfig.adapterPath` - **Tests**: Updated 4 test fixture `next.config` files - **Docs**: Updated app router doc (removed `version: experimental` frontmatter, top-level config example), pages router doc title, and v16 upgrade guide
-
nextjs-bot authored
-
Tobias Koppers authored
### What? Remove the `TURBOPACK_STATS` feature that generated webpack-compatible `webpack-stats.json` files from Turbopack's output. **Deleted:** - `crates/next-api/src/webpack_stats.rs` — the entire 305-line Rust implementation that built webpack-format stats (assets, chunks, modules, entrypoints) from Turbopack's module graph **Rust changes:** - `crates/next-api/src/lib.rs` — removed `mod webpack_stats;` - `crates/next-api/src/project.rs` — removed `should_create_webpack_stats()` which read the `TURBOPACK_STATS` env var - `crates/next-api/src/pages.rs` — removed `generate_webpack_stats` import and stats output emission - `crates/next-api/src/app.rs` — same **TypeScript changes:** - `packages/next/src/shared/lib/constants.ts` — removed `WEBPACK_STATS = 'webpack-stats.json'` constant - `packages/next/src/shared/lib/turbopack/manifest-loader.ts` — removed `loadWebpackStats()`, `writeWebpackStats()`, `mergeWebpackStats()`, the `webpackStats` field, webpack type imports, and the `TURBOPACK_STATS` env guard in `writeManifests()` - `packages/next/src/server/dev/turbopack-utils.ts` — removed `shouldCreateWebpackStats` flag and two `loadWebpackStats()` call sites - `packages/next/src/build/handle-entrypoints.ts` — same ### Why? This feature is no longer needed and adds dead complexity. It was opt-in via `TURBOPACK_STATS=1` but nothing in the current codebase or tooling depends on it. ### How? Pure deletion — no behavior change for any existing user, as the feature was opt-in via an environment variable that is no longer checked. **Intentionally left untouched:** - Webpack's own `stats.json` generation (non-Turbopack path) - The Turbopack bundle analyzer / `analyze` feature - `route-bundle-stats.json` in `.next/diagnostics/` Co-authored-by:
Tobias Koppers <sokra@users.noreply.github.com> Co-authored-by:
Claude <noreply@anthropic.com>
-
Zack Tanner authored
This PR makes configured `allowedDevOrigins` apply to cross-site no-cors dev asset requests. When browsers omit Origin for subresource loads, the dev guard now falls back to `Referer` so explicit allowlisted hosts can load `/_next/*` resources in development. Previously, when `allowedDevOrigins` was configured, cross-site no-cors requests to internal Next.js dev resources were still blocked even for allowlisted hosts, because that code path never consulted the allowlist.
-
Hendrik Liebau authored
[Flakiness metric](https://app.datadoghq.com/ci/test/runs?query=test_level%3Atest%20%40git.repository.id%3A%22github.com%2Fvercel%2Fnext.js%22%20%40test.name%3A%28%22use-cache%20should%20cache%20results%20for%20cached%20functions%20imported%20from%20client%20components%22%20OR%20%22use-cache%20should%20cache%20results%20for%20cached%20functions%20passed%20to%20client%20components%22%29%20%40test.status%3A%22fail%22%20%40duration%3A%3E%3D1ns&agg_m=count&agg_m_source=base&agg_t=count&citest_explorer_sort=timestamp%2Casc&cols=%40test.status%2Ctimestamp%2C%40test.suite%2C%40test.name%2C%40duration%2C%40test.service%2C%40git.branch¤tTab=overview&eventStack=&fromUser=false&index=citest&start=1772476060657&end=1773772060657&paused=false) I'm not sure why these tests recently got much more flaky (they were somewhat flaky before), but they definitely were missing `retry` blocks around the assertions after clicking the reset button.
-
Tobias Koppers authored
### What? Removes the `experimental.devCacheControlNoCache` config option entirely and hard-codes `no-cache, must-revalidate` as the dev server `Cache-Control` header value. Previously the option controlled whether the dev server responded with: - `no-store, must-revalidate` (default, `false`) - `no-cache, must-revalidate` (opt-in, `true`) This PR first flips the default to `true`, then removes the option altogether — making `no-cache, must-revalidate` unconditional in all dev code paths. ### Why? `no-cache` is strictly better than `no-store` for the dev server: - `no-cache` allows the browser to revalidate (conditional `If-None-Match`/`If-Modified-Since` requests), letting the server respond with `304 Not Modified` when nothing changed → faster page loads during development. - `no-store` forces a full re-fetch every time, discarding valid cached responses. Since `no-cache` is the correct behavior for all dev users, the toggle has no remaining value and can be removed to simplify the codebase. ### How? **Two commits:** 1. `bcec825` — Flip the default from `false` → `true`; update tests/fixtures/manifest to reflect the new default. 2. `e6e919f` — Remove the option entirely: - Deleted `devCacheControlNoCache?: boolean` from `ExperimentalConfig` interface, `config-schema.ts` Zod schema, `defaultConfig`, `NextConfigRuntime`, and `getNextConfigRuntime()`. - Replaced all four conditional ternaries in `base-server.ts`, `router-server.ts`, `pages-handler.ts`, and `app-page.ts` with the hard-coded string `'no-cache, must-revalidate'`. - Deleted the `dev-cache-control-no-cache-disabled` test suite (was testing the `false` path which no longer exists). - Simplified the remaining `dev-cache-control-no-cache` test (removed experimental framing). - Synced `rspack-dev-tests-manifest.json`. --------- Co-authored-by:
Tobias Koppers <sokra@users.noreply.github.com> Co-authored-by:
Claude <noreply@anthropic.com> Co-authored-by:
Vercel <vercel[bot]@users.noreply.github.com>
-
Luke Sandberg authored
## What? Update the `qfilter` crate to an alpha version. ## Why? Performance improvements in the quotient filter implementation used by turbo-persistence for SST file lookups. ## Benchmark Results Benchmarks run on Apple Silicon (M-series), comparing `canary` baseline vs this branch. Focused on qfilter-sensitive paths: the filter itself, SST lookups, uncompacted multi-commit DB reads, and writes. ### qfilter microbenchmarks (direct filter operations) | Benchmark | canary | branch | change | |---|---|---|---| | **Lookup (hit)** | | | | | 1Ki entries | 22.10 ns | 14.63 ns | **-33.8%** | | 10Ki entries | 22.21 ns | 15.41 ns | **-30.6%** | | 100Ki entries | 24.96 ns | 17.47 ns | **-30.0%** | | 1000Ki entries | 25.05 ns | 16.61 ns | **-33.7%** | | **Lookup (miss)** | | | | | 1Ki entries | 12.09 ns | 9.19 ns | **-24.0%** | | 10Ki entries | 14.24 ns | 11.07 ns | **-22.3%** | | 100Ki entries | 18.13 ns | 13.72 ns | **-24.3%** | | 1000Ki entries | 13.36 ns | 10.00 ns | **-25.2%** | | **Insert (build filter)** | | | | | 1Ki entries | 8.54 us | 9.64 us | +12.9% | | 10Ki entries | 118.16 us | 120.97 us | +2.4% | | 100Ki entries | 3.18 ms | 2.57 ms | **-19.2%** | | 1000Ki entries | 20.88 ms | 18.31 ms | **-12.3%** | **Summary:** Lookups 22-34% faster across all sizes. Insert is slightly slower at small sizes but 12-19% faster at larger sizes where it matters most. ### SST file lookup (filter + block read) | Benchmark | canary | branch | change | |---|---|---|---| | **Hit (uncached)** | | | | | 1Ki entries | 2.52 us | 2.52 us | ~0% | | 10Ki entries | 3.60 us | 3.52 us | -2.2% | | 100Ki entries | 3.77 us | 3.72 us | -1.3% | | 1000Ki entries | 6.65 us | 6.55 us | -1.5% | | **Miss (cached)** | | | | | 1Ki entries | 124.50 ns | 121.13 ns | -2.7% | | 10Ki entries | 168.18 ns | 161.96 ns | **-3.7%** | | 100Ki entries | 195.97 ns | 189.80 ns | **-3.1%** | | 1000Ki entries | 249.85 ns | 235.68 ns | **-5.7%** | **Summary:** Small but consistent improvements across SST lookups. Miss/cached shows the clearest gains (filter is the primary code path for rejecting misses). ### DB-level reads (20 commits, uncompacted -- amplifies filter cost) | Benchmark | canary | branch | change | |---|---|---|---| | **10.67Mi entries** | | | | | hit/uncached | 3.49 us | 3.13 us | **-10.3%** | | hit/cached | 1.65 us | 1.49 us | **-9.7%** | | miss/uncached | 899.75 ns | 746.28 ns | **-17.1%** | | miss/cached | 793.51 ns | 668.92 ns | **-15.7%** | | **85.33Mi entries** | | | | | hit/uncached | 11.24 us | 10.64 us | ~0% (noisy) | | hit/cached | 4.53 us | 4.10 us | **-9.5%** | | miss/uncached | 5.01 us | 4.36 us | **-13.0%** | | miss/cached | 4.81 us | 4.02 us | **-16.4%** | **Summary:** 10-17% faster reads on uncompacted DBs with many SSTs. Miss paths benefit most since the filter rejects without I/O. ### Write path (includes filter construction) | Benchmark | canary | branch | change | |---|---|---|---| | 85.33Ki entries | 24.91 ms | 23.42 ms | -6.0% | | 853.33Ki entries | 140.63 ms | 131.84 ms | **-6.3%** | | 8.33Mi entries | 1.14 s | 1.07 s | **-6.1%** | **Summary:** ~6% faster writes across all sizes. ## How? Updated the `qfilter` dependency to a new alpha version with improved lookup and insert performance.
-
Jiwon Choi authored
https://github.com/vercel/next.js/actions/runs/23170738194/job/67327462789#step:36:318 is holding up CI, including release. Cause is not from `catchError` PR, it's just that the test has discovered missing support of Next.js for Pages + React 17/18 + React compiler. Will work in parallel.
-
Sebastian "Sebbie" Silbermann authored
-
Benjamin Woodruff authored
docs(turbopack): Migrate chunking docs from mdbook, with proof-reading and minor updates from claude (#91472) Copied from https://turbopack-rust-docs.vercel.sh/turbopack/chunking.html I had claude review it for correctness against the code. It found a few things where the names weren't correct or a trait was actually a struct, and it grouped things into sections. It also added some more details to a few sections, like the dev vs production chunking. I think this is a reasonable improvement. I did a second pass with claude where I had it remove things it 1:1 duplicated with the existing rustdocs, and I had it add intradoc links. Rendered: 
-
Andrew Clark authored
**Previous:** 1. https://github.com/vercel/next.js/pull/91487 2. https://github.com/vercel/next.js/pull/91488 **Current:** 3. https://github.com/vercel/next.js/pull/89297 --- Most of the vary params infrastructure was already implemented in previous PRs for static prerenders. This wires up the remaining pieces for runtime prefetches — creating the accumulator, setting it on the prerender store, and resolving it before abort — and adds additional test cases covering empty/full vary sets, searchParams, metadata, and per-segment layout/page splits with runtime prefetching.
-
Andrew Clark authored
**Previous:** 1. https://github.com/vercel/next.js/pull/91487 **Current:** 2. https://github.com/vercel/next.js/pull/91488 **Up next:** 3. https://github.com/vercel/next.js/pull/89297 --- When a prefetch response includes vary params, the segment cache rekeys entries to a more generic path based on which params the segment actually depends on. Previously, the rekeying only happened when vary params were provided. Now that vary params are tracked for more response types (and eventually will always be tracked), entries are rekeyed in more cases than before. This exposed a potential race condition: the scheduler would capture a vary path at scheduling time and upsert the entry at that path when the fetch completed. But the fetch functions themselves rekey entries to a different (more generic) path upon fulfillment. The deferred upsert could then move the entry back to the less generic path, undoing the rekeying. To fix this, move the upsert logic inline into the fetch functions that fulfill entries, rather than deferring it to an external callback. This removes the race condition, simplifies the model, and reduces implementation complexity. The previous structure existed to avoid the rekeying cost when vary params weren't available, but rekeying is inexpensive and not worth the added indirection. The upsert function itself already handles concurrent writes by comparing fetch strategies and checking whether the new entry provides more complete data than any existing entry. So it's safe to always call it inline — whichever entry wins will be the most complete one.
-
Andrew Clark authored
**Current:** 1. https://github.com/vercel/next.js/pull/91487 **Up next:** 2. https://github.com/vercel/next.js/pull/91488 3. https://github.com/vercel/next.js/pull/89297 --- Prefetch responses include metadata (in the Flight stream sense, not HTML document metadata) that describes properties of the overall response — things like the stale time and the set of params that were accessed during rendering. Conceptually these are like late HTTP headers: information that's only known once the response is complete. Since we can't rely on actual HTTP late headers being supported everywhere, we encode this metadata in the body of the Flight response. The mechanism works by including an unresolved thenable in the Flight payload, then resolving it just before closing the stream. On the client, after the stream is fully received, we unwrap the thenable synchronously. This synchronous unwrap relies on the assumption that the server resolved the thenable before closing the stream. The server already buffers prefetch responses before sending them, so the resolved thenable data is always present in the response. However, HTTP chunking in the browser layer can introduce taskiness when processing the response, which could prevent Flight from decoding the full payload synchronously. The existing code includes fallback behavior for this case (e.g. treating the vary params as unknown), so this doesn't fix a semantic issue — it strengthens the guarantee so that the fallback path is never reached. To do this, we buffer the full response on the client and concatenate it into a single chunk before passing it to Flight. A single chunk is necessary because Flight's `processBinaryChunk` processes all rows synchronously within one call. Multiple chunks would not be sufficient even if pre-enqueued: the `await` continuation from `createFromReadableStream` can interleave between chunks, causing promise value rows to be processed after the root model initializes, which leaves thenables in a pending state. Since the server already buffers these responses and they complete during a prefetch (not during a navigation), this is not a performance consideration. Full (dynamic) prefetches are not affected by this change. These are streaming responses — even though they are cached, they are a special case where dynamic data is treated as if it were cached. They don't need to be buffered on either the server or the client the way normal cached responses are.
-
Hendrik Liebau authored
Follow-up to #91189 which added support for accessing root params inside `generateStaticParams`. Previously, if a `generateStaticParams` function tried to read a root param that hasn't been defined yet — either because the current segment is supposed to define it, or because a child segment defines it — `getRootParam` would silently return `undefined`. This is especially problematic because #91019 will type root param getters as `Promise<string>` without `undefined`, making this a silent type safety violation. This change makes `getRootParam` throw an explicit error with the `generate-static-params` work unit store when the requested param is not present in `rootParams`.
-
Niklas Mischkulnig authored
In many cases, these are just modern selectors that aren't supported yet.
-
Niklas Mischkulnig authored
`snapshot_issues` emits effects when `UPDATE=1`
-
Benjamin Woodruff authored
This is implemented as a dummy module that includes a markdown file. Clap does something similar in their rustdocs. I had claude review the content for accuracy. It made a few modifications. I added rustdoc links by hand. I converted the mermaid diagram to excalidraw and uploaded the image to vercel blob. Copied from: https://turbopack-rust-docs.vercel.sh/turbopack/layers.html Rendered: 
-
xusd320 authored
Use `Bytes::from_owner(napi::Buffer)` to eliminate the `Buffer → Vec<u8>` memcpy on the JS→Rust path in the worker pool. `bytes::Bytes::from_owner` (>=1.9.0) wraps any `T: AsRef<[u8]> + Send + 'static` without copying — the data pointer comes from `T::as_ref()` and `T` is dropped when the `Bytes` is dropped. Since napi@2's `Buffer` implements `AsRef<[u8]>`, this gives true zero-copy. Also unifies the `Operation` trait to use `Bytes` for both `send` and `recv`. This also helps reduce memory consumption, without zero-copy, the memory consumption of the data returned by the loader would be doubled until GC on the JS side or dropped on the Rust side.
-
nextjs-bot authored
-
nextjs-bot authored
-
Tobias Koppers authored
## What? This PR improves CSS parsing error handling in Turbopack by making parse errors recoverable instead of fatal. 1. **Extracting CSS parsing logic** into a new `parse_css_stylesheet` function that handles both parsing and CSS module validation in one place 2. **Fixing error recovery** when CSS minification fails — instead of immediately returning an unparsable result, the code now re-parses the original CSS to recover valid styles 3. **Improving error reporting** by renaming variables for clarity (`source` → `issue_source`) and ensuring errors are properly emitted before attempting recovery 4. **Adding comprehensive tests** for CSS parse error scenarios with both snapshot tests and e2e tests The snapshot test fixture exercises several CSS features to confirm they survive error recovery: - Basic selectors (`.before`, `.after`) — valid rules are preserved when surrounded by invalid ones - `::highlight(highlight-test)` — CSS Custom Highlight API pseudo-element - `scroll-marker-group`, `::scroll-marker`, `::scroll-marker:target-current` — CSS scroll marker pseudo-elements (new spec) - `oklch()` color values — converted to `#rrggbbaa` + `lab()` fallbacks for broader browser compatibility ## Why? Previously, when CSS minification encountered an error, the entire stylesheet would be marked as unparsable, losing any valid CSS that could have been recovered. This meant `turbopackIgnoreIssue` could not suppress the errors since the module produced no output regardless. Now, when lightningcss recovers from parse errors (collecting them as warnings), issues are still emitted but processing continues with the recovered stylesheet. Only truly fatal parse errors (where `StyleSheet::parse` returns `Err`) remain non-recoverable. The refactoring also consolidates CSS validation logic into a single function, reducing code duplication and making the error handling flow clearer. ## How? - Created `parse_css_stylesheet()` function that wraps `StyleSheet::parse()` and applies CSS module validation - Modified error handling in `process_content()` to call the new function and recover from minification errors by re-parsing - Changed early returns to error emission followed by recovery attempts - Added test fixtures and e2e tests to verify CSS parse error recovery works correctly - Added snapshot tests showing expected output when CSS contains parse errors (valid rules are preserved, invalid ones are skipped) - Skipped CSS parse error recovery e2e tests for webpack (webpack has its own CSS pipeline) ## Test Plan - Added e2e tests in `css-parse-error-recovery.test.ts` that verify: - Pages with CSS parse errors still render when using `turbopackIgnoreIssue` config - Parse errors are properly reported in CLI output - Added snapshot tests showing CSS output with parse errors, including modern CSS features (`::highlight`, `scroll-marker-group`, `oklch()` color conversion) - Existing CSS tests continue to pass
-
Jiwon Choi authored
Docs for https://github.com/vercel/next.js/pull/89688
-
Hendrik Liebau authored
When a `"use cache"` entry is newly generated during a prerender (`prerender` or `prerender-runtime`), `collectResult` defers propagation of cache life and tags to the outer context. This is because the entry might later be omitted from the final prerender due to short expire or stale times, and omitted entries should not affect the prerender's cache life. However, when a cache handler returns a hit for an existing entry, `propagateCacheEntryMetadata` was called unconditionally, without the same deferral logic. This meant that short-lived cache entries retrieved from the cache handler could propagate their cache life to the prerender store, even though they would later be omitted from the final render. This inconsistency is currently not observable because runtime prefetches use a prospective and final two-store architecture (see `prospectiveRuntimeServerPrerender` and `finalRuntimeServerPrerender` in `app-render.tsx`). The cache handler hit propagation corrupts the prospective store, but the response is produced from the final store, which reads from the resume data cache with correct stale and expire checks. Static prerenders have a similar two-phase architecture that masks the issue. Because of this, there is no test case that can observe the incorrect behavior, but the fix avoids confusion and prevents the inconsistency from becoming a real bug if the architecture changes. This change extracts a `maybePropagateCacheEntryMetadata` function that encapsulates the conditional propagation logic and is now called from both the generation path (inside `collectResult`) and the cache handler hit path. The resume data cache read path continues to call `propagateCacheEntryMetadata` unconditionally, since it runs in the final render phase after short-lived entries have already been filtered out.
-
Jiwon Choi authored
Improve the RSC error messages to be more comprehensive. x-ref: https://github.com/vercel/next.js/pull/89688#discussion_r2865847895 --------- Co-authored-by:
Claude Haiku 4.5 <noreply@anthropic.com>
-
Andrew Clark authored
## Summary - Fixes flaky test "per-page value overrides global staleTimes.dynamic regardless of direction" introduced by #91437 - The test was flaky because `browser.back()` restored accordion state from BFCache, causing previously-opened `LinkAccordion` links to be immediately visible. This triggered uncontrolled re-prefetches outside the `act` scope. When the `IntersectionObserver` fired inside a subsequent `act` scope (after clock advancement), stale data would trigger a prefetch that violated the `no-requests` assertion. - Fix: instead of navigating back to a previously visited page, navigate forward to fresh "hub" pages with their own `LinkAccordion` components. Since these are never-visited pages, accordions start closed and no uncontrolled prefetches are triggered. - General principle: when using the router `act` test utility, always use `LinkAccordion` to control when prefetches happen. Prefetches should only be triggered inside an `act` scope by toggling an accordion, never by navigating back to a page where links are already visible. ## Test plan - [x] Ran the full test file 4 times locally — all 5 tests pass consistently
-
Hendrik Liebau authored
Root params (e.g. `import { lang } from 'next/root-params'`) can now be read inside `"use cache"` functions. The read root param values are automatically included in the cache key so that different root param combinations produce separate cache entries. Since which root params a cache function reads is only known after execution, the cache key is reconciled post-generation. When root params are read, a two-key scheme is used: the full entry is stored under a specific key (coarse key + root param suffix), and a lightweight redirect entry is stored under the coarse key. The redirect entry's tags encode the root param names using the pattern `_N_RP_<rootParamName>` (e.g. `_N_RP_lang`), following the convention of existing internal tags like `_N_T_<pathname>` (e.g. `_N_T_/dashboard`) for implicit route tags. This allows a cold server to resolve the specific key on the first request after restart. An in-memory map (`knownRootParamsByFunctionId`) provides a fast path for subsequent invocations. When no root params are read, the full entry is stored directly under the coarse key with no redirect involved. The in-memory map grows monotonically — if a function conditionally reads different root params across invocations, the set accumulates all observed param names. The redirect entry's tags are built from this combined set, ensuring cold servers always resolve the most complete specific key. The two-key scheme only applies to the cache handler. The Resume Data Cache (RDC) always uses the coarse key because each page gets its own isolated RDC instance, so root params are fixed within a single RDC and no disambiguation is needed. When an RDC entry is found during resume, it seeds `knownRootParamsByFunctionId` so that subsequent cache handler lookups can use the specific key directly. Reading root params inside `unstable_cache` still throws. Reading root params inside `"use cache"` nested within `unstable_cache` throws with a specific error message explaining the limitation. Alternatives considered: extending the `CacheEntry` interface (would be a breaking change for custom cache handlers), encoding root param metadata in the stream via a wrapper object, or sentinel byte, or Flightception (runtime overhead of stream manipulation on every cache read), and deferring `cacheHandler.set` until after generation (breaks the cache handler's pending-set deduplication for concurrent requests). -
Jiwon Choi authored
### Why? TypeScript fails to infer the generic `P` from `Omit<P, 'children'>` in the fallback function parameter. ``` Argument of type '(props: { title: string; }, { error, reset, unstable_retry }: ErrorInfo) => Element' is not assignable to parameter of type '(props: Omit<UserProps, "children">, errorInfo: ErrorInfo) => ReactNode'. Types of parameters 'props' and 'props' are incompatible. Property 'title' is missing in type 'Omit<UserProps, "children">' but required in type '{ title: string; }'.ts(2345) catch-error-wrapper.tsx(7, 12): 'title' is declared here. ```
-