- 12 Sep, 2026 2 commits
-
-
next-js-bot[bot] authored
-
Tobias Koppers authored
## What? Stabilize the OpenTelemetry instrumentation e2e suite by keeping its local span collector available for each application's full lifetime. Reset collected span state between tests without closing the collector, and cover continuity across a test boundary. ## Why? The suite kept Next.js and custom-server exporters alive across tests while closing and rebinding their collector port after every test. Exports during that gap failed with closed/reset/refused socket errors before trace assertions timed out or observed incomplete trees. Aligning the collector lifetime with the exporter removes that race instead of masking it with retries, longer timeouts, or weaker assertions. ## How? - Start the collector before starting each managed application. - Keep the listener bound until application teardown, while clearing only buffered spans in `beforeEach`. - Replace per-test collector reconnects across the affected suites and remove the disabled-fetch suite's fixed teardown delay. - Assert that one collector remains connected, resets its state, and receives a fresh trace across sequential tests. ## Verification - Webpack dev / React 18.3.1: 5 consecutive focused runs, 54 tests passed per run - Webpack start / React 18.3.1: 5 consecutive focused runs, 97 passed and 13 existing skips per run - `pnpm test-types` - Prettier and ESLint on the changed files <!-- NEXT_JS_LLM --> <!-- fleet c7f6c6e4-56b2-4648-bc2d-88b2f256bb7a --> Co-authored-by:
vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by:
Tobias Koppers <1365881+sokra@users.noreply.github.com>
-
- 11 Sep, 2026 16 commits
-
-
Will Binns-Smith authored
### What? Refactors the JavaScript-facing `TurbopackResult<T>` into a stable wrapper whose payload lives under `value` and whose issues remain top-level. Native API consumers, entrypoint conversion, development-server paths, HMR handling, and direct API tests now follow the disjoint shape. Two event subscriptions that had inaccurate wrapper declarations now expose their existing plain runtime payloads explicitly: update-info events remain `UpdateMessage`, and compilation events remain `CompilationEvent`. Nullable native entrypoint payloads are also declared accurately and normalized at the JavaScript API boundary. ### Why? The previous intersection-based representation merged payload fields with result metadata. That allowed fields such as `issues` to overwrite one another and caused non-object payloads to be discarded, making the result shape depend on `T`. A dedicated payload property avoids those collisions and preserves every payload type, including `null`. Keeping plain event streams distinct from result wrappers also ensures `TurbopackResult<T>` consistently means the native API actually provides wrapper metadata. ### How? The N-API serializer now always creates a fresh wrapper rather than mutating an object payload. The shared TypeScript type models that wrapper directly and requires an explicit payload type. Conversion layers replace only the nested payload while explicitly preserving wrapper issues. Call sites continue to process wrapper issues while reading domain data through `value`. The update-info and compilation-event declarations were aligned with their native callback types instead of introducing new runtime wrappers for streams that do not collect issues. Rust `Option<NapiEntrypoints>` payloads are declared as nullable, then normalized to the existing empty-entrypoints representation after a null-safe route check. ### Verification - `pnpm build-all` - `pnpm --filter=next types` - `pnpm swc-build-native` - `cargo check -p next-napi-bindings` - `cargo fmt --all -- --check` - ESLint and Prettier on changed files - `pnpm test-dev-experimental-turbo test/development/app-aspath/app-aspath.test.ts` - `pnpm test-dev-turbo test/development/basic/next-rs-api.test.ts` — 26 passed, 1 skipped, 15 snapshots; Jest reported lingering open handles after the green summary - `pnpm test-dev-turbo test/development/app-dir/concurrent-install/concurrent-install.test.ts` - `pnpm test-dev-experimental-turbo test/development/app-dir/concurrent-install/concurrent-install.test.ts` <!-- NEXT_JS_LLM --> <!-- fleet 74688340-f99a-462e-8f75-88d12c88000a --> --------- Co-authored-by:
vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by:
Will Binns-Smith <755844+wbinnssmith@users.noreply.github.com>
-
next-js-bot[bot] authored
-
Niklas Mischkulnig authored
We now separately track code that accesses non-inlined env vars at runtime in two categories - (existing) actual reads, the full value is accessed - (new) only unset/falsy/truthy is read at runtime For the second case, we only need to invalidate use-cache functions when the given env var transitioned betwen unset/falsy/truthy. But transitioning between two different truthy values doesn't caused invalidation.
-
Jimmy Miller authored
Pretty straightforward. But a number of loaders depend on it including - postcss-loader - sass-loader - stylus-loader - vue-loader - nunjucks-loader - thread-loader
-
next-js-bot[bot] authored
-
Steven authored
In a previous PR, `mozjpeg` was set to true which might be the reason output jpeg spikes cpu. - https://github.com/vercel/next.js/pull/65846 I made a benchmark and found that disabling MozJPEG saved 72% CPU, with average outputs 31% larger. - https://github.com/lovell/sharp/issues/4603 So this PR adds a new experimental flag to enable (or rather disable) mozjpeg and try with real workloads. This is useful becaues in many cases, cpu is more costly than bandwidth since most CDNs provide [near unlimited bandwidth](https://vercel.com/blog/introducing-flat-rate-cdn).
-
Jimmy Miller authored
## Summary Defer compiling client-side dynamic import targets in Turbopack development until the browser requests their manifest chunk. This avoids compiling untouched dynamic imports while preserving server-side imports, CSS loading, Server Actions, source maps, and Fast Refresh behavior. One caveat on this is next/dynamic still does some eagerness. I looked a bit at changing things. But it breaks some of the guarantees there and decided to leave it off the table. --------- Co-authored-by:Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
-
Joseph authored
Fixes #98468 ## Claude explanation of the fix `useDrag` listened for `pointermove` and `pointerup`, but never `pointercancel`. When a user agent cancels a gesture — a browser or system gesture takes over, a second finger arrives — it fires `pointercancel` and no `pointerup`, implicitly releasing pointer capture as it does. So `cancel()` never ran: the state machine stayed `{ state: 'drag' }` and `cleanup.current` was never invoked, leaving the `pointermove`/`pointerup` listeners on `window`. The next `pointerup` anywhere on the page then hit those orphaned listeners, reached `cancel()` with the state still `'drag'`, and called `releasePointerCapture()` on a pointer that no longer existed — the reported `NotFoundError`. Each cancelled drag also leaked another listener pair. This registers `pointercancel` alongside `pointerup` and removes it in the same cleanup, so the machine unwinds when a gesture is cancelled; and it releases pointer capture only when `hasPointerCapture()` says it is still held, which is preferable to `try/catch` swallowing genuine faults too. Note `touch-action: none` (#97723) removed the common touch trigger, but not the defect: on canary a forced `touchCancel` still throws. https://github.com/user-attachments/assets/45a9524d-9ffa-40b6-b59a-5af9d947f8c7 ## Fixed version https://github.com/user-attachments/assets/b5ada68c-7442-42ef-a256-bacc512fbeca ## Browser checks - [x] Chrome, as describe by the bug report - [x] FF works fine pre and post fix (with and without the pointer simulation) - [x] iOS safari simulator, before the fix, I can't see an error, but, the drag gets frozen, with this fix it works correctly https://github.com/user-attachments/assets/bcfdc786-bada-4462-b530-299523fdca6d🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by:Claude Opus 5 (1M context) <noreply@anthropic.com>
-
Sebastian "Sebbie" Silbermann authored
Logs of passed tests are hidden by default in CI. There's an argument to be made to always show them in CI. For now we just wire up GitHub's built-in "re-run with debug logging enabled" to show logs of passed tests. <img width="1358" height="936" alt="CleanShot 2026-09-10 at 19 00 18@2x" src="https://github.com/user-attachments/assets/70fb9c56-c681-4394-958b-7fa9aea19970" /> Co-authored-by:
Claude Code (kimi-k3[1m]) <noreply@anthropic.com>
-
James Argarin authored
-
Sebastian "Sebbie" Silbermann authored
The fixture's API route proxies the incoming request to `http://<host>/api/post`. On Vercel, that plain-HTTP hop hits the edge's http→https upgrade and the handler pipes the resulting 308 back to the test client, which then has to replay the POST body across the redirect. Node.js' fetch implementation cannot replay bodies across 307/308 redirects and fails the request with `UND_ERR_REQ_CONTENT_LENGTH_MISMATCH`, which broke this test in deploy mode after the test harness switched from `node-fetch` to global `fetch` in #98195. This change proxies over `https` when `VERCEL_URL` is set so no client-visible redirect occurs, while local dev and start modes are unaffected since they keep using plain HTTP. Fixes ``` TypeError: fetch failed 29 | 'x-custom-header': 'some value', 30 | } > 31 | const res = await fetchViaHTTP(next.url, `api`, '', { | ^ 32 | method: method.toUpperCase(), 33 | headers, 34 | body: method.toLowerCase() !== 'get' ? body : undefined, at Object.<anonymous> (e2e/proxy-request-with-middleware/test/index.test.ts:31:19) Cause: RequestContentLengthMismatchError: Request body length does not match content-length header ``` -- https://github.com/vercel/next.js/actions/runs/34543344283/job/103105861941#step:35:555
-
Sebastian "Sebbie" Silbermann authored
Removes the `Test examples` workflow and its orphaned test suite. The workflow fails every scheduled run: its pinned Playwright docker image (v1.35.1) is incompatible with the Playwright version the repo now requires (v1.61.0), so the browser cannot launch. It also no longer runs what it was created for: since the `run-tests.js` glob root moved from `test/` to the repository root, the `--type examples` string-prefix filter `examples/` matches test files inside example apps instead of `test/examples/examples.test.ts`, leaving that suite without any runner. This deletes `.github/workflows/test_examples.yml`, the `test/examples/` suite, and the `--type examples` filter in `run-tests.js`. The `examples/` prefix stays in the default-run exclusion list so test files inside example apps (which run with each example's own jest/vitest setup) are still not picked up by bare `run-tests.js` invocations. Co-authored-by:Claude Code <noreply@anthropic.com>
-
Hendrik Liebau authored
`next dev` reported missing Suspense boundaries in layouts that the build accepted. For `/[top]/items/[bottom]`, `generateStaticParams` returned `[{ top: 't1' }]`, and the page wrapped its `bottom` access in Suspense. A request for `/t2/items/b2` still reported the layout's access to `top` as an error. Development treated both parameters as unresolved because the requested `top` value was not generated, although the required static shell only needed to defer `bottom`. Production Cached Navigations used the same overly broad parameter set and omitted eligible static content from repeat visits. Resumes also reconstructed that set from the original build manifest, even after an on-demand prerender had produced a more complete shell. This replaces the alternative proposed in #98460. That proposal fixes the development error by selecting a separate fallback parameter set for validation while keeping response staging unchanged. The two sets are not intended to differ for the same shell target. Correcting only validation would preserve the incorrect staging decision and leave production Cached Navigations without the eligible static content. Staging and static-shell validation now use one `stagedFallbackParams` set for each selected shell target. Required partial shells retain their unresolved parameters, even when a later request can complete them. Prerenders record their parameter set in postponed state, and resumes use that recorded set rather than reconstructing it from the generic source. Dynamic RSC requests now read and revalidate the completed-shell cache key, so they find partial artifacts that the fully resolved pathname lookup missed. Request metadata and `RequestStore` both expose the set as `stagedFallbackParams`. Action-only fallback detection checks actual unresolved parameters instead of treating deferred values as missing. -
Hendrik Liebau authored
Cached Navigations incorrectly reused uncached timestamps as static page content. A repeat visit showed the previous request's `Date.now()` result while the new response was still pending. This affected both dynamic RSC responses and the RSC payload embedded in the initial HTML. The production renderer left synchronous IO untracked because it assumed the build had already checked it. A private cache exposed the gap: the static prerender suspended at the cache call and never reached the `Date.now()` after it. A production request resolved the private cache during the static stage and included the uncached timestamp in the reusable response. Production staged renders now end the static stage when synchronous request-time IO occurs. They mark the interrupted static and shell prefixes as empty, while the rest of the response renders normally. The client skips those prefixes instead of waiting for a Flight root that the interrupted stage may not have emitted. The regression tests cover dynamic RSC navigation, initial HTML hydration, and full prefetching with a paramless private-cache fixture.
-
Sebastian "Sebbie" Silbermann authored
This workflow is responsible for periodically updating the manifest. The workflow broke in https://github.com/vercel/next.js/pull/97590 since the [called workflow requires `pull_request: write`](https://github.com/vercel/next.js/blob/626ab223bae3f9b29b3ec8cbd18a58d86b871ec1/.github/workflows/integration_tests_reusable.yml#L172) to open the update PR. Fixes ``` [Invalid workflow file: .github/workflows/rspack-nextjs-build-integration-tests.yml#L10](https://github.com/vercel/next.js/actions/runs/34439645923/workflow) The workflow is not valid. .github/workflows/rspack-nextjs-build-integration-tests.yml (Line: 10, Col: 3): Error calling workflow 'vercel/next.js/.github/workflows/integration_tests_reusable.yml@334052ffbb383395b74cac6a90e0b15c7317957b'. The nested job 'collect_nextjs_development_integration_stat' is requesting 'pull-requests: write', but is only allowed 'pull-requests: none'. ``` -- https://github.com/vercel/next.js/actions/runs/34439645923
-
Sebastian "Sebbie" Silbermann authored
The manifest is no longer considered for skipping test since https://github.com/vercel/next.js/pull/81170. It also didn't update anymore automatically so I removed updating areweturboyet.com which was broken for a while now anyway when we switched away from static tokens.
-
- 10 Sep, 2026 19 commits
-
-
next-js-bot[bot] authored
-
Jimmy Miller authored
We removed this because we fixed the original crashes. This crash does not happen out of the box. But it isn't hard to trigger with plugins. And we'd rather not have people experience this without being explicit.
-
Aurora Scharff authored
## Summary - add a Partial Prefetching optimizer Skill for selected source Links and destinations - keep prefetch stages and Link policy in the public [Optimizing prefetching guide](https://nextjs.org/docs/app/guides/optimizing-prefetching), and rely on the same static-shell documentation as the Cache Components optimizer for cache placement, Suspense, loading UI, and authorization - keep the Skill focused on the product decision, production `instant()` loop, differential verification, and mutation freshness when an optimization adds a cache around mutable data - reference the canonical [`unstable_prefetch()`](https://nextjs.org/docs/app/api-reference/functions/prefetch) and [`unstable_navigation()`](https://nextjs.org/docs/app/api-reference/functions/navigation) docs instead of explaining the APIs again in the Skill - link cache-writing optimizations to the canonical [Revalidating](https://nextjs.org/docs/app/getting-started/caching-and-revalidating#revalidating) documentation and verify a populated-cache mutation in the Skill and eval - bundle a self-contained production rig aligned with the related adoption and optimizer Skills, tuned to record each source-link and prefetch-stage contract - add an eval that compares baseline, the bundled guide, and the local Skill against the same prefetched-UI and cache-freshness goal - document the optimizer in the AI agents guide This follows the same guide/Skill split as #97737. Partial Prefetching adoption preserves existing behavior; this optimizer is the later decision about what is worth preparing before a click and what should wait for navigation. Related: #97712, #97737, #97759, #98122, #98175 ## Eval One run per treatment with Claude Opus 4.8 and Claude Sonnet 4.5, using a fixed Claude Haiku 4.5 judge. The bundled-guide and Skill treatments use a local Next.js tarball containing the new guide and API references. | Model | Treatment | Criteria | Score change | Overall | Duration | Tokens processed | Total run cost | Cost change | | --- | --- | ---: | ---: | ---: | ---: | ---: | ---: | ---: | | Opus 4.8 | Baseline | 10/10 (100%) | — | Pass | 18m 42s | 3.39M | $3.46 | — | | Opus 4.8 | Bundled guide | 9/10 (90%) | -10 pp | Fail | 13m 37s | 3.02M | $2.84 | -18.0% | | Opus 4.8 | Local Skill | 10/10 (100%) | +10 pp | Pass | 17m 22s | 2.80M | $2.54 | -10.6% | | Sonnet 4.5 | Baseline | 2/10 (20%) | — | Fail | 15m 55s | 1.97M | $1.06 | — | | Sonnet 4.5 | Bundled guide | 5/10 (50%) | +30 pp | Fail | 15m 49s | 2.17M | $1.11 | +4.5% | | Sonnet 4.5 | Local Skill | 8/10 (80%) | +30 pp | Fail | 15m 31s | 1.41M | $0.77 | -30.4% | Token totals count each unique model message once and include uncached input, cache creation, cache reads, and output. Cache reads account for most of the total in every treatment. Total run cost applies the current AI Gateway base rates to each token category: Opus 4.8 costs $5/M input, $6.25/M cache writes, $0.50/M cache reads, and $25/M output; Sonnet 4.5 costs $3/M input, $3.75/M cache writes, $0.30/M cache reads, and $15/M output. The six agent runs cost $11.78 in total. Compared with baseline, the Opus Skill run maintained a 100% criteria pass rate while reducing cost by 26.7%. The Sonnet Skill run improved the criteria pass rate from 20% to 80%, a 60 percentage-point increase, while reducing cost by 27.3%. The stronger model could solve the fixture without the Skill, although it independently searched the bundled Next.js documentation and took slightly longer than the Skill treatment. The Opus guide-only run implemented the correct behavior but missed the required RED-before-GREEN proof. The Sonnet treatments show a clearer progression. Baseline did not implement the required caching, navigation stage, `instant()` contract, or cache invalidation. The bundled guide added the cached summary and production test, but missed the navigation stage, deferred-state assertions, tag invalidation, and RED-before-GREEN proof. The Skill treatment completed the `instant()` RED-to-GREEN loop and final production behavior, but left `connection()` in the related-sessions read and used path revalidation instead of tagging the cached read. It therefore passed 8 of 10 criteria but failed the overall eval. All six measured runs completed through grading. Chromium and its system dependencies are provisioned before the agent starts, so missing browser libraries did not determine these results. ## Verification - `pnpm --filter=next build` - `pnpm prettier --check` for the changed guide, prompt, Skill, and eval fixture - `pnpm exec tsc -p evals/evals/agent-051-optimize-partial-prefetching/tsconfig.json --noEmit` - `node --check run-evals.js` - `git diff --check` - packed a local Next.js tarball and confirmed it contains the optimizer guide plus the `navigation()` and `prefetch()` references - verified the `navigation()` contract in the minimal reproduction and NextBeats on Next.js 16.4.0-canary.22 - merged the latest `canary`, preserving both generic fixture setup and Playwright provisioning <!-- NEXT_JS_LLM -->
-
Will Binns-Smith authored
Extends the view toggle (introduced in the previous PR for compare mode) to single-build mode as well. The table view lists all sources for the selected route with sizes and env badges. Internally it reuses `DiffTable` in `mode="single"` by diffing the build against itself, which produces an all-`identical` summary — this keeps a single source-listing implementation regardless of mode. <!-- NEXT_JS_LLM_PR --> Co-authored-by:
vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by:
Will Binns-Smith <755844+wbinnssmith@users.noreply.github.com>
-
Will Binns-Smith authored
Adds a table view to compare mode, switchable from the treemap via a toggle in the top bar. The `DiffTable` lists every source file with its A/B sizes, delta, and env badges, and supports text search. Removed sources (which can't appear in the treemap since they don't exist in the current build) are only visible here. The view toggle defaults to Table when entering compare mode and resets to Treemap when leaving it. <!-- NEXT_JS_LLM_PR --> Co-authored-by:
vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by:
Will Binns-Smith <755844+wbinnssmith@users.noreply.github.com>
-
Will Binns-Smith authored
Adds a compare mode to the bundle analyzer. When the user picks a historical snapshot from the new baseline picker in the top bar, the UI switches into compare mode: routes are diff'd by name and size, and the per-route view shows a `DiffTreemap` that colors each source tile by its change status (added/removed/grew/shrank/unchanged). The compare sidebar shows the import chain for the selected tile on either the baseline ("A") or current ("B") side. Route totals are fetched in parallel so the route picker can sort by largest impact and classify routes as `changed`/`identical` rather than just name-presence. <!-- NEXT_JS_LLM_PR --> --------- Co-authored-by:vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by:
Will Binns-Smith <755844+wbinnssmith@users.noreply.github.com>
-
Sebastian "Sebbie" Silbermann authored
`unstable_getResponseFromNextConfig` parsed the request URL with the deprecated `url.parse()` (DEP0169) This change constructs the same pathname/query/protocol/host shape from the WHATWG `URL` API instead, keeping `protocol` and `host` null for relative URLs so the existing rewrite base fallback keeps working. Query parsing goes through the existing `searchParamsToUrlQuery` helper, which decodes `+` as a space where the legacy parser left it untouched; we accept that edge-case difference in this testing utility.
-
Kazma Endo authored
Co-authored-by:Claude Fable 5.1 <noreply@anthropic.com>
-
Hendrik Liebau authored
An early `cacheHandler.set()` call previously made subsequent same-key `get()` calls wait for generation and persistence. This prevented another background revalidation, but those requests waited instead of receiving the existing stale data. The work in #94694 added private-cache persistence in dev. Its helper refactor made cross-request invocations wait for cache writes before retrying root-param-specific lookups. It also moved the coarse-key `set()` call after entry collection. That unintentionally allowed subsequent requests to receive stale data and start another background revalidation while one was already running. This change tracks background work separately for each lookup key within a runtime instance. Subsequent requests can receive the existing stale entry without waiting for generation or starting duplicate work. The task remains registered until collection and its cache writes settle. Each lookup records existing work before calling `get()`, so a slow lookup does not start another revalidation after the task it observed has completed. The handler still receives `set()` after collection, including asynchronous rendering of the cached result. Subsequent `get()` calls can still block while the handler persists the entry. We accept that remaining wait to preserve the cache-handler contract without bypassing handler reads. **Alternatives Considered** - Restore early `set()` calls and rely on the handler's pending-set promises. This would prevent duplicate regeneration, but would also make subsequent requests wait for generation again instead of receiving stale data. - Extend the existing cross-request sharing mechanism through background revalidation. We prototyped retaining stale and regenerated results, but that required additional stream ownership, invalidation checks, and root-param matching. The separate background-task map avoids those changes and leaves cold and foreground generation unchanged. Fixes #98326
-
Benjamin Woodruff authored
By documenting both the partial and non-partial versions of these objects, we were documenting everything multiple times. Just reference the non-partial object from the partial object's documentation.
-
Josh Story authored
With strict route matching a layout can have sibling slots whose pages can never form a complete route. For example: ``` app/ layout.tsx @left/ foo/ page.tsx @right/ bar/ page.tsx ``` `/foo` is always missing `@right`, and `/bar` is always missing `@left`. The pages were authored as route targets, but neither URL can construct the complete slot tree owned by `app/layout.tsx`. Catchall pruning removes broad matchers that cannot render and the unmatched-page validation reports dangling files, but neither explains this project-level mistake. This validates the finalized ordinary matcher set and reports each incomplete URL at the layout that owns the conflicting slots. Adding the corresponding pages or an explicit `default.tsx` makes the topology valid. Framework-owned defaults do not invent a `children` slot, and interception matchers remain exempt because they intentionally describe partial router state updates. <!-- NEXT_JS_LLM --> -
Josh Story authored
Interception routes only describe the branch used during a soft navigation, but every URL they can produce still needs to be handled by an ordinary App Router page matcher for a direct request or refresh. Today an interception-only URL can appear to work during client navigation and then 404 when the same URL is loaded directly. This makes strict route matching reject that configuration. For example, this setup is incomplete: ``` app/ @modal/ (.)photo/ [...id]/ page.tsx photo/ [id]/ page.tsx ``` The ordinary route handles `/photo/1`, but the interception route also handles `/photo/1/2`, which has no ordinary page matcher. Widening the ordinary route makes the setup valid: ``` app/ @modal/ (.)photo/ [...id]/ page.tsx photo/ [...id]/ page.tsx ``` The validation checks coverage rather than requiring an identical matcher. A broader catchall can cover the intercepted pattern, and multiple ordinary matchers can cover different accepted lengths. For example, `items/page.tsx` together with `items/[...rest]/page.tsx` covers an intercepted `items/[[...parts]]` matcher. Route handlers and generated metadata routes do not count as canonical page matchers. Webpack and Turbopack now apply the same coverage check and report the interception matcher and the canonical pattern that is not fully covered. Existing interception fixtures now include semantically complete ordinary routes instead of relying on interception-only URLs. <!-- NEXT_JS_LLM --> -
Josh Story authored
## What? This reports an error under `experimental.strictRouteMatching` when a `page.tsx` is left out of every retained matcher. A page can lose its own broad catchall matcher and still be valid if it participates in a more specific matcher, so this checks the final matcher set instead of treating every pruned candidate as an error. Both Webpack and Turbopack report every unmatched page in development and production builds. ## Why? Pages that are never selected by any complete loader tree are unreachable by construction. This usually means parallel slots define incompatible paths without matching pages or defaults, and silently ignoring those files makes the project look like it has routes that cannot actually exist. For example: ```text app/disagreeing-slots/ ├── layout.tsx ├── @first/foo/page.tsx ├── @second/bar/page.tsx └── [...slug]/page.tsx ``` Every candidate is incomplete: `/foo` has no match in `@second`, `/bar` has no match in `@first`, and URLs handled only by the catchall have no matching page or applicable default in either named slot. Strict route matching prunes all three matchers, and this change reports all three page files instead of silently leaving them out of the build. The same validation catches a real `children` branch that only becomes incomplete below its page: ```text app/declared-children/ ├── layout.tsx ├── page.tsx └── @panel/ ├── default.tsx └── details/page.tsx ``` `/declared-children` is valid, but `/declared-children/details` only has a page in `@panel`. Because the declared `children` slot has no matching page or default at `/details`, that matcher is pruned and `@panel/details/page.tsx` is reported as unreachable. The root `page.tsx` is still part of the valid `/declared-children` matcher and is not reported. A pruned matcher is not automatically an error. If `@slot/[...parts]/page.tsx` is combined into retained `/foo` and `/bar` matchers, that page still participates in routes and remains valid. ## How? Webpack snapshots the authored app page paths before pruning and compares them with the pages used by the retained app paths. Turbopack collects authored page source files from the directory tree and compares them with the files referenced by the final accepted loader trees. The tests cover disagreeing named slots, declared `children`, optional catchalls, route groups, nested slots, and the valid case where a pruned catchall is still used by more specific matchers. ## Verification - `pnpm test-start-turbo test/e2e/app-dir/unmatched-app-pages/unmatched-app-pages.test.ts` - `pnpm test-start-webpack test/e2e/app-dir/unmatched-app-pages/unmatched-app-pages.test.ts` - `pnpm test-dev-turbo test/e2e/app-dir/unmatched-app-pages/unmatched-app-pages.test.ts` - `pnpm test-dev-webpack test/e2e/app-dir/unmatched-app-pages/unmatched-app-pages.test.ts` - `pnpm test-start-turbo test/e2e/app-dir/parallel-routes-pruned-matchers/parallel-routes-pruned-matchers.test.ts` - `pnpm test-start-webpack test/e2e/app-dir/parallel-routes-pruned-matchers/parallel-routes-pruned-matchers.test.ts` <!-- NEXT_JS_LLM --> -
Tobias Koppers authored
### What? Adds `get_relative_request_to`, next to `get_relative_path_to`, for callers that need a relative path they can hand to the resolver as a module request. It returns `./c`, `../c` or `.`, where `get_relative_path_to` returns `c`, `../c` or `.`. Fixes `import.meta.glob`'s `base`-relative keys, which currently come back without the leading `./`: `{ base: '../outside' }` produces `one.js` where Vite (and our own docs, and the existing execution fixture) expect `./one.js`. That fixture is failing on `canary` today; it passes here unchanged. ### Why? The `./` prefix is not decoration — it is what makes a string a *relative* request. Without it, `c` resolves as the package `c` rather than the file next to `from`. `get_relative_path_to` stopped emitting the prefix for a path below `from`, and every caller that builds a request had to add it back by hand. Eight of them do, each with the same three lines. That works, but it puts the requirement in the call sites instead of the API, and nothing tells a new caller that it exists — so the ninth request-building call site, `import.meta.glob`'s `base`-relative key, was written without it and silently produced the wrong keys. The two changes were authored independently and each was green on its own; only together do they produce the bug, which is why CI caught it on `canary` rather than on either pull request. Rather than add a tenth hand-written prefix, this makes "give me a request" something you can ask for. The failure mode it removes is the silent one: a caller that forgets is no longer possible, because the choice is now the function you call. ### How? `get_relative_request_to` shares its traversal with `get_relative_path_to` through one private helper, so the two can't drift; the only difference is whether a result that would be bare gets the prefix. `get_relative_path_to` keeps its signature and behaviour exactly, including the fast path that returns `target` by reference when `from` is empty — the request form can't borrow there, and the unit tests assert that difference so the fast path isn't reused by mistake. `FileSystemPath` gains the matching method. The eight hand-written prefixes now call the new function and drop their snippets. Deciding which call sites to convert needed care, because the callers of `get_relative_path_to` genuinely want different things, and the ones that want a plain path deliberately keep it: - source-map paths reported back to the client, - the Next.js template expander, whose invariant check expects the bare form, - the paths written into NFT files, which are data rather than requests. Two locals that hold requests rather than paths are renamed accordingly, and one leftover `strip_prefix("./")` is removed — it had become a no-op undoing a prefix that is no longer produced. ### Testing The `import-meta-glob-relative` execution fixture already asserts the correct keys and currently fails, so the fix is verified by that fixture passing **unmodified** — its expectations were right all along. The unit test that covered these cases before the prefix went away is restored, now run against both functions and against `FileSystemPath`, which had been left with no coverage of either method. Its original assertions turn out to describe the request form exactly, so they pin that `get_relative_request_to` reproduces the earlier contract rather than merely resembling it. Beyond that: the full `turbopack-tests` suite, and the `next-server-nft` and `next-taskless` tests, which are what would break if a call site that wants a plain path had been converted by mistake. <!-- NEXT_JS_LLM --> <!-- fleet 3acc7e63-52a8-4472-89cd-b1bbb8ad59fa --> Co-authored-by:vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by:
Tobias Koppers <1365881+sokra@users.noreply.github.com> Co-authored-by:
Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
-
Sebastian "Sebbie" Silbermann authored
Became orphaned in https://github.com/vercel/next.js/pull/97792. Another script and the test harness needed some utils from `next-stats-action` so I moved that into `test/lib/link-packed-packages`.
-
Sebastian "Sebbie" Silbermann authored
We're using Node.js versions with a built-in `fetch` implementation in all of these scripts.
-
Sebastian "Sebbie" Silbermann authored
I don't believe they tested `node-fetch` specifically and rather used it because Node.js didn't have a built-in `fetch` implementation.
-
Sebastian "Sebbie" Silbermann authored
Node.js ships with a built-in `fetch` now so `node-fetch` is no longer necessary. Mostly motivated by tracing Node.js deprecation warnings which originated from `node-fetch` by calling the deprecated `url.parse`. Call sites keep working through a compatibility type on `fetchViaHTTP` that translates node-fetch-only options: Instead of `agent` we pass to `http(s)` directly, `timeout` becomes `AbortSignal.timeout`, and Node.js readable streams are accepted as bodies with `duplex: 'half'` set automatically. The `abort-controller` polyfill is dropped since its signal type predates the current AbortSignal and undici would not honor it. `node-fetch` stays installed because `scripts/generate-release-log.mjs`, `scripts/reset-project.mjs`, and `scripts/update-google-fonts.js` still import it (follow-up material). Fixture apps will be migrated separately.
-
Tobias Koppers authored
### What? `import.meta.glob()` now resolves `../`-relative and `/`-project-root-absolute patterns (and `base`), validates every pattern (positive and negative) for whether it escapes the filesystem root, and shares the underlying "resolve leading `./`/`../` against a directory" primitive with `next-core::relativize_glob` (used by `outputFileTracingIncludes`) instead of duplicating it. ### Why? `import.meta.glob()` handed its patterns straight to Turbopack's `Glob`, which matches relative to the scanned directory and understands neither a leading `/` nor `..` segments. `import.meta.glob('../../content/*.js')` and `import.meta.glob('/content/*.js')` therefore silently returned `{}`, and a `base` that walked above the filesystem root failed with an internal error and a panic report instead of a normal diagnostic. A negative (exclusion) pattern that escaped the root was silently dropped, which is the worst outcome for an exclusion — it would silently include files the user asked to exclude. ### How? - Patterns are split into the directory they're rooted in and the remaining glob, matched relative to a single common scan directory covering every positive and negative pattern. `/` is resolved from the project root, matching Vite's rule that patterns are relative to the importing file or absolute from the project root. - Map keys follow the pattern too: `base` now produces base-relative keys (`'./zeta.js'` instead of `'../../content/zeta.js'`, matching Vite), a project-root-absolute pattern produces project-root-absolute keys, and origin-relative keys are unchanged otherwise. - Every pattern is validated up front; one that leaves the project (a `base`, a positive pattern, or a negative one) reports an error issue at the call site and yields an empty object, instead of crashing or being silently dropped. - The `./`/`../`-resolution loop is extracted into `turbo_tasks_fs::glob::relativize_glob`, a crate both `next-core` and `turbopack-ecmascript` already depend on. `next-core::relativize_glob` is now a thin wrapper over it (same name, signature and error message); its 5 unit tests are removed since the shared primitive's own tests cover the same cases. <!-- NEXT_JS_LLM --> Co-authored-by:Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com> --------- Co-authored-by:
vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by:
Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com> Co-authored-by:
Tobias Koppers <1365881+sokra@users.noreply.github.com>
-
- 09 Sep, 2026 3 commits
-
-
next-js-bot[bot] authored
-
Josh Story authored
## Summary Restore `skipDeployment` and the early return in the shared Cache Components error-test runner. The migration in #98154 replaced them with a force-gate pragma, but the gate transformer only processes `.test.*` files, so the pragma in `shared.util.ts` did not preserve the deployment exclusion. This is a temporary rollback to unblock deploy testing. Moving the test definitions out of the helper and migrating them again will be evaluated separately; this PR does not change the transformer or refactor the tests. ## Verification - Ran all 12 importing test files through Jest in deploy mode with deployment setup mocked to throw before any fixture or deployment work. Before the rollback, all 12 reached that guard and failed. After the rollback, all 12 take the legacy exclusion path and no deployment setup is attempted. - `pnpm typescript --skipLibCheck` passes. - Full type-check reports the existing nine Octokit dependency declaration errors; no errors in the changed file. <!-- NEXT_JS_LLM -->
-
Josh Story authored
## Motivation Parallel routes are separate rendering branches, but the existing metadata resolver collects every matched slot into one shared chain. As a result, traversal order can decide which slot supplies the document head, and metadata errors from one slot can interfere with another. ## What this does This adds a fork-aware resolver behind `experimental.parallelRouteMetadata` while retaining the existing resolver as the default. Each slot resolves metadata and viewport independently, with isolated accumulators, and a single branch is selected for the document head at every fork. The built-in selector prefers real routes over implicit fallbacks and prefers `children` when it contributes head data. Otherwise it chooses the branch with the deepest head definition, using route depth and lexical slot order only as stable tie-breakers. Head selection is separate from rendering outcomes. Every slot gets its own `MetadataOutlet`, which replays navigation and regular errors for that slot regardless of which branch supplied the head. ## Review notes - `generateMetadata`, `generateViewport`, and generated static metadata still start eagerly; a fork does not serialize sibling branches or parent/child generation. - Branch state is isolated only where the tree forks, preventing metadata mutation from crossing between slots. - An outlet rejects as soon as either metadata or viewport rejects, but resolves only after both succeed. This lets one failing result reach the slot boundary even if the other never settles. - Existing navigation convention metadata is preserved for the selected branch. Errors from unselected branches remain observable only through their own rendered outlets. - The old resolver remains available behind an explicit flag so this implementation can be compared or disabled during rollout. ## Verification - `pnpm --filter=next types` - Metadata resolver unit coverage - Parallel-route metadata, navigation, and not-found coverage in development and production with Turbopack and webpack <!-- NEXT_JS_LLM -->
-