- 11 Dec, 2018 3 commits
-
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Oscar Busk authored
Hello! I was looking at the [`with-firebase-hosting`](/zeit/next.js/tree/canary/examples/with-firebase-hosting) example and was having some various issues running it: * `npm run serve` will choke on windows because trying to set enviroment variables with `NODE_ENV=production` * `npm run build-funcs` failing because of babeljs mismatches between `@babel/cli@^7.0.0-rc.1` and `next@^6.0.3` * Not being able to deploy because `firebase-tools` being a deprecated version. I remedied this and also improved some other factors: * Use standard JSON formatting on `package.json` so that `npm install` doesn't cause changes on every run. (a83e930) * Remove "prettier" as a devDependency as there is no use of it in the example and most other examples does not have it as a dependency. (6095663) * Update all dependencies. The simple usecase in this example didn't really require any changes to the code. (ccde086) * [`firebase-admin@6`](https://github.com/firebase/firebase-admin-node/releases/tag/v6.0.0) * [`firebase-functions@2`](https://github.com/firebase/firebase-functions/releases/tag/v2.0.0) * [`firebase-tools@4`](https://github.com/firebase/firebase-tools/releases/tag/v4.0.0) * [`firebase-tools@5`](https://github.com/firebase/firebase-tools/releases/tag/v5.0.0) * [`firebase-tools@6`](https://github.com/firebase/firebase-tools/releases/tag/v6.0.0) * Make `npm run serve` runnable on windows using [`cross-env`](https://www.npmjs.com/package/cross-env). (b20dda7) * Update `.gitignore` to ignore firebase cache (bf761b7) * Remove `src/app/.babelrc` that seems to have been added as a previous bugfix but doesn't seem to do anything currently. (1b02045) * Remove point from [`README.md`](https://github.com/zeit/next.js/blob/canary/examples/with-firebase-hosting/README.md) that was mentioning any `predeploy` hooks in `firebase.json` as they were removed in 4f4b7a1b. (5636d9f) * Use the possibility added by upgrading `firebase-tools` to [`>=4.0.0`](https://github.com/firebase/firebase-tools/releases/tag/v4.0.0) and `firebase-functions` to [`>=2.0.0`](https://github.com/firebase/firebase-functions/releases/tag/v2.0.0) to make the deployable functions use node 8 rather than node 6. Also make babel compile with node 8 as target for less polyfills etc. (c954cc2) * Added comment to [`README.md`](https://github.com/zeit/next.js/blob/canary/examples/with-firebase-hosting/README.md) explaining how firebase deploys to node 8 and that babel will compile code for node 8. (d8b2e65, 91953dc) This was tested to `serve` on windows, linux(WSL) and on mac. Deploy was tested on linux(WSL) and mac. --- This PR is a based on #5806 with correct base. ---
🔔 @jthegedus @timneutkens
-
- 10 Dec, 2018 11 commits
-
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Kenneth Luján Rosas authored
Per @timneutkens suggestion [here](https://github.com/zeit/next.js/pull/5631#issuecomment-440588455) I went ahead and gave a shot at trying to document `renderPage` usage. This PR: - Documents `renderPage` legacy and current usage.
-
Diogo Dutra authored
* Added a new example with relay modern and a graphql server with express. * removed .graphqlconfig file from with-relay-modern-server-express example
-
Saro Vindigni authored
* ADD with-firebase-hosting-and-docker example * Improve doc
-
Leon authored
-
Oscar Busk authored
This PR Fixes #4920 So the problem is that when a next.js application is built on windows, the `pages-manifest.json` file is created with backslashes. If this built application is deployed to a linux hosting enviroment, the server will fail when trying to load the modules. ``` Error: Cannot find module '/user_code/next/server/bundles\pages\index.js ``` My simple solution is to modify the `pages-manifest.json` to always use linux separator (`/`), then also modify `server/require.js` to, when requiring page, replace any separator (`\` or `/`) with current platform-specific file separator (`require('path').sep`). The fix in `server/require.js` would be sufficient, but my opinion is that having some cross-platform consistency is nice. This change was tested by bulding an application in windows and running it in linux and windows, aswell as building an application in linux and running it in linux and windows. The related tests was also run. # Conflicts: # test/integration/production/test/index.test.js -
Justin Stahlman authored
The demo did not work. Updating to babel-plugin-inline-react-svg v1.0.1 did work.
-
moflo authored
Google seems to be deprecated the legacy realtime database and moving towards default use of Firestore, although it's still officially in beta. This PR migrates towards Firestore and the recommended loading methods for the Firebase 5.6.0 libraries. Note: the Firebase and Firebase-Admin dependencies should be updated to 5.6.0 and 6.3.0 respectively.
-
Bill Searle authored
Hey @timneutkens I've updated this example a bit. - Fixed `/asserts` spelling to `/assets`. - Removed the `/assets/styles.less` as importing this caused the entire ant-design css sheet to be loaded, now only the React components imported will have their styles loaded via the babel plugin which was already configured. Resulted in dropping the CSS for this example from ~630kb to ~220kb. - Removed `index.js` as it's not needed.
-
- 09 Dec, 2018 1 commit
-
-
Tim Neutkens authored
-
- 08 Dec, 2018 1 commit
-
-
Tim Neutkens authored
* Remove app variable as it’s only used once * Remove double spread
-
- 07 Dec, 2018 2 commits
-
-
Tim Neutkens authored
* Move send-html function and rewrite in typescript * Move getPageFiles and convert to ts * Move getPageFiles and convert to ts (#5841) * Move getPageFiles and convert to ts # Conflicts: # packages/next-server/server/render.js * Fix unit tests
-
Tim Neutkens authored
* Move getPageFiles and convert to ts # Conflicts: # packages/next-server/server/render.js * Fix unit tests
-
- 06 Dec, 2018 7 commits
-
-
Tim Neutkens authored
-
Peter Kellner authored
* Added length calculation for insert of cache rather then default to 1. changed default cache from 100 to 100MB * adjusted for lint
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Tim Neutkens authored
Couldn't find a reference to these functions as next-server uses the renderToHTML directly.
-
Tim Neutkens authored
We don't have to check if the file already exists here, since it's always in production mode (dev overrides the readBuildId method to always be `development`) If the file is not found (error is thrown) we check if the file exists. If not we throw a helpful error. In other cases we throw the original error.
-
Jeroen Knoops authored
Firebase has some issues with grpc. ( Firebase has some issues with grpc ) This is resolved in a newer version of firebase. Especially with npm 6.4.1. https://github.com/firebase/firebase-js-sdk/issues/1341 Issue #5688
-
- 05 Dec, 2018 9 commits
-
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Tim Neutkens authored
* Add tsc type checking * Add linting on circle * Add node-fetch types * Use strict mode
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Tim Neutkens authored
We ran into this eg on hyper-site, which has `module.exports` in the content.
-
Hirofumi Wakasugi authored
-
tylim authored
* add new example * update gitignore * fix lint * fix linting * fix linting again * update unstated example * remove unsued var * update readme
-
- 04 Dec, 2018 6 commits
-
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Tim Neutkens authored
* Add docs for returning `null` from generateBuildId * Add test for setting custom buildid * Fix linting
-
nodegin authored
* Delete .babelrc * Update package.json * Create next.config.js * Update next.config.js
-
Tim Neutkens authored
-
Tim Neutkens authored
-