- 02 Apr, 2019 2 commits
-
-
Joe Haddad authored
-
Shahzeb K authored
* Added a check for ad_ in the buildId * ad_ > ad Co-Authored-By:
lfades <luis@zeit.co> * Update the `ad` comment Co-Authored-By:
lfades <luis@zeit.co> * Avoid all buildId's that contain "ad" Looking through the uBlock Origin filter list, it uses regex wildcards to avoid various things with "ad" anywhere in the string. It's a safe bet to just avoid "ad" all together (as opposed to just at the start). * Use regex (case incensitive) to check for "ad" The following cases will set this regex to true: ``` /ad/i.test("somead") /ad/i.test("someADlksdjf") /ad/i.test("adlksdjf") /ad/i.test("ADlksdjf") ```
-
- 01 Apr, 2019 4 commits
-
-
Luis Fernando Alvarez D authored
* Added a check for ad_ in the buildId * ad_ > ad Co-Authored-By:
lfades <luis@zeit.co> * Update the `ad` comment Co-Authored-By:
lfades <luis@zeit.co>
-
JJ Kasper authored
-
JJ Kasper authored
* Re-add previous webdriver setup with falling back to BrowserStack setup * Add missing webdriver imports
-
Allen authored
self explanatory
-
- 31 Mar, 2019 2 commits
-
-
JJ Kasper authored
-
Luis Fernando Alvarez D authored
Use `Object.assign` for the rest-spread transform.
-
- 30 Mar, 2019 8 commits
-
-
JJ Kasper authored
-
Tim Neutkens authored
-
Tim Neutkens authored
-
JJ Kasper authored
Changed release workflow from `resolve` to `resolves`
-
Tim Neutkens authored
-
JJ Kasper authored
This adds triggering the PR Stats GitHub Action for a canary release. It compares the latest canary release with the last stable release and posts it as a comment to the commit.
-
Luis Fernando Alvarez D authored
Related to [create-react-app#5278](https://github.com/facebook/create-react-app/pull/5278#issue-220142150)
-
Luis Fernando Alvarez D authored
Replaces `import()` with `require` only for the testing environment.
-
- 29 Mar, 2019 5 commits
-
-
JJ Kasper authored
Drops user `<script>` tags and shows a warning in AMP mode. Right now they are only dropped in production mode and left in dev mode so the validator shows its warning since it looks like conflicting props log messages are being cleared causing them to not show. Closes: #6688
-
JJ Kasper authored
-
JJ Kasper authored
It appears this workaround sometimes throws a `NS_ERROR_NOT_AVAILABLE` so we add error handling for it
-
JJ Kasper authored
Update tests to setup webdriver stuff in `jest-environment` and re-use one browser session instead of spawning one for each webdriver call to prevent creating too many BrowserStack sessions.
-
Yeoh Joer authored
-
- 28 Mar, 2019 3 commits
-
-
Luis Fernando Alvarez D authored
-
Danil Shashkov authored
* Add example with astroturf (Zero runtime CSS-in-JS)
-
Luis Fernando Alvarez D authored
I also removed the copy it had of `runNextCommand`
-
- 27 Mar, 2019 14 commits
-
-
Corbin Crutchley authored
* with apollo and redux example: Update deps and fix build * Fix linting errors
-
Corbin Crutchley authored
* with apollo and redux saga example: Update deps * Fix linting problems
-
Corbin Crutchley authored
* form handler example: Update deps and fix build from dep update * Ran lint error fixers * Fixes errors that occur when commit occurs * Commit linter fixes
-
Joe Haddad authored
-
Joe Haddad authored
-
Alexander Nanberg authored
`unfetch` ^4.0.0 is already used by `isomorphic-unfetch` so this simplifies the dependency tree a tiny bit. Release notes https://github.com/developit/unfetch/releases/tag/4.0.0 https://github.com/developit/unfetch/releases/tag/4.1.0
-
Jason Miller authored
* Add default viewport meta tag (fixes #6698) * Do not inject default viewport when rendering an AMP document * Remove redundant viewport on error page * Plumb withSideEffect() to pass through props, then use that for isAmp. * Add tests for viewport meta tag. * Fix linting * Update dedupes test
-
Joe Haddad authored
-
Joe Haddad authored
* [wip] individual page builds * Make flag experimental and remove from main bin * Do not split chunks when using shared runtime
-
Václav Nosek authored
* Make `ctx` optional in `captureException` function * Make 'release' optional when calling sentry util * Fix code style
-
Chris Cowan authored
The with-google-analytics example had the "routeChangeComplete" event listener set up in components/Page.js, but that the event listener would only be set up if the user visited a page using that component. From the example, it's not clear if google analytics can be used without making every page use a component like components/Page.js. Someone following the example may make pages that don't use components/Page.js and fail to have page views reported, or feel compelled to force a shared component into their design unnecessarily, or might even make a mistake by making multiple different components like Page.js which each add a new "routeChangeComplete" event listener, causing page views to be over-reported when the user navigates between pages using the different components. This PR moves the "routeChangeComplete" event listener into _app.js, where it's guaranteed to be executed for every page and is more obviously decoupled from page-layout-related components. This PR also fixes a React warning about the lack of an onChange handler on an input tag, and removes the unnecessary implementation of `getInitialProps` in _document.js (the default implementation is inherited if not present, there's nothing this example needs to do with `getInitialProps` specifically, and the body of the method seems to have been based on an old version of next's internal implementation). This PR also fixes the url being passed to google tag manager incorrectly. It looks like page_path should be used instead of page_location because the `url` value only has the path, not the full url with the domain name, etc. (https://developers.google.com/analytics/devguides/collection/gtagjs/pages)
-
Luis Fernando Alvarez D authored
Tests don't catch this change because `isProduction &&` is always false so I tested it with a local build
-
Tomáš Hapl authored
-
Corbin Crutchley authored
Minor changes to examples. Updating major semver updates with only `package.json` changes. I've done my best to make sure that these packages.json files all have `latest` for the `nextjs` package, `cross-env` for those with `server.js` files, etc. I also added a `package.json` to `with-dynamic-app-layout` (it was missing one previously) Made sure to test all of these packages post-upgrade to ensure maintained functionality
-
- 26 Mar, 2019 2 commits
-
-
JJ Kasper authored
* Add err.sh link and pool validation results to wait to show error until export is finished * Fix wording in amp-export-validation err.sh * Update validation error message Co-Authored-By:
ijjk <22380829+ijjk@users.noreply.github.com> * Update ways to fix text Co-Authored-By:
ijjk <22380829+ijjk@users.noreply.github.com> * Update why the error occurred wording Co-Authored-By:
ijjk <22380829+ijjk@users.noreply.github.com> * Update wording some more Co-Authored-By:
ijjk <22380829+ijjk@users.noreply.github.com>
-
JJ Kasper authored
-