1. 10 Oct, 2020 1 commit
  2. 09 Oct, 2020 2 commits
  3. 08 Oct, 2020 5 commits
    • JJ Kasper's avatar
      v9.5.5-canary.0 · 62b9183e
      JJ Kasper authored
      62b9183e
    • JJ Kasper's avatar
      Handle css-loader file resolving change (#17724) · ec2ffb42
      JJ Kasper authored
      This is a follow-up to https://github.com/vercel/next.js/pull/16973 which adds handling for the breaking change in the latest version of css-loader that causes unresolved file references in `url` or `import` to cause the build to fail. This fixes it by adding our own resolve checking and when it fails disabling the `css-loader`'s handling of it. 
      
      Fixes: https://github.com/vercel/next.js/issues/17701
      ec2ffb42
    • Jens Meindertsma's avatar
      Fix with-msw example (#17695) · c021662d
      Jens Meindertsma authored
      When using the `with-msw` example I noticed it increased my bundle size in production, even through MSW is meant to be used in development only. 
      
      **Build size before implementing MSW**
      ```
      Page                                                           Size     First Load JS
      ┌ λ /                                                          479 B          58.9 kB
      ├   /_app                                                      0 B            58.4 kB
      └ ○ /404                                                       3.44 kB        61.9 kB
      + First Load JS shared by all                                  58.4 kB
        ├ chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b1b405.js  10.3 kB
        ├ chunks/framework.cb05d5.js                                 39.9 kB
        ├ chunks/main.a140d5.js                                      7.28 kB
        ├ chunks/pages/_app.b90a57.js                                277 B
        └ chunks/webpack.e06743.js                                   751 B
      
      λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
      ○  (Static)  automatically rendered as static HTML (uses no initial props)
      ●  (SSG)     automatically generated as static HTML + JSON (uses getStaticProps)
         (ISR)     incremental static regeneration (uses revalidate in getStaticProps)
      ```
      **Build size after implementing MSW according to the `with-msw` example**
      ```
      Page                                                           Size     First Load JS
      ┌ λ /                                                          479 B          71.6 kB
      ├   /_app                                                      0 B            71.1 kB
      └ ○ /404                                                       3.44 kB        74.6 kB
      + First Load JS shared by all                                  71.1 kB
        ├ chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b1b405.js  10.3 kB
        ├ chunks/framework.cb05d5.js                                 39.9 kB
        ├ chunks/main.a140d5.js                                      7.28 kB
        ├ chunks/pages/_app.c58a6f.js                                13 kB
        └ chunks/webpack.e06743.js                                   751 B
      
      λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
      ○  (Static)  automatically rendered as static HTML (uses no initial props)
      ●  (SSG)     automatically generated as static HTML + JSON (uses getStaticProps)
         (ISR)     incremental static regeneration (uses revalidate in getStaticProps)
      ```
      
      There was a 12.7 kB large increase in the `_app` First Load JS which increased the pages' First Load JS size. I tracked the problem down to the following code: 
      ```js
      if (process.env.NEXT_PUBLIC_API_MOCKING === 'enabled') {
        require('../mocks')
      }
      ```
      Removing this reduces the `_app` First Load JS to what it was previously. The `NEXT_PUBLIC_API_MOCKING` environment variable is defined in the `.env.development` file, as this means that Next.js will only activate MSW during development/testing, which is what MSW is intended for.
      
      After discussing with @kettanaito, the author of MSW, I did some investigation. This dynamic require statement is intended to allow tree-shaking of the MSW package for production. Unfortunately this did not seem to be working. To fix this, I changed the code to the following:
      ```js
      if (process.env.NODE_ENV !== 'production') {
        require('../mocks')
      }
      ```
      This means I could remove the `NEXT_PUBLIC_API_MOCKING` environment variable  from `.env.development`, as it is no longer used. 
      
      It is important to note that this still achieves the same functionality as before: MSW runs in development / testing, and not in production. If MSW must be enabled in production for some reason, the following code can be used to run MSW regardless of the environment:
      ```js
      if (true) {
        require('../mocks')
      }
      ```
      
      If possible, I'd love to hear from the Next.js maintainers regarding the tree-shaking process when using environment variables.
      
      Lastly, I made the necessary changes to have the example work in production mode as well, because there is no real backend. Of course there is a comment explaining what should be changed in a real world app.
      c021662d
    • JJ Kasper's avatar
      Update to have default locale matched on root (#17669) · bbc1a21c
      JJ Kasper authored
      Follow-up PR to https://github.com/vercel/next.js/pull/17370 when the path is not prefixed with a locale and the default locale is the detected locale it doesn't redirect to locale prefixed variant. If the default locale path is visited and the default locale is visited this also redirects to the root removing the un-necessary locale in the URL. 
      
      This also exposes the `defaultLocale` on the router since the RFC mentions `Setting a defaultLocale is required in every i18n library so it'd be useful for Next.js to provide it to the application.` although doesn't explicitly spec where we want to expose it. If we want to expose it differently this can be updated. 
      bbc1a21c
    • Henrik Wenz's avatar
      Fix with-apollo example (#17686) · a79bcfb7
      Henrik Wenz authored
      # Issue
      
      The cache updates are performed in a wrong way, resulting in a duplicate collection:
      
      **Error:**
      
      ```log
      webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:88 Warning: Encountered two children with the same key, `6f3f7265-0d97-4708-a3ea-7dee76dc0a0a`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
      ```
      
      **Video:**
      
      ![broken](https://user-images.githubusercontent.com/1265681/95336501-0c170180-08b1-11eb-9273-6ac9e37ceb41.gif)
      
      # Fix
      
      **Video:**
      
      ![fixed](https://user-images.githubusercontent.com/1265681/95336538-15a06980-08b1-11eb-8d5e-6acc07e16138.gif)
      
      a79bcfb7
  4. 07 Oct, 2020 4 commits
    • JJ Kasper's avatar
      Add initial changes for i18n support (#17370) · b2d1d87e
      JJ Kasper authored
      This adds the initial changes outlined in the [i18n routing RFC](https://github.com/vercel/next.js/discussions/17078). This currently treats the locale prefix on routes similar to how the basePath is treated in that the config doesn't require any changes to your pages directory and is automatically stripped/added based on the detected locale that should be used. 
      
      Currently redirecting occurs on the `/` route if a locale is detected regardless of if an optional catch-all route would match the `/` route or not we may want to investigate whether we want to disable this redirection automatically if an `/index.js` file isn't present at root of the pages directory. 
      
      TODO: 
      
      - [x] ensure locale detection/populating works in serverless mode correctly
      - [x] add tests for locale handling in different modes, fallback/getStaticProps/getServerSideProps
      
      To be continued in fall-up PRs
      
      - [ ] add tests for revalidate, auto-export, basePath + i18n
      - [ ] add mapping of domains with locales
      - [ ] investigate detecting locale against non-index routes and populating the locale in a cookie
      
      x-ref: https://github.com/vercel/next.js/issues/17110
      b2d1d87e
    • JJ Kasper's avatar
      v9.5.4 · 65881081
      JJ Kasper authored
      65881081
    • JJ Kasper's avatar
      v9.5.4-canary.25 · 7108567b
      JJ Kasper authored
      7108567b
    • JJ Kasper's avatar
      Update workflow step to restore cache (#17656) · 5d79a8c0
      JJ Kasper authored
      5d79a8c0
  5. 06 Oct, 2020 2 commits
  6. 05 Oct, 2020 9 commits
  7. 04 Oct, 2020 1 commit
  8. 03 Oct, 2020 2 commits
  9. 02 Oct, 2020 4 commits
  10. 01 Oct, 2020 2 commits
  11. 30 Sep, 2020 1 commit
  12. 29 Sep, 2020 2 commits
  13. 28 Sep, 2020 2 commits
  14. 27 Sep, 2020 1 commit
  15. 25 Sep, 2020 2 commits