- 15 Oct, 2020 7 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
This adds the i18n config items to the routes-manifest so that they can accessed in the builder. This doesn't increment the routes-manifest version as existing value shapes haven't been modified and an additional non-breaking value is being added x-ref: https://github.com/vercel/next.js/pull/17370
-
Tim Neutkens authored
-
Slawek Kolodziej authored
Co-authored-by:
Tim Neutkens <tim@timneutkens.nl> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
kamei authored
-
Davidson Nascimento authored
-
JJ Kasper authored
This adds the `locale` prop for `next/link` to allow transitioning between locales client-side and also allows passing the locale to `router.push/replace` via the transition options similar to `shallow` e.g. `router.push('/another', '/another, { locale: 'nl' })` x-ref: https://github.com/vercel/next.js/pull/17370
-
- 14 Oct, 2020 8 commits
-
-
JJ Kasper authored
This updates to set the `NEXT_LOCALE` cookie to the default locale when the user prefers a different locale from the default in their `accept-language` header but visits the default locale path e.g. `/en-US` with a `accept-language` preferred header of `nl` will set the `NEXT_LOCALE=en-US` header and then redirect to `/` x-ref: https://github.com/vercel/next.js/pull/17370
-
Tim Neutkens authored
-
Tommaso De Rossi authored
Co-authored-by:
Luis Alvarez D <luis@vercel.com> Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-
Simone Corsi authored
-
Alex Castle authored
Co-authored-by:
Tim Neutkens <timneutkens@me.com> Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-
JJ Kasper authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Jan Potoms authored
Co-authored-by:
JJ Kasper <jj@jjsweb.site> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Greg Rickaby authored
Noticed there's an extra backslash in the example which causes an error. **EDIT:** Also the promise needs to be resolved using `.toString()` before it can be returned as `content` in props.
-
- 13 Oct, 2020 3 commits
-
-
José Antonio Chio authored
Related issue: https://github.com/vercel/next.js/issues/10647#issuecomment-623703149 Sometimes we have both Yarn and NPM installed and want to explicitly bootstrap an app with the CLI using NPM. Having this flag documented could help people understand the package manager behavior and select NPM if that's their preference.
-
GP authored
Fixes https://github.com/vercel/next.js/issues/17828. This change adds a caveat to both the "Custom `App`" and "Custom `Document`" pages about how both `getStaticProps` and `getServerSideProps` aren't supported.
-
Amir Ali authored
`higherOrderComponent(WrappedComponent)` causing the layout broken in mobile screen. * refer to screenshots below.   if we could make it `HOC(WrappedComponent)` it will not break the layout in mobile screen 
-
- 12 Oct, 2020 3 commits
-
-
Prateek Bhatnagar authored
Co-authored-by:
Tim Neutkens <tim@timneutkens.nl> Co-authored-by:
Tim Neutkens <timneutkens@me.com>
-
Henrik Wenz authored
## Change To opt-in to using the new layers mode by default. ## Motivation - Reduces CSS filesize - Prevents users from using the already deprecated old layers mode - Removes the following console warnings: ```log risk - There are upcoming breaking changes: purgeLayersByDefault risk - We highly recommend opting-in to these changes now to simplify upgrading Tailwind in the future. risk - https://tailwindcss.com/docs/upcoming-changes ``` [more info](https://tailwindcss.com/docs/upcoming-changes)
-
JJ Kasper authored
While working on https://github.com/vercel/next.js/pull/17755 noticed a couple of cases that needed fixing and broke them out to this PR to make that one easier to review. One fix is for `ssgCacheKey` where it wasn't having the `locale` prefix stripped correctly due to the locales no longer being populated under the server instances `renderOpts` and the second fix is for the `asPath` not being set to `/` when the `locale` is the only part in the URL e.g. `/en` became an empty string `""` x-ref: https://github.com/vercel/next.js/pull/17370
-
- 11 Oct, 2020 3 commits
-
-
JJ Kasper authored
Follow-up to https://github.com/vercel/next.js/pull/17370 this makes sure the locale detection is case-insensitive.
-
SaintMalik authored
### Description Easy navigation and easy reading for others.
-
Adebiyi Adedotun authored
A URL is correct, not An URL
-
- 10 Oct, 2020 2 commits
-
-
JJ Kasper authored
Follow-up to https://github.com/vercel/next.js/pull/17370 this adds mapping of locales to domains and handles default locales for specific domains also allowing specifying which locales can be visited for each domain. This PR also updates to output all statically generated pages under the locale prefix to make it easier to locate/lookup and to not redirect to the default locale prefixed path when no `accept-language` header is provided.
-
JJ Kasper authored
-
- 09 Oct, 2020 2 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
Follow-up PR to #17370 this adds generating auto-export, non-dynamic SSG, and fallback pages with all locales. Dynamic SSG pages still control which locales the pages are generated with using `getStaticPaths`. To further control which locales non-dynamic SSG pages will be prerendered with a follow-up PR adding handling for 404 behavior from `getStaticProps` will be needed. x-ref: https://github.com/vercel/next.js/issues/17110
-
- 08 Oct, 2020 5 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
This is a follow-up to https://github.com/vercel/next.js/pull/16973 which adds handling for the breaking change in the latest version of css-loader that causes unresolved file references in `url` or `import` to cause the build to fail. This fixes it by adding our own resolve checking and when it fails disabling the `css-loader`'s handling of it. Fixes: https://github.com/vercel/next.js/issues/17701
-
Jens Meindertsma authored
When using the `with-msw` example I noticed it increased my bundle size in production, even through MSW is meant to be used in development only. **Build size before implementing MSW** ``` Page Size First Load JS ┌ λ / 479 B 58.9 kB ├ /_app 0 B 58.4 kB └ ○ /404 3.44 kB 61.9 kB + First Load JS shared by all 58.4 kB ├ chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b1b405.js 10.3 kB ├ chunks/framework.cb05d5.js 39.9 kB ├ chunks/main.a140d5.js 7.28 kB ├ chunks/pages/_app.b90a57.js 277 B └ chunks/webpack.e06743.js 751 B λ (Server) server-side renders at runtime (uses getInitialProps or getServerSideProps) ○ (Static) automatically rendered as static HTML (uses no initial props) ● (SSG) automatically generated as static HTML + JSON (uses getStaticProps) (ISR) incremental static regeneration (uses revalidate in getStaticProps) ``` **Build size after implementing MSW according to the `with-msw` example** ``` Page Size First Load JS ┌ λ / 479 B 71.6 kB ├ /_app 0 B 71.1 kB └ ○ /404 3.44 kB 74.6 kB + First Load JS shared by all 71.1 kB ├ chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b1b405.js 10.3 kB ├ chunks/framework.cb05d5.js 39.9 kB ├ chunks/main.a140d5.js 7.28 kB ├ chunks/pages/_app.c58a6f.js 13 kB └ chunks/webpack.e06743.js 751 B λ (Server) server-side renders at runtime (uses getInitialProps or getServerSideProps) ○ (Static) automatically rendered as static HTML (uses no initial props) ● (SSG) automatically generated as static HTML + JSON (uses getStaticProps) (ISR) incremental static regeneration (uses revalidate in getStaticProps) ``` There was a 12.7 kB large increase in the `_app` First Load JS which increased the pages' First Load JS size. I tracked the problem down to the following code: ```js if (process.env.NEXT_PUBLIC_API_MOCKING === 'enabled') { require('../mocks') } ``` Removing this reduces the `_app` First Load JS to what it was previously. The `NEXT_PUBLIC_API_MOCKING` environment variable is defined in the `.env.development` file, as this means that Next.js will only activate MSW during development/testing, which is what MSW is intended for. After discussing with @kettanaito, the author of MSW, I did some investigation. This dynamic require statement is intended to allow tree-shaking of the MSW package for production. Unfortunately this did not seem to be working. To fix this, I changed the code to the following: ```js if (process.env.NODE_ENV !== 'production') { require('../mocks') } ``` This means I could remove the `NEXT_PUBLIC_API_MOCKING` environment variable from `.env.development`, as it is no longer used. It is important to note that this still achieves the same functionality as before: MSW runs in development / testing, and not in production. If MSW must be enabled in production for some reason, the following code can be used to run MSW regardless of the environment: ```js if (true) { require('../mocks') } ``` If possible, I'd love to hear from the Next.js maintainers regarding the tree-shaking process when using environment variables. Lastly, I made the necessary changes to have the example work in production mode as well, because there is no real backend. Of course there is a comment explaining what should be changed in a real world app. -
JJ Kasper authored
Follow-up PR to https://github.com/vercel/next.js/pull/17370 when the path is not prefixed with a locale and the default locale is the detected locale it doesn't redirect to locale prefixed variant. If the default locale path is visited and the default locale is visited this also redirects to the root removing the un-necessary locale in the URL. This also exposes the `defaultLocale` on the router since the RFC mentions `Setting a defaultLocale is required in every i18n library so it'd be useful for Next.js to provide it to the application.` although doesn't explicitly spec where we want to expose it. If we want to expose it differently this can be updated.
-
Henrik Wenz authored
# Issue The cache updates are performed in a wrong way, resulting in a duplicate collection: **Error:** ```log webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:88 Warning: Encountered two children with the same key, `6f3f7265-0d97-4708-a3ea-7dee76dc0a0a`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version. ``` **Video:**  # Fix **Video:** 
-
- 07 Oct, 2020 4 commits
-
-
JJ Kasper authored
This adds the initial changes outlined in the [i18n routing RFC](https://github.com/vercel/next.js/discussions/17078). This currently treats the locale prefix on routes similar to how the basePath is treated in that the config doesn't require any changes to your pages directory and is automatically stripped/added based on the detected locale that should be used. Currently redirecting occurs on the `/` route if a locale is detected regardless of if an optional catch-all route would match the `/` route or not we may want to investigate whether we want to disable this redirection automatically if an `/index.js` file isn't present at root of the pages directory. TODO: - [x] ensure locale detection/populating works in serverless mode correctly - [x] add tests for locale handling in different modes, fallback/getStaticProps/getServerSideProps To be continued in fall-up PRs - [ ] add tests for revalidate, auto-export, basePath + i18n - [ ] add mapping of domains with locales - [ ] investigate detecting locale against non-index routes and populating the locale in a cookie x-ref: https://github.com/vercel/next.js/issues/17110
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
-
- 06 Oct, 2020 2 commits
-
-
Tantan Fu authored
-
Joe Haddad authored
-
- 05 Oct, 2020 1 commit
-
-
Jashn Maloo authored
Fixes #17200
-