Unverified Commit e78c6ec2 authored by Wyatt Johnson's avatar Wyatt Johnson Committed by GitHub

Replace eslint rule for `no-shadow` with `typescript-eslint/no-shadow` (#44936)

parent 28bf7032
......@@ -158,6 +158,9 @@
{
"files": ["packages/**/*.tsx", "packages/**/*.ts"],
"rules": {
// Note: you must disable the base rule as it can report incorrect errors
"no-shadow": "off",
"@typescript-eslint/no-shadow": ["warn", { "builtinGlobals": false }],
"@typescript-eslint/no-unused-vars": [
"warn",
{
......
......@@ -1325,9 +1325,9 @@ export default async function build(
runtimeEnvConfig
)
// eslint-disable-next-line no-shadow
// eslint-disable-next-line @typescript-eslint/no-shadow
let isNextImageImported: boolean | undefined
// eslint-disable-next-line no-shadow
// eslint-disable-next-line @typescript-eslint/no-shadow
let hasSsrAmpPages = false
const computedManifestData = await computeFromManifest(
......
......@@ -2448,7 +2448,7 @@ export default async function getBaseWebpackConfig(
devtoolRevertWarning(originalDevtool)
}
// eslint-disable-next-line no-shadow
// eslint-disable-next-line @typescript-eslint/no-shadow
const webpack5Config = webpackConfig as webpack.Configuration
// disable lazy compilation of entries as next.js has it's own method here
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment