Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
e78c6ec2
Unverified
Commit
e78c6ec2
authored
Jan 17, 2023
by
Wyatt Johnson
Committed by
GitHub
Jan 17, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace eslint rule for `no-shadow` with `typescript-eslint/no-shadow` (#44936)
parent
28bf7032
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
3 deletions
+6
-3
.eslintrc.json
.eslintrc.json
+3
-0
index.ts
packages/next/src/build/index.ts
+2
-2
webpack-config.ts
packages/next/src/build/webpack-config.ts
+1
-1
No files found.
.eslintrc.json
View file @
e78c6ec2
...
@@ -158,6 +158,9 @@
...
@@ -158,6 +158,9 @@
{
{
"files"
:
[
"packages/**/*.tsx"
,
"packages/**/*.ts"
],
"files"
:
[
"packages/**/*.tsx"
,
"packages/**/*.ts"
],
"rules"
:
{
"rules"
:
{
//
Note
:
you
must
disable
the
base
rule
as
it
can
report
incorrect
errors
"no-shadow"
:
"off"
,
"@typescript-eslint/no-shadow"
:
[
"warn"
,
{
"builtinGlobals"
:
false
}],
"@typescript-eslint/no-unused-vars"
:
[
"@typescript-eslint/no-unused-vars"
:
[
"warn"
,
"warn"
,
{
{
...
...
packages/next/src/build/index.ts
View file @
e78c6ec2
...
@@ -1325,9 +1325,9 @@ export default async function build(
...
@@ -1325,9 +1325,9 @@ export default async function build(
runtimeEnvConfig
runtimeEnvConfig
)
)
// eslint-disable-next-line no-shadow
// eslint-disable-next-line
@typescript-eslint/
no-shadow
let
isNextImageImported
:
boolean
|
undefined
let
isNextImageImported
:
boolean
|
undefined
// eslint-disable-next-line no-shadow
// eslint-disable-next-line
@typescript-eslint/
no-shadow
let
hasSsrAmpPages
=
false
let
hasSsrAmpPages
=
false
const
computedManifestData
=
await
computeFromManifest
(
const
computedManifestData
=
await
computeFromManifest
(
...
...
packages/next/src/build/webpack-config.ts
View file @
e78c6ec2
...
@@ -2448,7 +2448,7 @@ export default async function getBaseWebpackConfig(
...
@@ -2448,7 +2448,7 @@ export default async function getBaseWebpackConfig(
devtoolRevertWarning
(
originalDevtool
)
devtoolRevertWarning
(
originalDevtool
)
}
}
// eslint-disable-next-line no-shadow
// eslint-disable-next-line
@typescript-eslint/
no-shadow
const
webpack5Config
=
webpackConfig
as
webpack
.
Configuration
const
webpack5Config
=
webpackConfig
as
webpack
.
Configuration
// disable lazy compilation of entries as next.js has it's own method here
// disable lazy compilation of entries as next.js has it's own method here
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment